- 20 Jul, 2018 40 commits
-
-
Marc Treib authored
Most instances of EXPECT_CALL(...).WillRepeatedly(...) don't actually set up any expectation, they just set a return value for the mock function. For this purpose, ON_CALL(...).WillByDefault(...) is more appropriate, and IMO makes the tests easier to read, since it's clearer what the actual expectations are. Bug: none Change-Id: I8b9da317bc24cd10a8349a75d6864808c3cd9a9d Reviewed-on: https://chromium-review.googlesource.com/1141730Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#576809}
-
Jia authored
Once an idle event is received, UserActivityManager will call a smart dim model to predict whether the upcoming dim should be deferred. The smart dim model currently does nothing. It will be implemented to make prediction in a later cl. The purpose of this cl is to set up the structure, specifically how various classes work together. This cl also contains the following changes: 1. All data that are used in prediction and logging now live in UserActivityEvent. - This makes prediction and logging simpler as all data are now in one place. 2. Add additional metrics to log (i). Model prediction data. (ii). Previous positive and negative actions count. - They were derived data from other logged data. They are used as prediction features, and we log them directly now to avoid training-serving skew. 3. Stop logging several tab-related metrics logged, this will significantly reduce data logged. - Also only log one active tab in the focused/topmost browser that's visible. 4. Add a flag to disable/enable prediction. - It's disabled by default but will be set in experiments later. Bug: 862461 Change-Id: I7770efdfb5f15679fc4b49f8bf892292e7a347fc Reviewed-on: https://chromium-review.googlesource.com/1132828Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#576808}
-
jdoerrie authored
This change improves the testing coverage of the password section browsertest by adding more test cases and increasing the number of checked expectations. Bug: 865458 Change-Id: Ibcfad5d5a8556bddc3b928b3a6898585cf20031f Reviewed-on: https://chromium-review.googlesource.com/1143468Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#576807}
-
Khushal authored
This just re-enables the cache use that was disabled in the previous patch. TBR=piman@chromium.org Bug: 865138 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib61a148ddefea7e7491bea8f59ea363af990d811 Reviewed-on: https://chromium-review.googlesource.com/1144788 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#576806}
-
Matt Falkenhagen authored
Handle Fetch algorithm: If request is a non-subresource request...invoke Soft Update algorithm with registration. https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm Bug: 865839 Change-Id: I56eb447313171eebd2da4b4eb79771e8b89e212b Reviewed-on: https://chromium-review.googlesource.com/1144584 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576805}
-
Robert Ma authored
This makes sure web platform tests for Picture-in-Picture do not time out when Picture-in-Picture API is not available. Besides, wpt/picture-in-picture/request-picture-in-picture is split to work around a flaky timeout in WPT upstream that's related to https://github.com/web-platform-tests/wpt/issues/10398 Note: based on https://github.com/web-platform-tests/wpt/pull/11329 Bug: 806249 Change-Id: I6185253dfa4aae5111e87553581b8464032558d1 Reviewed-on: https://chromium-review.googlesource.com/1107626Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#576804}
-
Eliot Courtney authored
Currently this only contains some basic things for telling Chrome when Android PIP has started or finished, but later we may add more. Bug: 841886 Bug: b/69370942 Test: compiles and ARC runs. ArcPipBridge comes up as well. Change-Id: I14ac5b6d8628c4cc2f571f06690e6d3c228d943d Reviewed-on: https://chromium-review.googlesource.com/1120085 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576803}
-
Uladzimir Miniailau authored
This CL implements the first step in removing PasswordStoreWin and related code (more context in the design doc linked at https://crbug.com/456119#c13): * Deleting the PasswordStoreWin class and replacing it with PasswordStoreDefault on Windows. * Marking a metric measured in the deleted code as obsolete. Bug: 456119 Change-Id: I326e05101f904e3afd56fbb5dcce22e0ba2f2729 Reviewed-on: https://chromium-review.googlesource.com/1131495 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576802}
-
Koji Ishii authored
By reviewing results of build 8137 after some test fixes. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icc5162d94003c6dd6e0e2913fd739f57343195ab Reviewed-on: https://chromium-review.googlesource.com/1144810 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576801}
-
Tetsui Ohkubo authored
This reverts commit f82109c5. Reason for revert: Crash https://crbug.com/865198 Original change's description: > Unified: Hide inactive top buttons instead of dim. > > On the login screen, we made the settings button and the lock button > look dim. > > According to UX, we should just make them invisible. > > TEST=manual > BUG=864233 > > Change-Id: I90fc6853b2735a73d426dbb05b2f693be7ff2ce6 > Reviewed-on: https://chromium-review.googlesource.com/1139847 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575970} TBR=yoshiki@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864233,865198 Change-Id: I4f3d30c529a5ecc5e68c69cb833bfd6a4c8e2c6d Reviewed-on: https://chromium-review.googlesource.com/1144860 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576800}
-
Koji Ishii authored
This patch: 1. Fixes out-of-flow static position to be flow relative, from line-relative. 2. Fixes bidi-reordering orders out-of-flow objects incorrectly. The first fix has been a bug since the beginning, but most RTL out-of-flow tests pass due to the second problem. The second problem was introduced when we stopped inserting an Object Replacement Character for out-of-flow, because it creates a break opportunity but all 4 impls do not create a break opportunity for out-of-flow. It wasn't a good idea because bidi algorithm cannot resolve embedding levels without a character that represents. This fix will change break opportunities around out-of-flow objects. We can fix it in NGLineBreaker if this turns out to be a problem. Bug: 848496 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3f3c7b5a8ddf93cb4b9d6fce21ccc5e2b7623901 Reviewed-on: https://chromium-review.googlesource.com/1133106Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576799}
-
Ryan Sturm authored
PreviewsState is maintained in a content pathway (ResourceRequestInfo -> common_params) and does not need to be kept in ResourceResponseInfo as well. For context, PreviewsState is mostly a Navigation level concept. The browser allows certain states for certain hosts, and communicates the state to content to push to blink. There is really no reason for previews_state to be in the network response, but was there for historical reasons. There is still PreviewsState in the Network Request due to ClientLoFi and ServerLoFi. ClientLoFi uses the state for metrics and there is a solution for addressing that by using a new data use metrics framework that goes through the renderer (see page_load_metrics/renderer). Server LoFi will be deprecated and replaced with Client LoFi, but certain work is required before that is possible. In a set of follow-up CLs, PreviewsState will be modified on the UI thread instead of the IO thread simplifying this even further. Bug: 842233 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I949fc71089367afefa8c9e2880b0aa19d8ad99ac Reviewed-on: https://chromium-review.googlesource.com/1135922Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#576798}
-
Yutaka Hirano authored
external/wpt/service-workers/service-worker/navigation-timing.https.html has an expectation file consisting of two FAILs and one PASS, but in virtual/outofblink-cors[-ns] the test result changes to two PASSes and one FAIL. Since PASS is better than FAIL let's accept that result. Bug: 736308 Change-Id: I4bc33bf2c7c68b16528371cc1b0987dd6048e324 Reviewed-on: https://chromium-review.googlesource.com/1144597Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576797}
-
Gary Kacmarcik authored
Launch bug (w/ approvals): crbug.com/831743 Intent 2 ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2xR7cucnOA Bug: 832811, 831743 Change-Id: I24d2f49e82b5afe1dd668dc57e0ceb98af36e205 Reviewed-on: https://chromium-review.googlesource.com/1141104Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#576796}
-
Yutaka Hirano authored
external/wpt/service-workers/service-worker/service-worker-csp-connect.https.html has been passing for a while. Remove the stale expectations. Bug: 736308 Change-Id: I5feaaf93b73733c25054cb8e92678f0e635bdce9 Reviewed-on: https://chromium-review.googlesource.com/1144595Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576795}
-
Kenichi Ishibashi authored
Similar to non-S13nServiceWorker tests, just checks if handlers are created (or not created) accordingly. Bug: 860361 Change-Id: I070731dcbe7e5f037453005a2cca8ef462fdf03e Reviewed-on: https://chromium-review.googlesource.com/1144598 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Tim Song authored
The CoreBluetooth APIs expect CBUUID objects instead of raw UUID strings. BUG=865851 TBR=ortuno Change-Id: I1ad7ac21a9213d0ee19edafe54f7de096b283347 Reviewed-on: https://chromium-review.googlesource.com/1144657 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576793}
-
Khushal authored
This includes the browser side setup for initializing a seperate disk cache for skia generated shaders. It also temporarily disables using this cache in the GPU, to narrow down whether that is causing the CQ bots to fail. TBR=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1a84d2757fa0e534dd57e89d68ba6a374be26d77 Reviewed-on: https://chromium-review.googlesource.com/1144647 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
Bug: 845079 Test: Ran on DUT. Change-Id: Icc7653a29afc42aea7abeacebcd412aef70c2eee Reviewed-on: https://chromium-review.googlesource.com/1143105Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#576791}
-
Ramin Halavati authored
Network traffic annotation for Geo location is updated. Change-Id: Iea53ce53c8f9262055212b49675c2cb4e4afeb32 Reviewed-on: https://chromium-review.googlesource.com/1142775 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#576790}
-
Sebastien Marchand authored
This CL add a feature parameter to the Proactive Tab Discarding and Freezing experiment to prevent discarding tabs that share their browsing instance with another tab. This might be too agressive, in practice we might just want to consider tabs under the same SiteInstance but this is not an information that we can access yet. Check this page for more details about the SiteInstance/BrowsingInstance concepts: https://www.chromium.org/developers/design-documents/process-models#Implementation_Notes UKM privacy document has been updated here (pending approval): https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAABzM-vE0 Bug: 775644, 862203 Change-Id: Iaf5107db1d68aa4a0155ecbae7283f487c23bb7c Reviewed-on: https://chromium-review.googlesource.com/1144188 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576789}
-
Tetsui Ohkubo authored
Input method icon color was affected by UnifiedSystemTray flag. TEST=manual BUG=859824 Change-Id: Id004e2bfe7e0f9addbc02385cd829b2b278eee6b Reviewed-on: https://chromium-review.googlesource.com/1143110Reviewed-by:
-
Fady Samuel authored
This CL replaces primary and fallback SurfaceIds stored internally in SurfaceLayer and SurfaceLayerImpl with a SurfaceRange. This simplifies code substantially and makes updating surface layers faster because it involves creating fewer temporary objects. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib0d0e96210366f5127c34ccd2a46f103a6c208a3 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1144207Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576787}
-
Scott Violet authored
All interesting tests have been moved into ash_unittest and/or nuked. BUG=842365,725095,838520 TEST=covered by tests Change-Id: I27069966c2ea214a071371b7959f4e44b533dd83 Reviewed-on: https://chromium-review.googlesource.com/1142622 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576786}
-
tzik authored
Remove tzik from Service Worker and Pepper to reduce the CCed CLs. Tbr: tzik@chromium.org Change-Id: I962235b70453c15c65699a6168b99c72e4b0e61a Reviewed-on: https://chromium-review.googlesource.com/1144596Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#576785}
-
Hiroshi Ichikawa authored
Bug: 862537 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib7f92055fb4bdcf1b27b1801be2d6f1dad969282 Reviewed-on: https://chromium-review.googlesource.com/1143100 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576784}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I62e30adfad4dfded4c9644d8859bf3897cda8548 Reviewed-on: https://chromium-review.googlesource.com/1143020 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576783}
-
Paul Irish authored
Change-Id: I2184b7fbd0d16543c310a5f52195feae60962c23 Reviewed-on: https://chromium-review.googlesource.com/1142730Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#576782}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20c1311957dd..3899f1bcce7b git log 20c1311957dd..3899f1bcce7b --date=short --no-merges --format='%ad %ae %s' 2018-07-20 vapier@chromium.org pylint: upgrade to 1.5.6 Created with: gclient setdep -r src/third_party/depot_tools@3899f1bcce7b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:863669 TBR=agable@chromium.org Change-Id: I367e9aa371d3240965079c92b6b1598a24b60f7f Reviewed-on: https://chromium-review.googlesource.com/1144681Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576781}
-
Dominic Farolino authored
This aims to tackle the issue of setting a ResourceRequest's referrer and referrer policy (corresponding to Fetch's concept request referrer and concept request referrer policy) independently. There is no observable effect from this CL; it serves only as a refactoring of when we generate a ResourceRequest's Referer header. Before this CL, in order to set a ResourceRequest's referrer policy, the Referer header had to be generated on the spot. After this CL, a ResourceRequest's referrer and referrer policy are stored and able to be set independently. Prior to the ResourceRequest being sent out, we generate the final Referer header (analogous to Main Fetch invoking "determine request's referrer" algorithm). This CL also adds TODOs for later work revolving around storing ResourceRequest's referrer in the form of a separate member, as opposed to a Referer header. Bug: 863769 Change-Id: I269c95a956b347c131115ce2cec34965d1baf090 Reviewed-on: https://chromium-review.googlesource.com/1137928 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
http/tests/fetch/chromium/call-extra-crash-tee.html and http/tests/fetch/chromium/release-handle-crash.html are marked as slow. Let's mark virtual/outofblink-cors-ns/ ones as slow as well instead of marking them as TIMEOUT. Bug: 862184, 853977 Change-Id: Ia26c116e5c43912591ce61137abe50473c9e8881 Reviewed-on: https://chromium-review.googlesource.com/1144592Reviewed-by:
-
Ian Kilpatrick authored
This shouldn't have any behaviour change. Instead of using the ComputeInlineSizeForFragment call directly, we optimistically perform layout on the float to determine this size. This saves an allocation of an NGConstraintSpace (and simplifies the code dramatically), which results in a 25% perf increase in some float benchmarks (see previous pinpoint result). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I111e62a4c16c206473085ebd309719f017196959 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1143882 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eb4ac1447746..25fb576a3ccd git log eb4ac1447746..25fb576a3ccd --date=short --no-merges --format='%ad %ae %s' 2018-07-20 dgarrett@google.com config_lib: Add workspace_branch option. 2018-07-20 derat@chromium.org cbuildbot/stages: Make TastVMTest support "informational". Created with: gclient setdep -r src/third_party/chromite@25fb576a3ccd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If23ca05714fc8058607479b386b054299b537ba6 Reviewed-on: https://chromium-review.googlesource.com/1144680Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576777}
-
Kenichi Ishibashi authored
When S13nServiceWorker is on, this test was faiiling because we didn't implement SetIdleTimerDelayToZero() in MockServiceWorker. This resulted in not calling StopWorkerIfIdle() on the first active ServiceWorkerVersion. This CL implements SetIdleTimerDelayToZero() as an empty virtual method in EmbeddedWorkerTestHelper. MockServiceWorker just calls it. Subclasses of the helper implement the method as needed. To make ServiceWorkerActivationTest.NoInflightRequest pass, this CL creates a new subclass of the helper. It implements SetIdleTimerDelayToZero() so that it calls RequestTermination() for the corresponding EmbeddedWorkerInstanceHost. This results in calling ServiceWorkerVersion::StopWorkerIfIdle(). Bug: 860361 Change-Id: Ibd178d5ca1f01e7fddd115296188793fb31edb53 Reviewed-on: https://chromium-review.googlesource.com/1136160 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Preferences defined in 'components/translate/core/browser/translate_pref_names.h' 'components/translate/core/browser/translate_prefs.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I5d54f16d6637a6da53514a01ffe1f19f9ad2f4f1 Reviewed-on: https://chromium-review.googlesource.com/1142774Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576775}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I090c5ba73823e8586533d5ad2ce27824d2223841 Reviewed-on: https://chromium-review.googlesource.com/1144654Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576774}
-
Matt Falkenhagen authored
This more closely matches the legacy code path. We wait for network quiet as an optimization, as the update may adversely impact page load performance. The design is: - During the main resource request, mark the provider host as needing to update its controller service worker. - After navigation, the renderer sends the provider host a HintToUpdateServiceWorker IPC on network quiet. When the host receives this message, it schedules an update task on the relevant ServiceWorkerVersion, which triggers after 1 second. - If the HintToUpdateServiceWorker IPC was never received and the host is being destroyed while marked as needing to update, it schedules the update task then on the ServiceWorkerVersion as above. This CL handles the major case. Future work can be to expand this to shared workers and intermediate service workers in the redirect chain. A unit test is added. There is also an existing WPT: update-after-navigation-fetch-event.https.html See also design doc: https://docs.google.com/document/d/1f0oVW9d04qTLRX9e0qJ9gQW6bQIgN-_fiAFgmn6UcpI/edit?usp=sharing Bug: 853635 Change-Id: I7196d4e8b84312504851bf04defb3d8cfae291c6 Reviewed-on: https://chromium-review.googlesource.com/1143061Reviewed-by:
-
Dean Liao authored
Move constructor must be explicitally defined. In the mean time, disable copy constructor and adds Clone() as an explicit object copier for parameter passing. BUG=b:110815424 TEST=pass media_unittests --gtest_filter=VideoFrameLayout.* Change-Id: I70af93080107280ac7e062d222c73d7947c45d07 Reviewed-on: https://chromium-review.googlesource.com/1143122 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576772}
-
Parastoo Geranmayeh authored
Regex constants are added to cover phone code (as in +1). The regex for other languages are also improved. Bug: 865704 Change-Id: Iab678b7419f04fb6e495eda1c35d5911b2217997 Reviewed-on: https://chromium-review.googlesource.com/1144251 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576771}
-
Yutaka Hirano authored
Based on UMA data, it's fairly common for extensions to modify WebSocket cookie headers. Support this in the network service. Only adding cookie headers is supported. Extensions don't see cookie headers that would be sent to the network. Extensions cannot express an intent not to attach cookies. Bug: 721400 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I462735930f63a8d45cc66604888bae2e71e6345f Reviewed-on: https://chromium-review.googlesource.com/1143088 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
