- 15 Jul, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
CSS-wide keywords should not be allowed here in general, but they currently are by Chrome and FF. (And WPT requires this behavior). It would be easy to make revert-in-fallback actually behave as 'revert', but I don't want to ship this behavior since the spec doesn't currently define how to handle this. So for now I'm just adding a unit test that verifies that we don't crash. Bug: 1105635, 1105782 Change-Id: Ia8c9100484c3c351f67aada850211a0ff6d2367f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300079 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#788624}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=hgrandinetti@chromium.org Change-Id: I0ab953517310bcb03b6edab3afa6dedb63b662e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298879 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#788623}
-
Sebastien Marchand authored
Change-Id: I8a926e13d6d499e9a1a2f4fad2dfa2d16eda749b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254878 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#788622}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b92d53afbead..14fdcdc891cc 2020-07-15 cwallez@chromium.org Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ic2aab65c3a414c81d281cbc573ffc80c9a172e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788621}
-
Sicheng Li authored
To include ScreenOrientation class with orientation type constants and setScreenOrientation method in TrustedWebActivityIntentBuilder to support screen orientation for TWAs. Bug: 989606 Change-Id: I1ba5e69c1c4f24ba573d6d397cf7283063bb64c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297841Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Sicheng Li <scli@google.com> Auto-Submit: Sicheng Li <scli@google.com> Cr-Commit-Position: refs/heads/master@{#788620}
-
Pâris MEULEMAN authored
Change-Id: I5a250161dc050319fddbb0b9a86821796c37ef96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290860 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#788619}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaa783975d7b49471dd1896897acace32e2c7c98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788618}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: Ia2a60209513c0185ec73741829ea9cb28f41c389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270564Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#788617}
-
Sebastien Marchand authored
This test has been failing consistently for months on the official bots. Bug: 682286 Change-Id: Ie13609eb0b806ad412d5569c73153d8e1eb4a192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300240 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#788616}
-
Etienne Bergeron authored
This CL is removing the stack checks executed in HandleVerifier::StartTracking(...) HandleVerifier::StopTracking(...) These stack checks were executed even hen the HandleVerifier is not enabled. There are three major changes: 1) Lift out the body of the tracking functions to a separate function. void StartTracking(...) { if (enable_) StartTrackingImpl(...); // StartTrackingImpl -> no-inline. } The intend of this change is to ensure no large local variable (e.g. StackFrame) is using space on the stack. When enable_ is false, no stack checks are executed. 2) Lift the error reporting to a no-inline function ReportErrorOnScopedHandleOperation(...) These error reporting function make a local copy of the creation stackframe. Even if the error reporting code was not executed, the required local variables were accounted into the total stack size used by the tracking functions. 3) Avoid copy of large objects to local variables Some tracking functions were making a local copy of the handle information. ScopedHandleVerifierInfo other = i->second; This class includes an instance of StackFrame (which is large). If possible, it's better to avoid the copy and the local variable needed on the stack. Bug: 1103763 Change-Id: I01644028b85e4ee856b1a6c4fd4e107eb82dea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291650 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#788615}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91efa6b5f84a7b88830de4313c29cb98d58101a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788614}
-
Robert Liao authored
Fixed: 1105019 Change-Id: Ia46096034bf7b6b0d2f4b32e38cf6a572ad96716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297603 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#788613}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6c7d0e0b1644105591b30f9806a92bf9eadd253b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300200Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788612}
-
Mugdha Lakhani authored
Add a test that verifies that prerenders taking too much memory will be terminated with the expected error code. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I91fe50c74a0076fc4c4d8dc91654bd63eabadc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297962 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#788611}
-
chrome://autofill-internalsDominic Battre authored
As the autocomplete attribute influences the field classification, this CL introduces that the type of the autocomplete attribute is presented in chrome://autofill-internals. This only happens if the autocomplete attribute actually exists in the DOM. Bug: 928595 Change-Id: Id8538f724311a95307470cebe525b40fb549be79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300080 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#788610}
-
Nela Kaczmarek authored
Change-Id: Icfd93e65930f2905b88886228fec833c514160cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297639Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#788609}
-
Dominic Battre authored
This CL adds a "Reset cache" button to chrome://autofill-internals to easily test whether a new server-side classification of fields fixes a problem. In the past we had to wait 2 weeks, clear all browsing data, or use a different profile. Bug: 928595 Change-Id: Ie9be9f0c0d78dd9141c7261e0c8c7c9a311401b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246138 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#788608}
-
Sigurd Schneider authored
Previously, we used the .get() method to get a pointer to an optional mojo struct member. However, if the struct is inlined, this will return a pointer even if the optional member is not present. This change uses the more idiomatic way that relies on the operator bool in the struct pointer to check for the presence. By doing it this way, new code that copies the pattern automatically works (independent of whether there are inlined mojo structs). Bug: chromium:1064873 Change-Id: I08091e4347ee3cdf96b96e54c857ece72960bc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300082Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#788607}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia5a89fdc848bc148a8be5a299470284b2c96e72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788606}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4265fce66e9b..25a5e06a7d17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melandory@google.com Change-Id: I7533d2944ae56644be7f66d31e3388669a65eb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788605}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5fe7c044c25b..b7c467b6efa5 2020-07-15 wl@gnu.org [doc] Stem darkening is off by default for CFF driver. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I80250f1dd0d60b31b5c4f357276534833b247f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788604}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594792759-0a538db695d514f42650e461e1847cd9df8b7634.profdata to chrome-mac-master-1594814211-0517d79b9f4059a1b68c79d5638e00f140bf56b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8edae0fc3923cbd36c609dcdcaab761a9cdee897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788603}
-
Vasilii Sukhanov authored
PasswordManager.DeleteUndecryptableLoginsReturnValue PasswordManager.EmptyUsernames.CountInDatabase PasswordManager.InaccessiblePasswords PasswordManager.LoginDatabaseInit Fixed: 1104966,1104968,1104969 Change-Id: Id307b531725ead9c550b9c5f8b8df25f5476ac89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297644Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#788602}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: I0cab3e0712e7188bafe53bb3e828f78c259f94c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298941 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788601}
-
Vasilii Sukhanov authored
Fixed: 1104945 Change-Id: I79461b13308f22c88d72f48a0587a630a8fbdf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297522Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#788600}
-
Roman Sorokin authored
This CL removes passing params to Gaia to show Guest mode and Keyboard options in the "More options" menu. The params are never passed currently. Also removes handler for the Guest mode trigger message. Bug: 1067260 Change-Id: Ie9b2efbf3e161d9a0877afbafcb0be0dce3a07dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297621Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788599}
-
Dominique Fauteux-Chapleau authored
Bug: 1100386 Change-Id: Ic6e4402021e476fa9c9abbe119b62e17ec782ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273680Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#788598}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c08b0ace9907..c44b2b2567ae 2020-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from fe24a54808c2 to b481744aea1e (5 revisions) 2020-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 94667fbf66ee to 4c33fb0d3dba (12 revisions) 2020-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cd0af6456eb1 to 1de497cc50ab (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8e66f5e2726b7c16f70118a0a14c2ee62c15ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788597}
-
Anders Hartvoll Ruud authored
Otherwise the active styles may be outdated when collecting matching rules. Fixed: 1104195 Test: inspector-protocol/css/css-set-effective-property-value.js Change-Id: I12868717665d2b8b109b3689b0dbe7cf69b2388e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299623 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#788596}
-
Mohamed Amir Yosef authored
Before this CL: only the profile store is accessed when reading credentials for credential management API. After this CL: if the account store is available, passwords are read from it as well. Bug: 1093286 Change-Id: I488e702d0dbe551abc5130c1e7f808bc10e55155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292394Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#788595}
-
Ewann authored
Bug: 1046787 Change-Id: I706042edba879ee88ab5cb864634ad2c40102007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279823Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#788594}
-
Sylvain Defresne authored
Bug: none Change-Id: I425a7e8b1bc46bb7d650ebb2fc873ca5f0f115d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299342 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#788593}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=antrim@chromium.org Change-Id: I9120c302b657accfed03be98ebee512e7c8b8071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298863 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#788592}
-
Albert J. Wong authored
This CL is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I58e449d5aa856a32fc24348f4bf5ccd34e5bc685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296820 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#788591}
-
Mikhail Khokhlov authored
This CL updates power profile data stored in the cloud by adding values for newer devices. Change-Id: I7829841349ab03e801001da8d34caaca7affa1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292527Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#788590}
-
Michael Ershov authored
Start using renewal_period_seconds field from cert provisioning policies. Track expiration date in CertProvisioningScheduler, provision a new certificate when necessary (according to policy), delete renewed certificates. Bug: 1045895 Change-Id: I756fab39c96cd8de80a5e89802533d9e3c38508d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283145Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#788589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee5d7c41..669d1401 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ebbc72f2c93c1992cbe7ff61bb247480cf8b927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300160Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788588}
-
Michael Ershov authored
Log a message about internet connection only when there are workers. In other cases it shouldn't matter. Bug: 1045895 Change-Id: I9ff4f03deabfb245017b14a13a834ba9148eda7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297499Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#788587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0a8e1d6457f..0cd57586efe0 2020-07-15 lalitm@google.com Merge "metatrace: fix subtle rpc metatrace bug" 2020-07-15 treehugger-gerrit@google.com Merge "Add "thermal" atrace category" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5f7a745f855275f711cc1ad60cb18cefac7bb764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788586}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=bnc@chromium.org Change-Id: I83e9cdc174bb9693256eb1df0a5bc1cbb39e525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298881 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#788585}
-