- 03 Apr, 2020 40 commits
-
-
Hailey Wang authored
Add usage of MaxSimultaneousLoad threshold in BackgroundTabLoadingPolicy's loading logic. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2122479 Reland due to test failing because of dependencies on system core number. Removed these dependencies in unit tests. Bug: 1059341 Change-Id: I20fd569aa13c2912ba8f6366bf5d3916f72e8f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134190Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#756267}
-
Manuel Rego Casasnovas authored
This patch removes LayoutTheme::IsFocusRingOutset() as it's only implemented in one place and returns always "false". Due to this we can also remove the method ShouldDrawInnerFocusRingForContrast() in graphics_context.cc, as it always return "false" too. No new tests as it's covered by existent tests, just removing dead code. Change-Id: Ib4715770603d2ac66b353c7d077b75385e24aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134248Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#756266}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52e2dbf1c115..16d0d371d549 git log 52e2dbf1c115..16d0d371d549 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mbonadei@webrtc.org Apply performance-for-range-copy fixes. 2020-04-03 tommi@webrtc.org Remove seemingly unused timer 2020-04-03 titovartem@google.com Extract PeerConfigurerImpl into separate file Created with: gclient setdep -r src/third_party/webrtc@16d0d371d549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a13a527edbb8983551e078e52c4d4782f058cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756265}
-
Jesse Schettler authored
Use cros_healthd to collect and report fan info for each of the device's fans. Bug: 1035579 Test: DeviceStatusCollector.TestCrosHealthdInfo Change-Id: I1f458f923e6017d601390bca9b4070b0590d53e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135314Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#756264}
-
Wez authored
This reverts commit 81e217be. Reason for revert: Broke the official builders' archive step. Original change's description: > [fuchsia] Migrate cr_package_fuchsia() to use SDK-provided rules. > > Migrate the cr_package_fuchsia() rule to use the SDK-provided > fuchsia_component() and fuchsia_package() rules internally. > > TBR=jbudorick > > Bug: 1050703 > Change-Id: I1ba54308f2f2f6fc0f0b305dab2b9c927a38b21e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094989 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756250} TBR=ddorwin@chromium.org,wez@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org,wilkinsonclay@google.com Change-Id: I9077ce9e4cab5dd85e3d5fc4f4d09cc91033e811 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050703, 1067614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135691Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756263}
-
Marc Treib authored
- Extract a new SetVotesForPendingCredentials() out of CreatePendingCredentials(). - Remove "update" param from SavePendingToStore() since it can be inferred from pending_credentials_state_. - Merge ProcessUpdate() together with corresponding code for the IsNewLogin() case into a new SetVotesAndRecordMetricsForPendingCredentials(). - Call UploadVotesAndMetrics() from within SavePendingToStore(), rather than at its call sites. No behavior changes. Bug: 1067194 Change-Id: Ib85a35de9a44b6ec362442351416b27368243cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134007 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#756262}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f99302c4efe6..2ce5fda2fea8 git log f99302c4efe6..2ce5fda2fea8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 bclayton@google.com Kokoro: Add the ppa:ubuntu-toolchain-r/test apt-repository Created with: gclient setdep -r src/third_party/swiftshader@2ce5fda2fea8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia17d0e2ee711a0679e6f0d377231a864ed65f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135602Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Ic7166feb015cf069d58173ea97c1976f008ecfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132768 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756260}
-
Raymond Toy authored
As with other fixes, use HasSampleAccurateValuesTimeline() to determine if there are sample-accurate values which is either caused by timeline events or connected inputs to the AudioParam. Added IsAudioRate() if any AudioParam is k-rate and use that to determine how to handle the AudioParam. This applies to the 6 AudioParams of a PannerNode, and the 9 AudioParams for an AudioListener since they're closely coupled. Performance impact is negligible, based on Spotify's benchmark. Without this CL (macbook pro): TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 495 495 530 550 556 1765 Panner-equalpower 359 359 377 395 399 1186 Panner-HRTF 948 948 1023 1119 1135 7163 With this CL: TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 496 496 545 558 578 8654 Panner-equalpower 359 359 377 395 399 611 Panner-HRTF 941 941 1021 1119 1134 8270 Bug: 1015760 Change-Id: Iea0ef37ae07c7113c8ab9cc3e1cb47e6179a151e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096786 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756259}
-
Scott Violet authored
This reverts commit 935efb98. Reason for revert: As 81 hasn't shipped yet, and the client library is being used from trunk, this is a bit aggresive. We need to wait until 83 goes to stable before doing this. Original change's description: > [WebLayer] Remove support for M79 > > Fixes this TODO before M83 branches. > > Bug: 1031830 > Change-Id: I280cc8378cb1124fdcc12965ff067382d669ef09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132827 > Auto-Submit: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755513} TBR=sky@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031830 Change-Id: Ie53395a683e34b95750577cec2ccfab8141131f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135539Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756258}
-
Danyao Wang authored
The bridge implements PaymentAppFactoryInterface on the Java side and acts as a PaymentAppFactory::Delegate on the C++ side to allow Java to invoke C++ PaymentAppService. This patch sets up the basic scaffolding. A subsequent CL will fill in the actual onPaymentAppCreated() callback, which is the most substantial part of the bridge. Bug: 1063118 Change-Id: Ie3b93b719712b9b95865ee769415c4cd91d35392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133120Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756257}
-
Tom McKee authored
In seemingly rare cases, LatencyInfo instances associated with CompositorFrames have ukm:SourceIds that we do not expect. More specifically, we're sometimes seeing unexpected kInvalidSourceIds and we're also sometimes seeing source id disagreement amongst multiple LatencyInfos associated to a single CompositorFrame. See the linked bug for more details, but we're currently seeing these issues intermittently while scrolling and navigating simultaneously. This CL adds a histogram to record when we're seeing these unexpected cases so that we can get a better sense of how often this happens in the wild. Bug: 1062764 Change-Id: I5f69c430df4e29a07eedda77fed0e64f529f1bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129861Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756256}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iebc6543337143e0c74fe04cd142672eed2554635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135605Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I1efa42cacfc40ddfa3642a9c2ef5deda7b26e70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135372Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756254}
-
Omer Katz authored
This is to address flaky timeouts of these tests. Bug: 986235 Change-Id: I82658d97947ea1314290f9ffbd40b6529b80e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134253Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756253}
-
kylechar authored
Two checks about the DrawQuad rects were added as deserialization errors. Add equivalent DCHECKs during serialization so the errors are caught closer to the source in debug builds. Bug: 1066139 Change-Id: I69665dd200d7ee2028fac6e55bd0264967ed9216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134609Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756252}
-
Daniel Rubery authored
When recording metrics for malware deep scanning, every verdict that is not VERDICT_UNSPECIFIED is a success. But SCAN_FAILURE should count as failure. Change-Id: I961f19d4a719be53ab04d6f39caf083f919a392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134914 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756251}
-
Wez authored
Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. TBR=jbudorick Bug: 1050703 Change-Id: I1ba54308f2f2f6fc0f0b305dab2b9c927a38b21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094989 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756250}
-
Christos Froussios authored
TBR=rsorokin Bug: 1067461 Change-Id: Ieae7074a542b9addfafc8be773ee4d8343b785a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135613 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#756249}
-
Anastasiia Nikolaienko authored
This change is limited to Chrome OS and is not related to Win7 Tests failure. This is a reland of 0a948617 TBR=xiyuan@chromium.org Original change's description: > Add EDU login flow: CSS fixes > > Address comments to UI implementation - update margins and logo size. > New screenshots: > http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI > > Bug: 1054798 > Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756012} Bug: 1054798, 1067443 Change-Id: I2dc2c9345808be2f3e84a3c4c91c3a1db6076a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134015 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#756248}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 123ddc4d. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icc1850715a23dcb51b9a1da88c5df1ae3fd3e6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135706Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756247}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I65e2e168c67edd2ffd2363479164f1a4e027c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135646Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756246}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47cd4085b978..52e2dbf1c115 git log 47cd4085b978..52e2dbf1c115 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mbonadei@webrtc.org Add voip_unittests to gn_isolate_map.pyl 2020-04-03 jonaso@webrtc.org Don't trigger OnNetworkChange when changing from 3G to 4G 2020-04-03 jonaso@webrtc.org Add new AdapterTypes to android sdk 2020-04-03 deadbeef@webrtc.org Temporarily increase DTLS buffer size to 2. Created with: gclient setdep -r src/third_party/webrtc@52e2dbf1c115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063834 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b31577b50d696823ed779dd6613cf98dc78c43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135601Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a prerequisite to allow DeviceAccountInitializer to be used on desktop to fetch authcodes for invalidations registration. Bug: 1026261 Change-Id: I9db6fbe4c420b34b5cc734207d728cc67045a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134188Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756244}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaef4f9e9baf735635e2b763bb246749fd0cc55e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134005Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ica922d40136c54683d995e134cdc3df0ea6d8dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135667Reviewed-by:
-
Stephen McGruer authored
This rolls testharness.js, idlharness.js, and webidl2.js to WPT SHA 39b27a7875 (https://github.com/web-platform-tests/wpt/commit/39b27a7875). The primary purpose is to consume the assert_throws/promise_rejects API removals. It does not roll to WPT HEAD as shortly after this SHA an API change occurs in the assert_throws_dom/promise_rejects_dom APIs that will require work in Chromium to consume. Some fixes done alongside: * One use of assert_throws fixed in payment-request-interface.html * Three expected files that reference line numbers in testharness.js updated for the new version. Bug: 1051932 Change-Id: I9cc1c8235ce88262a6a7a2905d0996ba64fe9866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129897Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756241}
-
Hans Wennborg authored
After 61e89737, libc++ no longer supports linking against the system libc++abi. We never cared about linking the library anyway, we just want the headers. This lets us do that; see bug for discussion. Bug: 1067216 Change-Id: Ib6265cf9c6c58d25e72f8f43ae994d9ec6da69a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133967Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#756240}
-
Elly Fong-Jones authored
Sometimes, users of MenuModel add items whose command ID is the same as their string ID, thus conflating command IDs with string IDs. Normally this is done because there is no matching IDC constant available. While this "works" it is dangerous: 1) IDS_FOO and IDC_FOO are from separate namespaces, and there is no reason they wouldn't overlap; 2) A common pattern is for MenuDelegate::Execute() to turn around and pass the provided command ID to CommandUpdater::ExecuteCommand(), which really does expect an IDC_* constant as the command ID; 3) Since it looks like a bug at first reading *and* many IDS_FOOs have a corresponding IDC_FOO, it is prone to being erroneously "corrected" to IDC_FOO, which breaks the menu. This change: 1) Introduces an enum Textfield::MenuCommands for the commands exposed via TextField's context menu, and uses these as command IDs for that menu instead of using the IDS constants; 2) Introduces an enum Label::MenuCommands for the commands exposed via Label's context menu, and uses those as command IDs too; 3) Introduces an enum OmniboxMenuCommands for the omnibox context menu's commands, and uses that; 4) Removes a bunch of special-purpose logic from ReloadButton that was only required because of using IDS constants for command IDs; in this instance there already exist available IDC constants, and using them allows removing a translation layer; 5) Updates a handful of tests to use the new constants; 6) Adds a DCHECK to SimpleMenuModel to forbid adding a command whose command ID is equal to its string ID. Change-Id: I5647f978f9bd7006e3e8f3332b289792c2c1418b Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132587Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756239}
-
Corentin Wallez authored
TBR=bajones@chromium.org Bug: angleproject:4539 Change-Id: I7e05c18e09ac1e62ce631dfa66deef4aa3fe1f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133978Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756238}
-
Corentin Wallez authored
TBR=bajones@chromium.org Bug: chromium:951628 Change-Id: I0fe1062e575e42d9e803bb3290218b877569afc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133934Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e6c0ac0b11d..56f8fb61b9d5 git log 2e6c0ac0b11d..56f8fb61b9d5 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 dberris@chromium.org Dashboard: Stop batching histogram processing Created with: gclient setdep -r src/third_party/catapult@56f8fb61b9d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067531 Tbr: nuskos@google.com Change-Id: Id8fce7cb4fc7735c364cb0b3f704a858ca13e226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135594Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f954babacc6c..31665eb818aa git log f954babacc6c..31665eb818aa --date=short --first-parent --format='%ad %ae %s' 2020-04-03 btolsch@chromium.org Get test data path by exe path Created with: gclient setdep -r src/third_party/openscreen/src@31665eb818aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic971a2d1e5e063cc6380b1ab167ab7858a28270d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135593Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b24fab368ae..c00163ba0925 git log 2b24fab368ae..c00163ba0925 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 hao.x.li@intel.com Return error instead of crash if compile shader failed on D3D12 Created with: gclient setdep -r src/third_party/dawn@c00163ba0925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If19f8b58ca6d8dda0d600653ef49b562351d7e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135587Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fca03eaabd52..331b83f63756 Created with: gclient setdep -r src-internal@331b83f63756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I72da591568ba549309fe8baad825d667b0c1047b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135592Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756233}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1cc49bb2e230..93040c8d0d4a git log 1cc49bb2e230..93040c8d0d4a --date=short --first-parent --format='%ad %ae %s' 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src ba07fa0be82c..bb74deab0a4d (1 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 0b66fa3b62cb..b5757b95005b (1 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader cb58662302c8..f99302c4efe6 (7 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src f20c0d7971c6..e95fbfb1f509 (7 commits) Created with: gclient setdep -r src/third_party/angle@93040c8d0d4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I650b2f23d83c6f5dde51b9bea36b8b208a0875cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135600Reviewed-by:
-
Armando Miraglia authored
Fixed: 1055395 Change-Id: Ibd095646a7ef14277d14f99657515ab0bacca62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132326Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#756231}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a10679ba4c58..76336cdd0411 git log a10679ba4c58..76336cdd0411 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 alexei.rudenko@gmail.com Set background color for scrollbars in dark mode 2020-04-03 alexei.rudenko@gmail.com Make TreeOutline in Changes not focusable until there is content Created with: gclient setdep -r src/third_party/devtools-frontend/src@76336cdd0411 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048986,chromium:953677 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I623e490e14768ebd1e00afb8d39eee6d36fdf0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135599Reviewed-by:
-
Joseph Kim authored
This work builds upon 2086358: Demo Mode: Display progress bar rather than spinner during Demo setup https://chromium-review.googlesource.com/c/chromium/src/+/2086358 Now Demo Mode setup progress is displayed to the user as a list of steps with individual progress indicators (not begun, in progress, complete). This is hidden behind the `ShowStepsInDemoModeSetup` flag, disabled by default. Bug: b:148753805 Change-Id: I5bdfe643e80f291755df64e28d671f5fc7069e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114014 Commit-Queue: Joseph Kim <josephkimsh@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756229}
-
Aya ElAttar authored
Bug: 1067528 Change-Id: I4aa1eb71244e082dabfa1ff9667ca6ab59fc5ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134288Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
