GitLab

Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (patchset #8 id:140001 of https://codereview.chromium.org/2062353002/ )

Reason for revert:
caused regression: crbug.com/628970

Original issue's description:
> Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND
>
> This fixes issues where the ntp background image was
> interrupted underneath the detached bookmark bar.
>
> Also the ntp_background color is now forced to be opaque
> even if a none opaque alpha value is provided from the
> theme. This prevent issues with subpixel AA which does not
> work on none opaque background. (and to avoid falling back
> to grayscale AA)
>
> Also see crbug.com/618278
>
> BUG=618335
>
> R=estade@chromium.org, pkasting@chromium.org
>
> Committed: https://crrev.com/bb4e97590966ba4138b759b8a6450e526a24fa27
> Cr-Commit-Position: refs/heads/master@{#405725}

TBR=pkasting@chromium.org,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=618335

Review-Url: https://codereview.chromium.org/2159833002
Cr-Commit-Position: refs/heads/master@{#406118}

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

Generated with clang-tidy.
See https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md

BUG=None

Review-Url: https://codereview.chromium.org/2152373003
Cr-Commit-Position: refs/heads/master@{#406117}

BUG=333201

Review-Url: https://codereview.chromium.org/2129413002
Cr-Commit-Position: refs/heads/master@{#406116}

This CL re-lands r405933 and removes the hack that was needed while
rolling in the reworked v8_target_cpu code, but this adds the missing
line that was needed for CrOS to work correctly with their custom
toolchain.

TBR=machenbach@chromium.org, llozano@chromium.org
BUG=593461, 625353

Review-Url: https://codereview.chromium.org/2158143002
Cr-Commit-Position: refs/heads/master@{#406115}

received from the PVer4 service.

BUG=543161

Review-Url: https://codereview.chromium.org/2151953003
Cr-Commit-Position: refs/heads/master@{#406114}

TBR=thestig@chromium.org
BUG=629167

Review-Url: https://codereview.chromium.org/2160783002
Cr-Commit-Position: refs/heads/master@{#406113}

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9f516b88a15fd%5E%21/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

BUG=

Review-Url: https://codereview.chromium.org/2110973002
Cr-Commit-Position: refs/heads/master@{#406112}

BUG=414157

Review-Url: https://codereview.chromium.org/2158703002
Cr-Commit-Position: refs/heads/master@{#406111}

This declares a new GN arg save_unstripped_output that can be enabled if
enable_stripping=true. If true, then an unstripped copy of the linker output
will be saved in the output directory with an ".unstripped" suffix.

BUG=628052
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2157573002
Cr-Commit-Position: refs/heads/master@{#406110}

TBR=petrcermak@chromium.org
BUG=629163
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2155163003
Cr-Commit-Position: refs/heads/master@{#406109}

This does two things: (1) enables accessibility for a PDF plug-in when
the accessibility mode changes for a RenderFrame (previously we only
checked the mode once on creation), and (2) fixes a potential UAF
in PdfAccessibilityTree if the RenderFrame deletes the
RenderAccessibilityImpl, in particular during loading.

BUG=54724

Review-Url: https://codereview.chromium.org/2100753003
Cr-Commit-Position: refs/heads/master@{#406108}

The ES3 implementation is not currently well tested enough to enable Skia's use of it. However, Skia is required to run the WebGL2 conformance tests. To work around this conundrum we'll temporarily limit Skia to using ES2 functionality within an ES3 context.

BUG=626431

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2154373002
Cr-Commit-Position: refs/heads/master@{#406107}

This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002.

We can either leave this implementation empty if it's not needed by DevTools or implement it.

Review-Url: https://codereview.chromium.org/2160613003
Cr-Commit-Position: refs/heads/master@{#406106}

With this CL, the user is able to drag the selected text from WebView/Chrome to
other apps (Copy operation) or within the same WebView/Chrome tab (Move
operation).

This feature is disabled by default until we fully test it, and can be enabled
by "switches::kEnableTouchDragDrop".

BUG=584789

Review-Url: https://codereview.chromium.org/2135493002
Cr-Commit-Position: refs/heads/master@{#406105}

BUG=590878

Review-Url: https://codereview.chromium.org/2161493002
Cr-Commit-Position: refs/heads/master@{#406104}

One of the clients need to support Mac OS X version 10.7, which means that Clang compiler that support C++11 is used but the application is linked against pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2150333003
Cr-Commit-Position: refs/heads/master@{#406103}

Currently in ImageBitmap, whenever we need to flip a SkImage, we call the
function flipSkImageVertically, which read the pixels of the SkImage,
swap the pixels and construct a new SkImage from the swapped pixels again.
This process is un-necessary in the case where we already have a SkCanvas
and are drawing to that canvas. In this case, we can just call the
equivalent transformation on SkCanvas to achieve the same flipY effect.

Review-Url: https://codereview.chromium.org/2144733011
Cr-Commit-Position: refs/heads/master@{#406102}

Similar to regular downloads, we want SB pings for requestors whose
URLs match the SB whitelist in flash downloads. To achieve that, we
sample 1% of whitelisted PPAPI downloads based on the
SafeBrowsingService::whitelist_sample_rate() if the user is in
extended reporting group and not in incognito mode.

Also refactored download_protection_service_unittest to elliminate
the use of MessageLoop (deprecated).

BUG=610924

Review-Url: https://codereview.chromium.org/2146703002
Cr-Commit-Position: refs/heads/master@{#406101}

Currently the command line switches for blimp are in the app directory,
but the code that will be using it will need to live in
//blimp/client/core. This means that the switches should be made
available to that code.

It is not moved to the public directory because for now it should not
be necessary for embedders to use them, and we should aim for the
configurations there to be made available as real runtime APIs instead.

BUG=611097

Review-Url: https://codereview.chromium.org/2154363002
Cr-Commit-Position: refs/heads/master@{#406100}

This saves us 357kb of .dex size and 44kb of memory per process.

BUG=625704

Review-Url: https://codereview.chromium.org/2127973003
Cr-Commit-Position: refs/heads/master@{#406099}

R=eae@chromium.org,dgrogan@chromium.org

Review-Url: https://codereview.chromium.org/2161733003
Cr-Commit-Position: refs/heads/master@{#406098}

This patch converts the usage of CanonicalCookie's constructor in
GaiaCookieManagerService::ForceOnCookieChangedProcessing() to use
CanonicalCookie::Create() method.

We are doing this because the Create() method validates the parameters
and we thus we can test the return value to see if it has passed or not.
Whereas we can not do this when using the constructor.

BUG=57061
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2113863002
Cr-Commit-Position: refs/heads/master@{#406097}

The shader translators are basically stateless, but they get recreated (a costly
operation) for every new decoder.
Just keeping a reference to them is enough to keep them in the shader translator
cache, so introduce a getter for them in the decoder, and keep a reference to
them in the fuzzer code.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2152733003
Cr-Commit-Position: refs/heads/master@{#406096}

The test has 10 squares filled with a color gradient. 10 different filter
effects are applied to each square. The filter effects are applied with a
keyframe animation to force the non-display list path.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2156793002
Cr-Commit-Position: refs/heads/master@{#406095}

BUG=598073

Review-Url: https://codereview.chromium.org/2153673002
Cr-Commit-Position: refs/heads/master@{#406094}

https://chromium.googlesource.com/skia.git/+log/6451a0cea600..034f243c6de4

$ git log 6451a0cea..034f243c6 --date=short --no-merges --format='%ad %ae %s'
2016-07-18 caryclark disable test that fails to compute bounds on nexus 5
2016-07-18 caryclark disable new test since it fails on skia_fast
2016-07-18 mtklein Tweak a couple things I found confusing in ColorSpaceXform unit tests.
2016-07-18 fmalita Remove SkDOM::build(const char doc[], size_t len)
2016-07-18 brianosman Introduce GrColorSpaceXform, for gamut conversion on textures
2016-07-18 borenet Convert SK Images to new assets format
2016-07-18 msarett Fix rewinding bug in SkJpegCodec
2016-07-18 bsalomon Initialize fGammaCorrect in DF Path Renderer unit test
2016-07-18 caryclark pathops coincidence and security rewrite

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2158153002
Cr-Commit-Position: refs/heads/master@{#406093}

Review-Url: https://codereview.chromium.org/2152023003
Cr-Commit-Position: refs/heads/master@{#406092}

The pin input right now is too tall, and a unwanted blue outline shows up around it.

BUG=627937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150383002
Cr-Commit-Position: refs/heads/master@{#406091}

BUG=628878
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2156883003
Cr-Commit-Position: refs/heads/master@{#406090}

Experimenting with a different text did not yield any positive results.

BUG=589128

Review-Url: https://codereview.chromium.org/2158103002
Cr-Commit-Position: refs/heads/master@{#406089}

Review-Url: https://codereview.chromium.org/2148143002
Cr-Commit-Position: refs/heads/master@{#406088}

Also, reposition scroll functionality from the popover helper to the
ColorSwatchPopoverIcon/BezierPopoverIcon. This will allow us to move
the popover helper so it can be re-used in Sources.

BUG=none
R=lushnikov

Review-Url: https://codereview.chromium.org/2155263002
Cr-Commit-Position: refs/heads/master@{#406087}

Tot has ARGB hardcoded, whereas certain platforms (e.g.
Android) usually have ABGR. Make that decision runtime.

Also, code in ToT uses SkBitmap, which is discouraged,
this CL changes it to using SkSurface and SkPixmap
instead.

BUG=628466

Review-Url: https://codereview.chromium.org/2153093003
Cr-Commit-Position: refs/heads/master@{#406086}

Reland of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #1 id:1 of https://codereview.chromium.org/2151253004/ )

Reason for revert:
Making a reland CL to investigate and try to reproduce the unit test failures (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653/steps/webkit_python_tests/logs/stdio)

Original issue's description:
> Revert of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #4 id:60001 of https://codereview.chromium.org/2144873004/ )
>
> Reason for revert:
> Seems to be causing failures in webkit_python_tests on multiple bots (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653).
>
> Original issue's description:
> > In rebaseline, include build number information with "test_prefix_list" dicts.
> >
> > When rebaselining, the main argument passed to the rebaseline method is a "test_prefix_list", which is currently a dict mapping test prefixes to builder names to baseline file suffixes.
> >
> > If we want to change _suffixes_for_actual_failures to fetch actual failures for try jobs, then that method needs to know the build number as well.
> >
> > This CL would replace the builder in all "test_prefix_list" dicts with a Build object, which includes builder name and build number, but build number is optional.
> >
> > Planned follow-up: changing build_data() to use a method to fetch and cache results for particular builds, and change _suffixes_for_actual_failures fetch results for particular builds using that method as well. This would make the "skip_checking_actual_results" workaround unnecessary. I could also include that change in this CL.
> >
> > Committed: https://crrev.com/e5830ddcf7cc0fc87decede44a0a0baa4d5e8c61
> > Cr-Commit-Position: refs/heads/master@{#405783}
>
> TBR=dpranke@chromium.org,wkorman@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/110c6f3a6dfa490acca83b2daa49615ee821ac8a
> Cr-Commit-Position: refs/heads/master@{#405804}

TBR=dpranke@chromium.org,wkorman@chromium.org,wjmaclean@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2153973002
Cr-Commit-Position: refs/heads/master@{#406085}

This attribute is used with copyable TrivialStruct which should be passed by
value. It is not transitive. std::vector<TrivialStruct> will be passed by const
ref, for example.

It is added because people think it is useful to make base::Time* pass by value
to be more consistent with our style requirements.

BUG=624136

Review-Url: https://codereview.chromium.org/2146153002
Cr-Commit-Position: refs/heads/master@{#406084}

Remove old callback-based ListenForRouteMessages API and replace it
with StartListeningForRouteMessages and OnRouteMessagesReceived. The
rationale is return value based API doesn't work well for event pages;
when the event page is suspended, the callback supplied by the old API
is lost and cannot be restored when the extension wakes up. Switching
to the listener model unblocks the work to reduce the nessesity of
keeping the event page alive and should result in considerably
simpler logic on the extension side.

To maintain backwards compatibility with older extensions, a smaller
adapter logic is introduced in media_router_bindings.js.

Add missing WakeReason for StartListeningForRouteMessages.

Also added OWNERs for the mojom file to comply with presubmit.

BUG=625007

Review-Url: https://codereview.chromium.org/2111303003
Cr-Commit-Position: refs/heads/master@{#406083}

The flaky suppression didn't work.

BUG=628697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2159983002
Cr-Commit-Position: refs/heads/master@{#406082}

BUG=627928

Review-Url: https://codereview.chromium.org/2142423003
Cr-Commit-Position: refs/heads/master@{#406081}

Revert of Disable some GLAndSoftwareCompositing content browser tests under MSAN. (patchset #2 id:20001 of https://codereview.chromium.org/1405873002/ )

Reason for revert:
This has been fixed.

Original issue's description:
> Disable some GLAndSoftwareCompositing content browser tests under MSAN.
>
> These tests give errors when run under MSAN. There is likely a real
> problem introduced recently (see bug for details).
>
> TBR=avi@chromium.org
> BUG=542896
>
> Committed: https://crrev.com/47cd72d660d736695b0a2f2a2dedc8d189a6bbfe
> Cr-Commit-Position: refs/heads/master@{#354224}

TBR=avi@chromium.org,benwells@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=542896

Review-Url: https://codereview.chromium.org/2159933002
Cr-Commit-Position: refs/heads/master@{#406080}

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2147933004
Cr-Commit-Position: refs/heads/master@{#406079}