- 14 Sep, 2020 34 commits
-
-
Ben Wells authored
In a multiprofile session, windows can be sent to other desktops. This can be done to the Files app, and when files are opened when it is in this state the apps may open on the original desktop (i.e. that of the profile that owns the files). When this occurs an info message is displayed as otherwise it appears to the user as though nothing happened. The files app shows this message for web apps even though they are opened on the current desktop. This change stops the info message being shown in this case. This change also adds some clarifying comments and also adds some TODOs for other situations that might have similar bugs. Bug: 1109589 Change-Id: I9ceab68fc6547813d4e83f879e04adbcf07a1093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359870Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#806545}
-
Alexey Baskakov authored
Disable CrExtensionsManagerTestWithIdQueryParam.UrlNavigationToActivityLogFail TBR=rdevlin.cronin@chromium.org Bug: 1127741 Change-Id: I43680caf65185718fcfce1e2d2f3a8484b6a1c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409055Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#806544}
-
Alexey Baskakov authored
TBR=dpapad@chromium.org Bug: 1127733 Change-Id: I7b8f2b17f503e5360f807faca4fd3d1ec9b4e09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408600Reviewed-by:
-
Yoichi Osato authored
This CL refactors ResourceFetcher::CreateURLLoader() to receive ResourceRequestHead instead of ResourceRequest. That change reduced the redundant instance creation. Change-Id: Ia1c64a39c480ea4f7ad298bc60160d78707be38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404286Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#806542}
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1110367 Change-Id: I7095c3cfa3e1614f52f11b8dfd4869129a7b7b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408239Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806541}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b711737c1384..81a7629b202f 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 948b3a05550b to dbd34449af20 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I67f8cee0875ae74e13dbee97825db9b7b9d6a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e53ee0c93173..534924ed9ee5 2020-09-14 fancl@chromium.org auto-triage: Only reopen issues closed by pinpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1113800 Tbr: wenbinzhang@google.com Change-Id: Ic92b9142361231a3b4319e16eeb2724bc851f8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409153Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/87a2e015f06e..6e621a98a0b7 2020-09-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I051a539d9ac95df58d92135800b75d6322d15565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409152Reviewed-by:
-
Joel Hockey authored
Bug: 971967 Change-Id: Ie7c609750401cffcc23b0850125ef50b4e04a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407677 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806537}
-
My Nguyen authored
Copied over from languages_page/edit_dictionary_page.js Mock: http://go/cros-lang-settings-ux-slide#slide=29 Duplicated word: http://screen/7ptBk8NJEDqhzEc Length limit reached: http://screen/5XQF6ePt4ctSgia Bug: 1113439 Change-Id: If17744293c18d6cb2b33c51373452bbe6d9a9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397056 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806536}
-
Bo Majewski authored
- Remove unnecessary explicit construction. - Replace DISALLOW_COPY_AND_ASSIGN deprecated macro with explicit deletions - Replace constructed optional value with a constant Bug: 903742 Change-Id: I486f5976c32dd4af312b9d9efa5941c7bd18ce09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389481 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#806535}
-
Alan Cutter authored
This CL makes - MigrateDefaultChromeAppToWebAppsGSuite - MigrateDefaultChromeAppToWebAppsNonGSuite available for enabling via about:flags for the purposes of manual testing. Bug: 1058265 Change-Id: Ia5e386564b9be7f56489980c35d9bd3881f469c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405716 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#806534}
-
Kent Tamura authored
* Add missing dependencies * Move html_media_test_helper.* from html:unit_tests to core:unit_test_support * Move fake_canvas_resource_host.h from platform:unit_tests to platform:test_support Because they are used in modules:unit_tests, and it can't depend on html:unit_tests and platform:unit_tests. This CL has no behavior changes. Bug: 800764 Change-Id: Ia97540cb14b51dabd36fe70bbb74c2c3abf21fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406233 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806533}
-
Meredith Lane authored
Fixes a null dereference crash on MacOS. Bug: 1126394 Change-Id: I8c8f4387cb4c424e17e5900f1faf1660e5d01bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400785 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600019602-ed2e256fac899ca1dee4e6eb48fd53d99ebb14eb.profdata to chrome-win64-master-1600041484-a30af8f2a2acd0d94a4d04ce1984e089b193fca0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib8cb6bb4ce987cde838c561d4c4416c06717f97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408720Reviewed-by:
-
tby authored
The suggested files v2 and soon-to-be file search projects will share code. This CL makes a new directory that we can gradually migrate all file-related search providers into, and adds a common result class for all files. Bug: 1034842 Change-Id: I29026120ec47382155125d1cf225388d233b4117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407675Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#806530}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96d76ad2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib8eb7a7354ba60fdb83d22a7c977a47eb10b0f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407581Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806529}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I94958f62f8ff8db0cb769ecffe22024eec7923db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409133Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806528}
-
Alexandre Courbot authored
When setting a new resolution, the V4L2 VD calls the pipeline's PickDecoderOutputFormat(), which is in charge of picking an output format that we can eventually display, if needed with the help of an image processor. However the image processor's requirements in terms of buffer size might be different from those of the decoder. Make PickDecoderOutputFormat() return the adjusted size along with the selected pixel format, so the decoder can align to it and set a resolution that the image processor can use as input. BUG=b:168193954 TEST=video.DecodeAccelVD.h264_resolution_switch passes on hana-kernelnext. Change-Id: Id92e75b3d8a3b0e1291f0638fb41ddd5956e6879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405347 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806527}
-
Yuki Yamada authored
This is a follow-up for https://crrev.com/c/2402459/. Bug: 1125952 Change-Id: Iea5bcf36d21e3ab4dd6584d0d46b436ea7e9b780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404231Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806526}
-
Tal Pressman authored
As part of MBI, most widget/view/frame-related messages will go through the AgentSchedulingGroup instead of RenderProcess/RenderThread. That can change the ordering in which messages are handled, and may break some assumptions we are currently making. In order to enable testing and experimentation with this ordering change, this CL makes the ASG interfaces channel-associated, thus preserving the current message order. This will allow us to migrate all the currently channel-associated interfaces to be associated with the ASG, and control the ordering via a flag. Bug: 1111231 Change-Id: Id04d90c748a2ce2cbb47d1cde7892fa99b1aac70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386859 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#806525}
-
Luciano Pacheco authored
Change FileTransferController.canCutOrDrag() to check for util.isNonModifiable() so folders that shouldn't be renamed/moved can't be moved via drag and drop. NOTE #1: With this change Downloads will be copied upon this drag and drop use case, but that's the normal behavior because users are allowed to copy Downloads. NOTE #2: This couldn't be tested with the integration tests because our test function fakeDragAndDrop() cannot emulate the DataTransfer required for this issue. Manually tested in the device dragging and dropping Downloads in another folder Test: browser_tests --gtest-filter=" FileManagerJsTest.FileTransferController" Bug: 1007234 Change-Id: I3ed28465c3d21abd34334b33c0dd65c68a47ea7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404226 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
My Nguyen authored
Copied over from languages_page/edit_dictionary_page.js One change: use computed property for hasWords_, for this to work iron-list can't be under template dom-if. Empty iron-list should not have too much impact on performance. Mock: http://go/cros-lang-settings-ux-slide#slide=28 and http://go/cros-lang-settings-ux-slide#slide=31 No word view: http://screen/34mebiVZeEXru8k With words view: http://screen/9mDdiNFpPv4avpu Bug: 1113439 Change-Id: Ide9edc3cbd95f055fd50109d1a17973152b3076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395903 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600019602-70deeea6efa76ec6386c7bc7963d060c951bcf80.profdata to chrome-mac-master-1600041484-c6ff66b09b98954e0f795d944deaf8a778f8e0c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4058a59de85c8bbabc44f20cfc92a08c20afd3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408961Reviewed-by:
-
Ahmed Mehfooz authored
This fix changes the battery icon slightly to match modified specs (It is 1px shorter). The spec also standardizes all battery icons to the same size so the regression for tethered device battery is also fixed. Bug: 1126674 Change-Id: Ia71972930c51c964e4110ba887f17b0eca027847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404417 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806521}
-
Patti authored
There are a few last remaining instances of strings containing the words 'whitelist' and 'blacklist' in the chrome/app/generated_resources.grd string file. Replace them with more respectful alternatives. Bug: 1114004 Change-Id: Ie14a2cf080fea1c61a91feecb3686a82c4e0188a No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400648 Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#806520}
-
Joel Hockey authored
In crrev.com/c/1837323 |controller_| is set to null when an animation starts. The old DCHECK was never updated. This CL updates it to expect |controller_| to be null if the spinner is being removed from UpdateApps() because the animation is Finished(). https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/ash/launcher/shelf_spinner_controller.cc;l=319-323;drc=c2c84a5ac7711dedcc0b7ff9e79bf7f2da019537 Bug: 1077722 Change-Id: Ie8d6b332c9cd869a7cc88dc58827e83e29e9e675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408595 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806519}
-
Maggie Cai authored
This CL uses the international string label from file manager for drive share action. BUG=1097623 Change-Id: I3f5aa1e3873b2677630fc49e2c341f2a3a63194f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404517Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806518}
-
Kent Tamura authored
After LayoutTheme::AdjustStyle() call, we can assume a LayoutObject with a HasEffectiveAppearnace() style always has a non-null Element for GetNode(). This CL simplifies blink::LayoutTheme and blink::ThemePainter by the assumption. * Change the |const Element*| arguments of |LayoutTheme:: AdjustSliderContainerStyle()| to |const Element&|. * Remove unused |const Element*| arguments of |LayoutTheme:: AdjustMenuList*Style()|. * Change the argument order of LayoutTheme::AdjustStyle() to follow Google C++ style guide. * Public methods of ThemePainter still take |const Node*| arguments, but the methods set up |const Element&| variables at the beginning. * Protected methods of ThemePainter take |const Element&| arguments. * Add |const Element&| arguments to some of ThemePainter methods because they refer to LayoutObject::GetNode(). * Remove IsDisabled(), IsPressed(), and IsHovered() in theme_painter_default.cc. They are not helpful any longer. This CL has no behavior changes. Change-Id: I8a8fee402720ddeacfe77ebf920146b72bf6767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404510 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#806517}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600019602-a9721894365ebf12d66621ff2aeda20a62d94ef9.profdata to chrome-linux-master-1600041484-5728f1bbdb3072c9a2ada1afd02e69514bec4d41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: If6db8efe79d2c193f662349673168f67f0e8c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408960Reviewed-by:
-
Mason Freed authored
Prior to this CL, if there were multiple form associated custom elements with the same "name" attribute, the document.forms.elements.namedItem() API would not contain the custom elements. Fixed: 1124818 Change-Id: I5f97fbddc6ef9d03432edde7a643c3e01df70e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398953 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#806515}
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper::CountExternalRequests to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: I2d9463fc57409baab94fef7197c6229fcf7d0c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401343 Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e384a5d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ideee0fe9e31c1168afbe7cd664872eb4a44d6b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408402Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I184ab3ce21629deb22b7fa6144ffd9becb0f3205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408947Reviewed-by:
-
- 13 Sep, 2020 6 commits
-
-
My Nguyen authored
Copied from languages_page/languages_page.js Current view: http://screen/79LZtEBFUnkevpP There is no mock for this yet, but I think this should just carry over. Strings will most likely be updated. Bug: 1113439 Change-Id: I6d0ed2fc1949ad55ebd265be0b71a34a0300cd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400546Reviewed-by:
-
My Nguyen authored
Mock: http://go/cros-lang-settings-ux-slide#slide=28 Current view: http://screen/5u7jNdndrP3bHcz Drive-by: - LanguagesSection::IsEmojiSuggestionAllowed to be consistent with header. - Add correct paddings for download error in input_page.html (accidentally removed earlier, added a comment to remind myself) Bug: 1113439 Change-Id: Ib63f44905db3b93f73c0be814b0fca37ee21f0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394878Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL caches the activity tab that PIP mode got turned on with, to use it when leaving PIP mode. In this way, the reported NPE can be avoided when the activity tab is not available at the time callback needs to be invoked. Bug: 1119340 Change-Id: I5d422b4d41961a09cc8c6c1f18ca89edf50d8eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371768Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#806509}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599973865-097838253c6e4fc922b30e85389ab39271465d8b.profdata to chrome-win32-master-1600019602-32c2a84e23bf8e92bb08ca2c2b541f0b03d0321b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id710b62e31798774a2afa7458b0de9c1e9afa575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408778Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599997444-587d45f2a7d0fcdd182d1f3f19319d856a10c377.profdata to chrome-win64-master-1600019602-ed2e256fac899ca1dee4e6eb48fd53d99ebb14eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia4f16cea861a01b82972dedc8e2cdf8870e34fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408779Reviewed-by:
-
Eric Willigers authored
When serializing nested selector lists for :is(), :where() and so on, we now include a space after the comma. We add various WPTs for the serialization of CSS Selectors include :is() and :where() The tests pass on Safari, Firefox and now Blink. https://drafts.csswg.org/selectors-3/ https://drafts.csswg.org/selectors/ Bug: 1127347 Change-Id: I6d990e04c50a3ea97bdab8d0225c9bf1d09d2cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407735Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806506}
-
