GitLab

This additionally moves extension app context menu functionality
to its dedicated class.

BUG=584691
TEST=unit_test passes and no visual menu changes on devices.

Review URL: https://codereview.chromium.org/1673683002

Cr-Commit-Position: refs/heads/master@{#374696}

Build rule and test runner changes to follow.

BUG=575975

Review URL: https://codereview.chromium.org/1684583003

Cr-Commit-Position: refs/heads/master@{#374695}

- use_nacl_clang is now the default and has no meaning.
- ninja is the default generator for gyp_chromeium and
  gyp_nacl.
- support for nacl_allow_thin_archives was reverted from NaCl
- Made GypNinjaBuild_Pnacl and GypNinjaBuild_PPAPI
  consistent.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=

Review URL: https://codereview.chromium.org/1684883002

Cr-Commit-Position: refs/heads/master@{#374694}

Broken multiprocess tests were bringing down the whole
mojo_system_unittests suite. These should be disabled on
Android for now since our test runner simply does not
have the ability to launch a child process at the moment.

This CL disables all existing multiprocess tests for
Android, but  turns everything else back on.

BUG=585784,585849
TBR=amistry@chromium.org

Review URL: https://codereview.chromium.org/1687093002

Cr-Commit-Position: refs/heads/master@{#374693}

The TaskQueueSelector is only supposed to touch the blocked_selector_
iff queue->should_report_when_execution_blocked() is true. Unfortunately
TaskQueueSelector::EnableQueue unconditionally added queues to the
blocked_selector_ leading to a potential UAF.

BUG=581973, 584544, 582712, 585744

Review URL: https://codereview.chromium.org/1685093002

Cr-Commit-Position: refs/heads/master@{#374692}

This will make it easier for Scroll Customization on the compositor
worker to pass ScrollState objects back and forth between main and the
compositor.

BUG=505851
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1646663002

Cr-Commit-Position: refs/heads/master@{#374691}

Added the "Show as Tab" option under the Window menu.
The option only appears if the current window is not tabbed.

BUG=43953

Review URL: https://codereview.chromium.org/1681863005

Cr-Commit-Position: refs/heads/master@{#374690}

This CL contains:
 * Expose resulting type of Bind as MakeUnboundRunType.
 * Refactor testing::CreateFunctor using base::Bind.
 * Remove generate_gmock_mutant.py.
 * Change argument ordering of testing::CreateFunctor to align to
   base::Bind.
 * Remove LATE_OBJECT_BINDING support, which no one use.

BUG=554299

Review URL: https://codereview.chromium.org/1680643002

Cr-Commit-Position: refs/heads/master@{#374689}

This should never be hit since we don't allocate more than 2 GB, but it's best practice to ensure so.

BUG=581409

Review URL: https://codereview.chromium.org/1683033002

Cr-Commit-Position: refs/heads/master@{#374688}

Revert of Make text section 2MB aligned for hugepages. (patchset #7 id:120001 of https://codereview.chromium.org/1619713007/ )

Reason for revert:
Causing failures on x86-alex, peach_pit, and daisy_skate (render process crash in login screen).

Original issue's description:
> Make text section 2MB aligned for hugepages.
>
> If we do not use the option '-Wl,--section-start=.text=2001000' at
> link time, the performance gain on hugepages is gone. This is probably
> because the original text section is not 2MB aligned and the after
> mremap, the hugepage is not preserved.
>
> BUG=chromium:569963
> TEST=The performance gain is back on micro benchmarks.
>
> Committed: https://crrev.com/1384534a94e6324d74906f0cbc1e707606c063f2
> Cr-Commit-Position: refs/heads/master@{#373673}

TBR=rickyz@chromium.org,cmtice@chromium.org,kenchen@google.com,llozano@chromium.org,shenhan@chromium.org,yunlian@chromium.org,yunlian@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:569963

Review URL: https://codereview.chromium.org/1687033002

Cr-Commit-Position: refs/heads/master@{#374687}

This reverts commit e6df3095.

The infobar UI will be replaced with dialog.

BUG=532876
TBR=dfalcantara@chromium.org

Review URL: https://codereview.chromium.org/1670673004

Cr-Commit-Position: refs/heads/master@{#374686}

Make sure NativeWidgetMus installs the ui::ContextFactory for the views::Widgets,
and doesn't use the stub context-factory installed for the AshWindowTreeHosts.

BUG=585141

Review URL: https://codereview.chromium.org/1679023007

Cr-Commit-Position: refs/heads/master@{#374685}

The test now checks for the speculative RenderFrameHost instead of the pending
one when PlzNavigate is enabled.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1681973002

Cr-Commit-Position: refs/heads/master@{#374684}

XMLHttpRequestProgressEvent is no more.

BUG=357112
R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1690503002

Cr-Commit-Position: refs/heads/master@{#374683}

For backward compatibility, ClearSyncDataPreferences uses both versions of the onAttach() method - the deprecated one, which refers to Activity, and the new one, which refers to Context. Supress the deprecation warning of the former. See crbug.com/585548 for more details.

BUG=585548

Review URL: https://codereview.chromium.org/1689693002

Cr-Commit-Position: refs/heads/master@{#374682}

WebRTC 11548:11553

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/608b2be..bb60460

Libjingle 11545:11551

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/bb467ca..ae925d4

TBR=
BUG=

Review URL: https://codereview.chromium.org/1685143002

Cr-Commit-Position: refs/heads/master@{#374681}

Revert of Remove the is_loading_ field from WebContentsImpl (patchset #24 id:460001 of https://codereview.chromium.org/1545973002/ )

Reason for revert:
CHECK(is_loading_) appears to fail (flakily?) on  Linux ChromiumOS Tests (1). More details in the bug.

Original issue's description:
> Remove the is_loading_ field from WebContentsImpl
>
> This CL removes the is_loading_ field from WebContents, in favor of only
> tracking the loading state through the FrameTree. Currently the loading state
> is tracked in both, leading to more complexity in the code.
>
> BUG=571887, 298193
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/db73eb6cf1e59e753fb53e8c744620b00606ccd5
> Cr-Commit-Position: refs/heads/master@{#374651}

TBR=rockot@chromium.org,carlosk@chromium.org,nasko@chromium.org,nick@chromium.org,clamy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571887, 298193

Review URL: https://codereview.chromium.org/1690633002

Cr-Commit-Position: refs/heads/master@{#374680}

BUG=546012

Review URL: https://codereview.chromium.org/1644773005

Cr-Commit-Position: refs/heads/master@{#374679}

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in Catapult first.

BUG=559117

Review URL: https://codereview.chromium.org/1678503002

Cr-Commit-Position: refs/heads/master@{#374678}

TBR=rockot@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1687693002

Cr-Commit-Position: refs/heads/master@{#374677}

BUG=429053

Review URL: https://codereview.chromium.org/1674573002

Cr-Commit-Position: refs/heads/master@{#374676}

This is one of the few remaining steps to removing biased bitcode (at
least for SFI NaCl).

Review URL: https://codereview.chromium.org/1681413002

Cr-Commit-Position: refs/heads/master@{#374675}

CallbackStacks are used only while Oilpan's GC is doing marking & weak processing.
However, currently each CallbackStack continues retaining one Block forever.

This wastes memory a lot. Oilpan has 4 global CallbackStacks and 1 CallbackStack per thread.
Each Block consumes 8192 * sizeof(Item) = 128 KB. This means that Oilpan wastes 128 KB * (4 + # of threads).
When I start Chrome's new tab page, it creates 18 CallbackStacks,
meaning that it wastes 2.3 MB of memory.

This CL removes the waste by discarding system pages of the Block after finishing every GC phase.

BUG=

Review URL: https://codereview.chromium.org/1686943002

Cr-Commit-Position: refs/heads/master@{#374674}

This will likely flake because it takes too long to run.
Disabling it preemptively until we can make it do less work.

BUG=None
TBR=sammc@chromium.org

Review URL: https://codereview.chromium.org/1686863003

Cr-Commit-Position: refs/heads/master@{#374673}

This was done for gyp in https://codereview.chromium.org/951083003/.
It was missing in gn, but base.isolate depends on this file. This makes
"isolate tests" fail on Windows bots that use gn and swarming.

BUG=460506,461160,498033

Review URL: https://codereview.chromium.org/1683793003

Cr-Commit-Position: refs/heads/master@{#374672}

BUG=571217

Review URL: https://codereview.chromium.org/1680913002

Cr-Commit-Position: refs/heads/master@{#374671}

2016-02-10 justincohen [Mac/iOS] Add custom fonts, target device and minimum deployment target to _CopyXIBFile

BUG=577711, 584320
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1688773002

Cr-Commit-Position: refs/heads/master@{#374670}

Pinned snapshot images were leaked when receiving a memory warning.

BUG=None

Review URL: https://codereview.chromium.org/1687453002

Cr-Commit-Position: refs/heads/master@{#374669}

ProfileInfoCache is being refactored into ProfileAttributesStorage and ProfileAttributesEntry, which use profile paths instead of numerical
indices in the interface. See https://codereview.chromium.org/1599013002
for details.

Member variable index is removed from message_center::NotifierGroup
and its subclasses because it is apparently unused except in tests.

BUG=305720

Review URL: https://codereview.chromium.org/1657913003

Cr-Commit-Position: refs/heads/master@{#374668}

serialized to storage by model types.

BUG=543405

Review URL: https://codereview.chromium.org/1678343002

Cr-Commit-Position: refs/heads/master@{#374667}

Revert of Fix SELinux violation when opening Chrome on Android (patchset #4 id:60001 of https://codereview.chromium.org/1655983002/ )

Reason for revert:
Given the M bot that this broke, plus http://crbug.com/585421, I'm reverting until I can properly sort out the bugs here.

Original issue's description:
> Fix SELinux violation when opening Chrome on Android
>
> This was caused by calling PathUtils.setPrivateDataDirectorySuffix()
> on the renderer process. Moving that call into
> ChromeBrowserInitializer should fix this.
>
> BUG=560152
>
> Committed: https://crrev.com/b5ce1bf969e760539c96fd215756dd1716415f25
> Cr-Commit-Position: refs/heads/master@{#373820}

TBR=yfriedman@chromium.org,simonb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=560152

Review URL: https://codereview.chromium.org/1684123002

Cr-Commit-Position: refs/heads/master@{#374666}

BUG=

Review URL: https://codereview.chromium.org/1687863002

Cr-Commit-Position: refs/heads/master@{#374665}

BUG=585802
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/1683903003

Cr-Commit-Position: refs/heads/master@{#374664}

Seems to be a special case where it's run as an instrumentation test but
doesn't have an apk_under_test.

This was broken by:
https://codereview.chromium.org/1679623002/

TBR=hartmanng
NOTRY=true
BUG=585806

Review URL: https://codereview.chromium.org/1687023002

Cr-Commit-Position: refs/heads/master@{#374663}

Adds to option --wpr-{archive,record} to respectively run with or
generate the benchmark's Web Page Replay archive. Https urls
support are postponed to another CL.

BUG=582080

Review URL: https://codereview.chromium.org/1684653003

Cr-Commit-Position: refs/heads/master@{#374662}

Examples:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/52088/steps/mojo_system_unittests/logs/stdio

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/25720/steps/ipc_mojo_unittests/logs/stdio

BUG=585784
TBR=rockot

Review URL: https://codereview.chromium.org/1673303005

Cr-Commit-Position: refs/heads/master@{#374661}

Revert of Refactor Chromoting JNI code to use jni/Client (Java changes only). (patchset #7 id:120001 of https://codereview.chromium.org/1537183002/ )

Reason for revert:
This broke ToT: http://crbug.com/585799

Original issue's description:
> Refactor Chromoting JNI code to use jni/Client (Java changes only).
>
> This removes globals from jni/JniInterface in favor of passing a
> jni/Client instance to code that needs to access the Chromoting
> client connection.
>
> The C++ code is unchanged - JniInterface class is still used to
> marshall Java <-> C++ calls. JniInterface still holds a singleton
> Client connection, but all other globals have been removed (including
> the singleton CapabilityManager instance).
>
> Each Activity's onCreate() method gets the singleton Client instance,
> and then passes it to objects that need it (for input injection and
> so on). This should make it easier to use a fake Client instance for
> unit-instrumentation tests.
>
> BUG=526336
>
> Committed: https://crrev.com/22ee9b8426839b0c2c841fbc919cd4a79b1456d0
> Cr-Commit-Position: refs/heads/master@{#374548}

TBR=sergeyu@chromium.org,joedow@chromium.org,lambroslambrou@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526336

Review URL: https://codereview.chromium.org/1687873002

Cr-Commit-Position: refs/heads/master@{#374660}

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead

Review URL: https://codereview.chromium.org/1686063002

Cr-Commit-Position: refs/heads/master@{#374659}

It's apparent that the field is never null in this method, and if it were, we'd have to change much more. So make the code a little more clear and remove the test.

BUG=

Review URL: https://codereview.chromium.org/1617243004

Cr-Commit-Position: refs/heads/master@{#374658}

It's not clear that all error suggestions should be shown on mobile, since some
of them are irrelevant (e.g., disabling an extension).

BUG=568415

Review URL: https://codereview.chromium.org/1673593002

Cr-Commit-Position: refs/heads/master@{#374657}