GitLab

        Reviewed by Eric Carlson.

        Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
        https://bugs.webkit.org/show_bug.cgi?id=55972

        Update test results, because they are now laying out timeline consistently.

        * media/audio-repaint-expected.txt: Updated.
        * platform/mac/media/audio-controls-rendering-expected.checksum: Ditto.
        * platform/mac/media/audio-controls-rendering-expected.png: Ditto.
        * platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
        * platform/mac/media/audio-repaint-expected.checksum: Ditto.
        * platform/mac/media/audio-repaint-expected.png: Ditto.
2011-03-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
        https://bugs.webkit.org/show_bug.cgi?id=55972

        Instead of poking at the time display elements all the way from RenderMedia,
        let the standard layout cycle take care of things. Move the logic of calculating
        when to collapse the time display elements into a custom renderer, since
        this is not something that can be accomplished with CSS.

        Also, the logic of keeping the timeline slider at least 100px needed refreshing,
        since it didn't actually keep it at 100px.

        * html/shadow/MediaControls.cpp: Moved the logic of determining visibility
            of time display elements to RenderMediaControlTimeDisplay, eliminating
            updateTimeDisplayVisibility method.
        * html/shadow/MediaControls.h: Removed decl.
        * rendering/MediaControlElements.cpp:
        (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
            Added new renderer class.
        (WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
            size-sensing logic, still using hard-coded values.
        (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
            Removed m_isVisible member, which is no longer necessary.
        (WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
            return the new renderer.
        * rendering/MediaControlElements.h: Adjusted decls.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
            media controls in layout.

git-svn-id: svn://svn.chromium.org/blink/trunk@80857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha Silva.

        Provide a knob to enable/disable DNS prefetching.
        DNS prefetching is enabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=55973

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

git-svn-id: svn://svn.chromium.org/blink/trunk@80856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Carlson.

        Start focusing updates to media controls, away from always updating everything.
        https://bugs.webkit.org/show_bug.cgi?id=56038

        For now, the new methods just call generic MediaControls::update.

        Covered by existing tests.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
        (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
        (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
        (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
            accessor.
        (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
            MediaControls::changedClosedCaptionsVisibility.
        (WebCore::HTMLMediaElement::mediaControls): Added.
        (WebCore::HTMLMediaElement::hasMediaControls): Added.
        * html/HTMLMediaElement.h: Added decls.
        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::reset): Added.
        (WebCore::MediaControls::changedMute): Added.
        (WebCore::MediaControls::changedVolume): Added.
        (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
        * html/shadow/MediaControls.h: Added decls.

git-svn-id: svn://svn.chromium.org/blink/trunk@80855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Martin Robinson.

        [GStreamer] When seeking webKitWebSrcStop release the frame but should not.
        https://bugs.webkit.org/show_bug.cgi?id=55703

        When calling webKitWebSrcStop in case of a seeking, the frame should not
        be reset (the source hasn't change). The frame may be used to get the network
        context. Some network stack (like Qt) are relaying on the network context
        to work.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcStop):

git-svn-id: svn://svn.chromium.org/blink/trunk@80854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed.

        Build fixes for GTK and Leopard.

        * bindings/gobject/GNUmakefile.am:
        - add missing WebKitAnimation* generated bindings
        * page/WebKitAnimation.idl:
        - use double in place of float (the core values are double anyway)

git-svn-id: svn://svn.chromium.org/blink/trunk@80853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was accidentally committed.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._loadLeaksFromURL):

git-svn-id: svn://svn.chromium.org/blink/trunk@80851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash is tracked by <http://webkit.org/b/56185>.

* platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped
possibly-related websocket crashes.

git-svn-id: svn://svn.chromium.org/blink/trunk@80850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.

* fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.

git-svn-id: svn://svn.chromium.org/blink/trunk@80849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@80848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix for QT.

        * WebCore.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@80847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser and Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=54151
        Implement an API to play/pause/scrub animations

        This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
        APIs, exposed via Element.getWebKitAnimations(). This first pass
        is a read-only API - a subsequent commit will add the ability
        to scrub animations.

        Test: animations/animation-api-1.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        - All build settings updated for new files
        * bindings/js/JSBindingsAllInOne.cpp:
        - Include new custom files
        * bindings/js/JSWebKitAnimationCustom.cpp: Added.
        (WebCore::JSWebKitAnimation::iterationCount):
        - Custom property getter so that we can return INFINITY
        * bindings/js/JSWebKitAnimationListCustom.cpp: Added.
        (WebCore::JSWebKitAnimationList::markChildren):
        - Make sure WebKitAnimations are marked
        * bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
        (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
        - Custom property getter so that we can return INFINITY
        * dom/Element.cpp:
        (WebCore::Element::webkitGetAnimations):
        * dom/Element.h:
        * dom/Element.idl:
        - New API entry point
        * page/DOMWindow.idl:
        - Constructor definitions for WebKitAnimation and WebKitAnimationList
        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::~AnimationBase):
        - Since AnimationBase can now live longer (if a WebKitAnimation is
        held in Javascript) we need to guard for the renderer having disappeared.
        (WebCore::AnimationBase::setElapsedTime):
        (WebCore::AnimationBase::play):
        (WebCore::AnimationBase::pause):
        - Stub implementations at present
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::animation):
        - Expose the Animation properties
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::animationsForRenderer):
        (WebCore::AnimationController::animationsForRenderer):
        - Builds the list of WebKitAnimations
        * page/animation/AnimationController.h:
        * page/animation/AnimationControllerPrivate.h:
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        - Make sure we clear the renderer if we are removing the animation
        (WebCore::CompositeAnimation::animations):
        * page/animation/CompositeAnimation.h:
        * page/animation/WebKitAnimation.cpp: Added.
        (WebCore::WebKitAnimation::WebKitAnimation):
        (WebCore::WebKitAnimation::name):
        (WebCore::WebKitAnimation::duration):
        (WebCore::WebKitAnimation::elapsedTime):
        (WebCore::WebKitAnimation::setElapsedTime):
        (WebCore::WebKitAnimation::delay):
        (WebCore::WebKitAnimation::iterationCount):
        (WebCore::WebKitAnimation::paused):
        (WebCore::WebKitAnimation::ended):
        (WebCore::WebKitAnimation::direction):
        (WebCore::WebKitAnimation::fillMode):
        (WebCore::WebKitAnimation::pause):
        (WebCore::WebKitAnimation::play):
        - The implementation of the new API. All the read-only parts are
        done, but elapsedTime, play() and pause() are stubs.
        * page/animation/WebKitAnimation.h: Added.
        (WebCore::WebKitAnimation::create):
        (WebCore::WebKitAnimation::~WebKitAnimation):
        * page/animation/WebKitAnimation.idl: Added.
        * page/animation/WebKitAnimationList.cpp: Added.
        * page/animation/WebKitAnimationList.h: Added.
        * page/animation/WebKitAnimationList.idl: Added.
        - Copies NodeList implementation

2011-03-11  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser and Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=54151
        Implement an API to play/pause/scrub animations

        This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
        APIs, exposed via Element.getWebKitAnimations(). This first pass
        is read-only. One new layout test that examines animation
        properties. Update existing layout tests for the new interfaces
        on Window.

        * animations/animation-api-1-expected.txt: Added.
        * animations/animation-api-1.html: Added.
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: introduce error argument for all the callbacks on frontend.
        https://bugs.webkit.org/show_bug.cgi?id=56100

        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end: number of files

2011-03-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: introduce error argument for all the callbacks on frontend.
        https://bugs.webkit.org/show_bug.cgi?id=56100

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        * inspector/console/console-dir-global.html:
        * inspector/elements/dom-agent-query-selector.html:
        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/protocol/runtime-agent.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.stopTimeline):




git-svn-id: svn://svn.chromium.org/blink/trunk@80845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        * bindings/js/JSInjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
        (WebCore::WeakReferenceCallback):
        (WebCore::createInjectedScriptHostV8Wrapper):
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::canAccessInspectedWindow):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::disconnect):
        (WebCore::InjectedScriptHost::inspectImpl):
        (WebCore::InjectedScriptHost::clearConsoleMessages):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::init):
        (WebCore::InjectedScriptHost::setFrontend):
        (WebCore::InjectedScriptHost::clearFrontend):
        * inspector/InjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::create):
        (WebCore::InjectedScriptManager::InjectedScriptManager):
        (WebCore::InjectedScriptManager::~InjectedScriptManager):
        (WebCore::InjectedScriptManager::disconnect):
        (WebCore::InjectedScriptManager::injectedScriptHost):
        (WebCore::InjectedScriptManager::injectedScriptForId):
        (WebCore::InjectedScriptManager::injectedScriptForObjectId):
        (WebCore::InjectedScriptManager::discardInjectedScripts):
        (WebCore::InjectedScriptManager::releaseObjectGroup):
        (WebCore::InjectedScriptManager::injectedScriptSource):
        (WebCore::InjectedScriptManager::injectScript):
        * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::focusNode):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::addInspectedNode):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::create):
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::releaseObject):
        (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):

git-svn-id: svn://svn.chromium.org/blink/trunk@80844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [GTK] JSC crashes in 32bit Release bots after r80743
        https://bugs.webkit.org/show_bug.cgi?id=56180

        Skipping a couple of tests until the original issue is fixed.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@80843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        [v8] Change the way group id for CSS objects is calculated
        https://bugs.webkit.org/show_bug.cgi?id=56117

        Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
        as they should not be reachable in JavaScript.

        Covered by existing layout tests.  Fact of absence of retention is not trivial to prove.

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId):
        (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

git-svn-id: svn://svn.chromium.org/blink/trunk@80842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Added new GTK+ test expectations.

        * platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
        * platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.png: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: hover over elements in Elements panel does not highlight nodes
        https://bugs.webkit.org/show_bug.cgi?id=56121

        In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
        is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
        for these 16px when computing the test point coordinates.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):

git-svn-id: svn://svn.chromium.org/blink/trunk@80840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed. Roll out r80837.



git-svn-id: svn://svn.chromium.org/blink/trunk@80839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.

        * inspector/report-API-errors.html:


git-svn-id: svn://svn.chromium.org/blink/trunk@80838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        * bindings/js/JSInjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
        (WebCore::WeakReferenceCallback):
        (WebCore::createInjectedScriptHostV8Wrapper):
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::canAccessInspectedWindow):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::disconnect):
        (WebCore::InjectedScriptHost::inspectImpl):
        (WebCore::InjectedScriptHost::clearConsoleMessages):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::init):
        (WebCore::InjectedScriptHost::setFrontend):
        (WebCore::InjectedScriptHost::clearFrontend):
        * inspector/InjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::create):
        (WebCore::InjectedScriptManager::InjectedScriptManager):
        (WebCore::InjectedScriptManager::~InjectedScriptManager):
        (WebCore::InjectedScriptManager::disconnect):
        (WebCore::InjectedScriptManager::injectedScriptHost):
        (WebCore::InjectedScriptManager::injectedScriptForId):
        (WebCore::InjectedScriptManager::injectedScriptForObjectId):
        (WebCore::InjectedScriptManager::discardInjectedScripts):
        (WebCore::InjectedScriptManager::releaseObjectGroup):
        (WebCore::InjectedScriptManager::injectedScriptSource):
        (WebCore::InjectedScriptManager::injectScript):
        * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::focusNode):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::addInspectedNode):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::create):
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::releaseObject):
        (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):

git-svn-id: svn://svn.chromium.org/blink/trunk@80837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Martin Robinson.

        [GTK] close-web-view emitted on disposed WebView
        https://bugs.webkit.org/show_bug.cgi?id=55932

        * WebCoreSupport/ChromeClientGtk.cpp:
        (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
        source before destruction of the ChromeClient.

git-svn-id: svn://svn.chromium.org/blink/trunk@80836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed.

        Skipping two test cases that are failing on GTK debug bots.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@80835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jeremy Orlow.

        IndexedDB: Make IDBBackingStore abstract
        https://bugs.webkit.org/show_bug.cgi?id=56013

        Make IDBBackingStore abstract to allow for multiple implementations.
        Move the SQLite implementation to IDBSQLiteBackingStore.

        No new tests: refactoring only.

        * WebCore.gypi:
        * storage/IDBBackingStore.h:
        (WebCore::IDBBackingStore::~IDBBackingStore):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
        (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
        (WebCore::runCommands):
        (WebCore::createTables):
        (WebCore::createMetaDataTable):
        (WebCore::getDatabaseSchemaVersion):
        (WebCore::migrateDatabase):
        (WebCore::IDBSQLiteBackingStore::open):
        (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
        (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
        (WebCore::IDBSQLiteBackingStore::getObjectStores):
        (WebCore::IDBSQLiteBackingStore::createObjectStore):
        (WebCore::doDelete):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
        (WebCore::whereSyntaxForKey):
        (WebCore::bindKeyToQuery):
        (WebCore::lowerCursorWhereFragment):
        (WebCore::upperCursorWhereFragment):
        (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
        (WebCore::bindKeyToQueryWithNulls):
        (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::clearObjectStore):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
        (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
        (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::getIndexes):
        (WebCore::IDBSQLiteBackingStore::createIndex):
        (WebCore::IDBSQLiteBackingStore::deleteIndex):
        (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
        (WebCore::keyFromQuery):
        (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
        (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
        (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexCursor):
        (WebCore::IDBSQLiteBackingStore::createTransaction):
        * storage/IDBSQLiteBackingStore.h: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build error fix.

        [EFL] Fix build break when SHARED_CORE is ON
        https://bugs.webkit.org/show_bug.cgi?id=56155

        * platform/efl/ContextMenuEfl.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/efl/ContextMenuItemEfl.cpp:
        (WebCore::ContextMenuItem::nativeMenuItem):
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):

git-svn-id: svn://svn.chromium.org/blink/trunk@80833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: resource load cancellation is reported to console as an error
        https://bugs.webkit.org/show_bug.cgi?id=55764

        - mark interruptionForPolicyChangeError as cancellation
        - do not log resource cancelation as an error
        - always push resource to front-end before console message, so front-end can use resource info while formatting message.

        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::didFailLoading):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::stopLoadingForPolicyChange):

2011-03-11  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: resource load cancellation is reported to console as an error
        https://bugs.webkit.org/show_bug.cgi?id=55764

        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download)
        * http/tests/inspector/console-xhr-logging-expected.txt:
        * http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors.
        * http/tests/inspector/resources/empty.zip: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@80832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
        https://bugs.webkit.org/show_bug.cgi?id=56096

        No new tests, as this is a refactoring.

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        * inspector/front-end/DetailedHeapshotView.js:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.BaseStorageTreeElement):
        (WebInspector.BaseStorageTreeElement.prototype.onattach):
        (WebInspector.StorageCategoryTreeElement):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameResourceTreeElement):
        (WebInspector.DatabaseTreeElement):
        (WebInspector.DatabaseTableTreeElement):
        (WebInspector.DOMStorageTreeElement):
        (WebInspector.CookieTreeElement):
        (WebInspector.ApplicationCacheTreeElement):
        (WebInspector.ResourceRevisionTreeElement):
        * inspector/front-end/utilities.js:
        (Element.prototype.removeStyleClass):
        (Element.prototype.addStyleClass):
        (Element.prototype.hasStyleClass):


git-svn-id: svn://svn.chromium.org/blink/trunk@80831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ojan Vafai.

        kill hung lighttpd processes on the chromium win bot
        https://bugs.webkit.org/show_bug.cgi?id=56152

        Sometimes this process doesn't exit and it holds on to
        a log file that we can't delete or copy, causing the tests
        to go red.

        * BuildSlaveSupport/win/kill-old-processes:

git-svn-id: svn://svn.chromium.org/blink/trunk@80830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Alice Liu.

* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item
as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will
be done by our call to loadURL elsewhere in the function.

git-svn-id: svn://svn.chromium.org/blink/trunk@80829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kent Tamura.

        [Chromium] missing HTMLInputElement::setValueForUser() to tests
        https://bugs.webkit.org/show_bug.cgi?id=55854

        * platform/chromium/test_expectations.txt: Removed onchange-setvalueforuser.html
2011-03-11  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] missing HTMLInputElement::setValueForUser() to tests
        https://bugs.webkit.org/show_bug.cgi?id=55854

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setValueForUser): Added.
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@80828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, skip
        tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
        on GTK again after being unskipped by accident in r80738.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@80827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        Adds GrContext flush call to PlatformContextSkia destructor.
Calls GrContext flush with int parameter instead of bool due to skia
revision.

        No new tests needed.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::publishToPlatformLayer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: svn://svn.chromium.org/blink/trunk@80826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jon Honeycutt.

        WebKit2 UI process crashes if web process crashes while computing page rects for printing
        https://bugs.webkit.org/show_bug.cgi?id=56160
        <rdar://problem/9027410>

        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView _suspendAutodisplay]): Added a null check for page, matching one that
        we have when resuming autodisplay.
        (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Added a FIXME.
        (pageDidComputePageRects): Sanitize results coming from the web process (and avoid crashing
        when there is a communication error, so results are all null).
        (-[WKPrintingView knowsPageRange:]): If there is no page any more, we can't tell how many
        pages it had.
        (-[WKPrintingView rectForPage:]): Handle the case where we are neither calculating pages
        nor knowing them, as it happens when the web process crashes.

git-svn-id: svn://svn.chromium.org/blink/trunk@80825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by James Robinson.

        Fix for Coverity discovered NO_EFFECT (self-assign) defect.
        https://bugs.webkit.org/show_bug.cgi?id=54143

        * platform/graphics/gpu/TilingData.cpp:
        (WebCore::TilingData::setMaxTextureSize):

git-svn-id: svn://svn.chromium.org/blink/trunk@80824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        The web colours palevioletred and mediumpurple are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=46658

        Added test for named colors.

        * fast/css/named-colors-expected.txt: Added.
        * fast/css/named-colors.html: Added.
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Alexey Proskuryakov.

        The web colours palevioletred and mediumpurple are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=46658

        Changed value for the palevioletred and mediumpurple colors to match
        the css3 specification.

        Test: fast/css/named-colors.html

        * inspector/front-end/Color.js:
        * platform/ColorData.gperf:

git-svn-id: svn://svn.chromium.org/blink/trunk@80823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed: update Chromium test expectations.

        * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-mac/fast/js/kde/function_length-expected.txt: Removed.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
        * platform/chromium-win/fast/js/kde/function_length-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        document.compatMode is incorrect for javascript: protocol URLs in IFRAMEs
        https://bugs.webkit.org/show_bug.cgi?id=27845

        This bug was randomly fixed by the HTML5 parser.

        * fast/parser/javascript-url-compat-mode-expected.txt: Added.
        * fast/parser/javascript-url-compat-mode.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        video-controls-in-media-document.html used to silently rely on
        timeupdate firing immediately upon playback start, and before any
        frames changed.  This was (unsurprisingly, in retrospect)
        super-brittle.  This change instead uses an explicit seek to put
        the video in a predictable state.  The expected.png change is only to
        change the "pause" button to "play" (which is part of what's
        required to have the video be in a predictable state for the pixel
        diff).  An equivalent rebaselining needs to happen for chromium
        mac & win.

        * media/video-controls-in-media-document.html:
        * platform/chromium/media/video-controls-in-media-document-expected.checksum:
        * platform/chromium/media/video-controls-in-media-document-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed: tweak Chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        Fixed a qdoc warning and terminology (WebKit instead of Webkit).
        https://bugs.webkit.org/show_bug.cgi?id=55756

        * Api/qwebhistoryinterface.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@80818 bbb929c8-8fbe-4397-9dbb-9b2b20218538