- 11 Jul, 2017 40 commits
-
-
yhanada authored
Caller takes ownership of the created object. We should use std::unique_ptr<> for it according to coding style guide. Bug: 731537 Test: Build passes. Change-Id: Ia8f5887219ec8696ed66728de3e65c04d7aaadbe Reviewed-on: https://chromium-review.googlesource.com/563278 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#485575}
-
Jérôme Lebel authored
The "ImpressionsTilDismiss" should be sent only when the setting view is closed (it was sent when going into a submenu of the settings). The display count should only be increased when opening the settings. Before it was increased for each data reload of the collection view. Bug: 709286 Change-Id: I301f96241f7704aa01695fc41e841364fca1f80a Reviewed-on: https://chromium-review.googlesource.com/563389 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485574}
-
Becca Hughes authored
If no sound was made then do not record significant playback BUG=729998 Change-Id: I348649bfa2fefc2556717e011609ffa7813672a8 Reviewed-on: https://chromium-review.googlesource.com/537253Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#485573}
-
Stanislav Albreht authored
The field was used uninitialized what may lead to arbitrary number of unwanted network request retries when server replies 5xx. Change-Id: I4700d8186f81dc133b64440a392d3a916247a739 Reviewed-on: https://chromium-review.googlesource.com/564610 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#485572}
-
Peter E Conn authored
After https://codereview.chromium.org/2946223002/ landed renaming FullScreenActivity to SingleTabActivity, we can rename FullscreenWebContentsActivity to FullscreenActivity to keep things simpler. Bug: 740534 Change-Id: Idb72b4734aaf211799f3c5956c3f626be05f0105 Reviewed-on: https://chromium-review.googlesource.com/565409Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#485571}
-
Dominic Cooney authored
This arises from the frame disconnecting the context's per context data when the frame is disconnected; which is <crbug.com/583429>. Bug: 740455 Change-Id: I71967c43b69f8dd4df7c9c97acf9db7868b13af6 Reviewed-on: https://chromium-review.googlesource.com/566265 Commit-Queue: Dominic Cooney (OOF until 7/28) <dominicc@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#485570}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cd46302..1604146f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I99ef67675285d4e3f106901c5315b480024c8ba3 Reviewed-on: https://chromium-review.googlesource.com/566618Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485569}
-
Marc Treib authored
This is mostly a reland of https://chromium-review.googlesource.com/548719 which was reverted because of perf impact. In the meantime, https://chromium-review.googlesource.com/558924 has landed which hopefully improves performance. It also adds the CaptureThumbnailDependingOnTransitionType feature, since the two will likely launch together (and that might also alleviate the perf impact). Bug: 718413, 737396 Change-Id: I0ef909f0015d07a3f908d0ba3dc52f6a897a53b1 Reviewed-on: https://chromium-review.googlesource.com/563202Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#485568}
-
Jia authored
Implement ConsumeShorthandGreedilyViaLonghandsAPI and API for shorthand property -webkit-text-emphasis. ConsumeShorthandGreedilyViaLonghandsAPI is a modified version of ConsumeShorthandGreedily of CSSPropertyParser. The difference between the two is that the new version expects component longhands to have API impl already as it will forward parsing logic to component longhands API via ParseLonghandViaAPI. ConsumeShorthandGreedily will be deprecated soon, when shorthand properties are ribbonised (i.e. have their own APIs). Until then, there is a slight code duplication between the two versions for the following reasons: 1. An alternative to code duplicate is to have the old ConsumeShorthandGreedily call the new ConsumeShorthandGreedilyViaLonghandsAPI. However, the new ConsumeShorthandGreedilyViaLonghandsAPI expects ALL component longhands to have APIs and will parse all longhands via their APIs. In order to parse shorthands, where some component longhands do not have APIs, the new ConsumeShorthandGreedilyViaLonghandsAPI will need to return to the old ConsumeShorthandGreedily which longhands have no APIs and thus are not parsed. The old ConsumeShorthandGreedily will then have to parse these longhands separately. Hence there's added code complexity with little code reduction. 2. All shorthand properties will have APIs soon, hence such code duplication is temporary only. This cl also implements API for shorthand property -webkit-text-emphasis as a use case of ConsumeShorthandGreedilyViaLonghandsAPI. Design doc for shorthand parsing: https://docs.google.com/document/d/1gF_3wAvO82iVNcyJ7z2YzT8sFa8JepkWmIgJ9NcT1Pc/edit Diff: https://gist.github.com/f9cff56b20f46225b6b90f033798eccf/revisions Bug: 668012 Change-Id: I1cf9295893bb113527b44c2935d296e2997164ac Reviewed-on: https://chromium-review.googlesource.com/564875Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485567}
-
Takayoshi Kochi authored
webcomponents-bugzilla@chromium.org is a legacy mailing list and nobody cares today. Change-Id: I53c99ec3b7b4ed7b9a1e4cf4b93e3bc0c0a80760 Reviewed-on: https://chromium-review.googlesource.com/566779Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485566}
-
Mark Cogan authored
This CL removes the IDC_SHOW_TOOLS_MENU command, and updates call sites. This involves: - Adding a command dispatcher to the stack view. This is done by defining a dispatcher property on the TabSwitcher protocol; StackViewController creates a dispatcher on init and returns it for this property. The tab switcher view controller returns nil (for now). - The special case in the tools menu on phones for the menu button to no-op but still record metrics is removed by simply not having the tools menu button in that case call -showToolsMenu. (Note that tapping the tools menu button while the menu is showing is still a no-op, presumably because that's easier than special-casing the button to do nothing. Since all of the menu and toolbar code is moribund, this doesn't seem worth cleaning up.) Bug: Change-Id: I6d90ff72cdc6969679ec1c5e07dd6ee32cf0deed Reviewed-on: https://chromium-review.googlesource.com/563660 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 45f7994f. Reason for revert: Broke BrowserWindowControllerTest.UsesAutoLayout Original change's description: > Enable ShouldUseFullSizeContentView(). > > Also fixes the known issues with enabling it: > > - crbug/665787: The tab background view was added in front of the content and > blocked interaction with the top of the scroll bar when the toolbar was > hidden. It's now inserted behind the content, like before. > > - crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the > frame view, which gets drawn using a different (layer-backed?) path when > NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction > flush] before taking each screenshot, and uses a different API to screenshot > the whole window instead of trying to grab just the frame view by accessing > the content view's superview. > > Bug: 605219, 655112, 665787, 730679, 734713, 737206 > Change-Id: Id78c21aff6748e02fd4b3e461c77ef9f7454d744 > Reviewed-on: https://chromium-review.googlesource.com/566030 > Commit-Queue: Sidney San Martin <sdy@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485544} TBR=tapted@chromium.org,shrike@chromium.org,sdy@chromium.org Change-Id: I00b73bc5d2d5607736ddc81b9ae81ec65527ebad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 605219, 655112, 665787, 730679, 734713, 737206 Reviewed-on: https://chromium-review.googlesource.com/566898Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485564}
-
calamity authored
This CL disables the sort button in the toolbar action menu for empty folders. BUG=737034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2973783002 Cr-Commit-Position: refs/heads/master@{#485563}
-
djmix.kim authored
This simplifies many conditions around the code in components/favicon, components/cast_certificate, components/cloud_devices and components/component_updater. BUG=561800 Change-Id: I4b806000938a513186c3c56cf9fef159028551cb Reviewed-on: https://chromium-review.googlesource.com/565359Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485562}
-
gambard authored
The height of the ContentSuggestions cells were calculated using auto layout. This introduce a lag when the layout is invalidated, visible when a scrolling gesture is started. Using a pre-calculated height allow us to reduce the compute time and eliminate the lag. BUG=740450 Change-Id: I64f0e670c460d8fbce5a2af9001fa874fa41d55c Reviewed-on: https://chromium-review.googlesource.com/563669Reviewed-by:
-
gambard authored
This CL removes the article summaries to be on par with the Android implementation. BUG=740504 Change-Id: Icbd6a8560ec4fbe2c59eccefac19a5bea0c7527e Reviewed-on: https://chromium-review.googlesource.com/565279Reviewed-by:
-
Kinuko Yasuda authored
time_origin_ is not initialized in PerformanceResourceTiming ctor for PerformanceNavigationTiming. This got broken in crrev.com/2647643004 Bug: 732622 Change-Id: I735ea6777d88b0e89031654216d74f860e05bcb8 Reviewed-on: https://chromium-review.googlesource.com/566261Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485559}
-
Daniel Bratell authored
Some of third_party/WebKit/Source/webdatabase uses sqlite withq internals exposed and some uses it with internals not exposed. That mismatch causes issues in jumbo builds since it compiles several files together and need headers to say the same thing. This changes webdatabase so that it all compile with the CHROMIUM_SQLITE_INTERNALS define set. R=michaeln@chromium.org Bug: 740542 Change-Id: I0b5c66fde7d191afd7a7143ef32c9c6f1b21b9e2 Reviewed-on: https://chromium-review.googlesource.com/565502Reviewed-by:
Michael Nordman <michaeln@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#485558}
-
tmoniuszko authored
Both Profile and Browser are used in code. BUG= Review-Url: https://codereview.chromium.org/2966033002 Cr-Commit-Position: refs/heads/master@{#485557}
-
dmazzoni authored
Patch r483065 (codereview.chromium.org/2958103002/) used the wrong function to convert the size of a root window to the desired units. It used ConvertDIPToScreenInPixels, which won't always do what we want depending on the relative position of the displays. Instead we should just multiply by the device scale factor. BUG=723147 Review-Url: https://codereview.chromium.org/2966913002 Cr-Commit-Position: refs/heads/master@{#485556}
-
Daniel Bratell authored
The PNG fuzzer included all of PNGImageDecoder.cpp and effectively compiled it a second time. Since the fuzzer already depends on the png encoder it will just be linked together anyway. This double compilation caused jumbo errors because symbols appeared twice. Change-Id: I0ef1502ba90247e34c33055056bdeb808e0dbb89 Reviewed-on: https://chromium-review.googlesource.com/565411Reviewed-by:
-
Tomasz Mikolajewski authored
This reverts commit 7fa78bb0. Reason for revert: Crashing browser process on null ptr dereference. Original change's description: > Add memory UKMs for existing UMA metrics. > > Bug: 730783, 728707 > Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b > Reviewed-on: https://chromium-review.googlesource.com/531804 > Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485159} TBR=rkaplow@chromium.org,erikchen@chromium.org,jchinlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 730783, 728707 Change-Id: I0993305f4eb65343faf6678054de0d1c2d1fcddb Reviewed-on: https://chromium-review.googlesource.com/566518Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#485554}
-
Minh-Duc Nguyen authored
image-rendering's camel-case keyword does not follow normal convention because it comes from a different format. https://developer.mozilla.org/en/docs/Web/CSS/image-rendering#Specifications text-align's webkit keyword is a webkit prefix keywords, if we can decide we should follow the convention of CSS property to be consistent. Bug: Change-Id: I0fea055fe67ea521ad0456ef120ba91adf273267 Reviewed-on: https://chromium-review.googlesource.com/566142 Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#485553}
-
Takashi Toyoshima authored
This patch introduces a field trial for the ResourceLoadScheduler and makes the feature configurable through chrome://flags and field trial parameters. Bug: 729953 Change-Id: Id8619ad8979669748e94a9988c0a46ef6a318726 Reviewed-on: https://chromium-review.googlesource.com/558902 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#485552}
-
Kent Tamura authored
DOMTreeMutationDetector missed to find unexpected DOM tree mutation if |parent| node is adopted to another Document during a watched operation. This CL fixes it. Bug: 740410 Change-Id: I7b4d2c4c525e10e0d6b19229c27b5d1ce077a271 Reviewed-on: https://chromium-review.googlesource.com/566267Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL adds a CreateVideoEncodeAccelerator() methods to the gpu.mojom and gpu_service.mojom files (renderer-to-browser interface and browser-to-gpu interfaces, resp.), and wires the new mojom::VideoEncodeAcceleratorRequest pass through. This is step 0 of VEA mojification, which is currently IPC-based. More info can be found in the DD https://goo.gl/PbTKnt, concretely this CL can be better understood in the context of the first diagram in the document, also here, for conveniency: https://goo.gl/HkwYvA. A playground with most of the changes pre-review can be found in https://crrev.com/c/558846. Bug: 736517 Change-Id: Id1f6d60d487d97ce3f304bead73738b2ba531408 Reviewed-on: https://chromium-review.googlesource.com/558833 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#485550}
-
Dominick Ng authored
BUG=None Change-Id: I8c2963866273a92e2b5b6e7ea80ca176d761a1b6 Reviewed-on: https://chromium-review.googlesource.com/566214Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#485549}
-
Kent Tamura authored
This macro requires an undefined-but-common behavior of C preprocessor, and is not used widely. We can simply replace USE(FOO) with defined(WTF_USE_FOO). WTF_USE_FOO macros are usually defined in BUILD.gn. As for WTF_USE_APPLE_SYSTEM_LOG, we don't need this macro because we support only macOS 10.9+. Bug: 667238 Change-Id: I55c6b952bc9d77744ccd3e9b0a241e3093b10c46 Reviewed-on: https://chromium-review.googlesource.com/566343Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#485548}
-
Colin Blundell authored
This CL augments the existing ServiceManager embedding on iOS with support for per-user embedded services. A "per-user" service is one that has one instance per user, rather than a shared instance for all users. Concretely, each BrowserState has a unique UserID, and there is one instance of a per-user service per UserID. Essentially, one can think of per-user services as the equivalent of profile-keyed services in the services world. The support added in this CL closely follows that of //content: - Public APIs are identical - Implementation in BrowserState follows that of BrowserContext with minor changes: - iOS doesn't use File Service at this time - No client of //ios/web needs to override how a user ID is generated This CL adds an Earl Grey test of web_shell that a per-user service can be embedded and if connected to from a given BrowserState, has its user ID properly associated with that of the BrowserState. Finally, this added support requires that all BrowserState subclasses call BrowserState::Initialize(). This is also done in this CL. Bug: 731588 Change-Id: Ie3bb79d4f754aecddd9c35c72576262dfc87cb55 Reviewed-on: https://chromium-review.googlesource.com/559529Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This malformed summary description causes continuous presubmit warnings for changes touching tools/metrics. TBR=isherman@chromium.org Change-Id: I3b745fb55f108b3a741046ac8809b6f421d15a0f Reviewed-on: https://chromium-review.googlesource.com/566165Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClient, as prepration to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I51397108a365d8b79b8de8a48263d7b62ef0182b Reviewed-on: https://chromium-review.googlesource.com/563153Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485545}
-
Sidney San Martín authored
Also fixes the known issues with enabling it: - crbug/665787: The tab background view was added in front of the content and blocked interaction with the top of the scroll bar when the toolbar was hidden. It's now inserted behind the content, like before. - crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the frame view, which gets drawn using a different (layer-backed?) path when NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction flush] before taking each screenshot, and uses a different API to screenshot the whole window instead of trying to grab just the frame view by accessing the content view's superview. Bug: 605219, 655112, 665787, 730679, 734713, 737206 Change-Id: Id78c21aff6748e02fd4b3e461c77ef9f7454d744 Reviewed-on: https://chromium-review.googlesource.com/566030 Commit-Queue: Sidney San Martin <sdy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#485544}
-
Wei-Yin Chen (陳威尹) authored
Context reporting records the URL, title, and selection to Icing. If the context is the same as last time, skip it to avoid useless API calls to Icing. This CL lowers the reporting per navigation to ~1. Bug: 739570 Change-Id: Id8d538c02f08e51ebdc729190a683856832b3a2e Reviewed-on: https://chromium-review.googlesource.com/562546 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485543}
-
Raphael Kubo da Costa authored
The typedef was added back in 2014 in commit 38b7b40a ("Improve the declared IDL type for postMessage()'s transferables"), when the HTML Living Standard defined a Transferable typedef like this: typedef (ArrayBuffer or CanvasProxy or MessagePort) Transferable; since the bindings layer did not support unions at the time and all uses of Transferable in our IDLs amounted to MessagePort objects, the current "typedef MessagePort Transferable" was introduced for compliance. https://github.com/whatwg/html/commit/bfb960c938580c95e77365e614218b952f96375b ("Write structured clone algorithm in terms of ECMAScript") got rid of the typedef in the spec altogether though, so we were again not compliant in our IDLs. This CL makes the switch by using object instead of Transferable in the IDLs. In practice, this does not make any difference, as |transfer| is always parsed via SerializedScriptValue::ExtractTransferables(), which does all the argument parsing on its own. While here, also make a few other IDL updates that do not change the generated bindings code, in some cases due to the fact that the postMessage() bindings code is more customized than usual: - Add a "= []" to the "optional sequence<object>" postMessage() arguments. - Change |message|'s type from "SerializedScriptValue" to "any" in some postMessage() declarations to match the spec(s). - Update the spec link in ServiceWorker.idl. Bug: 701482 Change-Id: I0a5c0dc7fed8f3498ccd072b4422fb269e5def97 Reviewed-on: https://chromium-review.googlesource.com/561459Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#485542}
-
Darren Shen authored
Since OutlineValue has been deleted, whether an outline is auto or not is now stored in a separate field. This means we no longer need EBorderStyle to store it. This patch removes the unused auto value in EBorderStyle. Change-Id: I3d698a65f6b0a8a1e2b4bc7cb2e1279e410a7461 Reviewed-on: https://chromium-review.googlesource.com/560807 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
suzyh authored
This patch moves SVG-related tests from the top level of the LayoutTests/animations directory to a dedicated subdirectory. Existing SVG-related subdirectories are untouched. BUG=623434 Review-Url: https://codereview.chromium.org/2975793004 Cr-Commit-Position: refs/heads/master@{#485540}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10d68afb..0cd46302 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ia0ed92cbb5c506b3cad318cc266d1df4312038bd Reviewed-on: https://chromium-review.googlesource.com/566331Reviewed-by:
-
Yoshifumi Inoue authored
This patch converts |TextGranularity| to enum class as a preparation of moving "TextGranularity.h" from header file to cpp file for reducing build time. Change-Id: I489b573e6717c44de55367e528f492fe52e11e85 Reviewed-on: https://chromium-review.googlesource.com/563138Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485538}
-
Bo Liu authored
Unbind and rebind if onServiceConnection does not come after a timeout, currently set to 10s. Add a unit test, but do not enable this behavior in production yet. The current plan is then to add some UMA metrics and evaluate result to decide whether it's worth turning this on or not. BUG=736066 Change-Id: Id06b11005c781932810b32e11592727f580ef38c Reviewed-on: https://chromium-review.googlesource.com/562653 Commit-Queue: Bo Liu <boliu@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#485537}
-
suzyh authored
This patch makes a number of small rearrangements in the LayoutTests/animations directory: - Enables a disabled but passing test (font-size-using-ems) - Deletes the under-used script-tests directory (inlining the only use, animation-css-rule-types) - Moves animate-shorthand-var to the custom-properties test subdirectory - Moves four tests to a new hit-testing subdirectory - Renames a test that refers to 'players' instead of 'animations' (get-css-players -> getAnimations-css) BUG=623434 Review-Url: https://codereview.chromium.org/2974853002 Cr-Commit-Position: refs/heads/master@{#485536}
-
