- 20 Sep, 2018 40 commits
-
-
Chinglin Yu authored
Use memory_instrumentation::OSMetrics::FillOSMemoryDump(), which reads /proc/<pid>/statm, to get private bytes of a process, to avoid contention with kswapd under heavy memory pressure. BUG=chromium:872253 TEST=manual R=cylee@chromium.org, sonnyrao@chromium.org, fdoray@chromium.org Change-Id: I4d43933a39c3c89d8ebb81e3ccef20277cedb258 Reviewed-on: https://chromium-review.googlesource.com/1212246 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#592701}
-
Marc Treib authored
Supervised users have been gone for a long time. Bug: 828890 Change-Id: I18b12e49ac10c445eabc7151e7f3b7995b5fa24d Reviewed-on: https://chromium-review.googlesource.com/1231314 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#592700}
-
Marc Treib authored
It doesn't really do anything useful: It provides an observer mechanism which only passes through SyncServiceObserver::OnStateChanged (so anyone interested might just use that directly), and it has single, misnamed method HasError() which is replaced by a global ShouldShowPassphraseError helper. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0116b6cf5d3a814bc2b3fa51e79da7a3c2eebc63 Reviewed-on: https://chromium-review.googlesource.com/1230056Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#592699}
-
Jia authored
This is almost the same cl as https://chromium-review.googlesource.com/c/chromium/src/+/1226715 The previous cl was reverted because it broke linux-chromeos-dbg due to missing "=0" for a virtual method of an abstract class (incorrect gn config meant the compiler didn't pick it up). It's added in this cl. This is the only change from the previous cl. Bug: 881215 Change-Id: Iaf5ab6e3ee98c11b593dcc9d759527c4fb3b2168 Reviewed-on: https://chromium-review.googlesource.com/1235262Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592698}
-
Hajime Hoshi authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1229739 Bug: 870606 Change-Id: I0b877b3b611e9696e9d8fe38c8091ec8fbe5b304 Reviewed-on: https://chromium-review.googlesource.com/1233102Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592697}
-
Matthew Cary authored
Adds ART build tools used for android builds, in particular dexlayout and associated profile management. Bug: 875276 Change-Id: I323e460dfca032a5b28a634d149d1f50c8563f3b Reviewed-on: https://chromium-review.googlesource.com/1218584Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592696}
-
tzik authored
MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog is failing on the mac bot. The error logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/1321 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935002203177419984/+/steps/browser_tests_on__none__GPU_on_Mac/0/logs/MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog/0 Tbr: mfoltz@chromium.org Bug: 883976 Change-Id: I9b7e42b65ec44a97a74d236c179e1698ef0c895e Reviewed-on: https://chromium-review.googlesource.com/1235264Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#592695}
-
Devlin Cronin authored
ui::MenuModel (which ui::SimpleMenuModel inherits from) declares a virtual method, `void MenuWillShow()`. SimpleMenuModel::Delegate declares a similar method, `void MenuWillShow(SimpleMenuModel*)`. This results in a conflict for any class that inherits from both SimpleMenuModel and SimpleMenuModel::Delegate (which is not uncommon). Resolve this by renaming the SimpleMenuModel::Delegate version to `void SimpleMenuWillShow(SimpleMenuModel*)`. Bug: 885198 Change-Id: I0581991fa7a12368007f6c082c461acb4833750c Reviewed-on: https://chromium-review.googlesource.com/1230581Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592694}
-
Donna Wu authored
The original CL has been reverted because it failed on USB browser tests for the race condition between UsbDeviceManager::SetClient() and UsbDeviceManagerClient::OnDeviceRemoved/Added() events. Before this CL, two client bindings from UsbDeviceManager to Blink have been made associated and a earlier connection is set up before all requests to UsbDeviceManager in this CL. The original CL's description: > For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled > after "OnDeviceRemoved". But for mojom interface UsbDeviceManager, > there is no way to provide such dependency among listeners. > > As all users will be converted from UsbService to UsbDeviceManager, > to avoid the potential race condition, WebUsbServiceImpl is made > listen to UsbChooserContext in this CL. > > Bug: 699790 > Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b > Reviewed-on: https://chromium-review.googlesource.com/1210386 Bug: 699790 Change-Id: Ied803bf1e3b0fcc8daad14f6acd4a6d3ca98129f Reviewed-on: https://chromium-review.googlesource.com/1226824 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592693}
-
Anand K. Mistry authored
And remove yamaguchi. BUG=None Change-Id: Icac3b856995fb0b60b0b309825852715de99059b Reviewed-on: https://chromium-review.googlesource.com/1235357Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592692}
-
Taiju Tsuiki authored
This reverts commit 16355cba. Reason for revert: This seems to cause an ASAN failure on the CI. The error logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29069 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934902171469785040/+/steps/interactive_ui_tests/0/logs/DownloadNotificationTest.IncognitoDownloadFile/0 Original change's description: > More OfflineItemModel implementation > > This CL makes OfflineItemModel inherit from DownloadUIModel > > Bug: 881499 > Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e > Reviewed-on: https://chromium-review.googlesource.com/1225888 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592645} TBR=qinmin@chromium.org,shaktisahu@chromium.org Change-Id: Ifdae8934bae3cf137fd2e4729f076f8df577241d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/1234099Reviewed-by:
-
Noel Gordon authored
Make the initialization promise await DOMContentLoaded and then apply i18n transforms to the video player DOM [1]. Minor: correct commentary, add commentary. Add assertions re document readyState when the i18n template strings are applied. [1] Applying i18n strings to an incomplete (readyState === 'loading') DOM document makes no sense at all. Test: browser_tests --gtest_filter="VideoPlayerBrowserTest*" Bug: 884963 Change-Id: Ie5a25763c54c56e949edde40c7e06b8eaad230c4 Reviewed-on: https://chromium-review.googlesource.com/1233394 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#592690}
-
Anand K. Mistry authored
BUG=875700 Change-Id: I8d54318dd4247d655d1e57d5d2dd358769082b83 Reviewed-on: https://chromium-review.googlesource.com/1235358Reviewed-by:
-
Hayato Ito authored
Change-Id: I06fa719a2480e45d8a5d236210f7ae6243471e7e Reviewed-on: https://chromium-review.googlesource.com/1235360 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592688}
-
Taiju Tsuiki authored
This reverts commit 310c1d6c. Reason for revert: This seems to cause a build failure on linux-chromeos-dbg. The failure logs are below. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7896 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934907190108326448/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 Original change's description: > [On-device adaptive brightness] Create a BrightnessMonitor. > > BrightnessMonitor receives brightness change signals from powerd and > sends out notifications if the change is requested by user. We use > this class instead of powerd directly because we need final/stablized > user brightness instead of intermediate values (that are individually > emitted by powerd). In order to wait for brightness to stablize, we > use a timer that starts when a user brightness is detected and times > out after a period of time if there's no more user brightness detected, > or if the next brightness change is not triggered by the user. > > BrightnessMonitor also notifies its observers as soon as a user > brightness is detected so that an observer can decide what to do (e.g > disable auto-adjustment). > > Bug: 881215 > Change-Id: I2d9aefd8ff48eab37de9527d12657fd4dfeba793 > Reviewed-on: https://chromium-review.googlesource.com/1226715 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Michael Martis <martis@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592605} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: I5e88966455c8bfab9e089580a0ba622c1a2c6026 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1235260Reviewed-by:
-
Amos Lim authored
InstanceCountersMemoryDumpProvider.cc was not renamed as snake case with no reason. Bug: 768828 Change-Id: Icf323d551341647dd7d3beb637f949f3053c95a5 Reviewed-on: https://chromium-review.googlesource.com/1235354Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#592686}
-
Aidan Wolter authored
Invalid timestamps can occur when a stream is closed. These timestamps are represented by the minimum value of an int64. This change catches this value and stops interpretting it as a valid timestamp. The rendering pipeline was crashing when receiving negative timestamps. Bug: b/115771591 Test: Play YT, Hit next/prev Change-Id: I0809a9563aa1e865e4832cbecb6a54886a350f2f Reviewed-on: https://chromium-review.googlesource.com/1235291Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75040d8b299c..98555ca139f9 Created with: gclient setdep -r src-internal@98555ca139f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6515a4d2c5bca500a9b3c89418709c48059a2c42 Reviewed-on: https://chromium-review.googlesource.com/1235414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592684}
-
David Staessens authored
The VAAPI JPEG decoder on some platforms won't convert the decoded images to the I420 format, but will return the decoded images in their original pixel format. This means a conversion must be done in the VAAPI wrapper to the expected I420 output format. This change adds a SamplingFormatChange test that will test whether the conversion is successful for JPEGS with different sampling formats. Additional cleanup: * Added some comments for clarification TEST=ran JDA tests on eve and grunt Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibade43422590268d774b8d330097e46a8a33bca1 Reviewed-on: https://chromium-review.googlesource.com/1218386Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#592683}
-
Donna Wu authored
Bug: 699790 Change-Id: I7fd6e119db118da8a00810e1015a4464d1a00cc4 Reviewed-on: https://chromium-review.googlesource.com/1224971Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#592682}
-
Hwanseung Lee authored
When HasEquivalentAttributes is called, Element object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I237a11e88236ef195ade12ee26b0722786f17e29 Reviewed-on: https://chromium-review.googlesource.com/1232810Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#592681}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c1a7f2c78db..4054351369df git log 6c1a7f2c78db..4054351369df --date=short --no-merges --format='%ad %ae %s' 2018-09-20 fmalita@chromium.org [skottie] Add support for external font loading Created with: gclient setdep -r src/third_party/skia@4054351369df The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I3ec23d5d0884e8a794775c966660a9e6ca4808f4 Reviewed-on: https://chromium-review.googlesource.com/1235328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592680}
-
Ned Nguyen authored
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6805cf73d89312072404297206de3fb6c0d044be TBR=perezju@chromium.org Change-Id: I6805cf73d89312072404297206de3fb6c0d044be Reviewed-on: https://chromium-review.googlesource.com/1234355Reviewed-by:
-
Felipe Salazar authored
Bug: internal b/115797741 Change-Id: Ib7d5c836a83ad43b44712ce86fb13f224be01823 Reviewed-on: https://chromium-review.googlesource.com/1234965Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Felipe Salazar <felipesalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592678}
-
Koji Ishii authored
Following bot results are included. 9841 9844 9847 9852 9854 9857 9863 9867 9874 9877 2 lines were removed and 0 lines were deflaked by consecutive results since 9840. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic57f641a46a9a1b1cddee362a58340d6e27962c8 Reviewed-on: https://chromium-review.googlesource.com/1233053 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#592677}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia0a8e23474358528d23d2c0822f028d8ed513e5a Reviewed-on: https://chromium-review.googlesource.com/1235379 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592676}
-
Sammie Quon authored
Test: manual Bug: 880947 Change-Id: Id5005664eab5f6988fe8f8368c75a8755e833554 Reviewed-on: https://chromium-review.googlesource.com/1234359 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592675}
-
Istiaque Ahmed authored
When EventAckData sees an event dispatch in IncrementInflightEvent on UI [1] thread, it hops to IO thread to start the associated worker and then returns to UI[2] to *record* that the event needs an ack from the renderer process. Event ACKs arriving between UI[1] and UI[2] would incorrectly fail to find the associated data in the *record*. This results in bad message termination. Move the data to IO thread instead, where both IncrementInflightEvent and DecrementInflightEvent can access the unacked event data. Note that both IncrementInflightEvent/DecrementInflightEvent has to pass through IO thread anyway to access ServiceWorkerContext. The new inner class IOEventData inside EventAckData contains the map for unacked events. This also fixes and enables an existing test's flakiness: FilteredEventsAfterRestart. Bug: 844821 Change-Id: Ia9df6c896abbae62c9f395f62ef67cab8e1bfb74 Reviewed-on: https://chromium-review.googlesource.com/1228994 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f524571e7f35..75040d8b299c Created with: gclient setdep -r src-internal@75040d8b299c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaff23ca0b9832a640985db862646f949b7a17ec1 Reviewed-on: https://chromium-review.googlesource.com/1234751Reviewed-by:
-
Luciano Pacheco authored
Fix is used on crrev.com/c/1188046 Change-Id: I9edeeac193584599230a9348e21e93ae4aec887c Reviewed-on: https://chromium-review.googlesource.com/1229738Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592672}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5445ed7b039684fe1479a8f20eadd25a6dcaa805 Reviewed-on: https://chromium-review.googlesource.com/1235226Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#592671}
-
Renjie authored
Currently when CloseSessionOnError() is called, it always does SILENT_CLOSE when closing the connection. However, sometimes this method is called to abort an active session, which means a connection close packet should be sent. Thus we should refactor this method to take a behavior paramater so the caller can decide which connection close behavior is proper in its own situation. Change-Id: I2601f4ed6fbd48d9ce89dad6f7a1f6b6fc4eddbd Reviewed-on: https://chromium-review.googlesource.com/1227399Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592670}
-
Erik Luo authored
With keyboard navigation experiment enabled, - Switch viewport's focus proxy from `element` > `_contentElement` - Clicking a message will select it - Click-selection applies "blue" highlight, except when a user expands objects, groups, or traces - Move focus from log > prompt when user types on 'keydown' - Better distinguish events below prompt (geometry works with MouseEvents, but not FocusEvents) - Stick to bottom when prompt gains focus Bug: 865674 Change-Id: I473bcdf714408406b0ce7a49772589daf3cbe9cb Reviewed-on: https://chromium-review.googlesource.com/1171814Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#592669}
-
Dan Beam authored
R=dpapad@chromium.org BUG=884428 Change-Id: Icfe2e0993204434e2639b506bd581e0fd7ef296e Reviewed-on: https://chromium-review.googlesource.com/1227596Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#592668}
-
Shakti Sahu authored
Bug: 885322 Change-Id: Id509eb2009958b2532a428abd8db5156a7c026ae Reviewed-on: https://chromium-review.googlesource.com/1232477 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592667}
-
Donna Wu authored
With separated pipes, there will be a race condition between GetDevices() method and OnDeviceAdded/Removed events. In this case, device list returned from GetDevices() may out of date if a event happened between the request sending out the client getting the device list. This CL made the client bindings associated for UsbDeviceManager interface and implemented it in device::usb::DeviceManagerImpl to eliminate the potential race condition. Bug: 699790 Change-Id: Iad019009fa831f6d2f3ccf9b5c7064f18c416cea Reviewed-on: https://chromium-review.googlesource.com/1223339Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chaopeng authored
In http://crrev.com/592186 we landed a performance improvement based on querying the direct compositing reasons of the transform node. This change lets us use that bit for non-BlinkGenPropertyTrees code which fixes the perf regression. Bug: 875991 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1eab209e49a9685877c90e61b8388dc548f1e73 Reviewed-on: https://chromium-review.googlesource.com/1231836 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592665}
-
Erik Luo authored
Bug: none Change-Id: I6e206b63e45e8b6e4510125195aa1169223d5d1e Reviewed-on: https://chromium-review.googlesource.com/1220550Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d39389f6ec2e..109aa6d0f673 git log d39389f6ec2e..109aa6d0f673 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 thestig@chromium.org Remove more unneeded STL #includes from headers. 2018-09-20 thestig@chromium.org Remove many unneeded STL #includes from headers. Created with: gclient setdep -r src/third_party/pdfium@109aa6d0f673 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I79cdf382a6e67cc2d5e449a80c6da07d090aa94a Reviewed-on: https://chromium-review.googlesource.com/1235324Reviewed-by:
-
David Tseng authored
TBR=dmazzoni@chromium.org Change-Id: I65cf219b1e2e89fc6889f65daedbc81e2a616e14 Reviewed-on: https://chromium-review.googlesource.com/1235017Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592662}
-
