- 28 Feb, 2019 40 commits
-
-
Jonathan Backer authored
DirectContextProvider shares a GL context with SkiaRenderer. Both of these have GL state trackers that don't know anything about each other. ScopedUseContextProvider is responsible for keeping the state trackers consistent. These changes were necessary to make my reuse of GLRenderer color conversion work. I believe that GLRendererCopier has similar requirements, but that we got lucky with timing and bugs did not manifest. Change-Id: I9ac64f51498df0518aeac296ef2bea8fd156d635 Reviewed-on: https://chromium-review.googlesource.com/c/1495196Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636606}
-
Jeffrey Cohen authored
Bug: 910390 Change-Id: I04bb4593152a3b7fd418fe836d755f176a19533b Reviewed-on: https://chromium-review.googlesource.com/c/1481583 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636605}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67e3f02c..96fc7ac1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I266b7442de64e5224f8afe3d3c56c924b150e84b Reviewed-on: https://chromium-review.googlesource.com/c/1495794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636604}
-
Steven Bennetts authored
NetworkHandler uses Shill service paths to identify network services, but the forthcoming mojo API and the rest of the UI code uses GUID so this code needs to switch to GUID to support the mojo API. Bug: 923444 Change-Id: I739b36762b6f380ae70e054eba9284bad2773ba9 Reviewed-on: https://chromium-review.googlesource.com/c/1470939 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#636603}
-
Jon Kunkee authored
Specific tools need to run on the test-initiating machines instead of the build host or the build target. Since GN does not provide a third toolchain designation for this, it needs to be calculated in the exceptional cases that need it. This CL adds this logic for imagediff. Bug: 893460 Change-Id: I07f7a39971f47517550fc4edc0922f4b15eb87e5 Reviewed-on: https://chromium-review.googlesource.com/c/1489484 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#636602}
-
Ryan Sturm authored
This is being launched to 100% of stable after this CL lands. Bug: 914029 Change-Id: Iecaeaa54fa404c9f25ae2d8172a3a620ff4533a9 Reviewed-on: https://chromium-review.googlesource.com/c/1490732Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#636601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72565d358a64..a365aff3ed0b Created with: gclient setdep -r src-internal@a365aff3ed0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790200,chromium:790185,chromium:790192,chromium:790194,chromium:790196,chromium:790229 TBR=mmoss@chromium.org Change-Id: I88faf5b2a64cf39fb8140c67dc7f7d6f589401f4 Reviewed-on: https://chromium-review.googlesource.com/c/1494830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636600}
-
Lukasz Anforowicz authored
Bug: 935094, 936887 Change-Id: Ie1df72cc3638f3bfd3ce22f1af26ab40bd1fa2ca Reviewed-on: https://chromium-review.googlesource.com/c/1495795 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636599}
-
Matt Falkenhagen authored
Heavily based on an original CL by Charles Vazac <cvazac@akamai.com> at https://chromium-review.googlesource.com/c/chromium/src/+/1396938 Service worker navigation preload[1] is a web platform feature that involves sending a request to network at the same time as starting up the service worker for a navigation. This network request was not visible to extensions. This CL: - Modifies the network service path for service worker navigation preload requests so that the embedder is aware of them. - In web_request_permissions.cc, if a request is not considered a browser side navigation, it becomes opaque to extensions. This CL makes it so that service worker navigation preload requests[1] are exempted from that. This CL deletes the unit test for navigation preload in ServiceWorkerNavigationLoaderTest. It was too much hassle getting that to work with a TestWebContents because the infrastructure for enabling NetworkService in content_unittests is not set up yet so unittest_test_suite.cc typically disables NetworkService (issue 901092). We have sufficient navigation preload test coverage in browser tests and web tests. [1] https://w3c.github.io/ServiceWorker/#navigationpreloadmanager Bug: 914062 Change-Id: I4c91521e55c1103a1a67d973e595094b78357c34 Reviewed-on: https://chromium-review.googlesource.com/c/1491168Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636598}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/25fb765367e1..b8a4d688f907 git log 25fb765367e1..b8a4d688f907 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 srte@webrtc.org Allow injection of task queue factory in RtcEventLog. 2019-02-28 crodbro@webrtc.org Add bandwidth floor for RTT based backoff. 2019-02-28 Peter) Slatala Fix: Ignore empty frames in Media Transport 2019-02-28 jakobi@webrtc.org Fix jitter buffer delay reporting. 2019-02-28 titovartem@google.com Add construtor from required fields for VideoConfig in PC E2E framework 2019-02-28 titovartem@google.com Add stream label to audio streams in PC E2E framework 2019-02-28 mbonadei@webrtc.org [clang-tidy] Apply bugprone-argument-comment fixes. 2019-02-28 jakobi@webrtc.org Cleanup NetEqPostponeDecodingAfterExpand field trial. 2019-02-28 tzik@chromium.org Add a presubmit check for absl/memory/memory.h inclusion for WrapUnique 2019-02-28 phensman@webrtc.org Only draw frames with height and width >0 2019-02-28 hbos@webrtc.org Reland "Fix getStats() freeze bug affecting Chromium but not WebRTC standalone." Created with: gclient setdep -r src/third_party/webrtc@b8a4d688f907 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:752720,chromium:850907 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c1452c4d47a55a1108abd1fd485111ade528aca Reviewed-on: https://chromium-review.googlesource.com/c/1495298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636597}
-
Aaron Krajeski authored
Bug: 851810 Change-Id: I92b6b76d47c1fed6e10721737e09fcc6277093a8 Reviewed-on: https://chromium-review.googlesource.com/c/1496001 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f6d776ff4a4a..00b1f1e2a50e git log f6d776ff4a4a..00b1f1e2a50e --date=short --no-merges --format='%ad %ae %s' 2019-02-28 saklein@chromium.org Build API: Recommend services when unrecognized value provided 2019-02-28 fqj@chromium.org cros deploy: set selinux to permissive. 2019-02-28 athilenius@google.com Upgrade chromite/third_party/httplib2 to 0.10.3 2019-02-28 dgarrett@google.com test_builders: chromite-pre-cq re-enable CidbIntrationTest. 2019-02-28 dhanyaganesh@chromium.org scripts/summarize_build_status: Delete the unused script 2019-02-28 dhanyaganesh@chromium.org CommitQueueSyncStage: Cleanup Git folder before fetch --all. 2019-02-28 xianuowang@chromium.org paygen: Double timeout of paygen suites. 2019-02-28 nednguyen@google.com chromite: update chromite OWNERS 2019-02-28 seanabraham@chromium.org test_reqs: Removing target test reqs from chromite. 2019-02-28 seanabraham@chromium.org testingconfig: Make a single "requirements" field rather than having 5 Created with: gclient setdep -r src/third_party/chromite@00b1f1e2a50e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5b769f5c2087fa01057b8cd42b96d2ff6340e580 Reviewed-on: https://chromium-review.googlesource.com/c/1496035Reviewed-by:
-
Matt Mueller authored
DnsProbeService becomes a BrowserContextKeyedService instead of an IOThread global. Bug: 874660 Change-Id: I18f03205b215f67b65efc6cbc3c5068bcf674058 Reviewed-on: https://chromium-review.googlesource.com/c/1471256Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Darwin Huang authored
- Chromium doesn't need compat/ and fossil/. - Use variable to avoid hardcoded version. - The year is now 2019 (only used once so this should be ok). Bug: 936694 Change-Id: If01ba58755bc692d6104f525cbc496ad628901d1 Reviewed-on: https://chromium-review.googlesource.com/c/1493263 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636593}
-
Lowell Manners authored
Change-Id: I66dec126821fe0b3e16563241bc3432671a18486 Reviewed-on: https://chromium-review.googlesource.com/c/1477065 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Lowell Manners <lowell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#636592}
-
David Bertoni authored
Change-Id: I93d9fb18100b46ba84aad03303129bd28409fba8 Reviewed-on: https://chromium-review.googlesource.com/c/1473838 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#636591}
-
Evan Stade authored
These tests would often fail when run in parallel, but would always pass in isolation. This change fixes the tests via proper use of SetUp and TearDown, and moves some initialization of EasyUnlockServiceRegular from the ctor to InitializeInternal(). This also removes some virtual method calls from the ctor, as per the style guide: "Constructors should never call virtual functions" Bug: none Change-Id: Ibdb8628778105ed242c137ffa5ee12ffa018b06e Reviewed-on: https://chromium-review.googlesource.com/c/1493072 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#636590}
-
David Bienvenu authored
Use GetSystemMetrics(SM_X/Y/CV/CYVIRTUALSCREEN) to get rect of virtual screen and clip app window rect by virtual screen rect to handle occlusion of windows partly off screen. Bug: 532128, 813093 Change-Id: I23e96ceb17deea6a16ade5780203112c218e640c Reviewed-on: https://chromium-review.googlesource.com/c/1484492Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636589}
-
Adrienne Walker authored
This is a followup to: https://chromium-review.googlesource.com/c/1444234 That previous patch worked, but only if --enable-oop-rasterization was passed on the command line. For finch and field trials, it's decided much later in gpu_util.cc that oop raster should be turned on and so the passthrough raster decoder needs to be enabled earlier. Bug: 627621 Change-Id: Ibe32cf715bca65faabc76954c46765ba3c18418d Reviewed-on: https://chromium-review.googlesource.com/c/1487143 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636588}
-
Paul Dyson authored
When choosing the apps to send as negative examples, prefer to send data from apps that have already been clicked on. These will have data more useful for training. Bug: 899123 Change-Id: I79973f0ca67fe8f6104dae5850125726bae0567d Reviewed-on: https://chromium-review.googlesource.com/c/1491151Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636587}
-
Yusuf Ozuysal authored
This changes the logic for the thumbnail to properly reset while reusing old ViewHolders in the RecyclerView. It also adds tests using DummyUIActivity for the View/VIewBinder logic in the TabList component. BUG=935714 Change-Id: Iabf4defc977bfbc38c98f02ee9a9fcca999bf190 Reviewed-on: https://chromium-review.googlesource.com/c/1484735Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636586}
-
Christopher Cameron authored
Plumb the result of shortcut creation through to BookmarkAppReparentTab. On macOS, only allow reparenting tabs for which a shortcut was successfully created. Enforce this requirement only on macOS, as it is not a requirement on other platforms. Change-Id: Ibb639da5d58223eda728b0a828c84237b1a77c69 Reviewed-on: https://chromium-review.googlesource.com/c/1491140 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#636585}
-
Meilin Wang authored
This change introduced a new mode of libassistant called SIGNED_OUT to assistant service, where Assistant server allows requests to still be made with the absence of user credentials. This mode makes it possible to test assistant service functionalities without real gaia login. and then run: test_that -b board DUT_ip assistnt_Startup.feature_tests. Bug: b/124415316 Test: remove the gaia login dependency manually in assistant_Startup.feature_tests Change-Id: I5301396820cad57ba9a567e486ee6bdae44fa77a Reviewed-on: https://chromium-review.googlesource.com/c/1490402 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636584}
-
Chris Cunningham authored
The finch configuration underwent some name changes, so just making the names match here. Bug: 920473, 920476, 920472 Change-Id: I115b7874593473d2e14a031f068a0791a5e2baeb Reviewed-on: https://chromium-review.googlesource.com/c/1490739 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Yusuf Ozuysal authored
Enable undo for the TabList UI module. Adds an API to insert at given index to the PropertyModel and uses that to undo at the right place. BUG=936925 Change-Id: Ida747684a31bea7fefd128ce156a18045d8bb6bb Reviewed-on: https://chromium-review.googlesource.com/c/1495453 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Manu Cornet authored
I am not really sure what these expectations are supposed to test. SKColorTRANSPARENT is defined as R = G = B = A = 0. So GetBaseColor() of SkColorTRANSPARENT is black. So what these expectations are testing is basically that the shelf background target color always gets back to a hardcoded black, which doesn't seem desirable (that color can change and is defined as shelf "base color" in shelf_constants.h, this sounds like a "change detector" test that isn't helping much) and seems very different from what the test claims to be checking in the first place. This removes some expectations where they didn't really make sense. Change-Id: Ic346b0aade25790d3645bb987c8bc483e39ebb6b Reviewed-on: https://chromium-review.googlesource.com/c/1493084 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
The Chrome OS power daemon's create timers D-Bus API now implicitly deletes any old timers registered with a tag. Consequently, this change changes the ARC++ client's implementation to not call a delete timers call before calling the create D-Bus API. BUG=chromium:916044 TEST=Run unit tests. Change-Id: I2fb07b5d417d24f6518e369f5f82b18165962506 Reviewed-on: https://chromium-review.googlesource.com/c/1493819Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636580}
-
Tony de Luna authored
The kiosk button is visible if there are apps to show and the session state is LOGIN_PRIMARY. During OOBE enrollment we were not sending the list of apps and we were not updating session state to LOGIN_PRIMARY after enrollment. KioskAppMenuUpdater is responsible for updating the list of apps shown by the shelf Apps button. KioskAppMenuUpdater is always created on LoginDisplayHostMojo but was missing from LoginDisplayHostWebUI. Sessions that started with OOBE would not get an app list and the Apps button wouldn't be shown. Bug: 936641 Change-Id: I2fb4ad6df255d06c2e5e76a702b63bce0a43c395 Reviewed-on: https://chromium-review.googlesource.com/c/1493440 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#636579}
-
Ella Ge authored
TBR: majidvp@chromium.org No-Try: true Bug: 915352 Change-Id: I9e9ab79de26d2b7e335f8a334cd373064251fef6 Reviewed-on: https://chromium-review.googlesource.com/c/1495745Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636578}
-
Josh Nohle authored
CryptAuth will only authorize Instance ID tokens that use the shared authorized entity (also known as sender ID) 16502139086. Bug: 899080 Change-Id: I8ba553f295d7ec5422d6aaa4f6e446aea19b9c27 Reviewed-on: https://chromium-review.googlesource.com/c/1495854Reviewed-by:
-
Ayu Ishii authored
Set net::LOAD_VALIDATE_CACHE flag instead when requesting service worker scripts with viaCache value Bug: 925249 Change-Id: I45578d8c0f61676b0958cfab9a7057796c0d2d0d Reviewed-on: https://chromium-review.googlesource.com/c/1474386 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636576}
-
David Quiroz Marin authored
There is a test for createImageBitmap that checks whether the source image can not be allocated (DstBufferSizeHasOverflow) and rejects the promise returning a null object when it should reject with kInvalidStateError Bug: 799025 Change-Id: I57b3afad681161e89c3cff746c3e433c31fe9895 Reviewed-on: https://chromium-review.googlesource.com/c/1495835 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
-
Justin DeWitt authored
Bug: 935795 Change-Id: Ifab2596ca6bea3a72fc5a8b620d71604576f3833 Reviewed-on: https://chromium-review.googlesource.com/c/1487522Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636574}
-
Ella Ge authored
Tests: symbols-function-invalid.html system-additive-invalid.html system-fixed-invalid.html system-numeric-invalid.html system-symbolic-invalid.htm also flaky on Linux and Win flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fcounter-styles-3%2Fsystem No-Try: True TBR: eirage@chromioum.org Bug: 935689 Change-Id: Ib6724b44713a9a8cb7370adf781d948aa99615e2 Reviewed-on: https://chromium-review.googlesource.com/c/1495742 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
Patrick To authored
Rename two test classes that currently have "OpenVR" in its name. These classes do not have OpenVR specific implementations and can be generalized to support other runtimes. - OpenVRTestHook -> VRTestHook. The file is also moved from /device/vr/openvr/test to /device/vr/test. - MockOpenVRDeviceHookBase -> MockVRDeviceHookBase Change-Id: I7b8ecad096e7c787d39a59fd7308fc25fdc904db Reviewed-on: https://chromium-review.googlesource.com/c/1479813 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636572}
-
Ella Ge authored
This reverts commit f57001bc. Reason for revert: suspect causing media/controls-drag-timebar-rendering.html failing on multiple builder Original change's description: > Show controls and update time indicators during seeking > > This commit modifies the MediaControls to show the controls and update > the current time indicators (current time text + timeline thumb) > immediately during seek requests so the element behavior during rapid > seek requests (e.g. user is holding down the FF button on their BT > keyboard) look similar to when a user is scrubbing the timeline with > their mouse. > > Bug: 748749 > > TEST=MediaControlsImplTest, manual testing > out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest* > > Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d > Reviewed-on: https://chromium-review.googlesource.com/c/1274945 > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636493} TBR=mlamouri@chromium.org,steimel@chromium.org,agdoug@amazon.com Change-Id: I37ebe9e972218afb164eead7c7f1142993bbb311 No-Presubmit: true No-Try: true Bug: 937029 Reviewed-on: https://chromium-review.googlesource.com/c/1495803Reviewed-by:
-
Gabriel Marin authored
Conditionally compile the heap profiler code and its dependencies when enable_profiling is set to true. This removes 9 static initializers in memory_region_map.cc with the new tcmalloc in release builds. BUG=b:119055819 TEST=Unit tests pass Change-Id: I99adbf662d97f40304e698661506ad0d2c066d79 Reviewed-on: https://chromium-review.googlesource.com/c/1464324 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636570}
-
Josh Nohle authored
Add the prefix "DeviceSync" to all unit tests in the chromeos/service/device_sync directory so all tests can be run with --gtest-filter="DeviceSync*". Bug: 899080 Change-Id: I0ed1124daa853da2c4ebecd2ec229dbcf5fea7bf Reviewed-on: https://chromium-review.googlesource.com/c/1495796Reviewed-by:
-
Yoichi Osato authored
This patch is a preparation for Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports removal. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Though we soon make these APIs only available for test by turning the json5 feature flag from status: "stable" to status: "test", there is browser tests/chrome internal components that use them. ZipArchiver is a one of them and this patch reenable the APIs for it. We should migration it using new APIs. Bug: 766694 TEST: browser_tests --gtest_filter=*FilesAppBrowserTest*zipFile* on patch crrev.com/c/1481130 Change-Id: Ica140afb8c78b990af3fd7ecfd85ffffce8f4635 Reviewed-on: https://chromium-review.googlesource.com/c/1493986Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636568}
-
Saman Sami authored
The renderer's surface should not be destroyed while it is still visible, because future CompositorFrames to that surface will be rejected. Bug: 933374 Change-Id: I46c34bad903f052bfd2ee43e6b673a8ef26fca30 Reviewed-on: https://chromium-review.googlesource.com/c/1495368 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#636567}
-
