- 27 Aug, 2020 40 commits
-
-
Findit authored
This reverts commit fb578abb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 802242 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZiNTc4YWJiNDExMTA5ZDQ1ZDU3MDJhMGI0Yjk5ZTE0YzVlMzNmMWUM Sample Failed Build: https://ci.chromium.org/b/8870798522002653936 Sample Failed Step: compile Original change's description: > [Nearby] Refactor NearbySharingService Send* methods > > Instead of SendText and SendFiles methods this now has one unified > SendAttachments methods to make it easier to handle Attachments coming > in from the UI. Also hooks it up through the DiscoveryManager all the > way to NearbySharingService. File URLs coming from the ShareSheet on > ChromeOS are converted to FileAttachments. > > Bug: 1085067 > Change-Id: I61ce93842920ffa303ee71f4373c237b113948bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378026 > Reviewed-by: Alex Chau <alexchau@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802242} Change-Id: Ib83a828cb16f771dc3d7b17b1aea5469949040be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380193 Cr-Commit-Position: refs/heads/master@{#802253}
-
Charlie Hu authored
This CL uses PolicyValue::CreateType(T) to replace PolicyValue::PolicyValue(T, Type) constructor call. Change-Id: I6219a5446620785a596210b25509b28a2052730f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375765 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802252}
-
Aaron Leventhal authored
- Do not use author-supplied names of embedded controls - Use the value from the embedded controls See https://github.com/nvaccess/nvda/issues/1282 Bug: 1121637 Change-Id: Ia4d175052c8279d10eec2d2e30f5d784c0b66d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374514 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#802251}
-
Orin Jaworski authored
This CL prevents Pedals from attaching (or moving to) matches with entity type because entities with unrelated buttons are confusing. Bug: 1122202 Change-Id: I02babd21cc2b86e2a9411f20a6d5c21bf2ee910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378762 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802250}
-
Morten Stenshorne authored
Forgot to add support for rendered legends in LayoutObject's ContainingBlock(); only did it for Container(). We were also missing support for AncestorSkipInfo. Not sure if it's causing any problems, but it would be pretty scary to leave it like that. Bug: 875235, 786475 Change-Id: If7d8e6a299cce1def02164b33305b29414e978cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377870 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802249}
-
Ganggui Tang authored
This reverts commit 48f89230. Reason for revert: Compile failure, https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/99068? Original change's description: > Handle click on success notification. > > Handles action on success notification as follows: > - Copies text to clipboard > - Copies image to clipboard > - Opens downloads folder for multiple files > > Bug: 1085069 > Change-Id: Ie26712e0195a261cade102a74037611f11fa5dab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375250 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802213} TBR=knollr@chromium.org,himanshujaju@chromium.org,vecore@google.com Change-Id: I8da2ef7a5a9845370134e1febe8d69ed11db84d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380073Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#802248}
-
George Steel authored
Previously, we compared the zoomed property values (as stored in ComputedStyle) for speed when deciding whether to start a transition. When zooming, the comparison now calculates computed values using the serialization logic (which unzooms the values) and compares them as CSSValues. The fast PropertiesEqual comparison is still used in the absence of zoom changes. Bug: 1030239 Change-Id: I39fded593e7bed5c2eca6ec48b90d5aaec63857c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369433Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802247}
-
George Steel authored
Prevents event from being fired when the CSS of finished animations is cleaned up. This behaviour now matches the spec and firefox. Bug: 1122071 Change-Id: I18f0aa22512d304312cbd2908b18bedebff05c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378457Reviewed-by:
-
Edward Jung authored
interstitial Improve the suggestion by asking the user to check for typos in the URL. Bug: 1109671 Change-Id: Ie3a8c21255ce858b26f2bd8b8ffea3b123ac0970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376824Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#802245}
-
George Steel authored
Eliminates false positive count due to cleanup of style by js after transitions finish. Bug: 934700 Change-Id: Id901f4b19f5e858f1e218b28688923436a876933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376377Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Matt Jones authored
This patch changes the concept of height that the bottom sheet is allowed to scroll through. Instead of using the container height and applying the toolbar shadow in various places, we now factor the shadow into the maximum offset that the sheet can scroll. With this, both clients that use "wrap content" and fixed ratios behave correctly on large and small screens. Bug: 1115770 Change-Id: I43fc0083d7b2c3639e017237b9695fe2b7884a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372811 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802243}
-
Richard Knoll authored
Instead of SendText and SendFiles methods this now has one unified SendAttachments methods to make it easier to handle Attachments coming in from the UI. Also hooks it up through the DiscoveryManager all the way to NearbySharingService. File URLs coming from the ShareSheet on ChromeOS are converted to FileAttachments. Bug: 1085067 Change-Id: I61ce93842920ffa303ee71f4373c237b113948bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378026Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802242}
-
Hoch Hochkeppel authored
Before this change, PostAsyncResults returned a value that was not explicitly initialized if the IAsyncOperation failed. This was not causing a problem in the code today because ComPtrs are implicitly initialized to a valid (though empty) state and all of the consumers of this code currently are for IAsyncOperations that return types that inherit from IUnknown (which causes the PostAsyncResults method to return them inside a ComPtr). If, however, PostAsyncResults is called for an IAsyncOperation that returns a different kind of value (e.g. an int), the returned value was unitialized memory (in the failure case). To protect against future use of PostAsyncResults with non-IUnknown types (like that planned as part of http://crbug.com/1035527) this change adds default value initialization of the result, as well as unit tests that validate this behavior and a test-helper class for simulating IAsyncOperations. Bug: 1121285 Change-Id: If87d817c3cff8830a9e91eeb8fa51d2c32d17f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373165Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802241}
-
Richard Knoll authored
The Sharesheet expects all icons to be the same size. Bug: None Change-Id: I2b2254a39269556977421e6b65eadaee332812ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379714Reviewed-by:
-
Garrett Beaty authored
Bug: 1119446 Change-Id: I280408afbfe033961552b7fca45ab05dcf93d997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378969Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#802239}
-
Caroline Rising authored
Previously if a mid-tabstrip tab in an uncrowded tabstrip was closed the tabs to the left could show a hover card since their bounds were not animating while the tabs to the right couldn't since they were moving. This change provides more consistent behavior across the tab strip. This change also fixes a bug where a hover card flashed on the first tab after closing a tab due to focus changing during the tab close. Bug: 965731 Change-Id: Id7161ec54b5f7bfc564df8f8b819fc828e561663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374287Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#802238}
-
Bailey Berro authored
Introduces method to check chromeos::features::IsDiagnosticsAppEnabled state. Bug: 1120206 Change-Id: If74a643c5f9c503305818c76901cb904d625db3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377318 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#802237}
-
François Doray authored
This reverts commit b44c4f9e. Reason for revert: Reverting to confirm that this causes https:crbug.com/1122452 Original change's description: > [blink scheduler] Add OptOutWebRTCFromAllThrottling to testing config. > > This is a pre-requisite for Beta and Stable experiments. > > Bug: 1101731 > Change-Id: Ib127de8a4e67b2ea55b87b6053ce2ae4673566be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364819 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800671} TBR=fdoray@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1101731, 1122452 Change-Id: If607518027d34155e80a9601a1ca13a290b34ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380070Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#802236}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c563ba8c. With Chromium commits locally applied on WPT: 31f43be3 "[COOP] access reporting: access-to-other test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I530e075c56db2d9236ecbc403c63c1d97ffbdf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379631Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802235}
-
Wez authored
Setting the browser process as 'critical' to its job enables automatic teardown of all child processes by the kernel if the browser terminates. Previously this was only set for browser processes started by the fuchsia.web.ContextProvider implementation. content::BrowserMainLoop now sets the browser process as critical, so that all //content embedders benefit, including ContextProvider and browser-tests. This is a pre-requisite for enabling checks in TestLauncher for tests leaking processes. Bug: 1109148, 1094369 Change-Id: I1883bd2747b6187bc3a82f8fa9eabe466ace6765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369193Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802234}
-
Michael Thiessen authored
Native Java Unittests are going away, these tests need to be migrated to an Instrumentation Test apk. Bug: 1103344 Change-Id: I2b52ea5c794f8ac9afeeb86f02c0ea143284cb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378535Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#802233}
-
Clemens Arbesser authored
Bug: b/166456155 Change-Id: I595b40a254b0952d9511b2d1bcaa16d47f15ab34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378031Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#802232}
-
Koji Ishii authored
This patch updates |NGInlineCursor| to iterate fragments for a |LayoutObject| by using the item index created by |FinalizeAfterLayout|. Bug: 1112657 Change-Id: Ifeb549c1fdf112c86e4f61439d7b8a2bedd1c94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289575Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, there wasn't any place in Chrome for WebAuthn to store the payment-specific information of PaymentCredential that could also be accessed by Web Payments for secure payment confirmation method. This patch adds an SQLite table for storing secure payment confirmation instrument information: credential identifier, relying party, label, and icon. The secure payment confirmation app factory reads the table to creating an app. To avoid instrument identifier collision among different relying parties, PaymentRequest constructor now requires a list of credential identifiers instead of an instrument identifier. After this patch, WebAuthn has a place to store the payment-specific information of PaymentCredential in Chrome and Web Payment has access to it as well. Design: https://bit.ly/secure-payment-confirmation Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Bug: 1121800 Change-Id: Ic1e9d5dca20a38bebbd35cbd9bd0aabd9a237da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368463 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#802230}
-
Oleh Lamzin authored
After moving from deprecated install URL Sample SWA still has manifest and pwa.html files. It is misleading other developers, because the guideline is that these files are not needed anymore. Also remove unused headers and add missing headers for sample_system_web_app_info.cc. Change-Id: Ieb22e0abd70d90c0d7f999bc8eb9e928a36c9c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377496 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#802229}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/128fd453..f41960f6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb385411af1eb179ab2ed471b8680bad07bc094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379632Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e3d6db4c3fac..aba6b93dfbc8 2020-08-27 johnstiles@google.com Replace C-style casts with as<T> in the Control Flow Graph. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I7846f977a8e3068bf362ef906afaef1484ce124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802227}
-
Maksim Sisov authored
I initially generated it by myself and made a huge mistake by setting base version to a single version. However, some symbols only appeared after certain version. Thus, fix that problem by copying and using the symbols file from wayland packages in https://git.launchpad.net/ubuntu/+source/wayland. Bug: 1116384 Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802226}
-
Jan Krcal authored
This CL adds additional histograms for insights about multi-signin based on primary account type. Bug: 1121944 Change-Id: Ibe3f8dff18d61c1075672242a3e29ea22b5b63a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377867 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802225}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/dc969f34a7..c03c18e7fe Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/dc969f34a7..c03c18e7fe Bug: None Change-Id: I2e2b52589517d886a04384ad72279a4da3758af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378308 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802224}
-
Rakina Zata Amni authored
We’re running an experiment that enables the back-forward cache for same-site navigations. Websites might be interested to know whether a page they’re serving is included in the experiment (which means the page might get stored into the back-forward cache and later restored) for analytics purposes (e.g. analyzing user behavior with back-forward cache enabled vs not). When a page opts-in into the Origin Trial, we will send a “Sec-bfcache-experiment” HTTP header on resource requests made by the page. The value will be set to the experiment group that the page is currently in (e.g. "experiment1-enabled", "experiment1-control", "experiment1-default") This CL adds the "BackForwardCacheExperimentHTTPHeader" Origin Trial feature and the "BackForwardCacheSameSite" feature to pass the info on whether same-site bfcache is enabled or not from content/ to blink/. This HTTP header will be removed after the Origin Trial and BFCache experiments ended. I2E: https://groups.google.com/a/chromium.org/g/blink-dev/c/RXxETBGaTYI/m/qJI6p9n_CQAJ Bug: 1121976 Change-Id: Ifc65908b55ae7aa726f9fc8d7a7c18bb4db23c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371148 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#802223}
-
Abhijeet Kandalkar authored
This patch enables the support of both xdg_shell_v6 and xdg-stable protocol to the wayland clients. In current implementation connection between client and server depends on order wayland-server announces support of two xdg shells and order in which wayland-client binds to it. But there is already a implementation(XDGPopupWrapperImpl & XDGSurfaceWrapperImpl) where wayland-client prioritize xdg-stable over xdg_shell_v6. The wayland connection code should bind both xdg_shell_v6 & xdg-stable protocol and should not prioritize any shell implementation. BUG= 1067535 Change-Id: I62f5364f3529905e8e81362e48893fd5f2512729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374919 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#802222}
-
Chris Lu authored
Feature is rolling out to stable, but turning flag on by default did not make M86 branch point. Bug: 790886 Change-Id: If3e20ff58595dcaf83260410394248996595a39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373428 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802221}
-
Ali Juma authored
This adds a field trial testing config entry for SafeBrowsingRealTimeUrlLookupEnabled on iOS. Bug: 1092963 Change-Id: I4e43b2872036739cc4e9ac7df62b8699b2cbb062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367975Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#802220}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8c012e879646..900bd341a3c6 2020-08-27 jiawei.shao@intel.com Enable TextureSubresourceTest.MipmapLevelsTest on Vulkan w/ validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifbd066352870949b4d739a989bf86373db6d37e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379326Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598504742-e0e2ad23b7826317b6903fc83935abb66348df31.profdata to chrome-mac-master-1598529464-36870a872fe98f9e50202a2a325506fd4bcc24c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8335371226629c520a1143302ccdb8d4d84b0068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379329Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11944f7122cf..8e6246dafe61 2020-08-27 fmayer@google.com Merge "Fix unwinding issues for multi ABI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I42ddb30e10b8cce6779c16d0960b43a00f5c4945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379327Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e9a7892232a..282596778418 2020-08-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7a71abb602a2 to cac2574c240a (1 revision) 2020-08-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 834673eaa34a to ced848d699b5 (1 revision) 2020-08-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 94ee680cab4c to 11fcbbf5d7cc (1 revision) 2020-08-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from e1c7eaa74142 to 0654095b63fb (3 revisions) 2020-08-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 2205254cfb50 to bceab9fab4bc (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I937315ebe0f19309b314a86e894b402f4c0b875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379323Reviewed-by:
-
gogerald authored
TBR: khorimoto@chromium.org, hsuregan@chromium.org Bug: 1122584 Change-Id: I5478c3a1fd207bf2d53cca31e31e2705690b3017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379951 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ced41e1f394d..11944f7122cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4290207adcccfd8ae055cbcd71de96e28f6add8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379256Reviewed-by:
-
