- 21 Aug, 2019 40 commits
-
-
Vincent Boisselle authored
Bug: 996025 Change-Id: Idabb5b920cbb59b5e6132ad18ae0ee8be87a13ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761353 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#689053}
-
Alex Ilin authored
TBR: fhorschig@chromium.org Bug: 984489 Change-Id: I2597f82efc20e7617d40555b2897ec851d456fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760790Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689052}
-
Saman Sami authored
If RunPendingMessages() triggers a root re-layout, |tabbed_pane_| and |child1| both will be resized to have the same width as |widget_| (which is 650) and the EXPECT_EQ below fails. Resize the root to (100, 200) to avoid this problem. Change-Id: I033869ce0ec148a8e54ed9592fc63d6109744257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#689051}
-
dalyk authored
The current limit on outstanding DNS requests does not need to apply to DoH requests. DoH requests will be treated by intermediary routers as HTTPS traffic rather than as DNS requests, and HTTP/2 offers mechanisms for DoH servers to control the number of outstanding requests if desired. This change prevents the deadlock that can occur when many DoH requests are all blocked on resolving a DoH server hostname. Request completion due to queue overflow eviction is now always handled asynchronously. Bug: 993905, 985589 Change-Id: I24510fb93dbf0c5c510949329e3dbcae5138b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754187Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#689050}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/538193cb0f15..3654f21952d9 git log 538193cb0f15..3654f21952d9 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 saklein@chromium.org api/contrib README.md: Better explanation of gen_call_scripts. Created with: gclient setdep -r src/third_party/chromite@3654f21952d9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I824fe391e9b64d1c701918a44461c127f84db919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689049}
-
Elly Fong-Jones authored
This test has not flaked in 100 local runs. Let's see if we are lucky! Bug: 674475 Change-Id: I9b54547ae00b6188c61eb3702b2ba758284c0e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761366 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#689048}
-
Peter Collingbourne authored
After https://crrev.com/c/1756721 we stopped passing -nostdlib on Android, so the -nostdlib++ flag is not redundant and is in fact required in some configurations to prevent linking against the NDK libc++. Bug: 996172 Change-Id: Iabede8e5cafad29debf6b5f098a247f399cb460c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762346 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689047}
-
Clark DuVall authored
This renames AwContentsIoThreadClient to AwContentsNetworkClient, since it can now be used on any thread. All of the methods from AwContentsIoThreadClient are thread safe since they either call AwSettings (thread safe), call AwServiceWorkerSettings (thread safe), get a background thread client which is only used on a background thread, or access a static bool set at startup (for the SW getSafeBrowsingEnabled). The RfhToIoThreadClientMap already used locks when accessing the map as well. Bug: 994948 Change-Id: I74c3a5e47072d4608810c106c03faf6a4d12d92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759009Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689046}
-
Avery Musbach authored
OverviewWindowDragController::should_allow_drag_to_close_ shall be named is_touch_dragging_ based on how it will be used to address Issue 995413. Other names, and comments, shall be updated to maintain consistency. Bug: 995413 Change-Id: Ie382d8a729b3f5459e5922e4150707af73daec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761307 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#689045}
-
Lowell Manners authored
Change-Id: I9d2d671c004931d9af0d982ca19fad136a53bb72 Bug: 992423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746178 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689044}
-
Chris Lu authored
To create BadgeMediatorTest, a few properties and methods in InfobarBadgeTabHelper were move to "protected" to allow for the fake subclass to use. Bug: 984974, 994045 Change-Id: I8834338adbf87d17ec5fa007903ac3db17e59672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762342 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#689043}
-
Chris Whelan authored
Bug: b/138672579 Test: Build Change-Id: I1b0b30c80b2a32fb48131ee8f5cd4cc9e9cf5a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729730 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#689042}
-
Evan Stade authored
Apply the same fix that was applied to ProfileResetterTest.ResetExtensionsByDisabling in f1207e30 Bug: 995851 Change-Id: I7355cb199dfcae0017ce11315025f71533c021b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762813 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689041}
-
Ben Pastene authored
But do strip them for tast tests on coverage bots. Tast is likely broken on the coverage bot right now, but the bot's stuck failing on compile, so I don't think anyone noticed. Bug: 995776 Change-Id: I3fbfe16133c876c110eddf0747e49f5ee7fdffe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762446Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#689040}
-
Melissa Galonsky authored
The Unity "Sync and Google services" link in settings doesn't have any error subtext. This is ok on desktop, when there are other ways of indicating that sync is broken in the settings UI, but is bad on Chrome OS, where the additional UI doesn't exist. This adds subtext telling a user to type in their passphrase to enable sync when sync isn't working due to a passphrase error to both desktop Chrome and Chrome OS. Screenshots when the user needs to enter their passphrase to test sync. CrOS, current, pre-Unity: https://drive.google.com/open?id=1E_YNkHjap68yghIAtLbDRBZkRym1jkc4 Desktop, current: https://drive.google.com/open?id=15eemM7tNZtJzMgBpgxY1TBTcNtMrZ4hI This Change: https://drive.google.com/open?id=1Plq5W6oewGGi24TaDcWujpO2xVZagsUi Bug: 985056 Change-Id: Icc9abe9ce3002eebf3cfc5d52fcded12c9ee848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742350 Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#689039}
-
Nazerke authored
Support dark mode for omnibox keyboard accessory view. Bug: 989488 Change-Id: I76d3f2d5b3dd55199ad90078286eca5ecf53585d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735383 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689038}
-
Donn Denman authored
Refactors the logic that allows insetting the Visual Viewport. Now the control is moved from RWHV to ViewAndroid and its delegates. This allows the setting to be established for an object with the same lifetime as a WebContents, so when a new RWHV is swapped in it will still apply. BUG=986384, 968150 Change-Id: I5cb3601ff460637f99e98a4edf090ad28321bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714286Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689037}
-
Kevin Bailey authored
Adds -fsanitize=bool to the list of check flags. This adds code to verify that, when reading a bool, it is 0 or 1. Change-Id: I709eb462a53fc37014ed1fd261f783722e4ff2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699228Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Nazerke authored
Supports dark mode for tab grid. Bug: 988415 Change-Id: I1ceb5ae19e9480308b4df2a10b9716aad8e139a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726054Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689035}
-
Andrew Lee authored
Change-Id: Ie7156b3b1e49b7dac4fa69c4b4f5ac089e6942c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762997Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689034}
-
Elly Fong-Jones authored
TBR=marinaciocea@chromium.org Bug: 996235 Change-Id: I38b2c62887f708511baa3c0c2ae1a794246baaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762470Reviewed-by:
-
Ryan Sleevi authored
As announced at https://security.googleblog.com/2019/08/protecting-chrome-users-in-kazakhstan.html Bug: 996164 Change-Id: Ibf0712105d6f86b283f73a15c7e45f4fecceb4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763229Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689032}
-
Adam Bujalski authored
This patch fixes one of three memory leaks found when page reloads NaCl module(s). In PepperPluginInstanceImpl ctor FrameHostMsg_DidCreateInProcessInstance message is sent to browser process, however message FrameHostMsg_DidDeleteInProcessInstance isn't sent from dtor. This is because PepperPluginInstanceImpl is created for unproxied module and later reinitialized as proxied one, which causes that PepperBrowserConnection::DidCreateInProcessInstance method is called in PepperPluginInstanceImpl ctor, however PepperBrowserConnection::DidDeleteInProcessInstance isn't called in PepperPluginInstanceImpl dtor. Bug: 922925 Change-Id: Ifb80108a99f591e7d30ec8013e94cef6d176eca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679692 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#689031}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/068e0cc6f357..78f41f5a6e33 git log 068e0cc6f357..78f41f5a6e33 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 zoddicus@users.noreply.github.com Fix some Python2 vs 3 issues in update_build_version.py (#783) Created with: gclient setdep -r src/third_party/shaderc/src@78f41f5a6e33 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Icd243637ad3a8a2bd4d7d01e33a80f87825892b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763941Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/92eb0415d0b1..f25a1c68473b git log 92eb0415d0b1..f25a1c68473b --date=short --no-merges --format='%ad %ae %s' 2019-08-21 capn@google.com Always rasterize lines as a rectangle Created with: gclient setdep -r src/third_party/swiftshader@f25a1c68473b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139755234 Change-Id: Id487fa7e4799a1ced86dbeecd14d51864174cf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763156Reviewed-by:
-
Alex Clarke authored
Split off from https://crrev.com/c/1751324 This test is no longer useful in the new model of consuming. Bug: 971191 Change-Id: I0bf1d55a1f801947f745f17e420926feb4af98e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760740Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#689028}
-
Sophie Chang authored
This is in preparation for supporting both the current and the Optimization Guide Keyed Service paths. The KeyedService path requires a navigation handle for any "CanApplyOptimization" decisions. Bug: 969558 Change-Id: If3b78c78d2ac655f114112bde24ef10673544009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762877Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689027}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e8ef87bdadcf..f69bd5f184cc git log e8ef87bdadcf..f69bd5f184cc --date=short --no-merges --format='%ad %ae %s' 2019-08-21 nisse@webrtc.org Delete AudioDeviceWindowsCore::WideToUTF8, replaced with rtc::ToUtf8 2019-08-21 sprang@webrtc.org Set local ssrc at construction of Rtp module 2019-08-21 hbos@webrtc.org Add implemented-but-missing members to RTCMediaStreamTrackStats::Members 2019-08-21 handellm@webrtc.org Simplify the VideoFrameDumpingDecoder API. 2019-08-21 sprang@webrtc.org Rename RtpRtcp::Configuration::media_send_ssrc to local_media_ssrc Created with: gclient setdep -r src/third_party/webrtc@f69bd5f184cc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:996146 Change-Id: Ia2a26f04d9cb7a59f8a93ef15664a21e12654e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763155Reviewed-by:
-
Christopher Thompson authored
We're removing the dangerous flag infobar for this for now in https://crrev.com/c/1760866. This change adds basic metrics for how common the use of SSLKeyLogger is. Bug: 991290 Change-Id: I74e932eef872c59f5b4c8b5de055a2197ac93f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761288Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#689025}
-
Jan Wilken Dörrie authored
This change implements logic rejecting forms with empty usernames for the leak detection feature. Also it adds a DCHECK that the password is non-empty. Bug: 986298 Change-Id: I178da166e0f7c0f9baa17ad6ed1452446c2e998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763692Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#689024}
-
Ian Kilpatrick authored
This patch was created by reverting: https://chromium-review.googlesource.com/c/chromium/src/+/1282724 And converting the tests to use promises, and switching the API to NG. I run the patch against the mac-bots a few times to determine if I could reproduced the flakiness which occurred initially to no avail. Bug: 726125 Change-Id: I5f6197699977c03d3efbd4ca0926815faabee19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761372Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#689023}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f341e24. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I9a8825b4101ae3744135853985e51669915a54a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763870Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689022}
-
Alex Clarke authored
EXPECT_DCHECK_DEATH is flaky with promises. This patch wires up an alternate way of observing Promise API errors that still DCHECKS in normal code but has an escape hatch for AbstractPromiseTest which doesn't rely on fork(). Bug: 993723 Change-Id: I176cf9aa93703d3d03b7f1a25c4f68a4311d3fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762072 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#689021}
-
Matt Menke authored
The test was simulating the H2 server hanging up after sending an H2 challenge, and then negotiating a new H1 connection, regardless of whether net/ tried to negotiate H2 or H1 when re-establishing the connection. This CL keeps the H2 session open, and explicitly checks that when re-establishing a connection, we only try to negotiate H1. Bug: 996042 Change-Id: Icb2d0e39382f9173308582b19d836a9cd26f047f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762458 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#689020}
-
Chris Hamilton authored
BUG=971272 Change-Id: Iba0542b6233df32366ac895662a96a6a53e48802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758906Reviewed-by:
-
Kevin Ellis authored
This patch aligns the implementation of web-animations with the spec. Previously updates were performed via a PlayStateUpdateScope. This class depended on an extra state (kPending) that is not to spec. Support for microtasks is also introduced in this patch, which addresses most of the remaining timing issues with the finished state of an animation. Bug: 960944 Change-Id: I62aff2254d2b5265f869415e0f763e140b460c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739386Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#689018}
-
arthursonzogni authored
The GlobalRequestID used for a navigation request are generated by NavigationURLLoaderImpl::MakeGlobalRequestID(). Unfortunately, this is not what is used in TestNavigationURLLoader. Added in https://codereview.chromium.org/2885453003, the TestNavigationURLLoader simulates getting a new GlobalRequestID. To support the non-BrowserSideNavigation code path, it had to define GlobalRequestID::child_id to be the ID of the process that has initiated the navigation. With BrowserSideNavigation (aka PlzNavigate), this is now always -1, because the browser handle the navigation. The non-BrowserSideNavigation code path has been removed in M65. We can now use the NavigationURLLoader's GlobalRequestID() instead. Bug: 992846, 992846 Change-Id: I36b9058b4f6b369416a082278fc9274eaeae29f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748695 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689017}
-
Edvard Thörnros authored
SMILTimeContainer::Elapsed() could return a negative time, this should not be possible anymore. Since if you now reinsert the SVG, it should resync. Nothing else should have changed. Bug: 996196 Change-Id: Id75b1604b8a087c5c046f842273cd8355075cb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763420 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#689016}
-
Finnur Thorarinsson authored
Bug: 993775, 860467 Change-Id: If9632021357c2deaf4e7dcfaa44f48e972f774fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760952Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#689015}
-
Guido Urdaneta authored
Add camera 05c8:0369 known to cause problems with MediaFoundation. Bug: 978852 Change-Id: Idb4b02e04514affa9e0d429aaf85b310435b2fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757937 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#689014}
-
