GitLab

This sub-CA does not meet the independence criteria to be exempt from
CT.

BUG=620178

Review-Url: https://codereview.chromium.org/2362593002
Cr-Commit-Position: refs/heads/master@{#420506}

browser_tests fail without this when redirection to TaskScheduler is
enabled.

Wait on the UI thread is disallowed by a call to
base::ThreadRestrictions::DisallowWaiting() in
BrowserMainLoop::PreMainMessageLoopRun().

BUG=553459

Review-Url: https://codereview.chromium.org/2361543002
Cr-Commit-Position: refs/heads/master@{#420505}

by screen readers.

BUG=648280

Review-Url: https://codereview.chromium.org/2355963002
Cr-Commit-Position: refs/heads/master@{#420504}

FileVideoCapture is a test-only feature, enabled via two
command line flags. It overwrites any system webcam and
introduces a file playback instead. This CL allows the
video capture thread to access IO operations.

BUG=648989

TEST= Run e.g.
./out/gn/Chromium.app/Contents/MacOS/Chromium --use-fake-device-for-media-stream --use-file-for-fake-video-capture=~/Downloads/old_town_cross_420_720p50.y4m https://rawgit.com/Miguelao/demos/master/gum_simple.html

with the said file d'led from https://media.xiph.org/video/derf/y4m/

Review-Url: https://codereview.chromium.org/2358093002
Cr-Commit-Position: refs/heads/master@{#420503}

These tests (*all* Selection tests, and a few of the IME tests) are
extremely flaky to the point that they often cause waterfall redness
despite @RetryOnFailure.  These areas are actively owned (amaralp@ owns
Android selection, and changwan@/yabinh@ own Android IME) and we plan to
circle back to reenable without @RetryOnFailure when they have been
fully deflaked.

The @FlakyTest annotation is deprecated so also replace existing uses of
it with @DisabledTest, and secondly don't comment out the other
annotations which seems to be unnecessary nowadays.

BUG=649411,628964,592428

Review-Url: https://codereview.chromium.org/2362013002
Cr-Commit-Position: refs/heads/master@{#420502}

Revert of Add ClientNativePixmap multi-planar support. (patchset #8 id:160001 of https://codereview.chromium.org/2272153002/ )

Reason for revert:
This makes samus stuck at the Chrome logo.

Original issue's description:
> Add ClientNativePixmap multi-planar support.
>
> ClientNativePixmap, that lets clients map pixmaps in user space,
> always assumed a pixmap contained only one plane.
>
> This CL adds support for multiple-planes.
>
> BUG=618516
> TBR=posciak
> TEST=gl_unittests on samus.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
> Cr-Commit-Position: refs/heads/master@{#420251}

TBR=ccameron@chromium.org,dnicoara@chromium.org,posciak@chromium.org,reveman@chromium.org,spang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618516

Review-Url: https://codereview.chromium.org/2361023003
Cr-Commit-Position: refs/heads/master@{#420501}

This CL adds External Clear Key support on Android for testing.
This is implemented by running AesDecryptor in the MojoCdmService,
which runs in the MojoMediaApplication in the GPU process. This is
only enabled when kExternalClearKeyForTesting feature is enabled.

A new content browser test is added to use External Clear Key on
Android. Since AesDecryptor doesn't support decoding, the media
pipeline is configured to do decrypt-only using the mojo CDM
(MojoDecryptor on MojoCdm), and then use the normal Android
pipeline (AVDA/MojoAudioDecoder) to decode encrypted audio/video.

Note that this is different from the default mode how Android
media pipeline works for encrypted content (decryption/decoding
both happens in the GPU process). When browser_tests are enabled
on Android, we should be able to have test coverage on that.

Here's what the new test covers:
- MojoCdm / MojoCdmService
- MojoDecryptor / MojoDecryptorService
- MojoMediaApplication
- Connection to services hosted in MojoMediaApplication through
  MojoShellContext.

This CL also fixes a bug in MojoCdm where the decryptor_ptr is bound to
one thread but is used on another thread.

BUG=581893
TEST=This CL adds a new test. No other functionality change.

Review-Url: https://codereview.chromium.org/2268283003
Cr-Commit-Position: refs/heads/master@{#420500}

Revert of HTMLImageElement: do not use fallback content for ImageDocument (patchset #2 id:20001 of https://codereview.chromium.org/2343613002/ )

Reason for revert:
Speculatively reverting to fix broken layout tests on Windows (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10, https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7)

Tests are

fast/backgrounds/border-radius-split-background-image.html
fast/backgrounds/border-radius-split-background.html
fast/borders/border-styles-split.html
paint/invalidation/background-resize-height.html

Original issue's description:
> HTMLImageElement: do not use fallback content for ImageDocument
>
> After https://codereview.chromium.org/1879793003,
> ImageLoader::hasPendingActivity() became false for ImageDocument and thus
> HTMLImageElement::selectSourceURL() didn't consider the image as still loading
> during load (|imageStillLoading| became false).
> This caused ImageDocument not to be displayed progressively.
>
> This CL makes HTMLImageElement to use primary content for ImageDocument.
> This causes ImageDocument not to be replaced with fallback content, but I
> expect that is more acceptable than images not displayed progressively.
>
> BUG=632495
>
> Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
> Cr-Commit-Position: refs/heads/master@{#420432}

TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,hiroshige@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632495

Review-Url: https://codereview.chromium.org/2365523003
Cr-Commit-Position: refs/heads/master@{#420499}

Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called
>
> This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the context gets destroyed.
>
> The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
> I think the risk is low.
>
> BUG=610176
>
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true

Review-Url: https://codereview.chromium.org/2365463004
Cr-Commit-Position: refs/heads/master@{#420498}

BUG=483282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2359363002
Cr-Commit-Position: refs/heads/master@{#420497}

Currently, Skia flushes unused items out of its caches after ~1 second
of non-use (50 flushes). This works fine while Skia is in-use, but when
a worker context goes idle we stop calling into Skia altogether. This
means that Skia will never flush out unused cache items from the last
piece of work it did. This can lead to some rather large temporaries
being kept around (~20mb).

This change adds an idle cleanup process which flushes Skia's caches
and cleans up worker context resources after a worker context is idle
for 1 second.

BUG=624630
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2353033003
Cr-Commit-Position: refs/heads/master@{#420496}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/68e74d1eef346395009cf05e4ad358c8a762dab0 [swarming/api] Add text in to indicate whether a shard is failing (nednguyen@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:639321

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2355413006
Cr-Commit-Position: refs/heads/master@{#420495}

A Espresso dependency (Dagger) throws an InvalidPackage lint error
for a javax.inject reference. Further details are in the bug.

BUG=648419

Review-Url: https://codereview.chromium.org/2350313004
Cr-Commit-Position: refs/heads/master@{#420494}

While writing other code, I found out that the error logging
in VCDWin is cumbersome: it is too verbose on Init() and
doesn't dump the HRESULT while capturing.

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also
sends an HRESULT to SetErrorMessage() to dump it on
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win
bots when those fail, so the less release code they take
up the better.

BUG=405016, 648490

Review-Url: https://codereview.chromium.org/2365533004
Cr-Commit-Position: refs/heads/master@{#420493}

There is no clean way to set the size for the dropdown menu arrow dynamically
without causing security bugs. Since this is only for tests, using a fixed
width works with _most_ of the test cases while the rest have minor changes
that are acceptable for layout tests.

Context: https://codereview.chromium.org/2340633002

BUG=649095, 649056, 649058, 649132, 640256
COMPONENT=ThemePainterDefault, Menu List Arrow
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2359753003
Cr-Commit-Position: refs/heads/master@{#420492}

Review-Url: https://codereview.chromium.org/2364613002
Cr-Commit-Position: refs/heads/master@{#420491}

If device_scale_factor of 2 is used then ash crashes trying to load the
2x icons. Add the icon resources.

BUG=none

Review-Url: https://codereview.chromium.org/2361943002
Cr-Commit-Position: refs/heads/master@{#420490}

AvPipelineImpl's Stop() call must prevent any pending buffer decryption callback
from ever running. StartPlayingFrom() sets enable_feeding_ back to true, so if
a pending decryption callback from before Stop() is allowed to complete after
StartPlayingFrom() is called again, it will think everything is fine
and try to push a buffer, resulting in a double push.

BUG= internal b/31543110

Review-Url: https://codereview.chromium.org/2361103002
Cr-Commit-Position: refs/heads/master@{#420489}

default dialog buttons blue.

BUG=644849

Review-Url: https://codereview.chromium.org/2361063002
Cr-Commit-Position: refs/heads/master@{#420488}

BUG=634443

Review-Url: https://codereview.chromium.org/2360953002
Cr-Commit-Position: refs/heads/master@{#420487}

In this case, the renderer does not need to consult the browser
process if subframes are created during the navigation.  Since there
are no history items for it, the renderer can just load the default
URL.

BUG=638088, 639842
TEST=Restore chrome://settings after disabling MD settings mode.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2316003002
Cr-Commit-Position: refs/heads/master@{#420486}

https://chromium.googlesource.com/skia.git/+log/5f544345d653..ae6e4869c945

$ git log 5f544345d..ae6e4869c --date=short --no-merges --format='%ad %ae %s'
2016-09-22 jvanverth Revert of Some Vulkan memory fixes and cleanup (patchset #2 id:20001 of https://codereview.chromium.org/2356343003/ )
2016-09-22 msarett G instead of R, thanks Gold
2016-09-22 caryclark don't close a contour with a line if nothing's there
2016-09-22 jvanverth Some Vulkan memory fixes and cleanup
2016-09-22 hcm Update Chrome section to include Skia roll/sheriff/bug info
2016-09-22 robertphillips Make AALinearizingConvexPathRenderer able to handle stroke and fill
2016-09-22 bsalomon Change implementation of flush-count based GrGpuResource purging
2016-09-22 csmartdalton skpbench fixes for linux
2016-09-22 msarett Add BGRA as input format to SkColorSpaceXform

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2359333002
Cr-Commit-Position: refs/heads/master@{#420485}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4f39e7d46c67b5dc0425696d2c9e009ed019ed04 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/32d8737bb9efcc4a4e118d263849b32e9792f597 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/5b64ce6370b70afd63e463ae72f02e69ecc034ec Require recipes to emit at least one full test case. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2360853004
Cr-Commit-Position: refs/heads/master@{#420484}

Not sure why we don't have any coverage for all buildable targets
on a Windows component build...

BUG=none
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2359343002
Cr-Commit-Position: refs/heads/master@{#420483}

Hack for AIA fetching on Mac Sierra: On >=10.12, always do FETCH_CRL_FROM_NET if adding a crl policy.

BUG=645629

Review-Url: https://codereview.chromium.org/2368453002
Cr-Commit-Position: refs/heads/master@{#420482}

https://pdfium.googlesource.com/pdfium.git/+log/a939bfe3e102..fe0179ded820

$ git log a939bfe3e..fe0179ded --date=short --no-merges --format='%ad %ae %s'
2016-09-22 tsepez Rename CPDF_CountedObject to CFX_WeakPtr::Handle

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2365533005
Cr-Commit-Position: refs/heads/master@{#420481}

This is necessary to avoid a DCHECK when opening the DOM inspector on
any page (and is also clearly correct)

R=mstensho@chromium.org,eae@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2360793002
Cr-Commit-Position: refs/heads/master@{#420480}

Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag.

BUG=647756
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2343993002
Cr-Commit-Position: refs/heads/master@{#420479}

Used only in tests.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2361203003
Cr-Commit-Position: refs/heads/master@{#420478}

The codepath for compositing opaque scrollers, enabled by
--enable-blink-feature="CompositeOpaqueScrollbars", was triggering two asserts.

One assertion was due to querying stacking order lists when those lists were
dirty. The assertion is fixed by updating the stacking order lists if needed
before the query, only if we actually need to look at the list.

The other assertion was a side-effect of an earlier change to remove a
different assertion, https://codereview.chromium.org/2191953002. The code
in question is attempting to update the shouldPaint flag of a FloatingObject
when that object has had a change in selfPaintingLayer status. But because
selfPaintingLayer status has already been updated, and the query for
FloatingObject::shouldPaint() checks the current selfPaintingLayer status,
we have no way of finding out if a floating object with a selfpaintingLayer
was previously shouldPaint. We were requiring that shouldPaint return
true so that we could set it false and return, but instead we were falling
out of the loop and hitting an ASSERT_NOT_REACHED.

The fix is to not check the previous status and just set shouldPaint to false
for all FloatingObject where the object has a selfPaintingLayer, and not assert
not reached as now we might exit the loop. We are no longer returning as soon
as we update the shouldPaint to false because we can no longer be sure that
we are actually changing the value of shouldPaint.

The lack of assertions allows 2 webkit_unit_tests to pass without crashing,
and prevents crashes in a slew of LayoutTests. Of note,
fast/overflow/overflow-float-stacking.html no longer crashes, but does fail
analogously to fast/overflow/overflow-stacking.html. In
https://codereview.chromium.org/1826013002 we had decided to live with that
failure as it is a manifestation of the fundamental compositing bug that
users on high DPI devices have always seen.

R=wangxianzhu@chromium.org,flackr@chromium.org
BUG=593097,381840
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2365673002
Cr-Commit-Position: refs/heads/master@{#420477}

https://chromium.googlesource.com/webm/libvpx.git/+log/4282d29355df..99ef84c65a2b

$ git log 4282d2935..99ef84c65 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 angiebird Detect invalid highbd iht input
2016-09-21 johannkoenig Keep vp8 sixtap read within bounds
2016-09-21 johannkoenig predict_test: align dst buffer to 16
2016-09-07 jzern vp8: remove VP8_SET_DBG* control support
2016-09-19 jzern vp9_rtcd: remove non-existent highbd convolve fns
2016-09-19 jzern examples: quiet -Wshorten-64-to-32 warnings
2016-09-19 jzern vp8: convert some uses of unsigned long to size_t
2016-09-19 jzern vp8/encoder: quiet some -Wshorten-64-to-32 warnings
2016-09-19 jzern variance_avx2: sync variance functions with c-code
2016-08-26 johannkoenig Remove -fno-strict-aliasing flag
2016-09-08 negge Code class0 using vpx_read() / vpx_write().
2016-09-19 aconverse Zero the whole rd_counts struct rather than the each member
2016-09-17 jzern loopfilter_mb_neon: remove unused load_8x8()
2016-09-15 linfengz Refactor lpf (size 16) NEON intrinsics optimization
2016-09-15 jzern vpx_subpixel_8t_intrin_avx2: tolerate unversioned clang
2016-09-08 johannkoenig Enable ssse3 bilinear tests
2016-09-02 johannkoenig Add vp8_bilinear_filter test
2016-09-16 johannkoenig Revert "Restore vp8_sixtap_predict4x4_neon"
2016-09-02 johannkoenig Restore vp8_bilinear_predict4x4_neon
2016-09-15 johannkoenig zero structures completely
(...)

Review-Url: https://codereview.chromium.org/2362513003
Cr-Commit-Position: refs/heads/master@{#420476}

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.6.2.

This CL is a step towards being able to reuse the classes VideoCaptureDeviceClient
and VideoCaptureBufferPool as part of the Video Capture Mojo Service, because they
implement functionality that is needed there. Expressed in class-diagram form, we
want to realize the cut indicated by the red line in [2].

Currently, the classes VideoCaptureDeviceClient and VideoCaptureBufferPool live in
content/browser/renderer_host/media. Even though their functionality is not specific
to renderer_host, their dependencies create a tight coupling to code that is. In order
to use them in services/video_capture, we need to move them out of there (and probably
into media/capture/video).

In this CL we move the nested and private classes from video_capture_buffer_pool.h/cc
into stand-alone classes using separate files. After this separation, we will be able to
move the parts that do not depend on content/browser/renderer_host/media to
media/capture/video and keep the other parts where they are.

Additional changes:
* Rename interface VideoCaptureBufferPoolBufferHandle to VideoCaptureBufferHandle

Note: Code in new file comes from either video_capture_buffer_pool.h or .cc.
      No additions or modifications oder than the required includes and guards.

BUG=584797
TEST=This is a pure refactoring. No new functionality. content_unittests still pass.

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://docs.google.com/drawings/d/1acJSbj8eCK5Lpvv9QPiU_V34t8GfgqfYSoYbA93jb5o/edit

Review-Url: https://codereview.chromium.org/2343423003
Cr-Commit-Position: refs/heads/master@{#420475}

BUG=646184

Review-Url: https://codereview.chromium.org/2345513003
Cr-Commit-Position: refs/heads/master@{#420474}

For the record, in case we decide to bring this back, there is also an
un-landed CL at
https://codereview.chromium.org/1917063002/

BUG=648670

Review-Url: https://codereview.chromium.org/2358083003
Cr-Commit-Position: refs/heads/master@{#420473}

R=dgozman@chromium.org, kozyatinskiy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2366433004
Cr-Commit-Position: refs/heads/master@{#420472}

The first bug was we were trying to start a nested cycle cycle, which is not allowed. The logic in the worker that tries to nudge in response to encryption changing is super old, and doesn't make any sense, so this was fixed by simply not nudging. If there needs to be a commit in response to encryption changing, the processor will drive this.

The second issue was that in certain cases the worker would try to commit something with an id but not a version. This isn't supposed to be able to happen. Turns out two quick commits could get us into this state because both would be created by the processor before getting valid version data. However, the WorkerEntityTracker can detect this is happening and has enough information to make things right.

BUG=647875

Review-Url: https://codereview.chromium.org/2350803005
Cr-Commit-Position: refs/heads/master@{#420471}

BUG=b:31665510
TEST=try, also manually confirmed that Always button still works

Review-Url: https://codereview.chromium.org/2357983006
Cr-Commit-Position: refs/heads/master@{#420470}

Extension provided certificates currently aren't shown on the certificates page, and this is bad from a security standpoint. This CL addresses the problem.

BUG=532038

Review-Url: https://codereview.chromium.org/2307373003
Cr-Commit-Position: refs/heads/master@{#420469}

Otherwise this may nuke intentional playbacks from the media session.

BUG=649271
TEST=playback doesn't pause after 5 seconds if play occurs.

Review-Url: https://codereview.chromium.org/2363813002
Cr-Commit-Position: refs/heads/master@{#420468}

Updates and simplifies the decoding of the Contextual Cards response data:
1) Add reading of the caption and thumbnail directly from the root level.
2) Remove full JSON response decoding.

BUG=647041

Review-Url: https://codereview.chromium.org/2364703003
Cr-Commit-Position: refs/heads/master@{#420467}