1. 16 Aug, 2011 40 commits
    • aroben@apple.com's avatar
      Skip another test that relies on eventSender.scalePageBy on Windows · 893d4205
      aroben@apple.com authored
      * platform/win/Skipped: Added fast/repaint/background-scaling.html.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93158 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      893d4205
    • senorblanco@chromium.org's avatar
      Canvas resizing can be slow · d29c4640
      senorblanco@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66251
      
      Canvas resizing was slow due to re-allocation of the ImageBuffer on
      each size change (width or height).  This was introduced inadvertently
      by calls to isAccelerated() during canvas reset().  Since we won't 
      know if we have successfully accelerated until ImageBuffer creation,
      move the compositor invalidation to createImageBuffer() as well.
      This patch also attempts to unify the Skia and CG accelerated canvas
      paths.  The DrawingBuffer used by the Skia path is now owned by 
      ImageBuffer[Skia], similar to how the IOSurface is owned by
      ImageBuffer[CG].  Some of the logic for when to accelerate was moved
      into HTMLCanvasElement and unified with the CG path.  Acceleration is
      also now enabled by the same "Accelerated" ImageBuffer create flag
      used by the CG path.  DrawingBuffer is now re-created even for a 
      same-size change (same as the memory buffer), but we speed it up
      by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
      instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
      clear it, since it's done with a glClear anyway).
      
      Reviewed by Kenneth Russell.
      
      Covered by existing tests in fast/canvas and canvas/philip.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      Don't call isAccelerated() from reset(), since we don't want to
      inadvertently create the ImageBuffer.  Also, since we won't know if
      we have successfully accelerated until createImageBuffer() is
      called, defer the compositor invalidation to createImageBuffer() as
      well.
      (WebCore::HTMLCanvasElement::shouldAccelerate):
      Unify the CG and Skia ports' logic for when to accelerate (Skia
      logic moved in from CanvasRenderingContext2D).
      (WebCore::HTMLCanvasElement::createImageBuffer):
      Use the unified shouldAccelerate() logic, and pass it as a flag
      to ImageBuffer.  Do compositor invalidation as well.
      * html/HTMLCanvasElement.h:
      (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
      Expose hasCreatedImageBuffer() publically, so
      CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
      it.
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
      (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
      Remove all acceleration setting and resetting, since it's now done
      during ImageBuffer creation.
      (WebCore::CanvasRenderingContext2D::isAccelerated):
      Check if the image buffer was created, so we don't inadvertently
      create it here.
      (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
      Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
      WebViewImpl may be null.  Ask the render tree instead.
      (WebCore::CanvasRenderingContext2D::reset):
      Don't reset acceleration here, since we don't own it anymore.
      (WebCore::CanvasRenderingContext2D::platformLayer):
      Call into the ImageBuffer to get our PlatformLayer.
      * html/canvas/CanvasRenderingContext2D.h:
      Remove m_drawingBuffer, and all acceleration-related calls.
      * platform/graphics/GraphicsContext.cpp:
      * platform/graphics/GraphicsContext.h:
      Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
      * platform/graphics/ImageBuffer.cpp:
      (WebCore::ImageBuffer::platformLayer):
      Implement a dummy platformLayer() call for non-skia ports.
      * platform/graphics/ImageBuffer.h:
      Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
      * platform/graphics/chromium/ImageBufferDataSkia.h:
      Add a DrawingBuffer data member.
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore::DrawingBuffer::reset):
      Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
      Since we immediately clear the framebuffer via glClear(), this whole
      resource safe business is overkill.
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      Remove setGraphicsContext3D() and paintsIntoImageBuffer().  This
      functionality is handled by ImageBuffer now.
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::ImageBuffer::ImageBuffer):
      Give the ImageBufferData ownership of the DrawingBuffer.
      (WebCore::ImageBuffer::platformLayer):
      Implement an accessor for the DrawingBuffer's PlatformLayer.
      * platform/graphics/skia/PlatformContextSkia.cpp:
      (WebCore::PlatformContextSkia::setGraphicsContext3D):
      * platform/graphics/skia/PlatformContextSkia.h:
      Remove isPathSkiaSafe() extern (unused).
      Remove paintsIntoImageBuffer() (now unused).  Remove IntSize param
      from setGraphicsContext3D() (unused).
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93157 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d29c4640
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. Take 3. · 66b0c5f3
      joepeck@webkit.org authored
      Include the proper includes!
      
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66b0c5f3
    • aroben@apple.com's avatar
      Teach TestFailures that tests that have failed or passed many times in a row are not flaky · a8e45b2d
      aroben@apple.com authored
      The basic strategy here is that once a test has failed or passed many times in a row we
      never again consider it as a possibly flaky test. It's a simple strategy but seems to result
      in many fewer false positives than our current behavior.
      
      Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
      flaky, including tests that failed for a while but then were fixed
      
      Reviewed by Dan Bates.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
      (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
      number of non-too-many-failure builds we've seen.
      (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
      failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
      tests, keep track of how many times they have passed or failed in a row. If they pass or
      fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
      considered flaky it doesn't matter how many times it passes or fails.)
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
      Added tests for the above.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93155 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a8e45b2d
    • tony@chromium.org's avatar
      [chromium] fast/css/custom-font-xheight.html is hitting an assert · 1ee044b5
      tony@chromium.org authored
      in debug on Linux.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93154 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1ee044b5
    • tony@chromium.org's avatar
      [chromium] Mark new tests as failing. Will pull results from the · d8c230b2
      tony@chromium.org authored
      bots when they cycle.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93153 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d8c230b2
    • dglazkov@chromium.org's avatar
      garden-o-matic needs a summary view with actions for each problem. · f6d1a7af
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66144
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93152 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f6d1a7af
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. Take 2. · a22323bf
      joepeck@webkit.org authored
      This just makes the troublesome enum public. If this
      fixes the build I will file a follow-up bug to clean-up
      these build issues and either keep the enum public and
      cleanup other functions or restore the enum to private.
      There is no harm in making the enum public right now.
      
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93151 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a22323bf
    • commit-queue@webkit.org's avatar
      Unmatrix algorithm implementation is wrong · b365c094
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66080
      
      Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Current version of the algorithm negates only the scaleX while
      it should negate also scaleY and scaleZ when appropriate.
      
      Test: animations/animation-matrix-negative-scale-unmatrix.html
      
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::decompose):
      
      LayoutTests:
      
      * animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
      * animations/animation-matrix-negative-scale-unmatrix.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93150 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b365c094
    • joepeck@webkit.org's avatar
      Unreviewed Chromium Windows build fix after r93140. · 69a3d559
      joepeck@webkit.org authored
      * platform/graphics/FontCache.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93149 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      69a3d559
    • eric.carlson@apple.com's avatar
      Make video-controls-no-scripting.html results platform independent. · c521cf50
      eric.carlson@apple.com authored
      * media/video-controls-no-scripting-expected.txt:
      * media/video-controls-no-scripting.html:
      * platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93148 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c521cf50
    • joepeck@webkit.org's avatar
      Unreviewed Windows and Chromium Windows build fix after r93140. · 359e10e2
      joepeck@webkit.org authored
      * platform/graphics/FontCache.h:
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (WebCore::getLastResortFallbackFontProc):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (WebCore::FontCache::getLastResortFallbackFont):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93147 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      359e10e2
    • aroben@apple.com's avatar
      Make placeholder text remain visible until a character is typed on Windows · caf6d0eb
      aroben@apple.com authored
      Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
      is focused on Windows, which doesn't match Lion or Windows native text fields
      
      Covered by existing tests (which are currently failing on the bots until this patch lands).
      
      Reviewed by Dave Hyatt.
      
      * rendering/RenderThemeSafari.h:
      (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
      * rendering/RenderThemeWin.h:
      (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
      Added overrides to return true.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93146 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      caf6d0eb
    • dino@apple.com's avatar
      Adding Ted "hober" O'Connor as a non-committing contributor. · 9e72940e
      dino@apple.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93145 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9e72940e
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=66254 · f35ec40a
      hyatt@apple.com authored
      Source/WebCore: 
      
      Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
      repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
      content.
      
      Reviewed by Simon Fraser.
      
      Added new tests in fast/repaint.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::repaintRectangleInRegions):
      * rendering/RenderFlowThread.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::enclosingRenderFlowThread):
      (WebCore::RenderObject::containerForRepaint):
      (WebCore::RenderObject::repaintUsingContainer):
      * rendering/RenderObject.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      (WebCore::RenderView::renderFlowThreadWithName):
      * rendering/RenderView.h:
      (WebCore::RenderView::hasRenderFlowThreads):
      
      LayoutTests: 
      
      Make regions repaint properly. Added new repaint tests.
      
      Reviewed by Simon Fraser.
      
      * fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
      * fast/repaint/line-flow-with-floats-in-regions.html: Added.
      * fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
      * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
      * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93144 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f35ec40a
    • joepeck@webkit.org's avatar
      Abandoned Memory: Temporary CSS Fonts May Never Be Purged · e8fe5414
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66153
      
      Reviewed by Dan Bernstein.
      
      While a remote CSS font face is loading we fallback to a
      temporary font. We don't want to retain the fallback font
      because noone takes ownership of the temporary font. This
      patch adds a way to get an uncached fallback font, which
      plumbs the ShouldRetain enum through the different platform
      implementations of getLastResortFallbackFont.
      
      No new tests, no functional change.
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      * platform/graphics/FontCache.cpp:
      (WebCore::FontCache::getNonRetainedLastResortFallbackFont):
      * platform/graphics/FontCache.h:
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::fontDataFromDescriptionAndLogFont):
      (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
      (WebCore::getLastResortFallbackFontProc):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/chromium/FontCacheLinux.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/freetype/FontCacheFreeType.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/haiku/FontCacheHaiku.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/pango/FontCachePango.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/qt/FontCacheQt.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::fontDataFromDescriptionAndLogFont):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wince/FontCacheWinCE.cpp:
      * platform/graphics/wx/FontCacheWx.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8fe5414
    • aroben@apple.com's avatar
      Add Windows expected results for some <canvas> tests · 1deb64f9
      aroben@apple.com authored
      <canvas> doesn't use accelerated compositing on Windows like it does on Lion.
      
      * platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
      * platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93139 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1deb64f9
    • dbates@webkit.org's avatar
      2011-08-16 Daniel Bates <dbates@webkit.org> · 7f8342bf
      dbates@webkit.org authored
              Add myself to the list of individual members in the WebKit Security Group.
      
              Rubber-stamped by Eric Seidel.
      
              * security/security-group-members.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93138 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7f8342bf
    • commit-queue@webkit.org's avatar
      Chromium Mac: Rubber banding gutter drawing · 39759b74
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
      draw the overhang areas.
      Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
      Add a different implementation for Chromium Mac.
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
      Reviewed by Dimitri Glazkov.
      
      No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93136 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      39759b74
    • rniwa@webkit.org's avatar
      Programmatically set selection should not have direction on Mac · 0630225d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60529
      
      Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore: 
      
      Modified default value of VisibleSelection->m_isDirectional from 'true'
      to 'false' by adding a defaulted argument to several VisibleSelection 
      constructors to make programmatic selection be directionless by default 
      on Mac. Also modified several calls to VisibleSelection's constructors
      to correctly preserve directionality.
              
      Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
      a call to setExtent triggers an editing delegate that uses the
      FrameSelection. The direction here should have been preserved from before,
      but setIsDirectional was not called until after FrameSelection.cpp:869. It
      has been moved up to make things behave.
      
      * WebCore.exp.in:
      * editing/ApplyBlockElementCommand.cpp:
      (WebCore::ApplyBlockElementCommand::doApply):
      (WebCore::ApplyBlockElementCommand::formatSelection):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::updateStartEnd):
      * editing/BreakBlockquoteCommand.cpp:
      (WebCore::BreakBlockquoteCommand::doApply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::moveParagraphWithClones):
      (WebCore::CompositeEditCommand::moveParagraphs):
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
      * editing/CreateLinkCommand.cpp:
      (WebCore::CreateLinkCommand::doApply):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
      (WebCore::DeleteSelectionCommand::doApply):
      * editing/Editor.cpp:
      (WebCore::Editor::selectionForCommand):
      * editing/FrameSelection.cpp:
      (WebCore::shouldAlwaysUseDirectionalSelection):
      (WebCore::FrameSelection::FrameSelection):
      (WebCore::FrameSelection::moveTo):
      (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
      (WebCore::FrameSelection::modify):
      (WebCore::FrameSelection::setBase):
      (WebCore::FrameSelection::setExtent):
      * editing/FrameSelection.h:
      * editing/InsertLineBreakCommand.cpp:
      (WebCore::InsertLineBreakCommand::doApply):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApply):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::performTrivialReplace):
      (WebCore::InsertTextCommand::doApply):
      * editing/MoveSelectionCommand.cpp:
      (WebCore::MoveSelectionCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::makeEditableRootEmpty):
      (WebCore::TypingCommand::deleteKeyPressed):
      (WebCore::TypingCommand::forwardDeleteKeyPressed):
      * editing/VisibleSelection.cpp:
      (WebCore::VisibleSelection::VisibleSelection):
      * editing/VisibleSelection.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      
      LayoutTests: 
      
      Added editing/selection/programmatic-selection-on-mac-is-directionless
      to test selection direction in programmatically set selections on
      windows, unix, and mac, in plain text, editable divs, text-input
      fields, and textareas. Modified text baselines for many editing tests,
      which had a delegate change as a result of the cpp patch.
      
      * editing/deleting/delete-ligature-003-expected.txt:
      * editing/deleting/paragraph-in-preserveNewline-expected.txt:
      * editing/deleting/whitespace-pre-1-expected.txt:
      * editing/selection/after-line-break-expected.txt:
      * platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
      * platform/mac/editing/deleting/delete-and-undo-expected.txt:
      * platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
      * platform/mac/editing/deleting/delete-br-002-expected.txt:
      * platform/mac/editing/deleting/delete-br-004-expected.txt:
      * platform/mac/editing/deleting/delete-br-005-expected.txt:
      * platform/mac/editing/deleting/delete-br-006-expected.txt:
      * platform/mac/editing/deleting/delete-br-009-expected.txt:
      * platform/mac/editing/deleting/delete-br-010-expected.txt:
      * platform/mac/editing/deleting/delete-br-011-expected.txt:
      * platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
      * platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
      * platform/mac/editing/deleting/smart-delete-002-expected.txt:
      * platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
      * platform/mac/editing/inserting/insert-at-end-01-expected.txt:
      * platform/mac/editing/inserting/insert-at-end-02-expected.txt:
      * platform/mac/editing/inserting/insert-div-010-expected.txt:
      * platform/mac/editing/inserting/insert-div-013-expected.txt:
      * platform/mac/editing/inserting/insert-div-015-expected.txt:
      * platform/mac/editing/inserting/insert-div-019-expected.txt:
      * platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
      * platform/mac/editing/pasteboard/3976872-expected.txt:
      * platform/mac/editing/pasteboard/4076267-2-expected.txt:
      * platform/mac/editing/pasteboard/4076267-expected.txt:
      * platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
      * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
      * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-015-expected.txt:
      * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
      * platform/mac/editing/selection/4932260-1-expected.txt:
      * platform/mac/editing/selection/anchor-focus2-expected.txt:
      * platform/mac/editing/selection/anchor-focus3-expected.txt:
      * platform/mac/editing/selection/expanding-selections-expected.txt:
      * platform/mac/editing/selection/expanding-selections2-expected.txt:
      * platform/mac/editing/selection/fake-drag-expected.txt:
      * platform/mac/editing/selection/move-by-word-001-expected.txt:
      * platform/mac/editing/selection/transformed-selection-rects-expected.txt:
      * platform/mac/editing/selection/triple-click-in-pre-expected.txt:
      * platform/mac/editing/style/create-block-for-style-008-expected.txt:
      * platform/mac/editing/undo/4063751-expected.txt:
      * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
      * platform/mac/editing/undo/undo-forward-delete-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93134 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0630225d
    • jpfau@apple.com's avatar
      New XML parser: Add document fragment parser · e34650f2
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66317
      
      Reviewed by Adam Barth.
      
      * dom/DocumentFragment.cpp:
      (WebCore::DocumentFragment::parseXML):
      * xml/parser/NewXMLDocumentParser.cpp:
      (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
      (WebCore::NewXMLDocumentParser::parseDocumentFragment):
      * xml/parser/NewXMLDocumentParser.h:
      (WebCore::NewXMLDocumentParser::create):
      * xml/parser/XMLTokenizer.h:
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::XMLTreeBuilder):
      (WebCore::XMLTreeBuilder::pushCurrentNode):
      * xml/parser/XMLTreeBuilder.h:
      (WebCore::XMLTreeBuilder::create):
      (WebCore::XMLTreeBuilder::NodeStackItem::node):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93133 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e34650f2
    • tony@chromium.org's avatar
      [chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey. · c796b410
      tony@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93132 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c796b410
    • senorblanco@chromium.org's avatar
      GraphicsContext3D should allow its hostWindow to be NULL · 30d2bcb6
      senorblanco@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66305
      
      Allow the hostWindow param (and m_webViewImpl) to be NULL.  This
      makes it much easier to enable GPU acceleration at a lower level
      in WebKit's platform/graphics layer, without needing access to the
      Page* or HostWindow*.  Also bump the chromium DEPS to chrome r96940,
      which includes a similar change for the in-process GraphicsContext3D
      implementations.
      
      Reviewed by James Robinson.
      
      * DEPS:
      * src/GraphicsContext3DChromium.cpp:
      (WebCore::GraphicsContext3DInternal::initialize):
      (WebCore::GraphicsContext3DInternal::platformTexture):
      (WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93131 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      30d2bcb6
    • jpfau@apple.com's avatar
      New XML parser: Replace assertions regarding character data in the prolog with proper checks · c7e63db0
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66269
      
      Reviewed by Adam Barth.
      
      This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
      
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processProcessingInstruction):
      (WebCore::XMLTreeBuilder::processXMLDeclaration):
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      (WebCore::XMLTreeBuilder::enterText):
      (WebCore::XMLTreeBuilder::failOnText):
      * xml/parser/XMLTreeBuilder.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93130 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c7e63db0
    • tony@chromium.org's avatar
      [chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in · 721f0ece
      tony@chromium.org authored
      debug (not just snowleopard).
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93129 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      721f0ece
    • aroben@apple.com's avatar
      Add Windows expected results for resource-har-conversion.html · ee37ca27
      aroben@apple.com authored
      While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
      extra fields in the request objects.
      
      * platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93128 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ee37ca27
    • apavlov@chromium.org's avatar
      Web Inspector: word wrap long edits · 3293d004
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65512
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/inspector.css:
      (.styles-section .properties li.child-editing):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93127 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3293d004
    • mnaganov@chromium.org's avatar
      ee03958f
    • pfeldman@chromium.org's avatar
      Web Inspector: convert DOM breakpoint types to strings. · 7fc15755
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66304
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::domTypeForName):
      (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/front-end/DOMBreakpointsSidebarPane.js:
      (WebInspector.DOMBreakpointsSidebarPane):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7fc15755
    • tony@chromium.org's avatar
      Copy the results of http/tests/inspector/resource-har-conversion.html · 07ae87e9
      tony@chromium.org authored
      to the chromium platform dir.  The mac result (r93112) was getting
      picked up by the chromium port.
      
      * platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      07ae87e9
    • tony@chromium.org's avatar
      Move media/video-controls-no-scripting-iframe.html into the resources · ebc19b9b
      tony@chromium.org authored
      subdir since it's not a standalone test.
      
      Also add chromium baseline (the top of the video control is in a
      different place).
      
      * media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
      * media/video-controls-no-scripting.html:
      * platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ebc19b9b
    • pfeldman@chromium.org's avatar
      Web Inspector: force pseudo element state when checking it in the styles sidebar. · 78d675bb
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66292
      
      This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
      calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
      they are guarded with the inline checks for the front-end count.
      
      Reviewed by David Hyatt.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::initForStyleResolve):
      (WebCore::CSSStyleSelector::styleRulesForElement):
      (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
      (WebCore::CSSStyleSelector::checkSelector):
      (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      * css/CSSStyleSelector.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::computePseudoClassMask):
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      (WebCore::InspectorCSSAgent::clearFrontend):
      (WebCore::InspectorCSSAgent::forcePseudoState):
      (WebCore::InspectorCSSAgent::getStylesForNode):
      (WebCore::InspectorCSSAgent::didRemoveDocument):
      (WebCore::InspectorCSSAgent::didRemoveDOMNode):
      (WebCore::InspectorCSSAgent::clearPseudoState):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::disconnectFrontend):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::forcePseudoStateImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::forcePseudoState):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      78d675bb
    • tony@chromium.org's avatar
      Unreviewed, rolling out r93114. · a2d69615
      tony@chromium.org authored
      http://trac.webkit.org/changeset/93114
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      broke the chromium mac compile
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      * platform/ScrollbarThemeComposite.cpp:
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      * platform/mac/ScrollbarThemeMac.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a2d69615
    • aroben@apple.com's avatar
      Update Windows results for a fast/text test for Safari 5.1's AAS · b248cf6d
      aroben@apple.com authored
      The results are now more like Mac's. Dan Bernstein says this is probably a progression.
      
      * platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b248cf6d
    • tony@chromium.org's avatar
      [chromium] Mark media/video-source-error.html as flaky in Debug. · b803ab28
      tony@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b803ab28
    • aroben@apple.com's avatar
      Update Windows results after r92890 · f179ef96
      aroben@apple.com authored
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f179ef96
    • aroben@apple.com's avatar
      Remove Windows-specific hyphenation test results now that hyphenation works on Windows · 48d06a10
      aroben@apple.com authored
      * platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
      * platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
      * platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      48d06a10
    • commit-queue@webkit.org's avatar
      Chromium Mac: Rubber banding gutter drawing · c45640da
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66226
      
      Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
      draw the overhang areas.
      Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
      Add a different implementation for Chromium Mac.
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
      Reviewed by Dimitri Glazkov.
      
      No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
      * platform/ScrollbarThemeComposite.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      (WebCore::scrollbarStateToThemeState):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c45640da
    • tony@chromium.org's avatar
      Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html · 4f5b94d0
      tony@chromium.org authored
      to the chromium platform dir.  The mac failing results (r93105) were
      getting picked up by the chromium port.
      
      * platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
      * platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4f5b94d0
    • aroben@apple.com's avatar
      Add Lion/Windows expected results for an Inspector test · 2516ae4c
      aroben@apple.com authored
      The only difference from the cross-platform results is that the .js resources are now given
      a MIME type of "text/plain".
      
      This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
      Windows), CFNetwork no longer uses the file extension as a fallback when determining the
      MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.
      
      * platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
      * platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2516ae4c