- 04 Dec, 2017 40 commits
-
-
Henrik Lundin authored
Adding the Enabled group, which is the intended launch config. Bug: chromium:780849 Change-Id: I11a7c6074204a009cdb3b6204da2ed8a7c15a76a Reviewed-on: https://chromium-review.googlesource.com/803271Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521294}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/56b08b1f2bb8..8509d3eaec1b $ git log 56b08b1f2..8509d3eae --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Make a CXFA_DocumentParser member Unowned. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib1335d520755701f05135122d7d79005ba6fd7a9 Reviewed-on: https://chromium-review.googlesource.com/804924 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521293}
-
suyambu.rm authored
This CL enables the following, 1.Vulkan support for Skia Renderer leveraging Skia's Vulkan backend. 2.Vulkan context creation based on Skia's GrVkBackendContext. Bug: 582554 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I226cd5819dd89e5b71b605093eed1feb6f5074f9 Signed-off-by:
suyambu <suyambu.rm@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/649387 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521292}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0407506a..0b24b652 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I24d5e214d1d6f1ce06b1da824eccd86433b74ed3 Reviewed-on: https://chromium-review.googlesource.com/805157Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521291}
-
cathiechen authored
Marker_container is a zero height anonymous block and marker is its only child. Marker_container positioned at the side of list content, it shouldn't break margin collapse. Gecko already do this. Change-Id: I8a47605e80eb927165c359a4bfcd66da0f847e4d Reviewed-on: https://chromium-review.googlesource.com/773766 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521290}
-
Suneel Kota authored
Adding runtimeFlags.overlayScrollbarsEnabled would help to make more of these branches take the overlay path Bug: 661783 Change-Id: I1d5523922fe3d6c8f671edd1c54789ef9aae399d Reviewed-on: https://chromium-review.googlesource.com/792833Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521289}
-
Yuichiro Hanada authored
Always create VirtualKeyboardContainer instead of creating on the fly, so we can register it as an ActivationParent correctly. This change also deletes code that checks the existence of virtual keyboard by the existence of the container window. The location of the container has been changed from between ImeWindowParentContainer & KeyboardContainer, to between VirtualKeyboardParentContainer and KeyboardContainer. The new hierarchy is: RootWindow -> ScreenRotationContainer -> LockScreenRelatedContainersContainer -> VirtualKeyboardParentContainer -> VirtualKeyboardContainer -> KeyboardContainer (which is owned by KeyboardController) -> keyboard contents window. Bug: 731537, 616909 Test: Unit tests pass. Change-Id: Ia9d04fe3ef9b2584dfbe1b785b498f8152fc398b Reviewed-on: https://chromium-review.googlesource.com/771470 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521288}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. TBR=sky@chromium.org Bug: 289619 Change-Id: Ib1071a21f851bded91100b503f991e09d691f0ff Reviewed-on: https://chromium-review.googlesource.com/789090 Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521287}
-
Hidehiko Abe authored
BUG=739622 TEST=Ran trybots. Change-Id: I0ed123db414da86e99846c36bebc657a35f4799d Reviewed-on: https://chromium-review.googlesource.com/803874 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#521286}
-
Yutaka Hirano authored
As we have launched LoadingWithMojo, the virtual test suite is no longer needed. Bug: 603396, 788241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo Change-Id: Id40b27d02de03d3880076c53283527c5fed7a294 Reviewed-on: https://chromium-review.googlesource.com/805175Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521285}
-
Hiroki Nakagawa authored
This is a clean-up CL. This specifies "Allow-Access-Control-Origin" header by *.js.headers files instead of "pipe=header()" query parameters for simplification. Bug: n/a Change-Id: Ia18ea8a1e00ea6854f69771d911bf3e4d88379d2 Reviewed-on: https://chromium-review.googlesource.com/804921Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#521284}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b8d86800487d..56b08b1f2bb8 $ git log b8d868004..56b08b1f2 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Make CXFA_SimpleParser members const or Unowned. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcb0aa7f168c7faf084b59abab91a6905ad184d1 Reviewed-on: https://chromium-review.googlesource.com/804611 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521283}
-
Christopher Lam authored
The console logs are going the other way now. Bug: 791393 Change-Id: I2769852d449ce8edc3ead9b2127a7e63b55786ea Reviewed-on: https://chromium-review.googlesource.com/804711Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521282}
-
Raymes Khoury authored
After the refactor in https://chromium-review.googlesource.com/c/chromium/src/+/756657/ which changes the DSE permissions to be reflected in the user's content settings, we need to make sure these are reset to their default values when the user clicks "Clear and Reset" or "Clear Browsing Data". Bug: 780344 Change-Id: I8e18ecc0d60b9ec0442ab2e5291c55cfd2480b61 Reviewed-on: https://chromium-review.googlesource.com/770592 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521281}
-
Darren Shen authored
CSSNumericValue.toSum converts a CSSNumericValue into the sum of terms with different units. For example, new CSSMathSum(CSS.em(1), CSS.cm(1)).toSum('mm', 'em') returns new CSSMathSum(CSS.mm(10), CSS.em(1)) Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-tosum Bug: 776173 Change-Id: I073c9c6d0b3246ff2a085092547ba6dfb2b5a873 Reviewed-on: https://chromium-review.googlesource.com/798932 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521280}
-
David Bokan authored
This patch fixes MouseEvent.layerX and layerY when root-layer-scrolls is enabled. The layer coordinates are calculated by subtracting from the document location the layer offsets of each parent layer starting from the current layer's parent. This yields the offset within the layer. The repeated subtraction gets us back to the absolute coordinate space. Pre-RLS, this was the same as document/content coordinates. With RLS turned on, the LayoutView is the same size as the frame and clips and scrolls its content. Thus, transforming through it yields frame coordinates. Therefore, the change is to start from the event's absolute location. With RLS off, the conversion yields a no-op so there's no change. When RLS is on this accounts for the LayoutView's scroll offset. Bug: 781431 Change-Id: Ib25859effbfb71516e5edb5173154c807ea98314 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/798832 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521279}
-
Raymes Khoury authored
The default search engine can be disabled by enterprise. In this case, we restore the permission settings for the old DSE. We also delete the underlying pref that tracks settings, so that if the DSE is re-enabled, the DSE permissions will be re-initialized for the new DSE as if being initialized for the first time. Bug: 780344 Change-Id: I6df13d6b085dbe8164fe003c3406245e5b8efb2f Reviewed-on: https://chromium-review.googlesource.com/765566 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521278}
-
Dmitry Gozman authored
This is a preparation to replace routing id + legacy IPC with Mojo interface retrievable from SharedWorkerHost. Temporarily duplicated some code from WorkerDevToolsAgentHost, which makes it possible to migrate shared and service workers separately. Removed a test for WORKER_STATE manipulations altogether with the state itself. Bug: 776009 Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e Reviewed-on: https://chromium-review.googlesource.com/783110 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#521277}
-
Leo Zhang authored
This CL is based on crrev.com/c/762540 1, Polish the UI. 2, Reading all language infos from native. 3, Enable "Remove" in the language menu. 4, Enable "Add language" for the settings page. 5, Created "Add language" fragment, it will list all unselected languages and provide a "search" function for users to find the language quickly. Tested on my local devices, demo video link https: //googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings.mp4 Bug: 783049 Change-Id: Ie5fdba908a99ad1116538bd69fe9c703c4c9051a Reviewed-on: https://chromium-review.googlesource.com/790091 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521276}
-
Tetsui Ohkubo authored
In Chrome OS, notification corners are rounded. However, when the actions row is expanded, its corners were not rounded. TEST=manual BUG=789056 Change-Id: Id29f3d1d193a682c478249089ae4bfa30c52fad3 Reviewed-on: https://chromium-review.googlesource.com/803134 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521275}
-
Xiaocheng Hu authored
This patch exposes two subroutines of ComputeInlineBoxPosition: - ComputeInlineAdjustedPosition - ComputeInlineBoxPositionForInlineAdjustedPosition After this patch, we can start converting callers of ComputeInlineBoxPosition with the following pattern: DoSomeBusiness(position) { adjusted = ComputeInlineAdjustedPosition(position); if (/* adjusted is laid out with LayoutNG */) return NGAlternativeImplementation(adjusted); legacy_box_position = ComputeInlineBoxPositionForInlineAdjustedPosition(adjusted); DoLegacyBusiness(legacy_box_position); } Bug: 771398 Change-Id: Iea01925e7ef986c5b00dd5b6e7172f7065c8df9e Reviewed-on: https://chromium-review.googlesource.com/792453Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521274}
-
Christopher Lam authored
This CL adds the "HostedAppFrame.WrenchMenu.MenuAction" metric which tracks which menu actions are being clicked from the hosted app browser frame. Bug: 785661 Change-Id: I4b6c349892615452ce8ed6ebc8b1c23e5f1a8a9e Reviewed-on: https://chromium-review.googlesource.com/802838 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#521273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e0e3bb53. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6851 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I2265c0367b490b15126095e36fb4d623f0329ecd Reviewed-on: https://chromium-review.googlesource.com/805097 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521272}
-
cathiechen authored
"Marker_rect" should contains the block direction offset of marker when propagate overflowRect to its ancestors. Change-Id: Idcbd3ab4688f48879bad3a702b5f19f63e8819d6 Reviewed-on: https://chromium-review.googlesource.com/798936Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#521271}
-
Christopher Lam authored
Flake examples: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51019 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51016 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/3170 TBR=mkwst@chromium.org Bug: 791389 Change-Id: I23a57c249151746ba07b70f36ee7aa4ee8da0aeb Reviewed-on: https://chromium-review.googlesource.com/804905 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521270}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: Ia61c712446434a346dbe3ed954fb5b7438dd76a2 Reviewed-on: https://chromium-review.googlesource.com/805098Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521269}
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL does not remove ash::system_notifier::CreateSystemNotification right now, as we also have to remove ununsed old |icon| assets with it. BUG=757703 Change-Id: Ibb7e8cdbf01068489b2c0f17443a66043834f1eb Reviewed-on: https://chromium-review.googlesource.com/802658Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#521268}
-
Christopher Lam authored
This CL adds standard wrench menu action stats for Copy URL, Open in Chrome, Site Settings and App Info. Bug: 785661 Change-Id: I1b94804076282ef9ecb97c581fb147670adaae70 Reviewed-on: https://chromium-review.googlesource.com/790172 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521267}
-
Michael McGreevy authored
This histogram has the same function as WebApk.Install.InstallSource (which tracks the mechanism by which a web app is installed on Android), but is intended for use on any platform. The associated enum has an extra entry, which will be used to count installs which are initiated via calls to BeforeInstallPrompt.prompt(). Once there is enough historical data for Android in Webapp.Install.InstallSource, WebApk.Install.InstallSource will be removed (tracking bug: crbug.com/790788) Bug: 785661 Change-Id: Ie7d185a7e66e1caa2c25e850745171cb32165518 Reviewed-on: https://chromium-review.googlesource.com/802336 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#521266}
-
Patti authored
Hebrew does not translate the string for 'Javascript'. This means any labels containing the English string will not have the RTL mark, and it will be displayed in LTR mode. Normally this would be OK, however, the permission labels in Page Info for Android have a width that matches the parent, so the label ends up aligning the text all the way on the left. Fix by changing the label width to wrap the content instead of matching its parent width. Note other strings are fine because they have Hebrew translations. Bug: 774934 Change-Id: I756c9e9584c8c89ab86462ba43aa8cefc10f024e Reviewed-on: https://chromium-review.googlesource.com/776333Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521265}
-
Yuzu Saijo authored
Bug: 777765, 763280 Change-Id: Ic808ad2a2d0735777e570118645ef6f5ca06cc4d Reviewed-on: https://chromium-review.googlesource.com/802657Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#521264}
-
Takayoshi Kochi authored
Support for creating V0 shadowRoot on elements that has a UA shadow was removed, but this flag is used to block V0 author shadow creation on elements which might add UA shadow later. For that purpose AreAuthorShadowsAllowed() exists, and AlwaysCreateUserAgentShadowRoot is redundant. Change-Id: I07387a2862eb5695eadf3cdcee8adc49467fab38 Reviewed-on: https://chromium-review.googlesource.com/803174Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521263}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=mmenke@chormium.org Change-Id: I95be755819bd151634e88ca26016e102d4d02f27 Reviewed-on: https://chromium-review.googlesource.com/799014Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521262}
-
Fumitoshi Ukai authored
add config for new bot names in tools/mb, testing/buildbot and ios/build/bots rename as cl/177104371 Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id46a0e61115d0699925f0219313086b3bae0dd65 Reviewed-on: https://chromium-review.googlesource.com/792672Reviewed-by:
smut <smut@google.com> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521261}
-
Hiroshige Hayashizaki authored
XMLHttpRequest's responseXML's SecurityOrigin is aliased with its ExecutionContext, i.e. either with Document or an isolated world, in XMLHttpRequest::InitResponseDocument(). This CL is a preparation for making SecurityContext::GetSecurityOrigin() and XMLHttpRequest::GetSecurityOrigin() return const SecurityOrigin* in [1], while preserving the aliasing behavior in XHR. [1] https://chromium-review.googlesource.com/744586 This CL - Introduces XMLHttpRequest::GetMutableSecurityOrigin(), - Uses ExecutionContext::GetMutableSecurityOrigin() for aliasing with another Document and - Uses the registered SecurityOrigin of an isolated world in DOMWrapperWorld for aliasing with the isolated world. This CL Takes IsolatedCopy() before DOMWrapperWorld::SetIsolatedWorldSecurityOrigin() in WebLocalFrameImpl::SetIsolatedWorldSecurityOrigin(), to make SecurityOrigin inside its argument (WebSecurityOrigin) const. This IsolatedCopy() doesn't cause semantic changes, because the callers of SetIsolatedWorldSecurityOrigin() never pass an aliased WebSecurityOrigin. Bug: 779730 Change-Id: I503c0623f15e37cba010a0c7f0b72e2b44f5af08 Reviewed-on: https://chromium-review.googlesource.com/752006 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521260}
-
Hidehiko Abe authored
Migrated seven test cases. BUG=234463 TEST=Ran bots. Change-Id: Idc33683a4221246ac3ec9e3414435144273c8866 Reviewed-on: https://chromium-review.googlesource.com/803774Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521259}
-
Christopher Lam authored
Flakes starting from: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64945 til https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64973 TBR=gene@chromium.org Bug: 517420 Change-Id: Ib75f72c56584acdc9e3f95163443e3eef14b5ace Reviewed-on: https://chromium-review.googlesource.com/804622Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521258}
-
David Reveman authored
Modifier flags needs same treatment as pressed keys. Move modifier flag tracking to Seat class. Bug: 788731 Tbr: yoshiki@chromium.org Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ife2fae2d622dfff3617830ba232d0267fdbc9b35 Reviewed-on: https://chromium-review.googlesource.com/805359Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521257}
-
Raymes Khoury authored
This adds support to automatically grant the Default Search Engine the notifications permission on Android. The behavior is similar to the way the geolocation permission works for the DSE. Although the behavior is mostly the same, this CL changes the way permissions (geolocation and notifications) are transferred between DSEs when the user changes their DSE. The new approach stores the permissions that the user had set on the DSE origin prior to it becoming the DSE. When the user changes the DSE, we restore the old settings. No UI for the notifications part has yet been implemented. Bug: 780344 Change-Id: Ifa57e395ad4a647f42debb78146d50574ee1b636 Reviewed-on: https://chromium-review.googlesource.com/756657 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521256}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id90c5a04af42b64ddc7b66984dc2b948f75f6532 Reviewed-on: https://chromium-review.googlesource.com/789719Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521255}
-