- 29 Sep, 2017 40 commits
-
-
Igor authored
When migration policy is changed during the user session, it might enable ARC for user with unpredictable consequences. This change caches the migration policy value for the session and uses the cached value. Bug: b:67013794 Test: Manual Change-Id: Id2f8c5173b8b63045a50531ec7e8d271d8df41da Reviewed-on: https://chromium-review.googlesource.com/692195 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505422}
-
rbpotter authored
Setting the paper size by ID does not work for custom user sizes, which have values >= DMPAPER_USER = 256. Set the width and length directly in these cases. Bug: None Change-Id: I7c23c656920ac6287c680e2408554c5da716871d Reviewed-on: https://chromium-review.googlesource.com/690698Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#505421}
-
Dan Sanders authored
This adds a queue to the write and read sides of MojoDecoderBufferConverter, allowing for multiple concurrent buffers to be processed. Writes are no longer guaranteed to fail as soon as the pipe is closed, since no write is attempted immediately. Since there is no error reporting mechanism on the write side, the only guarantee is that *eventually* writes will fail. Since MojoDecoderBufferConverter is not a primary communication channel, this isn't likely to cause complications. Bug: 751926 Change-Id: I11c985d8aba3acc8fba6453f5bcf22555334b5b0 Reviewed-on: https://chromium-review.googlesource.com/679735 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#505420}
-
Henrik Kjellander authored
bertholdherrmann08@googlemail.com reported this issue for WebRTC and it seems easy to just add r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise' to the predefined paths. BUG=webrtc:8299 Change-Id: I3bec73e2ef48e1a2b7e05a4df38faed2efc5ebfc Reviewed-on: https://chromium-review.googlesource.com/691730Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#505419}
-
Vladimir Levin authored
In the situations when the visible rect is scrolled far enough away, we can start experiencing floating point precision issues in the aa path of the gl renderer. To avoid this, this patch shifts the quads up and adjusts the quad_to_target_transform in the opposite direction. In effect, the quads still appear in the same place, but the absolute numbers involved in the calculation are smaller thus avoiding floating point problems. R=enne@chromium.org Bug: 765297 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib93ddc0fa367116d53b4d471c9523fcce518e0bd Reviewed-on: https://chromium-review.googlesource.com/690848Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505418}
-
sunxd authored
We previously reverted the SolidColorAnalyzer patch because of mask tiling regressions: Some texts are rendered blurry when mask tiling is enabled along with this patch. This patch was reverted because bisect points at this one. But actually, it turns out that the root cause is that ca layers cannot work with solid color mask layer correctly, there is nothing wrong with this patch. So we are relanding it. We also disabled mask tiling in https://chromium-review.googlesource.com/c/chromium/src/+/661072, and are fixing the bug in https://chromium-review.googlesource.com/c/chromium/src/+/685716. This reverts commit 8d1900b0. Reason for revert: The original bug will not reproduce again since mask tiling is disabled. We're also landing the patch that fixes the root cause of the bug. The reverted patch proves to be correct. The solid color analyzer change can be re-land. Original change's description: > Manually revert: cc: Support ClipRRect in SolidColorAnalyzer > > This CL reverts a previous CL here: > https://chromium-review.googlesource.com/c/chromium/src/+/591913 > > The previous CL caused a regression on Mac. GL renderer has > difficulties dealing with RPDQs converted from > SolidColorDrawQuads, this CL will make mask layer produce > solid quads. We need to keep it reverted before we fix the > gl renderer bug. > > NOTRY=true > > Bug: 760807 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I844d02886329acbbbebd98200f8d2f90681adb8a > Reviewed-on: https://chromium-review.googlesource.com/653317 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Reviewed-by: Xianda Sun <sunxd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500036} TBR=flackr@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,wkorman@chromium.org,xidachen@chromium.org,sunxd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 760807 Change-Id: I96969d458f14bc1129d8a9b4b7b22bd562806a92 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/674790Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#505417}
-
Khushal authored
Adding additional parameters to PlaybackImageProvider ctor causes a regression in total raster time on some mac configs. In order to address this, break out these settings to a separate struct which can optionally be given to the provider. The params are modified on the Settings object post construction. R=enne@chromium.org Bug: 768538, 768543 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e7fc0df225826e5a26f0f9d09c106a6b2d1f640 Reviewed-on: https://chromium-review.googlesource.com/691206Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#505416}
-
dougsteed authored
Allows the declaration in an unencrypted part of a stream of an intent to use sample-aes encryption later. This allows the decoding backend to be properly initialized with the appropriate encryption scheme. This involves prefixing a subset of the encryption metadata that is used to indicate encryption, but omits the key id and IV. This will typically be used in a live stream, when tuning in during an unencrypted part, e.g. a commercial. BUG=568326 Review-Url: https://chromiumcodereview.appspot.com/2783703002 Cr-Commit-Position: refs/heads/master@{#505415}
-
Alexandr Ilin authored
This CL changes a default LoadingPredictorConfig limit for a maximum number of tracked hosts. Since the whole database is loaded into the memory at startup, it'd be better to keep the database size reasonably small. New setting is closer to that is used in net::Predictor (see Predictor::kMaxReferrers with a comment). A number of maximum origins per entry also could be reconsidered after experimenting in canary in dev. Bug: 699080 Change-Id: Iae7ea78cda0910aba7ee4a7ad938cc0c1616e32a Reviewed-on: https://chromium-review.googlesource.com/692274 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#505414}
-
Mike West authored
This patch reverts commit 496fe9b7 (https://chromium-review.googlesource.com/c/chromium/src/+/685457) and commit 902a2b75 (https://chromium-review.googlesource.com/c/chromium/src/+/688751). I suspect that the former broke the deterministic builder (https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/7150) and the latter prevented reverting the former. TBR=dcheng@chromium.org,rockot@chromium.org,lhchavez@chromium.org,yzshen@chromium.org Bug: 673417, 770102 Change-Id: Ic463ed5d56f5535fc4697dd4aa9a219338350214 Reviewed-on: https://chromium-review.googlesource.com/691795Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505413}
-
Sigurdur Asgeirsson authored
This is a reland of e9d46063 Original change's description: > Reland "Make SECURITY_DCHECK play with Albatross." > > This is a reland of 06d64c00 > Original change's description: > > Make SECURITY_DCHECK play with Albatross. > > > > In Albatross builds, DCHECKs can be compiled in, but non-fatal. See > > https://docs.google.com/a/chromium.org/document/d/1QY4IbbJ8X6G-6-cMheEkP_mT7ZNPCuUJIW2sr_mEiH4 > > > > Bug: 596231 > > Change-Id: I84198f1d3f4122ac7a5bd8a90ed5ea96286b9022 > > Reviewed-on: https://chromium-review.googlesource.com/685498 > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Commit-Queue: Sigurður ÃÂÂsgeirsson <siggi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#504638} > > Bug: 596231 > Change-Id: I2c1223ba264dbdb06e814b92b84adfe9c3c619b7 > Reviewed-on: https://chromium-review.googlesource.com/687874 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Sigurður ÃÂÂsgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505025} TBR: jochen@chromium.org Bug: 596231 Change-Id: I942bdcfac1b48a666095c8b7b76db6b3ae4f6fe7 Reviewed-on: https://chromium-review.googlesource.com/690814 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#505412}
-
Nate Chapin authored
This is an attempt to fix https://bugs.chromium.org/p/chromium/issues/detail?id=763040, which shows font loads ending with a null ExecutionContext. I don't have a repro to work with, but I suspect this is due to font fallback occurring in the middle of ResourceFetcher shutdown and outliving its ExecutionContext. I previously attempted to fix this in ResourceFetcher in: https://chromium.googlesource.com/chromium/src.git/+/fb8a2de8d8190bacdaf53689c7762c9491f654ee Bug: Change-Id: I1fc2e6d8b1e1f7ed1cac49929ad3b7721489f428 Reviewed-on: https://chromium-review.googlesource.com/682454Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#505411}
-
Randy Smith authored
use it to wrap a weak pointer to enforce "No callback after destruction" guarantees. Bug: 761319 Change-Id: I34a8f10cbf40ac0f19f11e3d98c89e729a599567 Reviewed-on: https://chromium-review.googlesource.com/670002 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#505410}
-
Wenzhao Zang authored
If |focusedPod_| is already set, and it is the same with |podToFocus|, early return is hit in focusPod(), however we should force a focus update in order to ensure the correct wallpaper is set. Bug: 769492 Change-Id: I820a523c863d693663411e436be2baa8b62fa178 Reviewed-on: https://chromium-review.googlesource.com/691046Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#505409}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=treib@chromium.org Bug: 666525 Change-Id: Iff2b7f18d4c593b10846eac3c8ec5a03a0b0ef6d Reviewed-on: https://chromium-review.googlesource.com/689114Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505408}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I95a121d90642a3abbe51407ba14a90313f90322f Reviewed-on: https://chromium-review.googlesource.com/691214Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505407}
-
Iulia Harasim authored
This CL splits the xml file used to implement the promo view in 2 different files: one contains the header of the promo (the image and the dismiss button) and the other contains the description and the signin buttons. This change is necessary in order to provide custom paddings and margins for the header of the promo. Bug: 737743 Change-Id: I76532407444ca62d808dddbd874642fb1aa788e5 Reviewed-on: https://chromium-review.googlesource.com/691659Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#505406}
-
Andrew Grieve authored
Sometimes useful to have the unstripped library. E.g. when attempt to disassemble. Change-Id: Id06beb836525810f3508eed265c6018b06a18a5e Reviewed-on: https://chromium-review.googlesource.com/692815Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505405}
-
Kyle Horimoto authored
Previously, it was possible specify an ARGB value via the PATH_COLOR_ARGB command, which takes an alpha as well as RGB properties as parameters. However, there was no command to specify a change in opacity without also specifying the color to use. This presented a problem for system notification. When displayed on a notification, these icons are drawn in blue or red, depending on the warning level of the notification, and when displayed in the black bar at the bottom of the UI, they are drawn in white. Thus, for notification icons which need to be displayed in a single color with different opacities, a new command was needed. This CL introduces the PATH_COLOR_ALPHA command, which takes a single parameter expressing the opacity of the path. It will be used immediately in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/685304 Bug: 759257, 672263 Change-Id: I00a5dbb28a06de41239cda2fe1c608754f190bf6 Reviewed-on: https://chromium-review.googlesource.com/690706Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#505404}
-
chrome://flagsPhilippe Hamel authored
Bug: 646711 Change-Id: I82c20d2db71c9cec7363c395af4f348be3b6a6de Reviewed-on: https://chromium-review.googlesource.com/688220 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505403}
-
Mike Wasserman authored
Make the menu item handle click events on its icon view. (support clicking on a radio/check icon in a menu item) Bug: 768449 Test: See bug. Change-Id: I1da3ce9baad36b1e35278e3a7c466e96c4e00876 Reviewed-on: https://chromium-review.googlesource.com/691175Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505402}
-
Vladislav Kaznacheev authored
Although metalayer selection is constructed from stylus input points, it can sometimes cross the screen bounds. For example, when a horizontal stroke is recognized, its bounding rectangle is inflated to guarantee minimal height and generally be closer to the visual image of the stroke. This patch introduces necessary clipping to make sure that clients do not have to do that. Bug: b:67021526 Test: ash_unittests HighlighterControllerTest.SelectionInsideScreen Change-Id: I09d67c8b9f1176ea083a40f581b8a46536152296 Reviewed-on: https://chromium-review.googlesource.com/691278 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#505401}
-
Andrew Grieve authored
Without our new(ish) scheme of bytecode-rewriting asserts, the system property isn't used. NOTRY=true # Doesn't affect bots Change-Id: Ie0f9f2e9bb8674bba52380fc7983a13f54ae65f9 Reviewed-on: https://chromium-review.googlesource.com/692816Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505400}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ekaramad@chromium.org Bug: 666525 Change-Id: I8c9c9436301eabd31b5bfe1054956c63d5457dfc Reviewed-on: https://chromium-review.googlesource.com/689107Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505399}
-
Devlin Cronin authored
Remove the std::unique_ptr<> members from ExternalInstallInfoFile and ExternalInstallInfoUpdateUrl. These were used to hold the version and url members, but each of these will never be null and are cheaply copyable (or, in the case of GURL, movable), so have no reason to be pointers. Bug: 770007 Change-Id: I4b9c3ef8c9888a2d460ab082a9fa3339423a5ee6 Reviewed-on: https://chromium-review.googlesource.com/691045 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505398}
-
mark a. foltz authored
This reverts commit 6a8d2a72. Reason for revert: Bug 769979 Original change's description: > [Desktop Capture] Enable system audio capture without screen capture. > > This addresses a long standing issue where users are unable to cast system > audio to audio-only Cast devices by adding support for system audio capture > without screen capture. > > Bug: 662499 > Change-Id: I0c612861e36644298f161de47810c6d37ffbf501 > Reviewed-on: https://chromium-review.googlesource.com/656597 > Commit-Queue: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503491} TBR=mfoltz@chromium.org,jam@chromium.org,sergeyu@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 662499 Change-Id: I0fa48ea0647a7c8d7186805aa097e20c505d1ba9 Reviewed-on: https://chromium-review.googlesource.com/691279 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#505397}
-
Lei Zhang authored
Also group various enable_foo and use_bar blocks alphabetically at the end, after the is_quxos and use_bazui sections. Also remove all -= operator usage and use += in the right sections instead. Add a few new sections so certain files no longer need to be included twice/thrice in separate places. Change-Id: I2f62dcd98ab09d824080c750b3c98d2f457881b9 Reviewed-on: https://chromium-review.googlesource.com/689454 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#505396}
-
Mihai Sardarescu authored
StartupTabProvider may be called when Chrome starts in an incognito profile, which leads to a crash at start-up. This CL addresses this and adds a unit test to make sure it does not regress in the future. Bug: 769241 Change-Id: Idea489bc05e31d7ac693cb935b1481979099bd09 Reviewed-on: https://chromium-review.googlesource.com/689535Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#505395}
-
Sami Kyostila authored
BUG=769809 Change-Id: Ie4f3f0a26c911948b7b8cda1fbe8e8fde2e3d8b0 Reviewed-on: https://chromium-review.googlesource.com/692774Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#505394}
-
Robert Flack authored
BUG=755307 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I494ab70535eb14de98f1eb78d6e74aebef565e52 Reviewed-on: https://chromium-review.googlesource.com/690857 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505393}
-
Eugene Girard authored
Bug: 760012 Change-Id: I41397192fd7fc5ea585b4a4a11310fdef7b68fdc Reviewed-on: https://chromium-review.googlesource.com/690749 Commit-Queue: Eugene Girard <girard@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#505392}
-
Dmytro Golovchenko authored
Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict: The following packages have unmet dependencies: libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed Recommends: libdconf-doc:i386 but it is not installable Conflicts: libdconf-dev but 0.20.0-1 is to be installed This reverts commit 5b267c0c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add libdconf-dev to to install-build-deps.sh > > This is the first step in moving from using gconf to dconf. > > Bug: 768027 > Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e > Reviewed-on: https://chromium-review.googlesource.com/691097 > Commit-Queue: Tim Brown <timbrown@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505183} TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768027 Reviewed-on: https://chromium-review.googlesource.com/692974 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505391}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/776de290..b4df6351 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3b4e8b6a90f76f98c6307372df64cfcf1078a585 Reviewed-on: https://chromium-review.googlesource.com/692338Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#505390}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: Ib68682643dcf49005f05fe8b23a33a078f6bcef9 Reviewed-on: https://chromium-review.googlesource.com/689029Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505389}
-
Justin Novosad authored
When resource type is an AcceleratedStaticBitmapImage, the WaitSyncTokenCHROMIUM call in the release callback is skipped because the context_provider_wrapper_ is null. This change fixes the problem by setting the context_provider_wrapper_ field of the frame resource to the same context that own the image resource. BUG=769161 Change-Id: Ib05a0fa5a6a0d4dab676fcc27820d1171260a25d Reviewed-on: https://chromium-review.googlesource.com/685380Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505388}
-
Andrew Grieve authored
NOTRY=true # Doesn't affect bots Change-Id: Ic3058e571cf4409a0af851e183eebbb22a62fea9 Reviewed-on: https://chromium-review.googlesource.com/692178Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505387}
-
Aaron Leventhal authored
Bug: 770188 Change-Id: Iffe6636f58b8ad55b0c44ce90f9e93596e98e635 Reviewed-on: https://chromium-review.googlesource.com/692414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#505386}
-
Sky Malice authored
Bug: Change-Id: Id0b90f07d3be8355a29063519a95c1f6ca5e710a Reviewed-on: https://chromium-review.googlesource.com/691152Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#505385}
-
spqchan authored
Bug: 741138 Change-Id: I62e5475e3e4ec45797c4491e42d90ef0187491bf Reviewed-on: https://chromium-review.googlesource.com/691057Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505384}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lcwu@chromium.org Bug: 666525 Change-Id: I74bb2e240ca4a54ac280c8b8d770f88a34dd1f4f Reviewed-on: https://chromium-review.googlesource.com/689102Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505383}
-