- 17 Jun, 2019 40 commits
-
-
khmel@chromium.org authored
As described TEST=Locally BUG=b/132709527 Change-Id: I94572a590724969e54d865d54bf1f40fc4c7d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662734Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669855}
-
Patrick Noland authored
This means we won't handle AMP pages that don't use SXG(signed exchanges). Trusting the canonical URL blindly has potential privacy risks. Trusting only Google-provided AMP urls is also the wrong solution; we want to rely on the long term solution that is SXG. Bug: 961814 Change-Id: Ib3544e8c478a3a9089d8c7414f7ea42bb65b8794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659511Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#669854}
-
Matt Simmons authored
Bug: 970585 Change-Id: I6c745300316a9548a28e862aa44871c3cdf066a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656810 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669853}
-
Peter Kasting authored
* Unbans std::aligned_storage * Bans string/number conversions * Bans std::weak_ptr The next patch set will default-allow all of C++11, meaning all remaining TBD features will become allowed. https://groups.google.com/a/chromium.org/d/topic/cxx/iH4v7yfKX2A/discussion Bug: none Change-Id: If90aa78a36580dea3c1e77497eb7ebcbdd725e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659968 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#669852}
-
Christopher Cameron authored
Because PWAs (and anything using RemoteCocoa) need an app shim to be running to get anything on-screen, we added code to re-create an app shim if one cannot be launched. But this re-creation wasn't guarded on being a PWA, and as a consequence platform apps would go and create app shims that nobody expected to exist. So let's not do that. Some tests were inappropriately relying on this behavior. Update WebAppShortcutCreator to be more explicit about where it creates and updates its shortcuts. This was previously landed in crrev.com/669111 and reverted in crrev.com/669194. This time, do not re-enable tests in component build (and add comments explaining why). TBR=dominickn (reviewed previous instance) Bug: 941160 Change-Id: I43df81b36682c46eb1535d502c461a39e6cf0395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662910Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669851}
-
khmel@chromium.org authored
This build input tracing model from generic model. TEST=Locally, unit test BUG=b/132709527 Change-Id: Id7997001bf87548f9de04df85a06e2042d5a9e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640702 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 0f75b5b5. Reason for revert: For debugging crbug.com/974639. Original change's description: > Change CHECKs for debugging crbug.com/816810 to DCHECK > > Bug: 816810 > Change-Id: I7d3a9062f940cf0b16350c9cd2d7cae3d95ef152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553807 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647896} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974639 Change-Id: I29aa03beff64b97a36ea0aa727e478310994eeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662503 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669849}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibfccd10c3b49d2183c301c6b7705bbb65ec80cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662676Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669848}
-
Eugene But authored
The crash happened because decisionHandler was called multiple times from webView:decidePolicyForNavigationAction: This CL adds early return to avoid extra calls and adds EG test for window.open test case. Bug: 965067 Change-Id: I970aff7313e0c5c52f46de63e62ac3c17d6ca6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661502 Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#669847}
-
Katie D authored
Fades icon to a lower opacity in order that content behind the icon is still partially visible. Per UX request. Bug: 947068 Change-Id: I36d61f461af622c24cb1bf442c823730143e2a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662829Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#669846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bc23ca13f1b3..3390eddc9717 git log bc23ca13f1b3..3390eddc9717 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@3390eddc9717 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I10cd64f6a0f017144c6fa1fb5382a0aa3ce42d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662756Reviewed-by:
-
Evan Stade authored
This relands commit 243f71cb. Difference to original: SetQuietMode remains a part of the interface for now. Original change's description: > Mash cleanup: message center part 4. > > This pulls all notifier related code out of AshMessageCenterController > and AshMessageCenterClient into new C++ interfaces > NotifierSettingsController and NotifierSettingsObserver. > > TBR=tsepez@chromium.org,hidehiko@chromium.org > > Bug: 958191 > Change-Id: Ice561f2f1f4e90979847c5f410779a34691926a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653858 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669417} TBR=hidehiko@chromium.org Change-Id: I63dd4a2d46e39609573debd4268436d163b896df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662596Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Daniel Murphy authored
Refactors the IndexedDBClassFactory: * Moves construction of classes in the leveldb/ directory to the indexed_db::LevelDBFactory to keep separation between the two systems, * stops all calls to IndexedDBClassFactory::Get() except for in the IndexedDBContextImpl to construct the IndexedDBFactoryImpl, and * passes a pointer to the IndexedDBClassFactory (or LevelDBFactory) to classes that need it to construct classes. There are no functional changes in this patch, only refactoring. R=jam@chromium.org, pwnall@chromium.org Bug: 965282 Change-Id: Icda64b9c56522a934827826fdb55fc5d25e35dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636551 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#669843}
-
Aleks Totic authored
Bug: 970166 Change-Id: Ib85e5b819e5870c1867e6c753d9a250ea4e4a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660205 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#669842}
-
Michael Lippautz authored
Bug: 971424 Change-Id: I10c9379d0548ebeebe08e8ad08c69a959076a7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660346Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669841}
-
Jeffrey Kardatzke authored
These should be stripped from feedback reports. They can appear via 3 different logging techniques. They can be output after a Serialize call in AccountId, assertion failure in construction of AccountId and also via the ostream operator in AccountId. Callers could also get the GAIA ID by itself and log that out, but I didn't find any occurences of that in the source. Bug: 575821 Test: Unit tests pass Change-Id: Ib5241382c88d811471a26628a427b461d90c8d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658937 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#669840}
-
Morten Stenshorne authored
Fails in legacy, though. Must have got added to the expectations file during landing of the rebaseline for NG. TBR=eae@chromium.org Change-Id: I24756c7ccf52e4f11d1e3770fbff079e3224eaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662455Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#669839}
-
Aleks Totic authored
Bug: 974712 Change-Id: I8cd7c9ab91a0722782d444ccece69d705bfe1074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661485 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#669838}
-
Julian Kung authored
The MakeRedImageTestScript function used by the takeElementScreenshot* tests is difficult to understand and would benefit form being abstracted away since the code following it was identical for every test. In this CL MakerRedImageTestScript is replaced in the tests with a new function takeScreenshotAndVerifyCorrect, which calls MakeRedImageTestScript and passes on its output. R=johnchen@chromium.org Bug: chromedriver:2957 Change-Id: Id66c0165acd52a09c1fc9569a2ddbd94970dbdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662589Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#669837}
-
Boris Sazonov authored
Adds GaiaAuthFetcher::StartLogOutWithBlankContinueURL that specifies a blank page as a continue URL for Logout requests. This continue URL is necessary as sometimes Gaia redirects Logout requests to large pages that exceed 1MB body limit for SimpleURLLoader::DownloadToString. Bug: b/134618807 Change-Id: Ie4d57ac959f8936077f98fce6a288ebf41122fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656488 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#669836}
-
Joel Einbinder authored
The watch pane passes null to ObjectPropertiesSection.createNameElement, expecting a blank name element. But it was being incorrectly returned as an element with "null" as its textContent. Bug: 973807 Change-Id: Ibd3a88c6ad8756ebed86ec7d77659ea8e3bb1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661269Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#669835}
-
Nina Satragno authored
According to the CTAP2 spec, devices may return CTAP2_ERR_PIN_AUTH_INVALID if internal User Verification fails on MakeCredential requests or if the PIN token is not valid on either MakeCredential or GetAssertion requests. This patch handles this code treating it as a permission denied error. Bug: 974876 Change-Id: I7565b17a98bb4cc46da086c5412be8b19b7b269d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661486Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#669834}
-
Raymond Toy authored
When a long running decode task is finished, check to see if the execution context still exists. If not, don't bother to resolve the promises or run any of the callbacks for decodeAudioData. It's difficult to write a non-flaky test for this because decoding may take various amounts of time on the bots. Plus, we don't want to add a huge resource to the tests or take large amounts of time to decode. Bug: 812151 Change-Id: Ida72197b0e3a7a2a2f395cc74125c95762bf021e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661078 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea38f958d072..9283b2559c05 git log ea38f958d072..9283b2559c05 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 chrisforbes@google.com Wire up some required external functions for arm32 Created with: gclient setdep -r src/third_party/swiftshader@9283b2559c05 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135298866 TBR=swiftshader-team+autoroll@google.com Change-Id: I7984d86247e87e7421bb4655ea317b6f924af3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662750Reviewed-by:
-
rbpotter authored
Apply the advanced settings when the enter key is pressed, unless: - Focus is on the search box, where enter normally means "search" - Focus is on a select, where enter selects an item in the dropdown - Focus is on a cr-button (e.g. cancel or apply), where enter activates the button. This matches the behavior to the behavior on the main Print Preview UI, where enter is equivalent to clicking Print unless a control that normally handles the key event is focused. Bug: 974161 Change-Id: I4818996fb960bfc0c6ee3e92d2c132fc7f8dd466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661302 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#669831}
-
Bryan McQuade authored
I tested this manually, both by resizing a Chrome window, and by simulating mobile device rotation in devtools. Change-Id: I69297b2501827070de4255b152d3099cb91ab11e Bug: 958832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653609 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#669830}
-
Victor Costan authored
Chrome currently builds SQLite with SQLITE_TEMP_STORE=3, which disables temporary storage, so unixTempFileDir should never be called. Bug: 244385 Change-Id: Idfa8bf86d997654c619db5d2abf3198afae41983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661499Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#669829}
-
Julian Kung authored
The email input type being considered a text input caused bugs and crashes. In this commit it is removed from textControlTypes and thus no longer considered a text input. Also added support for content editable elements in compliance with the following W3C procedure: "Set the text insertion caret after any child content." Added test to run_py_test to test correct functionality. R=crouleau@chromium.org, johnchen@chromium.org Bug: chromedriver:2704 Change-Id: I95bb9ff2396aa0e6bdfa35dde33f338be83607b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658966 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#669828}
-
Jian Li authored
We can't use the CSS text included in the inline style elements. Instead, we scan document.stylesheets to look for those from style elements and wrap them in link elements. I also converted from collecting serialized elements to calling delegate method to add resource. This addressed the FIXME in the code and should improve the memory usage. Bug: 892492 Change-Id: I7ee36df1f3f72e4d2b725f030c7a12762e5fe447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661158Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#669827}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f40bcf804943..8b2600f715e5 git log f40bcf804943..8b2600f715e5 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/googletest fd20d1eccef6..176eccfb8f42 (1 commits) (#718) Created with: gclient setdep -r src/third_party/shaderc/src@8b2600f715e5 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I3a8a1fc9f2ea56c84c8f28fb1bf30767e324f755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662634Reviewed-by:
-
Kevin Marshall authored
Removes the package signing step, because "pm genkey" is deprecated in the Fuchsia builder toolchain. Change-Id: I8aebaf1658f77850f9d727a9952515b542d31fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662601 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#669825}
-
rbpotter authored
When directly navigating to chrome://print, it is possible to see "0 sheet of paper" as the summary. Rather than introducing a new set of strings to handle this case (since the singular/plural convention for 0 may differ by locale), hide the summary for this case, since it is not providing any useful information; there is no document to be printed from chrome://print. Bug: 92015 Change-Id: I64d9b5bb2762490993dd6e2cb6e3acac473658ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661390 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#669824}
-
Brian Osman authored
SkSL is being split into CPU and GPU sub-components, this is necessary to continue building the entire thing. Change-Id: Id58e4d0a7a68504a76be28f27df605492602f47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661369 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#669823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/731454a08543..b97824d4d1d1 git log 731454a08543..b97824d4d1d1 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 fmalita@chromium.org [skottie] Motion tile effect 2019-06-17 rmistry@google.com Fix ingested perf data from Skottie tracing bots + add renderer key 2019-06-17 bsalomon@google.com Revert "Store GrSwizzle on proxies for texturing and swizzling." 2019-06-17 egdaniel@google.com Store GrSwizzle on proxies for texturing and swizzling. Created with: gclient setdep -r src/third_party/skia@b97824d4d1d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: If3b8272054fa57f081c3bf605b9e70057e81cdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662672Reviewed-by:
-
Francois Doray authored
This CL adds the following histograms: Browser.Tabs.TabSwitchResult.NoSavedFrames_Loaded Browser.Tabs.TotalSwitchDuration.NoSavedFrames_Loaded Browser.Tabs.TotalIncompleteSwitchDuration.NoSavedFrames_Loaded Which combine the samples that were already recorded to the corresponding histograms with suffix: *.NoSavedFrames_Loaded_Frozen or *.NoSavedFrames_Loaded_NotFrozen The goal is to facilitate analysis when an experiment affects the number of frozen tabs, and thus the number of samples in the existing frozen-state-suffixed histograms. Change-Id: I51ff9b73de192aaaab76765f37640b8f5b1ddd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651764Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#669821}
-
Jérôme Lebel authored
Fixing -[MainController dismissModalDialogsWithCompletion:dismissOmnibox:] to get it working. This is a temporary fix. A better implementation can be done once crbug.com/966414 is fixed. Bug: 966061 Change-Id: If6245c71e386cfc42ed73bbe333f5464006de339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626860 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#669820}
-
Brian Sheedy authored
Rolls the version of goldctl that is DEPSed in to pick up some improvements such as correctly identifying a negative vs. an untriaged image and writing triage links to the failure file in addition to stdout. TBR=kbr@chromium.org Bug: 850107 Change-Id: Id77f24eb0146ab85a101060ebe58fad48c35cba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660287Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#669819}
-
Kyle Milka authored
Now that image previews are supported this special handling is no longer needed. Bug: 854028 Change-Id: I51719b6dd7d53e3212034b2a9f69cc36db7518f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661482Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669818}
-
Navid Zolghadr authored
Change-Id: I86149eaf90356f9bc2216a463f51db00533402bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658841Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669817}
-
Weiliang Chen authored
After removing overlay validators, the only difference between GLOutputSurfaceBufferQueueAndroid and its parent class GLOutputSurfaceBufferQueue is calling to send display transform over. Since sending display transform over is a no-op for not Android Surface Control (BufferQueue Android) case, always calling to send the display transform. R=khushalsagar@chromium.org Bug: 963597 Change-Id: Ie4654dc7482e57ff3094518f60672cf1c1849792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634399 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#669816}
-
