- 20 Apr, 2018 23 commits
-
-
Kurt Horimoto authored
This can be useful for localized translations of these labels, which may need to span multiple lines. Bug: 805100 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4a4a8b98cb8b7f56f5b7b19dbe8478bf50f4fbf2 Reviewed-on: https://chromium-review.googlesource.com/1018168 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552229}
-
Dmitry Gozman authored
Original patch exposed an issue in layout test controller, which was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1015221. > Onion-soupify blink leak detector > > - Expose LeakDetector interface in render process, remove unneeded plumbing. > - Switch from IPCs to Mojo in layout test runner. > - Move implementation to controller. > - Migrate inspector usage to browser. > - Merged two methods of LeakDetector into a single one. > - Fixed leaks in existing tests. > > Needs a followup to not register fetchers in leak detector, > but instead have a collection in ResourceFetcher. > > Reviewed-on: https://chromium-review.googlesource.com/999170 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551012} TBR=kolos,yuzus,dcheng,haraken NOPRESUBMIT=true Bug: 833609 Change-Id: I6723ffc4aa6a88e6d6d88cc3850410dcd42aa51c Reviewed-on: https://chromium-review.googlesource.com/1016021 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552228}
-
Joel Hockey authored
Console shows which test is running, and test status PASS/FAIL and time that each test takes, as well as overall status and time for all tests. This information makes it easier to determine which test fails when there are multiple tests running and one of them times out. Currently webui_resource_test.js is used for FilesApp unit tests and in the FileManagerUITest browser test. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie42d5dcdf678371e1a3692f1764f2d18533da3f2 Reviewed-on: https://chromium-review.googlesource.com/1007114Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#552227}
-
Dominick Ng authored
This will be relanded to target M68. BUG=782120,811578 Change-Id: I2f67f27e8aacc76c32efb3e3773e2482033b19fb Reviewed-on: https://chromium-review.googlesource.com/1020560Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#552226}
-
Sunny Sachanandani authored
Video swap chain size is zero when scaled overlays are supported, and contents rect is zero. The earlier fix missed this case. This CL moves the calculation of swap chain size to DCLayerTree so that we can skip swap chain creation and other steps which depend on swap chain size. A follow-up CL will remove the CHECKs and replace them with UMA where it makes sense. Bug: 792806 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3de017da44913c9522a0b98c91324efab8148ee6 Reviewed-on: https://chromium-review.googlesource.com/1018499Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#552225}
-
Joe Downing authored
This change integrates the FullscreenControlPopup with the KeyboardLock feature (via the ExclusiveAccessManager). The KeyboardLockController continues to own which WebContents is granted keyboard lock and the initial display of the exclusive access message, but now the FullscreenControlHost is responsible for showing the UI popup. I decided to go this route as the logic for mouse/touch exists in the FullscreenControlHost (via the events it is fed) and the alternative involved punching a hole through several interfaces to expose the popup to the KeyboardLockController. BUG=680809 Change-Id: I152003587cc872b9e2f52883f0698fa26c5dea12 Reviewed-on: https://chromium-review.googlesource.com/1014633Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#552224}
-
enne authored
This reverts commit b3fdac1b. Reason for revert: no longer needed Causes breakages in https://chromium-review.googlesource.com/c/chromium/src/+/1018402 Will roll Skia patch first and then reland this. Original change's description: > skia: Add workaround header define > > Chromium-side changes for: > https://skia-review.googlesource.com/c/skia/+/120608 > > Bug: 829614 > Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f > Reviewed-on: https://chromium-review.googlesource.com/1008924 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551370} TBR=bsalomon@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829614 Change-Id: I7512e16d2023c51407c2d3bc8b2969dc067d5f91 Reviewed-on: https://chromium-review.googlesource.com/1019730Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552223}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: I06b60671dfc32f88de8a7503b4add18ba54cb0e4 Reviewed-on: https://chromium-review.googlesource.com/1020379Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#552222}
-
Gabriel Charette authored
And use the new argument-less constructor to avoid being redundant. R=altimin@chromium.org TBR=thestig@chromium.org Bug: 781352, 825327 Change-Id: I57a0bd50934f402ec24409fa4b315bafec83bd7f Reviewed-on: https://chromium-review.googlesource.com/1020288 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552221}
-
https://pdfium.googlesource.com/pdfium.git/+log/9914d4dc1e7a..901f34332823 $ git log 9914d4dc1..901f34332 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 hnakashima Caret moves after clicked char if closer to its right rect boundary. 2018-04-19 hnakashima Fix duplicated text in each line in XFA widgets. 2018-04-19 hnakashima Fix caret moving to start of edit on click after the text. 2018-04-19 thestig Add public APIs for undo / redo in forms. 2018-04-19 thestig Change SHADING_STEPS from a #define to a constant. 2018-04-19 hnakashima Fix caret not moving to click target in XFA edit. Created with: roll-dep src/third_party/pdfium BUG=chromium:832293,chromium:832909,chromium:832293,chromium:764260,chromium:832293 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c49fb5b7d6ee39f132bf4c8e2daf7a9740e5c39 Reviewed-on: https://chromium-review.googlesource.com/1019973 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552220}
-
Christopher Grant authored
BUG=833439 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I483b430931a7719d8db91ac1b45b080de9d4480b Reviewed-on: https://chromium-review.googlesource.com/1020151Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#552219}
-
Joel Einbinder authored
This patch merges some variables together which were seperate inf JavaScriptSourceFrame, takes @unrestricted off of the plugins, and renames JavaScriptSourceFrame to DebuggerPlugin where appropriate in tests. Bug: 778043 Change-Id: If1d86f46afff1bf0af328090a15a5a1bc92726d7 Reviewed-on: https://chromium-review.googlesource.com/1015650Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#552218}
-
junweifu authored
Update the mojom interface definition of landmark to match the Spec, and adjust the usage in services/blink/LayoutTests. Export eyes and mouth landmarks that detect with Mac Vision Framework, the points are normalized to the bounding box of the detected face, with the origin at the bounding box of the detected face's lower-left corner. Link Mac 10.13 build bots [1] and Face Detection demo[2] here. [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ [2] https://codepen.io/miguelao/pen/PmJWro BUG=799319 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80 Reviewed-on: https://chromium-review.googlesource.com/982579Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#552217}
-
Jonathan Metzman authored
Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I02eb0293bdf3e0190a1b85938aa0f64e3c559efe Reviewed-on: https://chromium-review.googlesource.com/862103Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552216}
-
Oystein Eftevaag authored
This is a reland of 62436735 Also rolling DEPS to a newer rev of Perfetto which should exclude the fuzzer targets that weren't building. Original change's description: > Reland "Add a Mojo-based transportation layer for Perfetto" > > This is a reland of 4df8a2dd > > Original change's description: > > Add a Mojo-based transportation layer for Perfetto > > > > This adds a base layer that individual logging protocols (like tracing) > > can use to send their data to Perfetto, using Mojo messaging and > > shared memory. > > > > First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 > > > > A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 > > > > The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit > > > > R=primiano@chromium.org,skyostil@chromium.org > > > > Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 > > Reviewed-on: https://chromium-review.googlesource.com/980578 > > Reviewed-by: oysteine <oysteine@google.com> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > Commit-Queue: oysteine <oysteine@google.com> > > Cr-Commit-Position: refs/heads/master@{#551019} > > Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7 > > > Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7 > Reviewed-on: https://chromium-review.googlesource.com/1015189 > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551526} TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@google.com,skyostil@chromium.org Change-Id: I3ef4608a228decbe89280ffa8edad05f877a7b46 Reviewed-on: https://chromium-review.googlesource.com/1019619 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552215}
-
Christopher Cameron authored
No sense in re-converting the same image over and over. This can introduce a problem where one content source (e.g, a canvas) can create new frames that then pollute the cache. The source is identified by a stable id, and each version has a new content id. To avoid this problem, when allocating a new cache entry, ensure that we don't have cache entries with more than 2 different content ids for a given stable id. This is similar to what was done in the GpuImageDecodeCache in crrev.com/551078. Add the stable id to the software CacheKey, to enable the bookkeeping necessary for the above fix. Consolidate the code to delete a cache entry. Delete all references to NotifyImageUnused because it's unused and complicates adding the new deletion path. Bug: 791828 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5632afa03c6f5ba9885d6474d4666780d39ad340 Reviewed-on: https://chromium-review.googlesource.com/1016063Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#552214}
-
Daniel Erat authored
Make tapping the power button dismiss the power menu while in laptop mode. Previously, tapping the power button was a no-op in this case. The menu remains visible if the power button is held long enough to start the cancellable shutdown animation. Bug: 834447 Change-Id: I8761d846b334ce3712bc1062b609988b12c5b547 Reviewed-on: https://chromium-review.googlesource.com/1020376Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#552213}
-
Michael Thiessen authored
Huge thanks to bajones for building the prototype I built this CL off of, and for debugging for me ;) Uses a separate viewport with transform to avoid resampling the content quad when drawing it into our scene. The viewport is placed underneath the viewport for the other browser UI, and a transparent hole is punched through to the underlying viewport. Also avoids toggling multisampling at runtime (which recreates the swap chain) by re-using the two buffers (one multisampled and one not) across browsing and webVR modes. Bug: 714304 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ibcbb2752aaa957c3f904d4b76bf6dd5fdf9164c8 Reviewed-on: https://chromium-review.googlesource.com/1017589 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552212}
-
https://webrtc.googlesource.com/src.git/+log/06d094f3e621..e63d38ba342a $ git log 06d094f3e..e63d38ba3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icde8eeb55545a790968a48180aeda8a112a76d5a Reviewed-on: https://chromium-review.googlesource.com/1020403 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552211}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c7c22c11..ff6b34b4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ieba7f84e08645a0d518a58ef3c2d16572f4b9995 Reviewed-on: https://chromium-review.googlesource.com/1020302Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552210}
-
Devlin Cronin authored
When extensions are disabled with --disable-extensions, ExtensionPrefs would completely skip initializing the Extension-controlled preferences (which encompasses the content settings overrides, preferences API, and chrome settings overrides). This would result in no entry being added to the ExtensionPrefValueMap for extensions if --disable-extensions was used. This is generally desirable, since otherwise the settings may still take effect, even though the extensions were not enabled. However, some extensions are still loaded with --disable-extensions. Obviously, this includes component extensions, but this also (surprisingly) includes external extensions, such as those added by the windows registry. The result of this is that if an external extension used an API that relied on the ExtensionPrefValueMap, such as the chrome settings overrides, while --disable-extensions was used, there would be no entry in the value map. Chrome would then crash. Fix this by having ExtensionPrefs check if the extension will still be loaded, even if extensions are disabled. If it will, always load the corresponding extension-controlled preferences. Add two tests to cover this case: one general unit test to ensure the extension-controlled prefs are initialized for external extensions (which will always be loaded), and one end-to-end test with adding an external extension using the chrome settings overrides API. Bug: 828295 Change-Id: I0b01f6ed2fd41874f8fa47378f111c0692cb1ea5 Reviewed-on: https://chromium-review.googlesource.com/1013305Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552209}
-
Rob Wu authored
BUG=834055 Change-Id: I060d4e879f42416916bac8f2a5b5b3f487c0df1b Reviewed-on: https://chromium-review.googlesource.com/1019447Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Rob Wu <rob@robwu.nl> Cr-Commit-Position: refs/heads/master@{#552208}
-
Malay Keshav authored
This patch moves the flag base for enable display zoom slider from a switch to a feature and enables it by default. Bug: 790723,835030 Change-Id: I1b5ed5adac4febd1a0ca7a1aff36d5ac4e691b54 Component: display switches, chromeos switches, settings ui Reviewed-on: https://chromium-review.googlesource.com/1018145Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#552207}
-
- 19 Apr, 2018 17 commits
-
-
Jinsuk Kim authored
This is a preparatory CL for upcoming changes that will remove API getWebContents/getContainerView from ContentViewCore. Tab defines direct references to WebContents and container view. WebContents is passed to |initialize| and ContentView is created as the container view in |createContentViewCore|, so it doesn't need to access them indirectly through CVC. They are set in |setContentViewCore| and nulled out in |destroyContentViewCore| to keep their validity in sync. Accompanying changes for cleanup: - Deleted |getActiveContentViewCore|. Other method of similar name |getContentViewCore| returns null if Tab is showing native view or rendered content is already destroyed. So using it instead is enough for all the callsites that already have null checks or tests that know all the preconditions. - |getContentView| always returns container view for non-native page. In fact it is what it was already doing - just made it clearer by removing some dead code in it. Its return type is ViewGroup, and will be used as a replacement for CVC.getContainerView() in other classes. Bug: 598880 Change-Id: I0c5966b69f6871ce53aa5ffadb73a76214ad35b2 Reviewed-on: https://chromium-review.googlesource.com/1018561Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#552206}
-
Sergey Ulanov authored
Comments in callback.h were confusing because sample code was incorrect. Updated sample code to make it consistent with the documented behavior. Change-Id: Id42a9465c49b65937d7b34bf8c0b3664085a628f Reviewed-on: https://chromium-review.googlesource.com/1019870Reviewed-by:
-
Saman Sami authored
This method adds the right component id to snapshot-related latency info, We can just send the right component id to the renderer so that a correction browser-side is not necessary. Test: Lots of pixel tests take screenshots. Also tested Page.captureScreenshot manually. Bug: 810037, 775030 Change-Id: I61242ad63c5af8975331cb405fc629ce19ef92f8 Reviewed-on: https://chromium-review.googlesource.com/1019389 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552204}
-
Lily Houghton authored
This CL implements an HttpServer class for the network service, modeled after net::HttpServer, but using mojo tcp sockets. The goal is to convert existing embedders of net::HttpServer to using this wrapper class and eventually remove net::HttpServer. Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b567a932da0b4572d65f99e81c98ce1c79a1bb5 Reviewed-on: https://chromium-review.googlesource.com/973698 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552203}
-
Kent Tamura authored
Bug: 829697 Change-Id: Iccf1ebcccad3f7670b65d7e52c7d1481d328b289 Reviewed-on: https://chromium-review.googlesource.com/1018783Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552202}
-
Devlin Cronin authored
ExtensionFunction::GetAssociatedWebContents() returns a WebContents for ExtensionFunctions to use. However, *which* WebContents is returned is unclear and unpredictable. In *most* cases, it will return the sender WebContents; i.e., the WebContents associated with the RenderFrameHost from which the API call originated. This is what most callers expect. However, if this fails, it can also return other WebContents, including the WebContents for the currently-active tab. This is very unclear from the name and usages, and almost never what the APIs should be using. APIs which do require a WebContents other than the sender should explicitly retrieve that API (e.g., through TabStripModel::GetActiveWebContents(), etc). Explicitly mark the method as deprecated to discourage further use. Followup CLs will work on removing the remaining usages of this API. Bug: 461394 Change-Id: Ic636975e6ffe210cebcd15cdef99032ff16a1110 Reviewed-on: https://chromium-review.googlesource.com/1020194Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552201}
-
Kurt Horimoto authored
Bug: 805089 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2a51c2f60c7dd42d4fa3275947c6876333e2dce Reviewed-on: https://chromium-review.googlesource.com/1018111 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Mark Pilgrim authored
BUG=773295 Change-Id: I8916ad1ff43dd420c07efa8de4f9a886468c0d39 Reviewed-on: https://chromium-review.googlesource.com/1010515Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#552199}
-
sczs authored
- Removes TableContainerVC, Creates TableViewNavigationController. - Renames TableContainerConstants to TableViewNavigationControllerConstants. - Creates HistoryLocalCommands Protocol. - Deletes HistoryTableContainer VC. - Deletes HistoryUpdaterDelegate and HistoryTableVCDelegate. - Updates Eg tests with new constant name, Bug: 805192 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I43e27dbc58d2ad788ab6f7f16c44685dcd6a6f05 Reviewed-on: https://chromium-review.googlesource.com/1020404 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552198}
-
Demetrios Papadopoulos authored
Removing the --paper-button CSS mixin at r551209 changed the specificty of CSS rules being applied. Fixed by using the keyboard-focus class directly, instead of relying on yet another mixin --paper-button-flat-keyboard-focus. Bug: 834739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iabd8f698a2b1ed65bb98af6a86fe2f957280ae61 Reviewed-on: https://chromium-review.googlesource.com/1019880Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552197}
-
Shimi Zhang authored
We want to hide the active text handle when the HandleObserver is activated. We only want to make the handle invisible but still keep it functioning. So in this CL we are setting its alpha to control the visibility. Bug: 798017, 814868 Change-Id: I1d3018ab6a40307eae67c5f0146e84c0c297bcf3 Reviewed-on: https://chromium-review.googlesource.com/1011552Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#552196}
-
Chris Blume authored
When a child LSI allocation is being processed by the parent, the parent should not send extra IPCs which it will later overwrite. This suppression currently happens on Aura platforms but not Mac. This patch adds it to Mac. BUG=805073 Change-Id: I3bda7dbdb97afb982e031ac354f06ce1c385e07d Reviewed-on: https://chromium-review.googlesource.com/1011556 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#552195}
-
spqchan authored
Don't show the "Look Up" menu item in the textfield context menu if the textfield is a password field. Testing: views_unittests TextfieldTest.LookUpPassword. Bug: 832103 Change-Id: I1fd526b0e51b19ae6f118da1d628958f26da380b Reviewed-on: https://chromium-review.googlesource.com/1013782Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552194}
-
Theresa authored
Add missing parenthesis BUG=834718 Change-Id: I5df5cd2866663e16ab58b04575b5e5fd5c8b25fe Reviewed-on: https://chromium-review.googlesource.com/1020148Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552193}
-
Alexandr Ilin authored
This CL adds the support for passing PlatfromSharedMemoryRegions between processes via IPC messages. Bug: 795291 Change-Id: I13b22226866b0a4e5d97e66f4ce93e5ad28fdaac Reviewed-on: https://chromium-review.googlesource.com/937514 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#552192}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/161623779eaf..5c62ed59d2a3 $ git log 161623779..5c62ed59d --date=short --no-merges --format='%ad %ae %s' 2018-04-19 ehmaldonado owners: Add support for comments at the end of the line. 2018-04-19 tandrii [git-cl] make more informative error message. Created with: roll-dep src/third_party/depot_tools BUG=chromium:789773 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9c55e9864502a0ec1895124e9ed8c4421d73e3f3 Reviewed-on: https://chromium-review.googlesource.com/1020234 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552191}
-
Miguel Casas authored
This reverts commit 5eec3679. Reason for revert: Caused regression in video_VideoSeek: https://crbug.com/834146 Bug: 834146 Original change's description: > RELAND: Vaapi: Remove ConditionVariables and use PostTask > > This CL relands the attached CL that got reverted due to scaling > issues, i.e. when the decode bitstream changed resolution, there > was the chance that before marking |awaiting_va_surfaces_recycle_|, > we could get an "old" resolution frame, that would confuse |decoder_|. > > The solution is to move |awaiting_va_surfaces_recycle_| marking to > DecodeTask(), and hold off any more Decode() operations until the > "old" resolution frames are processed. This in turn makes > InitiateSurfaceSetChange() superfluous, so it's moved into DecodeTask(). > The rest is comment update :-) > ** Changes can be found here: crrev.com/c/973684/3..9 > > TEST=http://crosvideo.appspot.com/?codec=vp9&cycle=true&loop=true&mute=true > and letting it roll through many many many resolution changes. > > Original CL description ------------------------------------------------ > > This CL removes the use of the ConditionVariables inside VaVDA and > uses instead PostTask()ing. This removes blocking the worker > thread, which allows for moving other tasks there, e.g. the > Surface Blit (as done in the follow up WIP CL crrev.com/c/947341) > > For all that goodness, this CL: > > - Refactors the waiting logic that on ToT is spread between > GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and > simplifies it in DecodeTask() itself. > > - Moves the |curr_input_buffer_| filling logic in > GetCurrInputBuffer_Locked() into DecodeTask() proper. > > - Reduces the scoped of the |lock_| in DecodeTask() (note that > |curr_input_buffer_| and |decode_| are only used on the decoder > thread -- added a .h comment). > > Minor stuff: This CL also moves together the declaration of the > related member vars |input_buffers_|, |curr_input_buffer_| and > |available_va_surfaces_| > > TEST=simplechrome+crosvideo (including seeks) on soraka, and > v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true). > > Bug: 717265 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel > Change-Id: I86d179ac4d48c63b36787f5c7bdcb0da3839ed69 > Reviewed-on: https://chromium-review.googlesource.com/949283 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#542955} > Reviewed-on: https://chromium-review.googlesource.com/973684 > Cr-Commit-Position: refs/heads/master@{#546827} TBR=posciak@chromium.org,mcasas@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717265 Change-Id: Ic31471daf757fd08ff2f420afc5be7e973a88c01 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1020040 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
