- 12 Feb, 2018 40 commits
-
-
Vladislav Kuzkokov authored
Bug: 625126 Change-Id: I8929c0fa1825b6175dd9a92284aabc4ff4983461 Reviewed-on: https://chromium-review.googlesource.com/907548Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#536077}
-
Stephen Chenney authored
Background geometry calculations snap the background painting differently to the way borders snap. This patch forces the background to match the border whenever possible. In addition to the new test, our existing zoomed SVG-as-image tests also improve (they previously did not fill to their border). Some sprite background tests regress a little. They will be fixed by other forthcoming changes to background painting. Also factor the positioning area computation out of the primary Calculate method. TBR=fmalita@chromium.org BUG=716174 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/909450 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#535823} Change-Id: I0165da6a4448e1452626fc0045011a8216ed33b4 Reviewed-on: https://chromium-review.googlesource.com/913588Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#536076}
-
Tim Dresser authored
Not sure why it isn't failing consistently on the bots, but it fails consistently for me locally, and failed on the bots when I tried to submit an independent change. Change-Id: I70d9b1c855fbda908e1bebdf9aaacfb33e4490fe Reviewed-on: https://chromium-review.googlesource.com/913548Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#536075}
-
Koji Ishii authored
Following bot results are included. 3700 3704 3705 16 lines were removed and 21 lines were deflaked by consecutive results since 3670. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I38c522c6a3a4007e8b768a0742b9d0d04fe28181 Reviewed-on: https://chromium-review.googlesource.com/913071 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536074}
-
Jinsong Fan authored
The RESULT_CODE_MISSING_DATA in aw_result_codes.h is unused. The CL removes it. Change-Id: Icc37c7f73711a30ca06b799e7c3c747b92d9d0ea Reviewed-on: https://chromium-review.googlesource.com/913171Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#536073}
-
Sylvain Defresne authored
Avoid silently running the test if ClearBrowsingHistory() is unable to clear the browsing history. Instead propagate the error to the caller and convert failure to EarlGrey errors. Bug: none Change-Id: I7c12aef7fcad23e0f76d2e03279f256fd905e702 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/899247 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#536072}
-
Anita Woodruff authored
- Switched non-persistent notifications over to the mojo path and removed the legacy IPC message handlers and surrounding code. R=peter@chromium.org Bug: 796990 Change-Id: I49baccc562ffacb5f76f4cc3067d60824b269daf Reviewed-on: https://chromium-review.googlesource.com/908448Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#536071}
-
https://chromium.googlesource.com/catapult.git/+log/c60b98d9fa86..d38379370433 $ git log c60b98d9f..d38379370 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 kraynov Change fitting algorithm in AsyncSliceGroupTrack. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic0322f23a055b40ab95571f0985227b8070338a5 Reviewed-on: https://chromium-review.googlesource.com/912522 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536070}
-
Max Morin authored
Workaround shouldn't be needed anymore after crrev.com/530835. Reenabling realtime priority should reduce audio glitches. This really shouldn't cause any regressions, but adding the old bugs as FYI just in case. Bug: 754213,734490,710245,770312,803419 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2f7c6c793fade47a205a896a25468a7312ba55de Reviewed-on: https://chromium-review.googlesource.com/913272Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536069}
-
Sriram authored
This gives me an opportunity to involve more effectively in reviews and especially help samsung internal contributions. Change-Id: Ic999084075c5c2cf9addda81158312400ef02ec9 Reviewed-on: https://chromium-review.googlesource.com/912055Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#536068}
-
Elad Alon authored
Use remote_observer_ instead of creating own local observer in three tests. Bug: 775415 Change-Id: Ief3b3b28ac3af97b02faa94bf2d75db3ae806431 Reviewed-on: https://chromium-review.googlesource.com/909488Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#536067}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef424e13. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12497 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I8e78f7e826dcf8241c8f5ea466ffb71c77fef0ad Reviewed-on: https://chromium-review.googlesource.com/913009 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#536066}
-
Friedrich Horschig authored
The "ifRoom" property doesn't work properly with action views as the main item will not collapse in that case and just move the option to the settings menu. Using "always" (like Site Settings does it) fixes that issue. Removing the previously used "collapseActionView" prevents filling the entire action bar which fixes layouting on large screens. All other changes ensure no regressions although we now have to rely on different Listener methods and UI interaction flows. Bug: 809014, 807303 Change-Id: I63a07b8b91077e33c50e4859889474d072cb7c94 Reviewed-on: https://chromium-review.googlesource.com/909217 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#536065}
-
arthursonzogni authored
For URLs blocked by the administrator, stop trying to reloading it automatically after the error page has been displayed. Bug: 803839 Change-Id: Ifef147df57e15c58efc58d871aa057e4e09f54c3 Reviewed-on: https://chromium-review.googlesource.com/911250 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#536064}
-
Philipp Hancke authored
The current test relies on addTrack(track) which is not the API tested. Using addTrack(track, stream) works in Firefox as well as Chrome. BUG=790007 Change-Id: I098101cd6556620c42b4f51df98ef54b0a8ad1f7 Reviewed-on: https://chromium-review.googlesource.com/912289 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#536063}
-
https://webrtc.googlesource.com/src.git/+log/4b9124e43294..cb768a88319b $ git log 4b9124e43..cb768a883 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8dcc63aefee66a8ef876e419769831910e26915f Reviewed-on: https://chromium-review.googlesource.com/912734 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536062}
-
https://skia.googlesource.com/skia.git/+log/56a4a099e707..da2b4f279633 $ git log 56a4a099e..da2b4f279 --date=short --no-merges --format='%ad %ae %s' 2018-02-12 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8f27b0509..e5fe7aad8 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I995c6f2db755e768110b779ca2aa0b54f0ccec68 Reviewed-on: https://chromium-review.googlesource.com/911852 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536061}
-
Marc Treib authored
This reverts commit fc476d9c. Reason for revert: Introduced memleaks in KeyboardShortcutViewTest: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26098 Original change's description: > cros: Introduce KSV search box. KSV - part 4. > > Introduce the search box to Keyboard Shortcut Viewer (KSV). > > Changes: > 1. Add search box view. > 2. Handle searching shortcut. > > Bug: 768932 > Test: Manually test the search behavior. > Change-Id: I78648f2c17ee4359f0889a8aa67ccca0b6980161 > Reviewed-on: https://chromium-review.googlesource.com/902002 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535854} TBR=xiyuan@chromium.org,afakhry@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768932 Change-Id: I4c02b1665f8ffc84fb0c3fef029ae7257c75bfb0 Reviewed-on: https://chromium-review.googlesource.com/913133Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#536060}
-
Bernhard Bauer authored
Who sanitizes the sanitizers? Or something. Bug: b/73082949 Change-Id: Ibb418338e4f762ea2a385647656114dc619cf230 Reviewed-on: https://chromium-review.googlesource.com/913211Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#536059}
-
Bernhard Bauer authored
This reverts commit 4cb14ba3. Reason for revert: Breaks OfflinePageUtilsTest.CheckDuplicateDownloads in unit_tests and GetAllPagesV1HandlerTest.testMultiplePages in chrome_test_apk downstream (crbug.com/807420). Original change's description: > Publish the Offline Page to a public directory > > This change will move the offline page to a public directory and inform > the system download manager if any (for instance, on Android) of the > location and type of the file. If both steps succeed, the > offline page item will be written to the offline page model database. > > Bug: 758690 > Change-Id: Iabba419903849892a947d80bd82c39123e1bc962 > Reviewed-on: https://chromium-review.googlesource.com/896555 > Commit-Queue: Peter Williamson <petewil@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535893} TBR=petewil@chromium.org,jianli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758690, 807420 Change-Id: Ia1df88f658a2843ccd340b7593e25a8791693bb7 Reviewed-on: https://chromium-review.googlesource.com/912832Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/8f27b0509264..e5fe7aad8454 $ git log 8f27b0509..e5fe7aad8 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 oetuaho Store builtin symbols as const pointers Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I34cd425af296720b45b1c0704961d6e06f62e21d Reviewed-on: https://chromium-review.googlesource.com/912327 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536057}
-
Kush Sinha authored
Add caveat for SecondaryGoogleAccountSigninAllowed policy that users may be able to use Google services in an unauthenticated state on Chromebooks, if they block their cookies. Bug: 805519 Change-Id: Ib09f659a53ca43f5fdcfe5cb8ff49e1050ff7981 Reviewed-on: https://chromium-review.googlesource.com/908558 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit 233a134f. Reason for revert: New test fails on Linux CFI with "runtime error: control flow integrity check for type 'cc::(anonymous namespace)::DidDrawCheckLayer' failed during base-to-derived cast (vtable address 0x000000552cc0) 0x000000552cc0: note: vtable is of type 'cc::SolidColorLayerImpl'" First failing build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5805 Original change's description: > cc: Should Not Have Damage When No Contributing Layers > > Root should only has damage when there is visible damage and has > nothing to do with whether there is contributing layers. > > Damage with 0 quad is valid case when only drawn layer just got > removed. > > R=danakj@chromium.org > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I276e0edebfcb4d3c813c9f65541c554ecf7ba7e5 > Reviewed-on: https://chromium-review.googlesource.com/899947 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535873} TBR=danakj@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I27112020c3c421fc9a5d58e7592223d0036ed3b6 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/913209Reviewed-by:
-
Sergey Poromov authored
Add |notify| flag in RemoveRegularOrSupervisedUserFromList() so that it won't call OnUserRemoved() in some cases. Otherwise, when user is logged in, this function is called for the user and it's temporary removed from "reporting users" list. BUG=810815 TEST=Trybots. Change-Id: Ie28c4b700c4762da3c72bb88e6b4e827576fffa7 Reviewed-on: https://chromium-review.googlesource.com/911796Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#536054}
-
Marc Treib authored
This reverts commit e0520203. Reason for revert: The previous CL in the series (part 4) introduced memleaks in KeyboardShortcutViewTest: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26098 Have to revert this to be able to revert the previous one. Original change's description: > cros: Introduce bubble view to KSV. KSV - part 5. > > This cl introduces the bubble view to highlight keys in the shortcut of > Keyboard Shortcut Viewer (KSV). > > Bug: 768932 > Test: Manually test the bubble views. > Change-Id: I3b223465f41ee721920f263c25d157cc4114eeb0 > Reviewed-on: https://chromium-review.googlesource.com/902691 > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Qiang Xu <warx@google.com> > Commit-Queue: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535888} TBR=enne@chromium.org,afakhry@chromium.org,wutao@chromium.org,warx@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768932 Change-Id: Ifa63c8916f5af6794be85d002b5d8ee3223b0d54 Reviewed-on: https://chromium-review.googlesource.com/911631Reviewed-by:
-
Henrik Boström authored
Implementation: - addStream() is defined in terms of addTrack() and adding a listener of tracks being added/removed from the stream. The listener uses addTrack()/removeTrack(). - removeStream() is defined in terms of removeTrack() and removing the listener of tracks being added/removed from the stream. This fixes: https://crbug.com/738929 Related bug fixes: - By getting rid of local_streams_, this also fixes the issue where createDTMFSender() could only be called for tracks added with the legacy APIs. https://crbug.com/806875 - By adding code checking if a stream was the first/last stream added/removed, the chrome://webrtc-internals events related to adding or removing a stream are triggered by addTrack/removeTrack, fixing the bug where addTrack-streams did not appear in chrome://webrtc-internals. https://crbug.com/801093 Old code no longer exercised is removed. MockPeerConnectionImpl is updated to work with track-based APIs. We should get rid of this class in future CLs, it's a maintenance burden. Design doc: https://docs.google.com/document/d/1Obbeg-B4_04twVctHdf7C7vkUQrGlLvOaV0C8J5_-Gs/edit?usp=sharing Bug: 738929, 803021, 806875, 801093 Change-Id: I77541a3dce180e1cf8b311cb7803047215b0af7b Reviewed-on: https://chromium-review.googlesource.com/899346 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#536052}
-
Bhagirathi Satpathy authored
Modified StyleSheet |media|and CSSPageRule |style| IDL attribute to match the specification. https://drafts.csswg.org/cssom/#the-stylesheet-interface https://drafts.csswg.org/cssom/#the-csspagerule-interface Bug: 811173 Change-Id: Ifa2630e72fb66898fcb82a444162c8f2f41c7ac2 Reviewed-on: https://chromium-review.googlesource.com/903803 Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#536051}
-
Meredith Lane authored
Instead of streaming live updates, a ComputedAccessibleNode must be manually refreshed. This change adds the IDL code and implementation of this behaviour by requesting a fresh tree snapshot when a node needs to be refreshed. As all ComputedAccessibleNodes refer to the same tree snapshot, when ensureUpToDate is called on one node, all others are also refreshed, ensuring that all references to ComputedAccessibleNodes are consistent with the same snapshot. BUG=792783 Change-Id: I0ff900c947a8e005a64c9d1e9ef24f6908206e6c Reviewed-on: https://chromium-review.googlesource.com/905702Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@google.com> Cr-Commit-Position: refs/heads/master@{#536050}
-
Alan Cutter authored
This CL fixes nits from https://chromium-review.googlesource.com/c/chromium/src/+/910329 that didn't make it into the landed CL. Change-Id: I82d7312a40a6c182985ec10cdd166307b08ecf32 Reviewed-on: https://chromium-review.googlesource.com/913190Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536049}
-
Takuto Ikuta authored
This reverts commit 536b1e56. Reason for revert: This looks to drop necessary info for android crash report. crbug.com/809573 Original change's description: > Use -g0 in minimal_symbols config in non-sanitizer build > > I confirm that how -g0 affects stacktrace shown in test failure/crash. > With -g1: https://chromium-review.googlesource.com/c/chromium/src/+/892540/1 > With -g0: https://chromium-review.googlesource.com/c/chromium/src/+/892187/3 > > I summarize how stacktrace is shown on each builder affected by this CL. > This CL does not change stacktrace. > > |--------------------------+---------------+------------------+---------------+------------------| > | builder | -g0 crash | -g0 CHECK(false) | -g1 crash | -g1 CHECK(false) | > |--------------------------+---------------+------------------+---------------+------------------| > | android_n5x_swarming_rel | no stacktrace | correct | no stacktrace | correct | > | cast_shell_linux | correct | correct | correct | correct | > | ios-simulator | no stacktrace | no stacktrace | no stacktrace | no stacktrace | > | linux-chromeos-rel | correct | correct | correct | correct | > | linux_android_rel_ng | no stacktrace | correct | no stacktrace | correct | > | mac_chromium_rel_ng | correct | correct | correct | correct | > |--------------------------+---------------+------------------+---------------+------------------| > > > I see improved link time of some large binary on (very slow) andrdoin_n5x_swarming_rel builder. > > With this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave603-c4/ninja_log.slave603-c4.chrome-bot.20180130-001251.4049.gz/table?dedup=true > taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350571 > > Without this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave604-c4/ninja_log.slave604-c4.chrome-bot.20180130-005043.1186.gz/table?dedup=true > taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350593 > > |-----------------------------------------+---------+-----------| > | link time of each target | -g0 | -g1 | > |-----------------------------------------+---------+-----------| > | android_clang_arm/libmonochrome.so | 14.206s | 27.25s | > | android_clang_arm/libwebviewchromium.so | 12.355s | 1m44.577s | > | lib_components_unittests__library.so | 22.194s | 1m17.442s | > | libwebviewchromium.so | 30.729s | 1m45.147s | > | libmonochrome.so: | 31.862s | 1m33.027s | > | lib_unit_tests__library.so | 53.444s | 44.943s | > |-----------------------------------------+---------+-----------| > > This patch improved link time in most cases. > > Bug: 794423 > Change-Id: I757a8a01bed0dea4c62e2f8ebfccc5a163d8cc18 > Reviewed-on: https://chromium-review.googlesource.com/892187 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@google.com> > Cr-Commit-Position: refs/heads/master@{#533158} TBR=thakis@chromium.org,dpranke@chromium.org,tikuta@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 794423, 809573 Change-Id: Ica7c67699ebb388f2d0148173d3e254d45ac058e Reviewed-on: https://chromium-review.googlesource.com/912848Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#536048}
-
Marc Treib authored
This reverts commit e012089d. Reason for revert: use-of-uninitialized-value failures on MSan bots in the new tests, see FindIt comment or here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/5691 Original change's description: > Remove event coalescing from RenderWidgetTargeter. > > The code removed in this CL is believed to be the root cause of the > crash in the associated bug. > > The mechanism is this: when events are coalesced, some event types still > expect all of the original events to be properly acked, and at present > RenderWidgetTargeter doesn't implement this. The crash, in particular, > is the result of touch events being acked in a way that the unique ids > don't line up with the queue in > TouchDispositionGestureFilter::OnTouchEventAck() > because some of the ids are missing after being coalesced. > > At present we will only disable coalescing for touch and gesture > events,but that's reasonable since in most cases we only everhit-test > the initial TouchStart and everything else in the sequence latches to > its target. > > Further, it's not obvious if there's a significant performance > benefit to the coalescing these events, so for now we remove it. > In any case, implementing proper acking of these events would result > in a patch too big to merge back to M65. > > Bug: 807507 > Change-Id: I50dbef4f16f4b451321564e1e0c9cfb352aafabd > Reviewed-on: https://chromium-review.googlesource.com/905459 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535895} TBR=sadrul@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807507 Change-Id: Id5559d992b6e088996e42057f46854031bf2ad48 Reviewed-on: https://chromium-review.googlesource.com/913229Reviewed-by:
-
Patrik Höglund authored
This test has been broken for a couple months, we have no idea how to fix it, and its value is questionable compared to its complexity anyway. It finds ~1 bug per year, tops, and even when it does it's hard to troubleshoot. Also, the code to interact with Firefox has aged badly and is hard to extend. Bug: chromium:751211 Change-Id: I0b4f84d80a3f8c05fd40fe3d58b82ccabbb4e9d2 Reviewed-on: https://chromium-review.googlesource.com/913248Reviewed-by:
-
Filip Gorski authored
A promissed follow-up test refactoring, which removes friending of test classes. It also found a bug, already fixed in original patch. Bug: 805171 Change-Id: I1d7c3a8043df705f3e21cd7dabdab401b424f08f Reviewed-on: https://chromium-review.googlesource.com/903586 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#536045}
-
Morten Stenshorne authored
The presence of floats complicate min/max intrinsic inline size calculation. They affect lines and child blocks in the same block formatting context. Therefore, when calculating min/max sizes of a child, we need to pass along information about floats adjacent to the current "virtual" block position. This change actually makes NG slightly "better" than legacy Blink layout, Edge and Firefox. This may be an issue for compatibility. It should be fairly easy to "dumb down" the machinery to be compatible with the others, though, if this should become an issue. Two tests regressed because of this. Reported bug 810370. This change also caused grid-item-margins-not-collapse-expected.html to make room for the floats to fit beside each other, so I modified it. Also removed bogus "margin" attributes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I59730d7333fa7699a42ab93d2c4674c267d834aa Reviewed-on: https://chromium-review.googlesource.com/908753 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13101a6e42d1..705e51807fec $ git log 13101a6e4..705e51807 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 mgiuca git_test_utils: Fixed custom git metadata in git commit schemas. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I87814d775ac3f683374737b8f52ae586ef7accb4 Reviewed-on: https://chromium-review.googlesource.com/911983Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536043}
-
https://skia.googlesource.com/skia.git/+log/a76f6161f1c2..56a4a099e707 $ git log a76f6161f..56a4a099e --date=short --no-merges --format='%ad %ae %s' 2018-02-12 liyuqian Add init-once to threaded backend Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I30debaabfdbe13743cfb47195188671c3f719b60 Reviewed-on: https://chromium-review.googlesource.com/912521 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Marc Treib authored
This reverts commit 58525850. Reason for revert: Broke fast/webgl/texImage-imageBitmap-from-image-resize.html on Mac 10.11: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/23254 Original change's description: > opt Chromium back into HQ scaling clamps > > Change-Id: I2693be780057c1ba715fce3ae3c398c536f147ea > Reviewed-on: https://chromium-review.googlesource.com/911734 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536009} TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org Change-Id: I01d68484de5892eeab4c1ec42e389ab8c0fdbde7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/912471Reviewed-by:
-
Patrik Höglund authored
The idea is to add a bot and an empty target such that we invoke gcc empty_main.cc with Chromium's build flags. The intention is to catch clang-only flags that break the gcc build. Bug: chromium:776284 Change-Id: I9e7dc21b15e0903c813de31d4b0731515e6e4426 Reviewed-on: https://chromium-review.googlesource.com/876010 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
-
Tim Schumann authored
Change-Id: I54f63844b7c664553434008aafcf98e2d115d669 Reviewed-on: https://chromium-review.googlesource.com/913129 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 3674 3678 3684 3686 3688 3689 3690 3694 3696 3697 3698 3699 3693 39 lines were removed and 35 lines were deflaked by consecutive results since 3664. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I623bd148abe99a0982386e4ac746a4c42902bfa1 Reviewed-on: https://chromium-review.googlesource.com/912208 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
