GitLab

This reverts commit 7f9c2bff.

Reason for revert: <crbug.com/999467>

Original change's description:
> Include profile name in AppUserModelId for default profile.
> 
> Migrate pinned PWA shortcuts as well.
> 
> This makes pinned icons for the default profile on Windows have
> the profile name in the AppUserModelId, which prevents weird behaviors
> when other profiles are added/removed.
> 
> If shortcuts are migrated, shortcuts without a profile will be migrated
> to point to the default profile.
> 
> Originally submitted as 1658991, which was reverted because of an issue
> with pinned PWA shortcuts.
> 
> Bug: 593414, 328738
> Change-Id: I68bc7083e233cf6dd3cfd56359245df59fd0e4a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686222
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#677305}

TBR=gab@chromium.org,alancutter@chromium.org,davidbienvenu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 593414, 328738
Change-Id: I1414fe5915c0f8b78e7ae58f447274c42331f60c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787902Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693955}

This supports the new experiment groups here: cl/266241314

Change-Id: Ic6ae049784bcccc602b88028ab67b5f4333d7f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779574Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693954}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/browser/chromeos/arc.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=elijahtaylor@chromium.org

Bug: 891670
Change-Id: I5945428ec9b8eeeb0165da3b24cb52709d2961b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786741
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Commit-Queue: Elijah Taylor <elijahtaylor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693953}

These currently aren't being properly exposed in WebView and it's
causing ongoing test failures. Mark them as intentionally not exposed
for now - this can be reverted when the interfaces are fixed.

Bug: 994324
Change-Id: If5cf5fcf61ac6d046e913362c684430216528f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787890
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693952}

Default colour was white most likely by mistake which forced white as
the default background and foreground colour for captions.

Bug: 1000609
Change-Id: I87614e191ec3b3a1424f371d208691a7b6effa32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786250Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693951}

After https://chromium-review.googlesource.com/c/chromium/src/+/1022750/,
we've got the following ownership structure:

RFHI owns WebUI that owns DevToolsUI (as WebUIController) that owns
DevToolsBindings that owns DevToolsWindow (as Delegate) that owns
WebContents that owns
FrameTree->FrameTreeNode->RenderFrameHostManager->RenderFrameHostImpl.

This tries to mitigate the problem destroying DevToolsUI from RFHI
by deferring destruction of WebContents owner by DevToolsWindow.

Bug: 997299
Change-Id: I19fdf3cd9b39cf421bb29dc3214f868ec7095b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786252
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693950}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/browser/ssl.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=rsleevi@chromium.org

Bug: 891670
Change-Id: I827b531ccd4b0344dbb14656c506c413c09374ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786905
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693949}

Currently, a non-sandbox GPU process for the GPU info collection is launced
15 seconds after the browser starts. From the GPU watchdog crash reports, many
systems are still busy within the first 30 seconds of the GPU process launch.
Running a second GPU process during this period will make the system even
busier. Therefore, the delay is now extended from 15 seconds to 120 seconds.

The side effect of this delay is DX12/Vulkan won't be available in about:gpu
in the first 120 seconds. This will be fixed in the other CL.

TBR=jochen@chromium.org

Bug:949839

Change-Id: Ib21531f2ae8757199878f810ea33536d373081e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783108
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693948}

This change prevents copying from the non-inherited cache when there
is not an inherited cache hit in forced colors mode because
forced-color-adjust could be set to none, and copying colors
from the non-inherited cache could lead to the wrong color evaluations.

Bug: 970285
Change-Id: I30f300e4456f0d8ad9a4a4c02af06622a2d8d07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779535Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#693947}

The ukm.xml change simply add an enum value to a metric that has already been approved here: https://bugs.chromium.org/p/chromium/issues/detail?id=753486#c26

Bug: 995761
Change-Id: I7c83f490f1e86fef3d4d1ba1cdf60681cfdb3ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778406Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693946}

Replace 'ToDo' with actual comment.

Bug: none
Change-Id: I83f405214e68f0797975b60844658141b5e4a190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787554Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@google.com>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693945}

This CL makes use of the new |metadata| parameter of the
|OnInteractionStarted| event to make sure that pending query text is
not dropped due to overlapping Assistant interactions.

This CL does not fully address the issue of overlapping Assistant
interactions as calls to set the pending query text still occur outside
of the interaction lifecycle. That will be addressed as part of
b/140565663.

Bug: 973680, 941259
Change-Id: I6868387bee2b744a7573b9ed98e47077da011d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787867Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#693944}

This currently crashes on Android O builders when we intend to move
the clock forward since the queue flushes all pending tasks and one of
the tasks that gets posted at the end of startup attempts that the
creation of a TestingProfile triggers is to instantiate a
system_network_context_manager which is null in unit tests.
(crbug/981057)

Bug: 999349
Change-Id: Ie60ca11674eb332a277dc783181f0230c7a23ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788300Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693943}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ios/chrome/browser/ui/settings.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 891670
Change-Id: I9f04bae163251c4d44f9dde9b0e11bc8c4c050bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786809
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693942}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/service.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 891670
Change-Id: Id2b0b9a33e136e76d03363140e120a169f063054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786749
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693941}

* Adjust comments to be more consistent
* Avoid drawing unnecessary segments
* Eliminate |corner_gap|, which just makes the math less clear

No functional change.

Bug: none
Change-Id: I158dae73ca35a6ea6692a3064a5938d99a26ec79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786183
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693940}

In ozone builds, Gdk hits assertions mentioning GdkEventKey::group for
each key processed by libgtkui::GtkKeyBindingsHandler, as follows:

Gdk-CRITICAL **: 17:59:16.592: gdk_x11_keymap_translate_keyboard_state: assertion 'group < 4' failed

That happens because BuildGdkEventKeyFromKeyEvent does not initialize
`group` before calling gdk_x11_keymap_translate_keyboard_state function.
So, initialize it with 0 until keyboard layout switching is implemented
for Ozone, which will be addressed in an upcoming CL.

Bug: 987939
Change-Id: I16a150cdbef59972a29614edb1ac65e684a082a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788178Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#693939}

Bug: 994361
Change-Id: Ibab9ea4f67f6159dab0e1027be65270b44e9d73a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787461Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693938}

This is a speculative fix for the crash in question. The assumption
is that the PerformanceManagerTabHelper is getting interface requests
for speculative RenderFrameHosts that it has no record of.

Bug: 987445
Change-Id: I7b35b4845b6b1b3cb84bb3d4efa85b782fcf2460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787886
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693937}

This CL enables autosubmit of the pac when input field is complete.
It updates the tests to ensure that they don't have to press the
submit button the first time the input field is complete.

Bug: 999389
Change-Id: I287f228de484c466df71f0a9d713d9020e2aee4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784938Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693936}

This change makes the back button act the same way
when clicked as when selected (both in the menu,
and when the back button appears alone while
navigating outside the menu).

Test: With emulated Chrome OS on Linux and
the Switch Access and improved text input flags enabled
(--enable-experimental-accessibility-switch-access and
--enable-experimental-accessibility-switch-access-text),
checked that the back button behaved the same way when
clicked as when selected with a switch.

Bug: 999581
Change-Id: I564f2be0da353fb1c912b090d9bc9fc58dc84f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779104Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Sophie Yang <sophyang@google.com>
Cr-Commit-Position: refs/heads/master@{#693935}

Now no google.com domains are PSL matched. This CL looses this for
Google sign-in and change password forms domains.

Bug: 1001086

Change-Id: I103d560272fd9986364e6625adb0389fec947df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754004
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693934}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/browser/renderer_host/input.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=tdresser@chromium.org

Bug: 891670
Change-Id: I178884fcf70f05b71f828abb8c5648fb187d99ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786781
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693933}

Since an unresolved SMILTime will always differ from a resolved
SMILTime, the |new_begin_time| condition could turn true at the end of
an interval, resulting in the firing of an additional 'beginEvent'.

Add a check for |previous_interval_begin_| being resolved to the
condition, and also make sure it is updated when we get a new interval.

Bug: 998287
Change-Id: I58a30c5aa09e3270aae33a7fdc4bb9d81a679539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786452Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#693932}

Bug: 974219
Change-Id: I49f3e30ccad376dff72e51ec836185e390d1dee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787559
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693931}

While timeout scaling is still needed in some spots that don't use
CriteriaHelper/CallbackHelper, having these commonly-used helpers
apply the scaling should reduce the number of spots where tests
forget to scale their own timeouts.

Bug: 1001106
Change-Id: Iff9891916cb5c22227208abc48677c7d91698e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723422Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693930}

When building hit test data for v2, root_view could be overlapped by
ui::Layers on CrOS which it shouldn't. This leads to all hit testing
on CrOS with v2 hit test data becoming async.

This patch ignores the kHitTestAsk flag for root if it was caused by
being overlapped. The best way to fix this is not setting the flag
upon building the hit test data in LTHI. Will try to do that in a
follow up patch.

Bug: 999576, 996865
Change-Id: I84ad8fa6a732f52a9bc2f40149954562da5ef69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787118
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693929}

The contract for `SnapCoordinator::PerformSnapping` is that it returns true
when scroll operations results in snapping. Returning true ensures we skip the
logical scroll.

In a previous patch [1] the logic was incorrectly changed to return true only
if we snap *and scroll as a result of the snap*. This meant that if we snap to
current position, that snap operation is ignored as it does not cause any
scrolling. This lead to failure of a few tests.

This patch reverts that change. It also removes a unnecessary check where we
check in snap logic where it tries to avoid scrolling if offsets are the same.
`ScrollableArea::SetScrollOffset` already has similar shortcuts so there is no
need to recreate them here which may have contributed to the error.

Note: At the time [1] was landing at least one of the two tests affected [2]
was marked as skipped (See http://crbug.com/922951), and the other test
started flaking one day after [1] was landed (See http://crbug.com/986018).


[1] https://chromium.googlesource.com/chromium/src/+/b65606034fd91c1aaf1d132a7601721e552d625f%5E%21/#F3
[2] fast/scroll-snap/snaps-after-keyboard-scrolling.html

Bug: 986018
Change-Id: Iae0c0ae9cdef58023bb1bcd2b6fb12fbff13ecc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769044Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693928}

Bug: 925072
Change-Id: I8b9f355f33d95e7a35510eae8d5a671544f7fe6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784354Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ce Chen <cch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693927}

This is run of proto_export.py

Change-Id: Ib3c39abcdc54bae69f67213bbc21270b0f5d8031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786361
Auto-Submit: Tony Yeoman <tby@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693926}

https://swiftshader.googlesource.com/SwiftShader.git/+log/60a0dc7071fd..9746f8bf683e

git log 60a0dc7071fd..9746f8bf683e --date=short --no-merges --format='%ad %ae %s'
2019-09-05 jmadill@chromium.org Fix GN/Chromium build.

Created with:
  gclient setdep -r src/third_party/swiftshader@9746f8bf683e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140251624
Change-Id: Ib392d5924484195062a3b5e60e93fd992eb8be34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788079Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693925}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/renderer/pepper.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=bbudge@chromium.org

Bug: 891670
Change-Id: Idca36fd4180c5e8047274ffb141a074562413e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786807
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693924}

Current node instance used in chromium project does not support instance
class fields. Relocating those to constructor resolves failures of
minifying the JS file.

Bug: b/140562984
Test: Verify minify_with_uglify.py works
Change-Id: I353e4863696a4c56c7c27ec9104328f189d00565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786861Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693923}

USS implementation of Nigori isn't compatible with Directory
implementations of other datatypes, because Directory requires USS
unfriendly logic for reencryption.

This change should allow passing Directory-specific integration tests,
while USS implementation of Nigori is enabled and prevent browser
misbehaviour for users, who plays with experimental flags.

Bug: 922900
Change-Id: I4dd4e5251d2496b5221afb5ee7f8f38112e078f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784604
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693922}

- Do not update scroll if the delta is too small, this matches what
  drags on overview items do.
- Pause occlusion tracker on scroll.
- When scrolling, do not call SetBounds unless the item is leaving or
  entering the view of the grid.

Tested locally with OverviewScrollTest.Basic. Not the greatest gains
when only 12 windows, but scales much better with larger number of
windows.

Presentation time:
Before 12 windows: 55ms
Before 42 windows: 180ms
After 12 windows: 53ms
After 42 windows: 88ms

Also renamed a overview_grid_pre_event_handler ->
overview_grid_event_handler as it handles regular events now.

Test: manual
Bug: 978112, 993615
Change-Id: I28bcbb8ce3291f975df9f1033961fbe176052fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784349
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693921}

Tbr: martiniss@chromium.org,sque@chromium.org
Bug: 1001231,950413
Change-Id: Ic49b1ca112bc81e444aa5fe8c8787f9ab28c2616
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786872Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693920}

This allows the code to distinguish a tab created on startup from
tab created FROM_CHROME_UI.  We animate tabs created that use
FROM_CHROME_UI, but we do not want to do that for tabs created on
startup.

The aim is that this will fix the flakiness of the
MainIntentBehaviorMetrics.

BUG=980587

Change-Id: Id00df9944c30a2b7b120ecb29b268af8ea3618c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786672Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693919}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/mojo.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 891670
Change-Id: If1ba8688539709b8e28ce009e3483a1aac36fc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786977
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693918}

- Autogenerate Polymer 3 version of cr-search-field and its automated
tests
- Add to Polymer 3 demo page

Bug: 965770
Change-Id: I6901db78e71767f757642aa89dae43be4473dd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786177Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693917}

Currently, we are using 0-based indexing for anchor metrics, but 1-based
indexing for click metrics. This is addressable in UKM queries right
now, but a better long term fix is to match the metrics on the client.

Change-Id: I1c615971af7cd4f05c37c384d25673cc9efa09ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788217
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693916}