GitLab

For the given repro case, textInputType seems to get stuck in the
previous input type whereas textInputInfo is checking whether
an editor exists for the focused frame and exiting early with
with TextInputType set to None. Switching to using textInputInfo
in getTextInputType, as the comments in the header suggests the use of
textInputType by itself as an API should be deprecated anyway.

BUG=162831


Review URL: https://chromiumcodereview.appspot.com/11419218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158379


Review URL: https://chromiumcodereview.appspot.com/11348311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170557 0039d316-1c4b-4281-b951-d872f2087c98

The breakpad export has been unused for the last five months, so I suppose it's safe to remove it entirely.

BUG=162405
TEST=Chromium Win (aura) bot should be able to compile metro_driver.dll.

Review URL: https://chromiumcodereview.appspot.com/11412265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163548
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11416279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158308
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11428105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170553 0039d316-1c4b-4281-b951-d872f2087c98

Adds ShellPanelAsh and window_type=panel support to ShellWindow

BUG=161102


Review URL: https://chromiumcodereview.appspot.com/11363250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170552 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170477 - Removes the |event| parameter from ActivationDelegate::ShouldActivate and makes the method const.

It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.

Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11419251

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11416292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170550 0039d316-1c4b-4281-b951-d872f2087c98

There's a lot of valuable information in coalesced nudges.  Currently, one
nudge source can overwrite another, which leaves us in the dark as to why the
client behaved a certain way.  In fact, today we can't even determine whether
or not any coalescing was done.  

By logging all the coalesced sources and their payloads, we can learn a lot
more about client behaviour.  I'm hoping to use this to improve our
notification effectiveness metrics.

BUG=138613

Review URL: https://chromiumcodereview.appspot.com/11416126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170549 0039d316-1c4b-4281-b951-d872f2087c98

large data sets.

Also, go back to a limit of 200k entries, to monitor things, and increase the
version number to have clean stats after this change.

BUG=147383
TEST=none
Review URL: https://codereview.chromium.org/11415222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163111
TBR=nona@chromium.org,satorux@chromium.org

Review URL: https://codereview.chromium.org/11428120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170546 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danno@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11412270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162733
TEST=Test proxy settings on a system with GNOME3.

Review URL: https://codereview.chromium.org/11348279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11414240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170543 0039d316-1c4b-4281-b951-d872f2087c98

Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=103701


Review URL: https://chromiumcodereview.appspot.com/11299277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51636


Review URL: https://chromiumcodereview.appspot.com/11434043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158821

Review URL: https://codereview.chromium.org/11418265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170539 0039d316-1c4b-4281-b951-d872f2087c98

R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11412202

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170533 0039d316-1c4b-4281-b951-d872f2087c98

Fix the following chromium-style warning:
../../chrome/browser/ui/views/frame/desktop_browser_frame_aura.h:43:3: error: [chromium-style] Overriding method must have "virtual" keyword.

By adding the missing 'virtual' keyword.

TEST=build/gyp_chromium -Duse_aura=1, ninja -C out/Debug chrome should link.
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11316277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170531 0039d316-1c4b-4281-b951-d872f2087c98

`chrome --app-id=x --incognito` currently launches an app in incognito mode, which is not allowed. After this patch it will simply ignore the --app-id flag.


BUG=155130


Review URL: https://chromiumcodereview.appspot.com/11348315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170529 0039d316-1c4b-4281-b951-d872f2087c98

A BrowserPluginPropertyBinding is bound to a particular property name, so there
is no point to passing in the property name on GetProperty and SetProperty.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11299279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158821

Review URL: https://codereview.chromium.org/11416289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170527 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170526 0039d316-1c4b-4281-b951-d872f2087c98

This is needed before we can land:

https://codereview.chromium.org/11412233/

BUG=

Review URL: https://chromiumcodereview.appspot.com/11316232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170525 0039d316-1c4b-4281-b951-d872f2087c98

Before focusing did not work, which was especially noticeable for users using ChromeVox or those using keyboard only. This patch resolves following issues:
* Automatically focus the default button (depending on the screen).
* Focus the cancel button by default in the reset screen.
Besides, now it is possible to focus any control by default, not only buttons.

TEST=Turn on ChromeVox and navigate through the oobe screens.
BUG=161896


Review URL: https://chromiumcodereview.appspot.com/11421111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170523 0039d316-1c4b-4281-b951-d872f2087c98

This page set should be executed with a mobile user agent.

BUG=
TEST=./tools/perf/run_multipage_benchmarks --browser=system smoothness_benchmark tools/perf/page_sets/key_mobile_sites.json


Review URL: https://chromiumcodereview.appspot.com/11299273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170521 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=155525


Review URL: https://chromiumcodereview.appspot.com/11280115

Reason for revert: A review comment after commit showed that the
change is probably wrong (or at least changes behavior in a way that
was not intended). Reverting for now, until there is time to figure
out the correct change.

TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/11308295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170519 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bartfab@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/11348327

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170518 0039d316-1c4b-4281-b951-d872f2087c98

Note that the feature is still disabled in WebKit and it will remain so until we finalize the UI.

TBR=thakis
BUG=135771


Review URL: https://chromiumcodereview.appspot.com/11316153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170517 0039d316-1c4b-4281-b951-d872f2087c98

Just adding the API first to unblock other CLs and so
we can start to use the API. Async tasks are just
done synchronously, and the completion query is set
immediately when it executes in the GPU process.

BUG=161337


Review URL: https://chromiumcodereview.appspot.com/11412232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170516 0039d316-1c4b-4281-b951-d872f2087c98

Right now, we use 0.025 * bounds as the pivot, which basically amounts to the
upper left corner of the window. I don't think that was intended. I think that
we mean to scale about the center of the window when hiding.

BUG=163385


Review URL: https://chromiumcodereview.appspot.com/11411283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170515 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces two new concepts:
- API permissions that cannot be found in the manifest (and therefore
  need not be in the optional permissions section to be optionally
  requested)
- optional API permission requests that have associated data

BUG=119473
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11413099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170514 0039d316-1c4b-4281-b951-d872f2087c98

base::lock provides a simple detector for single-thread deadlock in
debug mode.  Implement a similar approach for the proxy lock in debug
or release.

BUG=161286


Review URL: https://chromiumcodereview.appspot.com/11280041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170513 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the hudLayer on retina displays, where the FPS counter appears offscreen and the paint rects at wrong locations.

BUG=163014


Review URL: https://chromiumcodereview.appspot.com/11415208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163630
TBR=jam@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11348324

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170511 0039d316-1c4b-4281-b951-d872f2087c98

This is probably overlooked when ShowRootWindow is added.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11412259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170510 0039d316-1c4b-4281-b951-d872f2087c98

Local change slipped in to commit

BUG=163653
TBR=frankf@chromium.org

Review URL: https://codereview.chromium.org/11412277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170509 0039d316-1c4b-4281-b951-d872f2087c98

This is so it can be run optionally on the trybots.


Review URL: https://chromiumcodereview.appspot.com/11299263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170508 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends the UserManager to handle public accounts defined through
policy. User pods are dynamically added and removed when the list of
public accounts in policy changes. Any data belonging to obsolete accounts
is also removed, taking care not to remove it prematurely if a user is
currently logged into the account.

The CL also makes the user list handling more robust by checking for
duplicate entries in the user list prefs and logging these as errors.

The pods added for public accounts are not functional yet. The login flow
for public accounts will be the topic of another CL.

BUG=158509


Review URL: https://chromiumcodereview.appspot.com/11419184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170507 0039d316-1c4b-4281-b951-d872f2087c98