- 04 Feb, 2020 40 commits
-
-
Patrick Monette authored
This is a reland of dec0aa0b The fix for the failure is in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2036479 Original change's description: > [PM] Add support for dedicated workers > > The WorkerWatcher observes dedicated workers through the > DedicatedWorkerService interface. > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736411} Change-Id: I40b86ea7de8fa4b252ffe805ec5992020dffc515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028214 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738160}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3c5406b19457ba5427cae24785fbae0a3c161d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037278Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738159}
-
Dominik Röttsches authored
Remove explicit hash and trait references when defining HashMaps based on FontCacheKey in place where that is used. Change-Id: Id77bb4a21102d8ed19c2fba66eda174d6e01ec65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035999Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#738158}
-
Roman Sorokin authored
Use OobeScreenWaiter to check if the screen is up. Fixed: 978267 Change-Id: I6725ae9b9184a4a0af3540ddff9c12423f2c9e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036094Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738157}
-
Side Yilmaz authored
|getLastUsedProfile#getOffTheRecordProfile| |Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This change replaces |Profile#getLastUsedProfile#getOffTheRecordProfile| with |Profile#getLastUsedRegularProfile#getOffTheRecordProfile|. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I4b1b97fb26beafaaae6c59bd6557eada032bf601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030870Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738156}
-
Philipp Hancke authored
in order to estimate how much of a use-case simulcast is BUG=823036 Change-Id: Id01ba23692d5fbe7ad95c5bb8f2904891cf9f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036092 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738155}
-
Nikita Podguzov authored
As far as these methods are computationally intensive we want to add quotas for them. Bug: 996785 Change-Id: I8573d39fa3d6388b97de08636a3997d51a768a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007812Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738154}
-
Jan Krcal authored
This is a reland of ba52e783 The test flakiness introduced by the previous attempt has been fixed by another CL [1] that removed unneccessary expectations). Thus, this CL should be safe to land again. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2022651 Original change's description: > Reland "Fix flaky test ServerAddressConvertsToSameLocalAddress" > > This is a reland of commit b3873b4d. > > The CL fixes a race condition in production code of autofill profile > sync bridge by modifying merge logic of the datatype. Previously, the > logic for dealing with duplicate entities was to always prefer the > remote one and silently delete the local one. This could end up with > two clients having a different entry each and the sync server having > both duplicate entries. The new behavior, introduced in this CL is to > keep the profile with greater GUID, lexicographically. > > This change should also remove flakiness of one integration test (that > uncovered the actual issue), so the CL reenables the test. > > The original CL caused flakiness in another integration test since GUIDs > in that test are randomly attributed. In this reland, we fix this by > making the expectation on the number of sync deletions depend on which > one of the test GUIDs is bigger. > > Bug: 917498 > Change-Id: I13994ac5bef8fcae41d37350e08ee80ab90f0916 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002571 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733636} Bug: 917498 Change-Id: I380f5f38de58a2250f19e28c3429869ca8624f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020927 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738153}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I4fa18067d55314b2e2e01531343216aba3ff360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033158 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738152}
-
Dale Curtis authored
Locally if I run "pactl exit" and log the start time, up to 3 seconds may elapse before the pa_context reaches the PA_CONTEXT_READY state. On my local machine, something is restarting the pulse daemon automatically within a few seconds. It's possible the bots are running in some state where the pulsedaemon will not respawn, so we end up hanging forever. There's no easy way to timeout the wait for PA_CONTEXT_READY since on the call into pa_threaded_mainloop_wait() just hangs and there's no way to pump the mainloop otherwise it looks like. If we want to make the loop timeout, we need to switch away from wait() to a spin/sleep loop. Lets see if this fixes the issue first, if not then we can try a timeout based approach. R=guidou Bug: 1047655 Change-Id: If81ef546c04aa33df8e35368102fd890016db76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036901 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#738151}
-
Ewann authored
Bug: 1035850 Change-Id: Ib261d2d4651c2a3c60de03f7696d44f1ec618380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033150 Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738150}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbebc4acd3b6..0bf9b99cb6fb git log dbebc4acd3b6..0bf9b99cb6fb --date=short --first-parent --format='%ad %ae %s' 2020-02-04 leese@chromium.org Test for duplicate tabs on reload Created with: gclient setdep -r src/third_party/devtools-frontend/src@0bf9b99cb6fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035843 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I053c3f4c2ce9ba0465476bc8bad7fcb59bf328ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738149}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3fa2b80e14fa..f5d877847fae git log 3fa2b80e14fa..f5d877847fae --date=short --first-parent --format='%ad %ae %s' 2020-02-04 ilnik@webrtc.org Reland "[VP9] Shift spatial layers on RTP level to always start from 0." Created with: gclient setdep -r src/third_party/webrtc@f5d877847fae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I82a063a098d5d2297c7883867fbcf7d8a3e9ca52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036818Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8f2b5ba75973..32bee3cbd581 git log 8f2b5ba75973..32bee3cbd581 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 fmayer@google.com Merge "Get rid of UnixSocket::BlockingMode." Created with: gclient setdep -r src/third_party/perfetto@32bee3cbd581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2414f7bb80f0350c9002b3d7223b72083b059884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036816Reviewed-by:
-
Yuki Shiino authored
Bug: 924839, 839389 Change-Id: I1c8c6dcd0d3e83f06816852e55351bc925974ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037293 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97c653589a1b..7fff9177174c Created with: gclient setdep -r src-internal@7fff9177174c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0fb91baa36c19f5dccec58a9d06e76e4f1de4873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036814Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738145}
-
Eriko Kurimoto authored
This CL removes codes for setting script_url value to outgoing_referrer when it is an empty string. Setting script_url value here instead of an empty string is wrong according to the spec, but we are doing so to pass DCHECK in security_policy.cc. (DCHECK: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/weborigin/security_policy.cc;l=114;drc=a1e88003b410ca2c3927e17be60a97ed8fedefab?originalUrl=https:%2F%2Fcs.chromium.org%2F) The reason why we were using script_url and not String() was to make the behavior same to the original code. It is discussed here: https://chromium-review.googlesource.com/c/chromium/src/+/1861294/8/third_party/blink/renderer/modules/service_worker/service_worker_container.cc However, now we change the constructor of WebFetchClientSettingObject to prevent outgoing_referrer from taking invalid values. (See https://chromium-review.googlesource.com/c/chromium/src/+/2033004) This CL changes the behavior when outgoing_referrer is empty, which occurs in some rare cases like extensions, and doesn't add tests because it's hard to test. Bug: 1047612 Change-Id: Ie4a1a5a784019706fcad156e1668f7f2236bb2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032691 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738144}
-
Marc Treib authored
TBR=dtseng@chromium.org Bug: 1048585 Change-Id: I7cada9b983f169e5730e8598105eb264143c87ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036172Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738143}
-
Miyoung Shin authored
This CL removes the useBrowserInterfaceBroker parameter in mojo.idl, mojo_interface_interceptor.idl and JS generate template since all the interfaces in the following call sites are acquired through BrowserInterfaceBroker. Bug: 995556, 994843 Change-Id: I1b50496084eaec315539d75c40a39ceff8c8aa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963910 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738142}
-
Mihai Sardarescu authored
During the migration to Earl Grey 2, the sign-in tests were upgraded to use the UI to clear the browsing data. This proves to be very flaky (see bug 1045478). This CL changes the setup of the sign-in EG tests to only clear the browsing history. It also moves to an interface call and thus avoids using any UI for clearing the browsing data. Bug: 1045478 Change-Id: Ia11d5ffe535852533f83dfccc36d720b66c04f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034521Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738141}
-
Igor authored
The moment the enrollment process started, switching to hangouts meet or back is disallowed, to avoid getting wrong policies. In order to enroll the device in hangouts for meet, the ctrl+alt+h shortcut should be pressed after ctrl+alt+e in the enrollment process. BUG=chromium:1040523 TEST=Manual tests on the device Change-Id: I4a5f589ab278bf2c6f47c8640d833b02e785735f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014406 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738140}
-
Swapnil authored
ContentSettingsRegistry::Init() method registers the content settings with their default values. Here, it specifies that DefaultPluginSettings should be registered with default value as "block". The default value for DefaultPluginSettings should be specified in the description for the policy. Bug: 956083 Change-Id: I19fbb3b9c36f0c71778fb4b0f0a3ab233b968f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036070Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#738139}
-
Saurabh Nijhara authored
Bug: 1048607 Change-Id: Ibbedd53b59028d0b83459e41c9b728e063974318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035973Reviewed-by:
-
Maksim Ivanov authored
Change a few places in the policy code to use std::move() with std::unique_ptr instead of calling release() on them. It's slightly more idiomatic and a bit safer. Bug: none Change-Id: I7b25af583369cac6234f712a4cadeefad09c47d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035879Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#738137}
-
Morten Stenshorne authored
Hit-testing must always traverse the layout tree backwards, since we want to hit whatever was painted last. Change-Id: I7029c0292fe09e47830bc30b555c42f8f4bca79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033077 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Deprecate "emaildomain" in favor of "hd" (hosted_domain) url parameter for domain hint Fixed: 1047925 Bug: b/73890774 Change-Id: I042ac7fca5574eed193d7ee95d21eacf40b9c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033519Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738135}
-
Richard Knoll authored
Ignore the //chrome/browser/sharing/internal folder for developers that pull in that directory via custom_deps in the .gclient file. Bug: None Change-Id: I01aa8ff1c056ca52bf64df8dce122d6f498a0cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033261 Auto-Submit: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738134}
-
anina koehler authored
Remove UMA for SchemaOnErrorStrategy.SCHEMA_ALLOW_INVALID which was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1841031 since SCHEMA_ALLOW_INVALID will be removed. Bug: 969706 Change-Id: Iaea896feabc06fa0104e50bdc2140bf826c7159c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027453 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#738133}
-
David Jean authored
Bug: 1040011 Change-Id: Ia43b028772713c4f140c06d76cee62b9acae1472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014963Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#738132}
-
Jan Wilken Dörrie authored
This change cleans-up the implementation of the chrome.passwordsPrivate API by making use of modern language features and introducing small helpers to reduce redundancy. Bug: 1047726 Change-Id: I2a478bd197b0a6677876f423922c179205952e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036171 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738131}
-
Marc Treib authored
This reverts commit abf9a1f5. Reason for revert: Broke tests on Win7 dbg, see linked bug Original change's description: > Call MFShutdown in places where MFStartup is called > > Bug: 1012527 > Fixed: 1012527 > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332 > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738063} TBR=xhwang@chromium.org,tmathmeyer@chromium.org Change-Id: I267213cc06b42769736c7eb337432ade7953de20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057Reviewed-by:
-
Markus Handell authored
MSRVS only provided base::TimeTicks() (0) as frame timestamps for already decoded frames. This interacted badly with MediaRecorder which received non-monotonic timestamps. Bug: 1048140 Change-Id: I9f351f6631154341fd07f5e3dbd429a4eff73a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033766Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1048173 Change-Id: I0746e310cec111661307b7fea7a0a3fcc2c73004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035672 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738128}
-
Richard Knoll authored
This adds UMA logging for various events during a Sharing WebRTC connection to identify where the bulk of the transmission delay is spent and to spot any issues. Bug: 1021984 Change-Id: I4aea9307cfe0a028ebf29d6054d38cf2f54ee417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027338 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#738127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38e18be3132d..97c653589a1b Created with: gclient setdep -r src-internal@97c653589a1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I863ea9a969927a57d49763b7b6c71cbd4d946cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036424Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes AppendToString from BasicStringPiece's API. Similarly to r736299 and r736749 AppendToString is not part of std::basic_string_view's API and thus would block us from adopting it. Existing usages of `piece.AppendToString(&str)` are replaced by either `str.append(piece.data(), piece.size())` or calls to base::StrCat and base::StrAppend when these made sense. TBR=dcheng Bug: 752720 Change-Id: Ifb5019f221052cd6cc24dce6ce5f2bfbbb24d060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031034Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#738125}
-
Maksim Ivanov authored
Fix the documentation of the "MaxInvalidationFetchDelay" policy to contain the correct default value: it's 10 seconds, not 5 seconds. Bug: none Change-Id: I31a35c57b8c1694c85f97662f281826544335af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036052Reviewed-by:
-
sandromaggi authored
Before this change, sometimes an asynchronous state could appear where the chip in the model was disabled while the chip in view was still enabled. Bug: b/148771795 Change-Id: I853819aa6046429ad0cd3a380713883f71084454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033771Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#738123}
-
Maksim Ivanov authored
This deletes the declaration of the BrowserProcessPlatformPart::DisableDinoEasterEggIfEnrolled() method, which is unused and has no implementation. Bug: none Change-Id: Idfc2743309b179ed0bd6ea308b4c7d4cb4fb2f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036051Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#738122}
-
Peter Marshall authored
Sending messages to V8 goes through the following entities: Browser -(IOSession) -> Renderer[IOThread] -- Can interrupt or not, depending on ShouldInterruptForMethod -(Session) -> Renderer[MainThread] -- All messages are non-interrupting At two points it must be decided whether a message should be interrupting: The first is on the browser side in ShouldSendOnIO, and the second is ShouldInterruptForMethod in the renderer's IO thread. This CL modifies ShouldInterruptForMethod in the renderer to handle all messages (except Runtime.evaluate) as interrupting if they are received via the IOSession, effectively letting the browser decide whether a message should be interrupting. This enables the browser to ensure that all messages whitelisted in ShouldSendOnIO are interrupting for non-workers, and that all messages for workers are interrupting (since the browser sends them on the IO channel). So there are now 3 types of messages: 1) Sent on Session, non-interrupting. These are most messages to non-workers. 2) Sent on IOSession, interrupting. These are the whitelisted messages using ShouldSendOnIO in the browser, plus almost all messages for workers. 3) Sent on IOSession, non-interrupting. Right now this is just Runtime.evaluate, as it shouldn't interrupt running JS. This, combined with flushing the notification queue after sending a 'resumed' notification, will fix the referenced bug. Bug: 1044989, 1044988 Change-Id: Icd6204fd0797d9594ade6f22fa895113d6b03bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027451Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738121}
-
