GitLab

Some restructuring and cleanup of EDK code and targets:

  - //mojo/edk/system sources are merged into //mojo/edk:core
  - embedder_internal.h is removed
  - mojo::edk::internal::g_core is replaced with mojo:edk::Core::Get().
  - Core ownership and initialization is moved into entrypoints.cc, where
    (a) it's used most frequently and (b) it can be shared with mojo_core
    in a follow-up patch.

Bug: 822034
Change-Id: I193549101f00aaf5b95764eeee7065423d6576e5
Reviewed-on: https://chromium-review.googlesource.com/977900
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545543}

Previously we gated run-time-configurable DCHECKs on the |is_syzyasan|
argument, to have them built-in to Chrome Canary SyzyASAN binaries.

We implement |dcheck_is_configurable| as a macro define rather than via
a buildflag, because Chromium currently has too many components with
undeclared dependencies on //base for introducing a new dependency of
//base/logging.h on a generated buildflags_header() to be safe.

Bug: 812058
Change-Id: Iac48c88e0c5964cc8bceac6c444e44f84133120e
Reviewed-on: https://chromium-review.googlesource.com/974904Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545542}

BUG=822137

Change-Id: I3b9bf9c5280599f061b3c22f78569d91b78d6168
Reviewed-on: https://chromium-review.googlesource.com/974647Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545541}

We stored ComputedStyle for option, optgroup, and svg:stop even when
their computed display was none. That caused descendants to get
ComputedStyle objects and confused the WhitespaceAttacher walking down
display:none subtrees for layout tree rebuilds.

Bug: 822581
Change-Id: I604033d96ff194119f328ac5ced71a9e04563ccb
Reviewed-on: https://chromium-review.googlesource.com/973962
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545540}

Bug: 818276
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie05e6d83dc71beac0e682fad967e75616e81f6af
Reviewed-on: https://chromium-review.googlesource.com/946856Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545539}

This was missed as part of the v2 paper-icon-button-light migration.

Bug: 822573
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifeacc6ca78efb16df0de851698bff71d11fac5b5
Reviewed-on: https://chromium-review.googlesource.com/976383Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545538}

This CL removes the need for ShowOnlyKeywordMatch() (and removes that
function).

The ShowOnlyKeywordMatch() was used to check whether the animation had
reached the suggestion icon and then it would make it invisible. The
code will now narrow the icon until it has no width, removing it
smoothly rather than making it pop out of existence.
ShowOnlyKeywordMatch() also had a very minor optimization effect by
not laying out the suggestion if the keyword search had finished
animating. This optimization is small and on an uncommon case.
The primary reason for this CL is to ease the transition to CL/974656.

Bug: None
Change-Id: I3217b1235352b4caa05d5bc01422c88e4b65991b
Reviewed-on: https://chromium-review.googlesource.com/977226Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545537}

Add a new type of IO buffer. Part of a series of changes to improve
performance of QUIC uploads that become CPU constrained.

R=rch@chromium.org

Change-Id: Ife3b6983d80744eb390939d0d9f751cecff8f958
Reviewed-on: https://chromium-review.googlesource.com/971827
Commit-Queue: Buck Krasic <ckrasic@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545536}

Bug: 811376
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1a745dbb16e9aa9791671afc90ff67106848c4d8
Reviewed-on: https://chromium-review.googlesource.com/944901Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545535}

Bug: 811766
Change-Id: Ia95dc3a6639ed4334243c4476930017aef2d560e
Reviewed-on: https://chromium-review.googlesource.com/978447Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545534}

has_backing_file_ being true implies that file_system_url_ is empty, so
remove unreachable code that tried to special case this situation.

This also leaves drag-and-drop code as the only user of file_system_url_,
but removing that dependency would require fixing bug 394955 first.

Bug: none
Change-Id: Ica9544156f58bab6915a451ec272d1ea23475e9d
Reviewed-on: https://chromium-review.googlesource.com/972348
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545533}

We used not to promote to overlays RGBA/BGRA quads requiring
no alpha blending, since we didn't have way of disabling alpha blending
at scanout time.

crrev.com/c/967415 introduced a way of controlling alpha blending
at scanout, that uses is_opaque flag in the overlay candidate,
that is already set correctly.
This patch removes the old check that avoided scanning out overlays
that reuqired to switch off alpha blending.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0015a20a27127179703d26be8dc5336febc5aac4
Reviewed-on: https://chromium-review.googlesource.com/976553Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545532}

Conditionally disables this test on dbg win.

BUG=825282,823003
TBR=mmenke@chromium.org
NO-TRY=True

Change-Id: I213d7500bef405ce1ebc4c6f100ab6ff21825fcb
Reviewed-on: https://chromium-review.googlesource.com/978620Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545531}

Do not animate the dismissal when the tab is closed or hidden.

Bug: 824017
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I11e2665301434d45677d339786bf6871315c9c63
Reviewed-on: https://chromium-review.googlesource.com/976090
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545530}

[SPv175] Apply local paint property and cull rect updates before checking for subsequence repainting.

Previously we were comparing incompatible cull rects.

Bug: 824738
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I12928f48ddb4316e538941e9429c91d86c1a842c
Reviewed-on: https://chromium-review.googlesource.com/976396
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545529}

As per jam@'s suggestion, this should no longer be necessary after crrev.com/c/973613. Reverting this and watching for crashes on canary will confirm this.

@jam: It still seems like a good defensive idea to make sure the dispatcher is running on the right thread. But you may have more context.


This reverts commit 943f2a2b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix crash when NoStatePrefetch is running a sync XHR.
> 
> I'm not sure why scripts are executing, but until that's figured out this should fix the symptom of the null dereference (and usage of PrerenderDispatcher on the wrong thread).
> 
> Bug: 819937, 823306
> Change-Id: I30cd24c7b5275a8f1a46babc437a9bcf7f6e8348
> Reviewed-on: https://chromium-review.googlesource.com/969082
> Reviewed-by: Matthew Cary <mattcary@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544743}

TBR=jam@chromium.org,mattcary@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 819937, 823306
Change-Id: Ic6c792e4b0be23e1ce515b2b3aacef0e8b4e8d89
Reviewed-on: https://chromium-review.googlesource.com/977829Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545528}

This CL initializes main frame activation computating throttles with
a DRYRUN page activation, so they can speculatively access the ruleset
on start + redirects.

This should be the final CL to drive ActivationComputingDelay metrics
to 0.

Bug: 809504
Change-Id: If2b3e871cc97a00400e777081a8bace80f728e9f
Reviewed-on: https://chromium-review.googlesource.com/967663
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545527}

We have some potential bugs that haven't been seen and crashes chrome
yet. This commit fixes them.

Bug: 733662
Change-Id: I5dba7f210a2a608085203c03377dd49c9cb920a7
Reviewed-on: https://chromium-review.googlesource.com/977162Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#545526}

BUG=714018

Change-Id: I7adfe8e440d29b4f775535a9942e2354d076a9d3
Reviewed-on: https://chromium-review.googlesource.com/976656Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545525}

Observers aren't hooked up in this CL, the NQE is just created.
Also makes the in-process path use the NetworkService object's
NQE, to make the two paths more similar and shared configuration
code.

Bug: 715695
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1b29df128820f77dc923bc2b6cfc09e04049866c
Reviewed-on: https://chromium-review.googlesource.com/950082
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545524}

This CL fixes SpellingMenuObserverTest.SuggestionsForceTopSeparator by
implementing TestingProfile::CreateMainNetworkContext() for network
service.

Bug: 779217
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib5c134c401a66feed97faf41d9e0b17b6ed2badf
Reviewed-on: https://chromium-review.googlesource.com/963402
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545523}

This reverts commit 8bc6affd.

Reason for revert: seems to break assistant at runtime

Original change's description:
> Add platform file provier to assistant
> 
> Bug: 820255
> Test: Manual
> Change-Id: I465d79c3b9cc2d8c0e1b0d6ea33a6b7db4833c37
> Reviewed-on: https://chromium-review.googlesource.com/961081
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544930}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 820255
Change-Id: I4b73a56219dd9dd58bc5072235fc7f8ce0b1f9e9
Reviewed-on: https://chromium-review.googlesource.com/978521Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545522}

Design doc (public): https://goo.gl/HmBYy6

This patch proposes the new API for the Shared Memory based on two
concepts, a shared memory region and a shared memory mapping. The
region controls the platform-specific handle and mediates sharing and
access control. The mapping is just a reference to the memory bytes
which knows how to unmap itself. Ownership is per-instance: neither a
region nor a mapping may be copied, and resources are freed when then
instance dies. This is accomplished through move-only semantics.

The goal of the new API is to provide a correct cross-platform
implementation that makes the sharing mode explicit via the C++ type
system.

Thus, this CL introduces two classes for shared memory mappings:
- WritableSharedMemoryMapping owns and provides an access to writable
shared memory
- ReadOnlySharedMemoryMapping for read-only shared memory

and three classes representing shared memory regions:
- UnsafeSharedMemoryRegion allows to create
WritableSharedMemoryMapping instances and cannot be used for making
read-only mappings
- ReadOnlySharedMemoryRegion, on the contrary, can produce only
ReadOnlySharedMemoryMapping instances and it also creates one writable
mapping in the caller process address space
- WritableSharedMemoryRegion allows to create writable
mappings and can be eventually converted to ReadOnlySharedMemoryRegion.
The important limitation in comparison with UnsafeSharedMemoryRegion
is that the WritableSharedMemoryRegion cannot be duplicated so in
order to pass the writable region to another process, the ownership of
the region must be moved/transferred to this process.

Bug: 795291
Change-Id: I7d1d0a24932145cc0f449b01ceb8cafef9b7e407
Reviewed-on: https://chromium-review.googlesource.com/893458
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545521}

In cases where there is a source tab, we are currently missing to set
the source ID, because at the time DidOpenRequestedUrl is received in
SyncSessionRouterTabHelper, the Java side Tab is not initializes and
TabHelpers are not attached yet. This plumbs the parent WebContents
during initialization, so that we can get another try at setting
the source tab ID.

Change-Id: Ic4194916518650e5c0e70b2f4d43ffaa183999d0
Reviewed-on: https://chromium-review.googlesource.com/972330Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Nicolas Zea (slow) <zea@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545520}

- The suggestions should include bullets according to the mock.
- The suggested values should always include all the passwords regardless of what is typed into the username field.

Bug: 819626
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ied795b335e00052f3629c2a0f30e26b9e51458b3
Reviewed-on: https://chromium-review.googlesource.com/978218
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545519}

Colors the toolbar white under Material refresh among others. These
colors are already used by the touch UI. This checks IsNewerMaterialUi()
which is true for both touch-optimized and material refresh.

Bug: chromium:810165, chromium:822069
Change-Id: I293537b0b03806ef1205a33a895cffa4d9552e9d
Reviewed-on: https://chromium-review.googlesource.com/976807Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545518}

In an effort to commit navigation faster, we are facing some failing
test: https://chromium-review.googlesource.com/c/chromium/src/+/951732

This CL update some of them. In these tests, there are a client-side
redirect. A new navigation is initiated by the document while
it is not fully parsed. These tests are waiting for 2 load stops:
  1) one for the initial navigation,
  2) one for the redirect.
It turns out, the second navigation may be fast enough, so that it
commits before the first document has been loaded.
DocumentLoader::LoadFailed() is called for the first document.
The browser receives DidStopLoading() only once instead of two.

Bug: 705744
Change-Id: I4201124c0e70d64204e3c9070aae588a684e0913
Reviewed-on: https://chromium-review.googlesource.com/960664
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545517}

Bug: 823876
Change-Id: I10b12d121becf8bda98f4200b18877e287e8ea7f
Reviewed-on: https://chromium-review.googlesource.com/976808
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545516}

Found from auditing suspicious classes in main dex.
https://maps.google.com shows location just fine without it.

Bug: 820570
Change-Id: Idb0d05c3598d966cbf3cfab667a5d4ddd876c541
Reviewed-on: https://chromium-review.googlesource.com/971022Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545515}

Buffer estimation paths were annotated to give info about which
estimation method was used. The decisions about how to act on estimated
buffers remain unchanged (for now).

Hopefully UMA data will show that splicing on top of buffers with
estimated duration is quite rare. This would give us confidence to
dissable this sort of splicing.

Once disabled, we could transition WebM audio buffer duration estimation
to use max-of-buffers-so-far (no longer in fear of over-triggering
splicing), which resolves the linked bug.

For buffers with duration type kConstantEstimate (all buffers had same
duration), the idea (down the road) is to treat this as if its not an
estimate at all and continue to allow splicing.

Bug: 396634
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icbe930cf013c24b05e033fd2aa5d5b7f83bf9ac6
Reviewed-on: https://chromium-review.googlesource.com/967514Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545514}

This reverts commit 65ae686a.

Reason for revert: breaks legacy page flips, since HardwareDisplayPlaneManager::IsCompatible tests with RGBA and fails.

Original change's description:
> viz: Make primary plane transparent
> 
> This CL enables alpha blending at scanout for the primary plane.
> In this way chromecast will be able to punch a hole in the primary
> plane and show content underneath.
> 
> Note that on platform using legacy pageflip we'll still be
> scanning out without alpha blending (crrev.com/c/964984).
> 
> Bug: 821944, b/74997524
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I654935dc630f7a9f6cb4717cd574a21a2749c442
> Reviewed-on: https://chromium-review.googlesource.com/976961
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545478}

TBR=dnicoara@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org

Change-Id: If2d49fb3d9b1042653f7d4359b699d784c757d14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821944, b/74997524
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/978581Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545513}

This reverts commit b5d6aaf9.

Reason for revert: This change cancels the download if the task did not complete within 60 seconds timeout.

Original change's description:
> Set 60 seconds as timeoutIntervalForResource for Downloads.
> 
> Background NSURLSession never fails due to connectivity errors. Instead
> that session waits for connectivity up to timeoutIntervalForResource
> timeout which defaults to 1 week.
> 
> This CL changes the timeout to 60 seconds.
> 
> Bug: 824018
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I841fc4580fa6bc6724198d825bb1736b91027fc4
> Reviewed-on: https://chromium-review.googlesource.com/976623
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545482}

TBR=sdefresne@chromium.org,eugenebut@chromium.org

Change-Id: I750099a0e3d786930a9d57dacdf62597be8d36f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824018
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/978471Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545512}

TBR=ashleymarie@chromium.org
NOTRY=true

Bug: 823357
Change-Id: Ia44f54405c5b6ad0dd0f3b859753de3cea7c35b4
Reviewed-on: https://chromium-review.googlesource.com/978478Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545511}

Switches to using an accessibility role of alert dialog which is more appropriate for a notification toast than a window role.
Alert dialogs are widgets that may contain interactive controls that need to be announced by a screen reader as soon as they appear.
Also, an alert event should be fired regardless to whether the notification has been updated or has been initiallly set.
R=aleventhal@chromium.org, dmazzoni@chromium.org, dewittj@chromium.org, peter@chromium.org

Tested: Manually with Jaws and NVDA screen readers on Windows
Change-Id: Ida3abe94b9dc32a5c95ce6b14c6fac11670348e3
Reviewed-on: https://chromium-review.googlesource.com/968672Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545510}

Bug: 821170
Change-Id: I6ad4d15ce7fbf0f168527aaac4029654b6632dd3
Reviewed-on: https://chromium-review.googlesource.com/976186Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545509}

Also implements getLastWrittenValue() and converts two tests to use
these.

FakeRemoteGattDescriptor::setNextWriteResponse allows tests to set the
next response for a write.

BUG=719825

Change-Id: I2807d23a55f79eeca35338e25916c6d5e0115e89
Reviewed-on: https://chromium-review.googlesource.com/964901
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545508}

Bug: skia:6718
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I75700d44a337f768e2c30cf92b78b721b915334e
Reviewed-on: https://chromium-review.googlesource.com/977946Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545507}

Mark as flaky on specific platforms.

BUG=825262
TBR=eae@chromium.org
NO-TRY=True

Change-Id: Iea0332aa3d2e192866b47dfef8aa2034ae24b13d
Reviewed-on: https://chromium-review.googlesource.com/978452Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545506}

This change refactors the URL bar into a set of buttons, layouts, and a
much smaller dedicated element to present the URL text.  In the future,
the URL text should be made into a Text subclass, or similar, to take
advantage of text layout.

This change also refactors and fixes some pieces of the vector icon
button class.

BUG=821946

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I186e6c32dbf8c61ddba7a5f9fe01c584067bd43e
Reviewed-on: https://chromium-review.googlesource.com/976685
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545505}

Change-Id: I612740b3a1196b7165a1555a3947753b598c2b65
Reviewed-on: https://chromium-review.googlesource.com/978378Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545504}