GitLab

Input handler was recieving the page scale after a frame was rendered,
which caused a race when sending mouse events after the page scale was
change but before the next frame was rendered.

This patch listens directly to the page scale changes.

Bug: 826012

Change-Id: I40ea7342f075aacde762a65dda7f71257f584a11
Reviewed-on: https://chromium-review.googlesource.com/969717
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545955}

There was an off-by-one error in parsing escape sequences.

Bug: 825067, 489301
Change-Id: Ic7a99b7c590cc3146b38a35d61e4c980e4e8e9a1
Reviewed-on: https://chromium-review.googlesource.com/981240Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545954}

Previously there was a bug where there was a mismatch of internal states
between the page control and the scroll view.
It is important that they both are synchronized with the same current
page.
This CL fixes the lack of synchronization.

TBR=marq@chromium.org
Bug: 825898

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I284460d9581a05f780057ef53715484254978859
Reviewed-on: https://chromium-review.googlesource.com/981302
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545953}

With this change you can, via a long press, summon the in-use
permissions while in WebVR presentation.

In order to distinguish between the initial state when the
indicators are shown (web-vr-is-good-to-go/no-long-press)
from the state right after releasing the button, we need to
know the previous value in the binding, so I've introduced
a variant of the setter that can be passed the previous
value.

Bug: 825354
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iad5696607e275169353695bb9d58d2b6a925478f
Reviewed-on: https://chromium-review.googlesource.com/978665Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545952}

The [Global] extended IDL attribute is used to mark up types like
Window and WorkerGlobalSope that get special treatment, like attribute
getters exposed as own-properties rather than on the prototype.

This was accidentally applied to a couple of Web Audio interfaces
thanks to the magic of copy/paste and obscure documentation, but was
revealed by new idlharness tests. Yay tests!

Bug: 823431
Change-Id: I1e79a8942e2e6bb9072ac1cf7b5d39ead5f88047
Reviewed-on: https://chromium-review.googlesource.com/969798
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545951}

Startup tracing is broken for several reasons:

1. When renderers are forked from a Zygote process, --trace-startup
   flags are ignored.

2. In a non-zygote mode, when --trace-config-file is used, it is
   ignored since sandboxed renderers do not have access to file
   system.

3. Another bug is that --trace-config-file is always passed to
   renderer processes, even if they are created after tracing is
   stopped, e.g. via DevTools.

4. Startup tracing flags are not passed along to the ppapi plugin
   and utility processes.

This CL fixes 1, 3, and 4 and partially fixes 2 by passing categories
and record mode of a trace config file using flags to sandboxed
renderer processes so that they do not need to ready these information
from a file. Obviously, this does not work for complex trace config
files, but should be enough to resolve existing telemetry issues
(please see discussions in crbug.com/809833).

Bug: 809833
Change-Id: I6723664fd477117262763476c0a86fd6881b94a7
Reviewed-on: https://chromium-review.googlesource.com/972145Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545950}

This patch introduces tests for hanling of "inline-block" and "float" of
|TextIterator| to avoid regression for improving code health.

This patch is a preparation the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Change-Id: I9259afac827cbfdd95a60da7d10c9e0844235e54
Reviewed-on: https://chromium-review.googlesource.com/979748Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545949}

Bug: 648992
Change-Id: Ida40b9d927d851af5d8ba700bfd6a6aeb41281d6
Reviewed-on: https://chromium-review.googlesource.com/977952Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545948}

With crrev.com/c/964984 we always scanout an opaque fb when
we're using legacy KMS.

HardwareDisplayPlaneManager::IsCompatible was still testing
that scanout buffer was compatible using a non opaque format.
This caused issues when we landed crrev.com/c/976961 and
would cause pageflip on samus (RGBA not supported) to fail.

This patch overrides HardwareDisplayPlaneManager::IsCompatible
for the Legacy HardwareDisplayPlaneManager and checks
using the opaque format.

Bug: 821944, b/74997524
Test: samus ui with crrev.com/c/976961 works.
Change-Id: I6fd77ba55832a2d77d1652e81a77f1f0555cffa1
Reviewed-on: https://chromium-review.googlesource.com/981239Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545947}

This is an initial implementation of the integration of Crostini apps
onto the Chrome OS shelf.

With this change, when a Crostini app starts to run, a new shelf item will be added to manage it. The icon will be the default Crostini app icon.

Coming changes will identify specific Crostini apps and use their respective icon when possible.

Design Doc: go/crostini-shelf
BUG=chromium:819444
TEST=Manually tested on an eve device.

Change-Id: Ibe5c731ffd602a493caa49a4928ddeba253a2663
Reviewed-on: https://chromium-review.googlesource.com/965586Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545946}

This reverts commit 4e043583.

Reason for revert: Broke geolocation for NetworkLocationProvider

Original change's description:
> Reland "Move WifiPollingPolicy to a global instance"
> 
> This is a reland of bd9b9ea0
> Original change's description:
> > Move WifiPollingPolicy to a global instance
> > 
> > The WifiPollingPolicy controls how frequently the network location
> > provider will initiate Wi-Fi scans. Previously, the policy was attached
> > to the WifiDataProvider, which is destroyed when there are no active
> > geolocation API calls. Destruction of the provider causes us to lose track
> > of our polling policy.
> > 
> > The policy allows the first scan to be performed immediately and schedules
> > subsequent scans at regular intervals. When the provider is destroyed and
> > recreated rapidly it considers each scan to be "first", which allows many
> > Wi-Fi scans to be performed in a short window.
> > 
> > This change moves the policy state to a global instance so it can be saved
> > when the provider is destroyed and recreated. The new policy allows the
> > first-ever scan to be performed immediately, and subsequent scans may also
> > be performed immediately if enough time has lapsed since the previous scan.
> > In all other situations, the configured polling interval is enforced.
> > 
> > The global policy instance is leaked at shutdown.
> > 
> > BUG=764954
> > 
> > Change-Id: If16c73dfd7d6535346e86d0fab5df24f0c7b297d
> > Reviewed-on: https://chromium-review.googlesource.com/850444
> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#527219}
> 
> Bug: 764954
> Change-Id: I394a671cdbcdb58d6e80c201777465d1d304987b
> Reviewed-on: https://chromium-review.googlesource.com/860778
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528466}

TBR=reillyg@chromium.org,mattreynolds@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 764954
Change-Id: I402e6085d966e4ed0c385515b6edcedb0119bb69
Reviewed-on: https://chromium-review.googlesource.com/978422Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545945}

The operation ("what time is it?") is conceptually const, so make the
method so. Implementations that mutate their state now have such state
expliclty marked as mutable.

This change was inspired by review comments on product code that uses a
TickClock for the sake of testability, in which the reviewers wondered
why a TickClock* class member was not const. Prior to this change, the
answer was "because it can't be". Following this change, the answer can
be "because I forgot to do that. Thanks!"

BUG=none

Change-Id: I813c5359b143c52d86306200ef50eeac4a0003d1
Reviewed-on: https://chromium-review.googlesource.com/980052Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545944}

http://crrev.com/477537 was the last attempt at this, it was
reverted due to perf regressions and an MTBR reduction on YT.
We'll watch this CL closely to ensure it doesn't cause any
similar regressions to the first attempt.

Here are the differences from the last attempt:
- Only offloading 1 extra frame instead of 3.
- No waiting for Reset() to complete (unnecessary).
- GpuMemoryBuffer upload stage is in parallel now.

This behavior only works with decoders that have synchronous
Reset() and Decode() calls, which is all of our software decoders,
but most importantly VpxVideoDecoder, which is the only offloaded
video decoder at the moment.

With this change the total time to read 4000 frames improves by 3x,
from 11659350us to 3427885us and drops zero frames on average when
running at 4K60 with https://www.youtube.com/watch?v=1La4QzGeaaQ

BUG=731841, 801245
TEST=new tests, manual verification.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I20852897044c504088a83434d6bde60104822864
Reviewed-on: https://chromium-review.googlesource.com/945029
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545943}

Bug: 820883
Change-Id: Ia587c6747c6f954802308385676a29420533fa25
Reviewed-on: https://chromium-review.googlesource.com/974662Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545942}

In a followup CL osk_display_manager.* will disappear because the
OnScreenKeyboardDisplayManager implementations will be hung off the
InputMethodWinBase class so that there isn't a singleton but are associated
with a HWND.

BUG=817501

Change-Id: I67123d1080a32d5dc888aa996079dc7512f20ff9
Reviewed-on: https://chromium-review.googlesource.com/978462Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545941}

This mode will only be respected in cases where it is known to be correct. Future
CLs will enable this mode for existing callsites.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id754fdefd35b1ff62e03123acf6f26eaf7fb281b
Reviewed-on: https://chromium-review.googlesource.com/981186
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545940}

Check the FD before attempting to close it, but continue to clear out the
pending translation requests.

Bug: 825971
Change-Id: Ia7f452586b6036b19859ed61d8cdbd74334aa0d4
Reviewed-on: https://chromium-review.googlesource.com/981324Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545939}

Change-Id: Ica95542165846ddf680155f51a86c4651393718d
Reviewed-on: https://chromium-review.googlesource.com/979750Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545938}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I9cfea5cfc14131a6f2b6a2aa853c5fd3252d7781
Reviewed-on: https://chromium-review.googlesource.com/981793Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545937}

We passed the wrong context for Chrome to start activity, so Android
complains about that.

Bug: 808510
Change-Id: I982f1d21cef0feeb3aaf0955fbe5ec6f755dcce9
Reviewed-on: https://chromium-review.googlesource.com/981439Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545936}

This CL adds some tests for PerformanceNavigationTiming
which are involved with service worker.
- SW intercepts a navigation
- SW falls back to network
- Redirect and SW intercepts a navigation

These tests check `workerStart <= fetchStart` because starting
a worker should happen before fetching a resource when service
worker is involved.

Bug: 782958
Change-Id: Idd3fa8f76a328e77ee531b81bd91ee3db223f12c
Reviewed-on: https://chromium-review.googlesource.com/979873
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545935}

Replace NOTIFICATION_BROWSER_WINDOW_READY with
NOTIFICATION_BROWSER_OPENED. While there was a difference
between them at one time, there is no longer any
difference, so simplify.

BUG=268984

Change-Id: I49ee92023508b5e8471f43ae62d40883786894e3
Reviewed-on: https://chromium-review.googlesource.com/979140
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545934}

This patch changes the window title color when the titlebar is painted.
This ensures that the proper contrasting color is picked for both active
and inactive states. The color is also made partially transparent when
the window is inactive.

The end result is that the window title should always be the same color
as the window caption button symbols (unless a theme uses a button
background with the opposite luma of the titlebar).

Bug: 821980
Change-Id: Ib84edf0b9d2bb9415cd293d3683915b9d64b40be
Reviewed-on: https://chromium-review.googlesource.com/979035
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545933}

This updates ios.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a59eb0e91b3813855e79352a6146f4d1410c85a
Reviewed-on: https://chromium-review.googlesource.com/981322Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545932}

and use it everywhere to express keysets.
This CL aims to reduce the risk to pass unexpected values
to InputMethodManager::OverrideKeyboardUrlRef.

- Rename OverrideKeyboardUrlRef to OverrideKeyboardKeyset

This CL addresses the comment in crrev.com/c/950523.

Bug: 819018
Test: No behavior change. Unit tests still pass.
Change-Id: I96139abaa867c91de039113bc9006b72f210be26
Reviewed-on: https://chromium-review.googlesource.com/974668Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545931}

Change-Id: I053cec0b52defc0ff4a6ceeb3f4f7c5efb5fd31d
Reviewed-on: https://chromium-review.googlesource.com/979338
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545930}

The flag is deprecated and replaced by --memlog and co. See
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory/debugging_memory_issues.md#taking-a-heap-dump
for more details.

Bug: 758739
Change-Id: I8f7ac614298334a90103cd5b4c9667468d662845
Reviewed-on: https://chromium-review.googlesource.com/970852Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545929}

R=rsesek@chromium.org
TBR=dcheng@chromium.org

Change-Id: Ib1499f0f5a48a87558ede6aa255be8eb8def7009
Reviewed-on: https://chromium-review.googlesource.com/978371
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545928}

Since Position::Before/AfterNode(text_node) are valid DOM
positions, offset mapping should accept such positions.

This patch ensures it, and also fixes test cases incidentally
passing such positions to offset mapping.

This patch is also preparation for crrev.com/c/974909

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I34aa4f9701d0476c93cbe5155e1b6758ebe8c7db
Reviewed-on: https://chromium-review.googlesource.com/974903Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545927}

Fixed small TODO by tomasz@ to reverse order of entries and parentEntry
in zipSelection() method.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8308cc85c4133e47036abeb02aab2df9002ecb58
Reviewed-on: https://chromium-review.googlesource.com/927901Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545926}

The current implementation was masking error return values, making
all test and executable runs return 0. This lead to waterfall errors
being shown as green/passing.

Bug: 825714
Change-Id: I977faf461fceb5b5cd2d3e8e22d0c0135c77ce71
Reviewed-on: https://chromium-review.googlesource.com/981438Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545925}

When user locks/unlocks screen using the on-screen keyboard, it will
trigger the display metrics change. But at this moment, the snapped
windows become inactivatable which will end the split view mode. We
should not end split view mode in this case.

Bug: 824833
Change-Id: I347caf0624c0683c48bbe44762e7449b8623939a
Reviewed-on: https://chromium-review.googlesource.com/978608Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545924}

The crash was being caused by having the NSView pointer passed back-and-
forth between threads. In the meantime, the NSView had become invalid.
This change ensures that the NSView pointer is always being used in the
same call stack, where we know it must be valid.

Bug: 818679
Change-Id: I5c9e0f9ac9b643785a99defd2041c78d90865208
Reviewed-on: https://chromium-review.googlesource.com/981309Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545923}

BUG=794736

Change-Id: Ie60cd3d4892dc0e641b8e59dee0294fee20fd8ec
Reviewed-on: https://chromium-review.googlesource.com/981242Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545922}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d39e8a4..6e9cb694

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7ef43031f28e31d3a9ee6e870eda6a94c5c54de3
Reviewed-on: https://chromium-review.googlesource.com/980606Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545921}

Even with min size change period of zero black borders are still
possible, so make sure we clip the video frame by content rect
before presenting it to the user. This CL also fixes an issue in
PaintCanvasVideoRenderer where we didn't handle visible rect properly.

Bug: 813929
Change-Id: I59db4caaa2e8751e65801ed5d0b230ddece8d03b
Reviewed-on: https://chromium-review.googlesource.com/974650Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545920}

Add a cached variable for RWHVMac's display::Display.
* Initialize it with the the current key window's display, and
  pass that to BrowserCompositorMac's constructor (and remove
  the equivalent initialization from BrowserCompositorMac).
* Update ui::DisplayLinkMac to use the id from the cached
  display::Display, and move its update code into
  UpdateNSViewAndDisplayProperties (this will usually just be a
  std::map lookup).

Move the display::DisplayObserver implementation from RWHVMac (in
the browser process) to RHWVNSViewBridgeLocal (in the AppShim
process).

Change -[RWHVCocoa updateScreenProperties] to only push a new
display::Display to the RWHVMac when the RWHVCocoa is attached to
a window.

Bug: 821651
Change-Id: Ifeddf82ca9858e7e9185b068094af45425790ad0
Reviewed-on: https://chromium-review.googlesource.com/979119
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545919}

This reverts commit 6dbf08b3.

Reason for revert: Compile failure on linux-chromeos-dbg
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4899

BUG=826101

Original change's description:
> Adds AshAssistantController.
> 
> Bug: b:76028606
> Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276
> Reviewed-on: https://chromium-review.googlesource.com/973551
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Muyuan Li <muyuanli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545908}

TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,muyuanli@chromium.org

Change-Id: Ic33bb5e3efcec6547469999fd42e662529275942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:76028606
Reviewed-on: https://chromium-review.googlesource.com/981464Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545918}

This adds the -theme-with-dark-background class to the html element
instead of the body.

Change-Id: I05fbc726a371de32447934825706d22c97a9edb5
Reviewed-on: https://chromium-review.googlesource.com/981460Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545917}

- Block NaCl plugins from using DEV APIs. No NaCl plugins should depend
  on DEV APIs outside of development scenarios, and since NaCl is being
  deprecated, there is little point allowing them in development
  scenarios now.
- Eliminate support for the DEV permission for NaCl in the renderer.

Bug: chromium:823171
Change-Id: Id39814cfbf11682f9867c96ecfddb24c1c184fd1
Reviewed-on: https://chromium-review.googlesource.com/974655Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545916}