- 26 Nov, 2019 40 commits
-
-
Igor authored
When the user session is stopped, we don't have access to user logs anymore, yet it's important to have information on the reason why the session was stopped. BUG=chromium:1014538 TEST=Check that reason is logged at sign out. Change-Id: I2869b000db5750cafba8566f8d1e13cb1c2369c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871673 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#719068}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9db46c2bd8737240c0ead624b46dcb00ac7affd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935642Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719067}
-
David Munro authored
Bug: chromium:1024718 Test: Build + CQ Change-Id: Icd5642e66beb4512090295e673421b5e002505e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935572 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#719066}
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch prepares for passing a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming. In order to identify a Mojo receiver corresponding to a FetchEvent, ServiceWorkerProviderContext has a map from |request_id| to a pending receiver. This patch adds a method to take a Mojo pending receiver from content::ServiceWorkerProviderContext to blink::ResourceFetcher. It's used to pass Mojo pending receivers to blink::PerformanceResourceTiming in later patches. There are two main changes. 1. A callback and a task runner in content::ServiceWorkerSubresourceLoaderFactory - A Mojo pending receiver to pass entries for workerTiming is stored in content::ServiceWorkerProviderContext when FetchEvent is dispatched from the subresource loader. 2. blink::FetchContext::TakePendingWorkerTimingReceiver() - Eventually blink::ResourceFetcher::HandleLoaderFinish() will take the Mojo pending receiver stored in content::ServiceWorkerProviderContext through blink::FrameFetchContext. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: Idafcfe10fd4c718b063bb26d23309e105dcb1ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909676 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719065}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9181ef6b5abc33cdcebc3d0159b84a6d9434bab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934188Reviewed-by:
-
Tim Schumann authored
This reverts commit 492c7591. Reason for revert: Times out on Win7 tests (dbg) Link to instance: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80319 From the logs: [ RUN ] CleanerSandboxInterface.DeleteService_HandleHeld ../../chrome/chrome_cleaner/engines/broker/cleaner_sandbox_interface_unittest.cc(809): error: Value of: service_handle.StartService() Actual: false (Failed to start 2E684A79ADD8581E0F0A57FB8FBF785B:The service did not respond to the start or control request in a timely fashion. (0x41D)) Expected: true Stack trace: Backtrace: base::debug::StackTrace::StackTrace [0x73FFA092+34] (o:\base\debug\stack_trace.cc:203) StackTraceGetter::CurrentStackTrace [0x0070905A+90] (o:\third_party\googletest\custom\gtest\internal\custom\stack_trace_getter.cc:24) testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0071DDCA+74] (o:\third_party\googletest\src\googletest\src\gtest.cc:820) testing::internal::AssertHelper::operator= [0x0071D93B+75] (o:\third_party\googletest\src\googletest\src\gtest.cc:397) [ FAILED ] CleanerSandboxInterface.DeleteService_HandleHeld (312 ms) Original change's description: > Re-enable DeleteService_HandleHeld test > > crrev.com/c/1919544 is the potential fix for the test. > I have to enable the test to see if it really can fix > the test and then enable more disabled tests. > > Bug: 956016 > Change-Id: I9448cb928edf50e131e8c1c5886e7d26437b0aaa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928129 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718748} TBR=joenotcharles@chromium.org,svenzheng@chromium.org Change-Id: Ie64b3260ce0cefc21a62c9736bc869a120fb7733 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936267Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719063}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLDivElement> and DynamicTo<HTMLDivElement> as new downcast helper 2. Use IsA<HTMLDivElement>(element) in place of IsHTMLDivElement(element) Bug: 891908 Change-Id: Icf2b04b39e87af309a7fc5d66fbd402ae8ed8b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930765Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719062}
-
Tim Schumann authored
This reverts commit 701b32b0. Reason for revert: Breaks Accessibility tests on Win7. Original change's description: > Include raw view elements in UI Automation tree dumps > > While working on tuning which nodes we include in the UI Automation > control and content views, I discovered that our tree dumper was only > dumping nodes in the control view. This CL applies a filter to dump the > raw view, which is a superset of the control view, giving us dumps that > are more complete. > > R=iapres@microsoft.com > > Bug: 1028345 > Change-Id: I98d53285abb77eb8490903f85a2c21e63e1f8c33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935027 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718915} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I6052bbdb112189983433aed93dabf55db8e60cc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028345,1028520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936247Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLDetailsElement>(element) in place of IsHTMLDetailsElement(element) Bug: 891908 Change-Id: Ibb0f5851d3f9649bd542635e88094a64ef4bbac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930764 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719060}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1933836. Remove deprecated ToInternalValue(). Instead, use TimeDelta::InMicroseconds(). Bug: 634507 Change-Id: I23ea205b77b910eee60e122b9374ffd501032be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935968Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#719059}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b29f9faf. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" f5ab855c "Mark external/wpt/cookies/http-state/path-tests.htm as slow test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6ad55ae0a752439e01c87d6d83b3aed8a5669657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935450Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719058}
-
Sergey Talantov authored
Since ContainerView was eliminated here: https://chromium-review.googlesource.com/c/chromium/src/+/1644758, manual call of CreateExampleView is required now. But for extra examples it is not called. BUG=1026180 Change-Id: I891c6099ff742110b62d870236acfcc25039579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926131Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719057}
-
Simon Que authored
Bug: 1025325 Change-Id: I463c52370c8eec7f7fd21a6cb7fa525918c3bb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933830Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#719056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a207daa8b57f..1a549754468c Created with: gclient setdep -r src-internal@1a549754468c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I18d5afafc67c3448b50eae2b93d3b94f4efebe47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936104Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719055}
-
Jeonghee Ahn authored
This patch extend the previous patch below. (https://chromium-review.googlesource.com/c/chromium/src/+/1461355) If an element has a mouseover or mouse enter handler of some sort, There's something for the user to interact with. So it is reasonable to tell it could be focusable element. And this is also related to the patch below. (https://chromium-review.googlesource.com/c/chromium/src/+/1557870) Moving with SpatNav triggers a mouseover event. Conversely, some element having mouseover handler could be focusable. In this patch, element having mouseover or mouseenver event handler can be focusable. Change-Id: I3f338253ab8aa137a7b9fb5f6e35e324b2ee72c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859535 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719054}
-
Tsuyoshi Horo authored
Bug: 1018640 Change-Id: Ic504359898ec4e6b4f7bc18876dafeb0378c192f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930250Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719053}
-
Hajime Hoshi authored
This CL allows pages with media (HTMLMediaElement) to use back-forward cache. Bug: 1024794 Change-Id: Ib6f4835a7835a959d55f036bf6cde0672c7c7a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916522 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#719052}
-
Hans Wennborg authored
This reverts commit 0ff2da3a. Reason for revert: The new warning was reverted upstream (see bug). Original change's description: > Disable -Wdeprecated-copy with tip-of-tree Clang > > while we figure out how to handle this new warning. > > TBR=rnk > > Bug: 1028110 > Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718651} TBR=hans@chromium.org,rnk@chromium.org Change-Id: I0e0babea932ff9ae3fd92530cc96e1c6547429a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935111Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719051}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e7af41224ee..40a7dfc268b6 git log 3e7af41224ee..40a7dfc268b6 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e9b68f332a30..f65b212492ec (10 commits) 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0ec8ef3c..92fe999a (465 commits) 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d44d61514749..f2637d0dd7eb (9 commits) Created with: gclient setdep -r src/third_party/skia@40a7dfc268b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: I6993852ac1cf33c928d214562c0b97cf56583c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719050}
-
Sergio Villar Senin authored
It was used to represent undefined values. We can easily remove it by making time_to_next_iteration_ an Optional<double>. Undefined values are now represented by base::nullopt. Bug: 737867 Change-Id: Ic216b56eb304091ce22b3bb336981c85fb246236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932554Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#719049}
-
liberato@chromium.org authored
This checks to see if |current_buffer_| has been cleared in DoDecode while looping over it. I don't see any path that would clear it without breaking out of that loop, except possibly for the reentrant DoDecode call in ReceivePictureBuffersFromClient. The trouble is that I don't believe that call can be reached without at least one post. If this fixes the problem, then more investigation is needed. Bug: 1012464 Change-Id: I72a7ad5e42c0ff2490831cbf4ac0bb62808c0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935862 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719048}
-
Jiewei Qian authored
Bug: 1021813 Change-Id: If28794060de32f58ce1a4dcae811dc914c99cf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921596 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719047}
-
Yoshifumi Inoue authored
This patch markes http/tests/devtools/storage-panel-dom-storage-update.js as slow test. Tbr: yosin@chromium.org Bug: 1027439 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I77b4b10dbd0b03c6333b70bf4ea8a6e75f0f35cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935638Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719046}
-
Jaeyong Bae authored
FrameSelection::ComputeAbsoluteBounds() is a generic API that computes the geometries of the selection anchor and focus. This function is called at every frame update, and can be a source of page slowness on large pages, since it computes the selection bounds from scratch every time it's called. To avoid duplicate computation and improve page performance, we can cache the results of ComputeAbsoluteBounds() in FrameSelection. The design document link: https://docs.google.com/document/d/1jtQpbJw9046lXJYMosIHOm0KLiQZMAeTooYgRGu_LrM/edit?ts=5dd4d6e8# Bug: 671593 Change-Id: If4153ae4f79856d29ccc35bd0012fb8b7fe5e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894666Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#719045}
-
Yoshifumi Inoue authored
This patch markes http/tests/devtools/a11y-axe-core/changes/changes-a11y-test.js as slow test. Tbr: yosin@chromium.org Bug: 1028478 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id9c1ff58de958c63eba76365b9ce792e80bc7ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935637Reviewed-by:
-
Francois Beaufort authored
This CL makes sure a NullPointerException is not fired when reading a record that is not handled yet by Web NFC. Bug: 520391 Change-Id: I3325816db121cd03829d9d414ae67343d716a37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932787Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#719043}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ad2608d39418..1f0fda29b7e8 git log ad2608d39418..1f0fda29b7e8 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 dberris@chromium.org Pinpoint: Use polymer-bundler when deploying Created with: gclient setdep -r src/third_party/catapult@1f0fda29b7e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I5abeb5668fcc2bf4ab96f47c5f0b8f8cb10fa0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936092Reviewed-by:
-
Yoshifumi Inoue authored
This patch markes jssourcemap-navigator-overlapping-sources.js as slow test. Tbr: yosin@chromium.org Bug: 1028479 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic3175af6df33225094f1de90ae4744a4fdd927fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935974Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTableSectionElement> and DynamicTo<HTMLTableSectionElement> as new downcast helper 2. Use IsA<HTMLTableSectionElement>(element) in place of IsHTMLTableSectionElement(element) Bug: 891908 Change-Id: I9713c7fdfdbbb57f0b8919efa8cd03b333710fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928343Reviewed-by: -
Timothy Loh authored
This CL updates the Plugin VM installer so that ChromeVox users can get updates to the labels (title, message, download progress and time left). Bug: 1021414 Change-Id: I4e80b95ceb232bb68327ee296da07054a2464aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935295Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719039}
-
Austin Tankiang authored
It's disabled in the toolbar [1] so disable it in quickview too. [1]: https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/task_controller.js?l=342&rcl=f5ab855ceb5c1237e29ff96f687357a0017d373a Bug: 983969 Change-Id: I334ddc578a7d95f640455f30d4ab46242bab132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935776 Commit-Queue: Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f50b090b72d4..a207daa8b57f Created with: gclient setdep -r src-internal@a207daa8b57f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: Ie631d2a1ed44ccab52b4e476e982d49fcae54c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935864Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: If3ba6d86527b39f405db74f0ddeea0862deb0c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928344Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |create_time_|, |frame_id_|, and relevant functions from ServiceWorkerContainerHost to ServiceWorkerProviderHost. For |render_process_id_|, it's kept as |worker_process_id_| in ServiceWorkerProviderHost, while ServiceWorkerContainerHost also has |process_id_| after this CL. This is because it should be natural that ServiceWorkerProviderHost (to be renamed to ServiceWorkerHost) has the identifier of the process where a service worker execution context lives. For example, this is used when handling mojo connection requests for Web API (e.g., CreateQuicTransportConnector()). Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I86b2ff93ecc44e001018d101a456bb938cff7dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935274Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719035}
-
Yoshifumi Inoue authored
This patch markes external/wpt/css/cssom/idlharness.html as slow test. Tbr: yosin@chromium.org Bug: 1028482 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I4a16f628b3b3e9d3f70dc97300f822ba624c4aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935579Reviewed-by:
-
Luciano Pacheco authored
Bug: 1028465 Fixed: 1028465 Change-Id: I1f6e4b60666ee130b6c02e25ed79e9c65da3bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935971 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements a C++14 version of C++17's std::as_const and makes use of it in a few //base classes. Bug: 752720 Change-Id: Ie3e525dc719e3cf579650ce50b018da82ad80c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932438Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#719032}
-
Yoshifumi Inoue authored
This reverts commit edc475ed. Reason for revert: Causes compilation failure: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8895755054118235408/+/steps/compile/0/stdout ../../clank/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderForQ.java:26: error: method does not override or implement a method from a supertype @Override ^ Original change's description: > Upstreaming ContentCapture > > Related downstream change: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 > > Binary-Size: all added code was from downstream, the size increase is expected. > Bug: 951275 > Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Tao Bai <michaelbai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718894} TBR=michaelbai@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org Change-Id: Id904c28aa48d561ccea36942da1f507982a698dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935578Reviewed-by:
-
Dominic Mazzoni authored
In http://crrev.com/c/1873964, I introduced a change that auto-focuses links when they get accessibility focus. This accidentally triggered re-focusing when you scroll the page, making it impossible to scroll because it keeps scrolling the focused node back into view. The fix is simple, just don't try to focus the link again if it's already focused. Bug: 1021918, 657157 Change-Id: If9d2a3a5e58cf4344d3b61f2e6c59da3bbad1257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917325Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719030}
-
Yoshifumi Inoue authored
This patch markes http/tests/devtools/sources/debugger/navigator-view.js as flaky test. Bug: 1028482 Tbr: einbinder@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I03ccd69f5e61ac8cd08a48efcef9c8fc86313f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935777Reviewed-by:
-
