GitLab

BUG=123402

Review URL: http://codereview.chromium.org/10105001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132470 0039d316-1c4b-4281-b951-d872f2087c98

[cros] Add Ctrl+Alt+E shortcut to Welcome/EULA screen that cancels update and starts with enrollment

Also fixes couple of style errors in display_manager.js + renamed virtual members.

BUG=121010
TEST=Manual.


Review URL: http://codereview.chromium.org/10096012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132469 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org,csharp@chromium.org
BUG=122214
TEST=Drag, switch to new pane, drop on original nav dot. Drop on newly created
pane. Nothing should asplode.


Review URL: http://codereview.chromium.org/10068001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132468 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122233
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132465 0039d316-1c4b-4281-b951-d872f2087c98

1326: ninja windows: fix wrappers not outputting with newlines
1327: Support for freebsd 9
1328: mac make/ninja: Add limited support for OTHER_CPLUSPLUSFLAGS.
1329, 1330: Temporarily accept strings as OTHER_CPLUSPLUSFLAGS

BUG=none
TEST=none
TBR=scottmg

Review URL: http://codereview.chromium.org/10107001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132464 0039d316-1c4b-4281-b951-d872f2087c98

New expected results for four tests need to be committed in WebKit.

BUG=119667
TEST=WebM tests in LayoutTests/media/W3C/video/canPlayType/ now say "probably" or "maybe".


Review URL: http://codereview.chromium.org/9969061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132463 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132462 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132461 0039d316-1c4b-4281-b951-d872f2087c98

Also remove several disabled tests that are now covered by unit tests.

BUG=85294
TEST=


Review URL: http://codereview.chromium.org/10081021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123428
TEST=none


Review URL: http://codereview.chromium.org/10080018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132459 0039d316-1c4b-4281-b951-d872f2087c98

We have to wait until handler's extension host loads before we can setup file access permissions
with ChilsProcessSecurityPolicy.
We can't get the extensions host process id before that.

BUG=chromium-os:29475
TEST=*FileBrowser*

Review URL: https://chromiumcodereview.appspot.com/10067021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132458 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10104001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119662
TEST=updated unittests, ran Chrome and verified SB functionality on new profile


Review URL: http://codereview.chromium.org/10069031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132456 0039d316-1c4b-4281-b951-d872f2087c98

This change causes the syncer to exit from its download then commit
function if the download fails.  This helps prevent the creation of
server-side conflicts, which would be more likely to happen if a
download failed but the following commit succeeded.

The main changes are as follows:
- Rather than proceed to the next step when a download updates failure
  is detected, the syncer will exit.  This should cause the
SyncScheduler to schedule a retry at a later time.  
- The definition of a download updates failure is now based on the
  return code of the download attempt, rather than checking the contents
of the (possible non-existent) returned protobuf.  This makes the error
detection logic used here more closely match the logic used to decide
whether or not to schedule retries.

This implementation has a side-effect on configure sync cycles.  The old
behaviour was to handle failures by applying whatever updates we had
downloaded at that point.  The new behaviour will leave updates
unapplied if any error occurs.  This better matches a nearby comment's
assertion which states that we should not attempt to apply updates until
we have downloaded all of them.  I believe the author of that comment
would approve of this change.

This change moves around some of the ExtensionActivityMonitor logic.
It's important that we not take the data from the extensions acitivity
monitor at the start of the cycle.  Restoring that data is handled in
the commit building and response code, which might not be executed if we
need to break out early.  This also fixes issue 123270.

Most of the diffs for this change are concentrated in the unit tests:
- Expose more of the SyncScheduler to the SyncerTest test harness.
- Add functions to SyncerTest for testing specific types of sync jobs.
- Add some functions that allow us to better control failures in
MockConnectionManager.
- Added tests for configure job success and failure.
- Added tests for update then commit job success and failure.
- Removed some redundant tests.

BUG=122033,123270
TEST=sync_unit_tests, specifically:
SyncerTest.UpdateThenCommit,
SyncerTest.UpdateFailsThenDontCommit,
SyncerTest.ConfigureDownloadsTwoBatchesSuccess,
SyncerTest.ConfigureFailsDontApplyUpdates

Review URL: http://codereview.chromium.org/10006046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=On KIOSK Chrome OS device, check that device-level proxy is mandatory.


Review URL: http://codereview.chromium.org/10097007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132450 0039d316-1c4b-4281-b951-d872f2087c98

Moved NOTIFICATION_TAB_ADDED, NOTIFICATION_TAB_PARENTED, and NOTIFICATION_TAB_CLOSING. Turned NOTIFICATION_TAB_CLOSED into NOTIFICATION_WEB_CONTENTS_DESTROYED.

BUG=76698
TEST=none


Review URL: http://codereview.chromium.org/10079023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10091005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132447 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10094015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110794
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10105002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10097003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118255
TEST=Open the internet details dialog for a WiFi connection.  Verify that the ip configuration is shown on the connection tab.  The contents of the old WiFi and network tabs have been merged for WiFi connections.


Review URL: http://codereview.chromium.org/10073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132442 0039d316-1c4b-4281-b951-d872f2087c98

load, so they can do whatever cleanup is necessary.

BUG=119620
TEST=no
TBR=arv

Review URL: https://chromiumcodereview.appspot.com/10082019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117407
TEST=


Review URL: http://codereview.chromium.org/10031002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132440 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10084030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9972014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123381
TEST=Try to install a blacklisted extension. The error message and the log detail the extension name and id.


Review URL: http://codereview.chromium.org/10097014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/10094010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132436 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10067023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132435 0039d316-1c4b-4281-b951-d872f2087c98

TBR=laforge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132432 0039d316-1c4b-4281-b951-d872f2087c98

browsing_data.BrowsingDataTest.testClearCookies
databases.DatabasesTest.testDeleteAndUpdateDatabase

BUG=123419
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9969184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132431 0039d316-1c4b-4281-b951-d872f2087c98

Also rename the 'refs' parameter to 'callbacks' to make the code a little bit
more clear, since 'refs' was only used to store callback information.

Matt noticed this bug after I landed 
https://chromiumcodereview.appspot.com/10054039/

It turns out the the rest of the JSON compiler infrastructure doesn't actually
support arrays of functions, but at least the IDL will generate the right JSON
in this case. 

BUG=none
TEST=included unit test should pass

Review URL: http://codereview.chromium.org/10080014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132429 0039d316-1c4b-4281-b951-d872f2087c98

Remove unused empty SpdyFrameBuilder constructor.


Review URL: http://codereview.chromium.org/10053029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132428 0039d316-1c4b-4281-b951-d872f2087c98

That way, the action reruns if pkg-dmg (called from the
build_app_dmg shell script) is touched.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10073026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132426 0039d316-1c4b-4281-b951-d872f2087c98

1.) Remove `set -x`
2.) Explicitly add '.dmg' extension to output, so pkg-dmg no longer
    warns about adding this implicitly
3.) Pass '--verbosity 0' to pkg-dmg to tell it to print only errors

If build_app_dmg needs to be debugged, it's easy to undo 1 and 3.
There's no need to have all this output on every single build.

BUG=none
TEST=`ninja all` has 38 lines less output.


Review URL: http://codereview.chromium.org/10073020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132424 0039d316-1c4b-4281-b951-d872f2087c98

This increased over 2% gradually over the last 950 revisions, without
clear culprit:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl2/report.html?history=950&rev=132408
Review URL: https://chromiumcodereview.appspot.com/10095019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132423 0039d316-1c4b-4281-b951-d872f2087c98

The save dialog, when viewed in the expanded mode, will show the 'Hide Extension'
checkbox with this change. This will apply to all save dialogs. Note that this
checkbox is only visible if Finder's 'Show all extensions' settings is turned
OFF.

I don't see any downside to having this checkbox available. Other apps that
appear to always enable this checkbox: Safari, Mail, TextEdit.

BUG=123118
TEST=Save a web-page, expand window, 'Hide Extension' checkbox should be visible.
Review URL: https://chromiumcodereview.appspot.com/10082016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132422 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10097001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132421 0039d316-1c4b-4281-b951-d872f2087c98