- 27 Nov, 2019 40 commits
-
-
Aga Wronska authored
Wrapper creates an abstraction layer and takes care of types conversion and data filtering, so it is not spread around per-app time limits code. Bug: 1015658 Test: AppServiceWrapperTest Change-Id: Iae04ea99e05f9495b70117e425374223e8583919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938567 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719734}
-
Natalie Chouinard authored
Move all classes under org.chromium.chrome.browser.preferences which are related to Android settings screens (rather than the underlying preferences persistence layers) to org.chromium.chrome.browser.settings instead. This disambiguation was decided in go/clank-preferences-refactor. Dependent downstream change: https://crrev.com/i/2222930 TBR=tedchoc@chromium.org NOPRESUBMIT=true Binary-Size: Keeping existing method name, see crrev.com/c/1935716 Bug: 1027271 Change-Id: I961a7b13ab0911503ee0e9a59fc267436bebbe90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938467Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#719733}
-
chrome://flagsDemetrios Papadopoulos authored
Bug: 720034 Change-Id: I5042226a6269b3d60884cdc92ba554c2aaacaf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940555 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719732}
-
Joe DeBlasio authored
This CL updates the cases in which mixed content download blocking will dump without crashing by excluding now-known cases where initiators are missing. These include downloads from webview/cct, internally-initiated downloads and user-initiated downloads of offline pages. It also silences dumps from a not-yet-understood situation where seemingly-normal downloads don't have initiators. The stack trace isn't helping in this case, so crash dumps aren't useful. Bug: 1029003 Change-Id: I77102e361d334e847331f5e0bc1b9ce5321ab4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940723 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719731}
-
Livvie Lin authored
Bug: 1027626 Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719730}
-
Carlos Knippschild authored
TBR=fgorski@chromium.org Bug: 1025251 Change-Id: I9034302de26f8be776045fdb3714da29fed5da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940867Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719729}
-
Devlin Cronin authored
The only remaining method of DeferredStartRenderHostObserver, OnDeferredStartRenderHostDidStopFirstLoad(), is only used in tests by a class that monitors ExtensionHost loads. Move this method to ExtensionHostObserver (and rename it OnExtensionHostDidStopFirstLoad()), and fully remove DeferredStartRenderFrameHostObserver. Bug: 1028334 Change-Id: I33afa64dd95ccc54903e99dc68c903818e6ef82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937357 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719728}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/7e8ae0dee24d..f54082a0145f $ git log 7e8ae0dee..f54082a01 --date=short --no-merges --format='%ad %ae %s' 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core (but not subdirectories). 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core/http. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in a few tests. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/quartc. 2019-11-26 dschinazi Deprecate quic_version_negotiation_grease 2019-11-26 dschinazi Deprecate quic_enable_version_49 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ib9a68a549f96a69c07686a06ef23dd6ec6928c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940753 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719727}
-
danakj authored
These Closures are all called more than once when WebContentsObserver events occur, so they are made to be RepeatingClosures. TBR=clamy@chromium.org Bug: 953861, 1007763 Change-Id: Idc328b2091b839151d0503ca518e50be50d71203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940357Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719726}
-
Andrew Luo authored
Bug: 1019521 Change-Id: I2074e8178214487c7677b45bd647ffc0191e1a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938450Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719725}
-
Ender authored
This reverts commit a59a4ff3. Reason for revert: Code crashes with following assertion: java.lang.AssertionError: Paint should be initialized when the search engine is Google. at org.chromium.chrome.browser.omnibox.status.StatusView.setStatusIcon(StatusView.java:343) Consulted Brandon and reverting this change as we agreed. We'll reland it when he's back. Original change's description: > Visually scale down the size of the Google G logo in the omnibox > > Bug: 1020774 > Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718931} TBR=twellington@chromium.org,wylieb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1020774 Change-Id: I858a8f362898af35de2b255af960029f64894373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940720Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719724}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/126d7a263625..4d6c84bf8985 git log 126d7a263625..4d6c84bf8985 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4d6c84bf8985 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I574439fbada47c3cdc499465e1d26b6b2768db09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719723}
-
Liquan (Max) Gu authored
Currently, the layout of Payment Handler toolbar has a layout issue. The title and the security icon has no padding between them and their container. As sheet_tab_toolbar is shared between Payment Handler toolbar and Ephemeral Tab toolbar, the Ephemeral Tab toolbar has been test-run to ensure looking normal. Bug: 1027713 Change-Id: I624ab42a0494b715ac2d5789704e95548d2eda9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940558Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719722}
-
Kelvin Jiang authored
Bug: 1017934 Change-Id: If9fe54ca0ca7b137c6a51187d9b81a7f37387d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937780 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719721}
-
Asanka Herath authored
Removes some no-op code. Bug: 927182 Change-Id: I295a0e9f3b166a1c204d053af9f86acb3917a5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938710Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#719720}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2613cb5e3a21..8a6dcf76315c git log 2613cb5e3a21..8a6dcf76315c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sugoi@google.com Support sample image instruction operand Created with: gclient setdep -r src/third_party/swiftshader@8a6dcf76315c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/135265531 Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c2110445a3f4c4f01828322cca979f1b09aec8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940544Reviewed-by:
-
weiliangc authored
For builder Linux FYI Release (AMD R7 240). BUG=1028639 TBR=cwallez@chromium.org Change-Id: Ib2113fc2825cd683d31ebd909316b90fa7bbfa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940808Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Auto-Submit: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719718}
-
Matt Mueller authored
This allows NetLog to safely be used from worker threads that are not joined on shutdown. It already was a leaked object in Chromium and in Cronet on Android (but not on Cronet iOS). Moves ownership of the global object into net_log.cc and adds NetLog::Get() to access it, and makes ~NetLog destructor private so that code can't accidentally create local NetLog objects. Tests can create a local NetLog with the TestNetLog class. Tests that only needed an NetLog incidentally but don't actually observe/test it are changed to use the global NetLog::Get(). Bug: 177538 Change-Id: I12a832801c108483db5b1a577c1094e7d2ceb3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912696Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719717}
-
David Benjamin authored
There were also two places where custom HttpResponses could just use one of the built-in ones. Bug: 1007815 Change-Id: I97dad08849c1ca0db04b200c2168ba4ff5939e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880529 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#719716}
-
Bo Liu authored
The expected though surprising behavior is that history API does not trigger onPageStarted or onPageFinished. Bug: 1027165 Change-Id: I26163f98fe87184719d5ca4e195d5577496c5b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940747 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719715}
-
Toby Huang authored
When the "Permissions for sites and apps" toggle in Chrome family dashboard is disabled, we should prevent child users from installing new extensions and approving additional permissions for existing extensions. This CL focuses on preventing child users from granting approval for additional permissions. When the toggle is disabled, pref kSupervisedUserExtensionsMayRequestPermissions becomes false, and this is used to implement the desired effects in this CL. Bug: 1018956 Change-Id: I492e9ffa2b5b4c923160c54aebbbc8a5622849a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929032Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719714}
-
Peter Kasting authored
For X11 this likely doesn't matter, as in practice NativeThemeGtk::GetColor() will probably override everything. For the increased contrast theme supplier, someday we probably want to replace this with better platform-native high contrast support on the platforms that use it, but for now, it doesn't make sense to disable incognito default colors in most cases; the code in question was only intended to apply to custom themes. This _does_ still apply "force non-incognito" to autogenerated themes, since these should basically work "like custom themes" as much as possible. If we wanted, we could likely change this by ensuring the autogenerator overrides everything necessary. I don't have a strong opinion. This is primarily a set-up change for fixing bug 621004, by exposing a method that we'll also use to control "disable dark mode". Bug: 621004 Change-Id: I6375cea9ae88d56a02c212258caf3b647af30585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938569 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#719713}
-
Asanka Herath authored
Renames auth_sspi to mechanism_. Separating this out before some more refactors come down the pipe. Bug: 927182 Change-Id: I8f4a5133ae296db742460b97a1dc5aa88221ef6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938709Reviewed-by:
-
John Abd-El-Malek authored
This only seemed to come up on Windows debug and not other desktop platforms, possibly related to timing. The user-data-dir override wasn't set on desktop and so tests in parallel shared a data directory. Bug: 1026523 Change-Id: Ifddf92266e63a2742c8806aabbf9c0dbdb94d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940718 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719711}
-
Daniel Murphy authored
R=enne@chromium.org Bug: 1024966 Change-Id: I8f7f1f31434668c1cdaadb07d0ee7ec3606b2b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924920 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719710}
-
Kevin McNee authored
In NavigationControllerImpl::NavigateFromFrameProxy, there is a check that prevents replacement if there are no existing entries. However, this is only done for the browser's NavigationEntry. The original value provided by the caller is used for the navigation request. The renderer sees the initial navigation being done with replacement which causes it to DCHECK in RenderFrameImpl::UpdateNavigationHistory. We now prevent replacement for the navigation request to be consistent with the navigation entry. Bug: 1029036 Change-Id: I34ee5bc0b4b9c44c531f2b70fba24133eba23064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877129 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719709}
-
Peter Kasting authored
Mostly gives clearer names to autogenerated theme functions. Some small comment tweak, ordering changes, and code shortening. Bug: none Change-Id: Id4237b208cbd07e2a61b2cb419102b5a7b241908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938461Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5fdb4933. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I20724e9152708ff5e9047252640ff46a0208e886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940130Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719707}
-
behdad authored
TBR=sadrul@chromium.org Bug: chromium:953895 Change-Id: Ibcdddad6fc8caed13e09482afc9ca23f816a544d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940590Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719706}
-
Matthew Mourgos authored
Bug: 1028796 Change-Id: I2172c998551a220d58b1658972f7c6137b19fb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937992Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719705}
-
Alan Screen authored
Cleanup triggered by review https://crrev.com/c/1935724. Multiple PrintPreview.* metrics are marked as obsolete 07/2019 and identified to expire after M77. One of these, PrintPreview.PageCount.Initial, was auto-extended [1] based on frequent use and did not get removed from the code even though it is marked as obsolete. Restore the expires_after value to M77 for this (to be like its sibling metrics) and remove the code which uses it. [1] https://crrev.com/c/1769095 Bug: 1028104 Change-Id: Ib62cde06466173f85d8c7e2a786512c5bee9843d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936110Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Matthew Mourgos authored
- Shelf opacity is now different in clamshell vs. tablet mode. In clamshell mode opacity is 74%. In Tablet mode opacity is 60%. - Overview shelf will now show the default shelf color unless in tablet mode with hotseat enabled where it will be completely opaque. - Blur is correctly shown in tablet home launcher when hotseat is disabled. Bug: 1027344 Change-Id: Idce2a471750bf6a14df97302e64956c888372dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935788Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51bd3fe58ca0..c4c0786bd310 git log 51bd3fe58ca0..c4c0786bd310 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tvanderlippe@chromium.org Fix race-condition with CodeMirror syntax highlighting Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4c0786bd310 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029037 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9110427bf12b2344fb6634934f9942f402521c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940545Reviewed-by:
-
Carlos IL authored
This CL prevents an extra report from being created when showing an interstitial for a bad subresource, which caused reporting to break for subresource triggered committed interstitials. This also re-enables the test for this behavior. Bug: 1024015 Change-Id: I0bd601a2adfc70dc46ca34d5de0518f26dce4932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913709 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719701}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40fb0777..cf59b855 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I64a44237e6721f9d54b7de349e73dd1d63e1c4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940131Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719700}
-
Bettina authored
Prioritize commonly spoofed popular domains for saved password warnings. In the password protection warning dialog, the domains that the saved passwords are associated with will be listed. We should create a default domain list that will be used if the saved passwords is associated with it. Bug: 1026898 Change-Id: I6f15bd9c1557a5217663ac6a9ebef80c7d0be650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929921 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#719699}
-
John Abd-El-Malek authored
Change-Id: Id7cf7144b55ebd133d93916eb12de6194c6f912e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938836Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719698}
-
Avery Musbach authored
When you switch from clamshell mode to tablet mode, only windows on the primary display shall be eligible to carry over to split view. Otherwise there is blatantly broken behavior and system instability. Bug: 1024294 Change-Id: I91cc3678e12523e9097115718c8b125e22a0e0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938037 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719697}
-
Vasilii Sukhanov authored
- the core logic of leak detection now checks 'Safe Browsing' except on iOS - the desktop UI is updated. SB off disables "Extended SB" toggle as well as leak detection. Bug: 1028095 Change-Id: Id00f485e27f02503342b37d78e3dea3a81c2a086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936293 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#719696}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74d4bf9893fc..b6148c3af63e git log 74d4bf9893fc..b6148c3af63e --date=short --first-parent --format='%ad %ae %s' 2019-11-27 lehoangq@gmail.com Metal: re-enable end2end tests Created with: gclient setdep -r src/third_party/angle@b6148c3af63e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ia55b627b7c532ee18a7fd1011f2f966c9cbe543c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940541Reviewed-by:
-
