GitLab

The problem was that ShowWindow that was eventually called through PlatformViewportWin::Show wasn't working because it was using the default from STARTUPINFO which was false.

Review URL: https://codereview.chromium.org/1106133002

Cr-Commit-Position: refs/heads/master@{#327048}

Previous reverted CL is here (https://codereview.chromium.org/1080723002/) and the first patch set also corresponds to it.

The problem for revert was in profile_io_data.cc file because of initiating two preferences for Android. The kMetricsReportingEnabled was introduced for future consolidation of two preferences. I have removed the initialization for kMetricsReportingEnabled which shouldn't change the behavior as the metrics service is still using kCrashReportingEnabled and Android side updates both preferences.

Rest of the code is not changed and corresponds to the version that was LGTM-ed before.

BUG=455847

TBR=dfalcantara@chromium.org,nyquist@chromium.org

Review URL: https://codereview.chromium.org/1058433007

Cr-Commit-Position: refs/heads/master@{#327047}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/778f653..0aae7c8

TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1109783002

Cr-Commit-Position: refs/heads/master@{#327046}

BUG=

Review URL: https://codereview.chromium.org/1110553002

Cr-Commit-Position: refs/heads/master@{#327045}

Upon a FrameTreeNode destruction a speculative RenderFrameHost might
be swapped-out instead of being destroyed along with the node. This
behavior differs from the current navigation implementation and was
causing a leak of a RenderFrameProxyHost.

This change adds a CHECK to stop the leak the same way
RenderFrameHostManager::SwapOutOldFrame does.

BUG=439423

Review URL: https://codereview.chromium.org/1066823004

Cr-Commit-Position: refs/heads/master@{#327044}

-Fixed Enterprise Enrollment window size
-Added autocomplete option to the offline login
-Added default domain "gmail.com" on offline login when user do not enter domain
-gaia-core-icon-button does not have box-shadow when it is hovered

BUG=480449,479128,478453,478452

Review URL: https://codereview.chromium.org/1110493002

Cr-Commit-Position: refs/heads/master@{#327043}

resources in installer gyp files.

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001

for details

BUG=

Review URL: https://codereview.chromium.org/1109523002

Cr-Commit-Position: refs/heads/master@{#327042}

BUG=481127

Review URL: https://codereview.chromium.org/1106173002

Cr-Commit-Position: refs/heads/master@{#327041}

BUG=481029
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/1105123002

Cr-Commit-Position: refs/heads/master@{#327040}

https://chromium.googlesource.com/angle/angle/+log/ad0a486b..2cb7b835

BUG=None

Review URL: https://codereview.chromium.org/1106053002

Cr-Commit-Position: refs/heads/master@{#327039}

Rename methods and members and const variables from "alternate protocol" to
"alternative service":

* alternate_protocol_probability_threshold_ to
  alternative_service_probability_threshold_ in HttpServerPropertiesImpl,
* switches::kAlternateProtocolProbabilityThreshold to
  switches::kAlternativeServiceProbabilityThreshold,
* test names in IOThreadTest,
* SetAlternateProtocolProbabilityThreshold() to
  SetAlternativeServiceProbabilityThreshold(),
* GetAlternateProtocolProbabilityThreshold() to
  GetAlternativeServiceProbabilityThreshold(),
* remove obsolete force-alt-protocols from comments in io_thread.cc,
* "Alternate Protocol" to "Alternative Service" in NetInternals user facing
  QUIC page,
* alternate_protocol_probability_threshold to
  alternative_service_probability_threshold in IOThread::Globals and
  HttpNetworkSession::Params.

BUG=392575

Review URL: https://codereview.chromium.org/1091283007

Cr-Commit-Position: refs/heads/master@{#327038}

This patch enables the code injection for
<webview>.addContentScript/removeContentScript API.

This is the third patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

BUG=461052

Review URL: https://codereview.chromium.org/1058113002

Cr-Commit-Position: refs/heads/master@{#327037}

BUG=479246

Review URL: https://codereview.chromium.org/1093923005

Cr-Commit-Position: refs/heads/master@{#327036}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1899651..6a307ba

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1104133003

Cr-Commit-Position: refs/heads/master@{#327035}

We now pull it via WebLayerTreeView::layerTreeId.

BUG=480980
TBR=kbr

Review URL: https://codereview.chromium.org/1110543002

Cr-Commit-Position: refs/heads/master@{#327034}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2544c1b..778f653

TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1105103002

Cr-Commit-Position: refs/heads/master@{#327033}

BUG=477678

Review URL: https://codereview.chromium.org/1084423002

Cr-Commit-Position: refs/heads/master@{#327032}

Cr-Commit-Position: refs/heads/master@{#327031}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c0ece44..2544c1b

TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1105053002

Cr-Commit-Position: refs/heads/master@{#327030}

force_spdy_always and force_spdy_over_ssl were obsoleted in
https://crrev.com/1075623002, they should be removed from the net-internals
page.

BUG=480916
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1053613005

Cr-Commit-Position: refs/heads/master@{#327029}

Review URL: https://codereview.chromium.org/1100953002

Cr-Commit-Position: refs/heads/master@{#327028}

This should reduce cycle time difference between linux_chromium_asan_rel
and linux_chromium_asan_rel_ng .

BUG=387743

Review URL: https://codereview.chromium.org/1104983002

Cr-Commit-Position: refs/heads/master@{#327027}

All problematic dependencies of TopSitesImpl have been removed, thus
move the file into //components/history/core/browser.

BUG=479174

Review URL: https://codereview.chromium.org/1099303003

Cr-Commit-Position: refs/heads/master@{#327026}

All call sites can deal with the blocking pool tasks continuing during shutdown, which means we don't have to block shutdown for them.

BUG=481491

Review URL: https://codereview.chromium.org/1104643003

Cr-Commit-Position: refs/heads/master@{#327025}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/992f946..c0ece44

TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1110463002

Cr-Commit-Position: refs/heads/master@{#327024}

PrefSelect must inherit from HTMLSelectElement, otherwise it will be
broken when the DOM attributes are moved to prototype chains.

Note that HTMLSelectElement does NOT inherit from HTMLInputElement, so
it's simply wrong that PrefSelect inherits from HTMLInputElement.

BUG=43394

Review URL: https://codereview.chromium.org/1061263004

Cr-Commit-Position: refs/heads/master@{#327023}

This is a fixed version of https://codereview.chromium.org/1094273003/,
that was reverted due to a global const std:string.

BUG=479673

Review URL: https://codereview.chromium.org/1102093002

Cr-Commit-Position: refs/heads/master@{#327022}

Revert of Flip extension background page throttling on by default (patchset #2 id:20001 of https://codereview.chromium.org/1106653002/)

Reason for revert:
Speculative revert - multiple browser_tests fail on Mac10.9 Tests (dbg)
http://goo.gl/4AqhVG

Original issue's description:
> Flip extension background page throttling on by default
>
> R=kalman
> BUG=424661
>
> Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd
> Cr-Commit-Position: refs/heads/master@{#326953}

TBR=kalman@chromium.org,oysteine@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=424661

Review URL: https://codereview.chromium.org/1106953002

Cr-Commit-Position: refs/heads/master@{#327021}

Flip the Switch!

Also, re-order a rule in the new system to fix a test.
Also, cleanup the test.

BUG=398257,478634

Review URL: https://codereview.chromium.org/1106613005

Cr-Commit-Position: refs/heads/master@{#327020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4333faa..992f946

TBR=

Review URL: https://codereview.chromium.org/1102223003

Cr-Commit-Position: refs/heads/master@{#327019}

Revert of ozone: Add ability to set clinet capabilities which we will need for atomic (patchset #2 id:20001 of https://codereview.chromium.org/1100803004/)

Reason for revert:
Speculative revert - Linux ChromiumOS Ozone Tests is broken.
http://goo.gl/vykWsG

Original issue's description:
> ozone: Add ability to set client capabilities which we will need for atomic
>
> Committed: https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713
> Cr-Commit-Position: refs/heads/master@{#326860}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1104013002

Cr-Commit-Position: refs/heads/master@{#327018}

When these tests fail, they time out after a long preriod of time instead of stopping when there's an error.

The specific error case I was hitting was that my camera didn't support the highest resolution. The error is to be expected given my configuration, but there's no need to wait for a timeout.

R=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1061473002

Cr-Commit-Position: refs/heads/master@{#327017}

Revert of ozone: Add sync flag for atomic commit (patchset #2 id:20001 of https://codereview.chromium.org/1099713005/)

Reason for revert:
Speculative revert - Linux ChromiumOS Ozone Tests is broken.
http://goo.gl/vykWsG

Related to https://codereview.chromium.org/1100803004/

Original issue's description:
> ozone: Add sync flag for atomic commit and page flip event handling
>
> Committed: https://crrev.com/f7553583492a8ea9a54d75cd6b2d3dd83c94512c
> Cr-Commit-Position: refs/heads/master@{#326863}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1098093005

Cr-Commit-Position: refs/heads/master@{#327016}

Removed LOAD_FROM_CACHE_IF_OFFLINE flag and related test cases.

BUG=426442

Review URL: https://codereview.chromium.org/1080673004

Cr-Commit-Position: refs/heads/master@{#327015}

Remove dependency on //chrome/browser/history/history_utils.h by
injecting the CanAddURLToHistory function (via a base::Callback)
into TopSitesImpl.

BUG=479174

Review URL: https://codereview.chromium.org/1100763002

Cr-Commit-Position: refs/heads/master@{#327014}

The --auto-select-desktop-capture-source flag is quite useful for
testing since tools like Selenium generally can't interact with dialogs
we pop up in the browser. It is implemented for aura-using platforms
like Linux, CrOS and Windows and this patch adds it for Mac too.

BUG=475372

Review URL: https://codereview.chromium.org/1084913002

Cr-Commit-Position: refs/heads/master@{#327013}

Revert of Evict Service Worker when reading it from disk cache fails. (patchset #2 id:20001 of https://codereview.chromium.org/1098083003/)

Reason for revert:
Broke Win 8 Aura content_browsertests

[ RUN      ] ServiceWorkerVersionBrowserTest.ReadResourceFailure
...
[2420:2792:0426/232049:1965296:FATAL:service_worker_registration.cc(44)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on Unknown Thread.
Backtrace:
	base::debug::StackTrace::StackTrace [0x07FB1081+33]
	logging::LogMessage::~LogMessage [0x07FFD9FF+63]
	content::ServiceWorkerRegistration::~ServiceWorkerRegistration [0x045639F5+293]
	content::ServiceWorkerRegistration::`scalar deleting destructor' [0x006A087A+26]
	base::RefCounted\u003Ccontent::ServiceWorkerRegistration>::Release [0x0372C3D2+114]
	scoped_refptr\u003Ccontent::ServiceWorkerRegistration>::Release [0x03D8F94E+14]

http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/29227/steps/content_browsertests/logs/ServiceWorkerVersionBrowserTest.ReadResourceFailure

Original issue's description:
> Evict Service Worker when reading it from disk cache fails.
>
> If reading the SW resources from the disk cache fails, we should evict
> the worker or else we will keep getting the same failure.
>
> This patch unsets the worker from the live registration, and then
> deletes the registration if the SW was the stored version.
>
> BUG=448003
>
> Committed: https://crrev.com/64e3ffb1c6b85c7d21e63afcbffe85c5a1112eb7
> Cr-Commit-Position: refs/heads/master@{#327000}

TBR=nhiroki@chromium.org,kinuko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448003

Review URL: https://codereview.chromium.org/1056913010

Cr-Commit-Position: refs/heads/master@{#327012}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d23c38..1899651

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1102223002

Cr-Commit-Position: refs/heads/master@{#327011}

This ensures that the PDF title will be truncated with ellipses if it is
too long, rather than pushing out the other controls to the right. Also
URL decode the title to remove ugly encoded characters.

BUG=439114

Review URL: https://codereview.chromium.org/1090313003

Cr-Commit-Position: refs/heads/master@{#327010}

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/1103113002

Cr-Commit-Position: refs/heads/master@{#327009}