- 31 Aug, 2016 40 commits
-
-
zengster authored
Review-Url: https://codereview.chromium.org/2293923005 Cr-Commit-Position: refs/heads/master@{#415640}
-
dtapuska authored
It doesn't make sense to wait arbitrary for touch events that are blocking. So make them appear as non-continuous events. BUG=625693 Review-Url: https://codereview.chromium.org/2296693003 Cr-Commit-Position: refs/heads/master@{#415639}
-
mmoroz authored
Usage of 'chromeos_with_codecs' mixin, that adds target_os="chromeos", leads to loosing of 36 active and 3 disabled fuzzers. This CL doesn't lead to loosing of any fuzzers and also brings back those 36 and 3 fuzzers. R=aizatsky@chromium.org, dalecurtis@chromium.org, dpranke@chromium.org, inferno@chromium.org BUG=638935 Review-Url: https://codereview.chromium.org/2291123006 Cr-Commit-Position: refs/heads/master@{#415638}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/7e7ef3dd60a8..87dffc031547 $ git log 7e7ef3dd6..87dffc031 --date=short --no-merges --format='%ad %ae %s' 2016-08-31 dsinclair Free the GifPlainText object when complete. BUG=638499 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2296183002 Cr-Commit-Position: refs/heads/master@{#415637}
-
jonross authored
MenuButton rejects openning new menus when a reposted event arrives too close to the closing time of the menu. However this calculation was based on menus always being synchronous. Updating MenuButton to set the closed time based on the pressed state being decremented to 0. This works for both synchronous and async menus. TEST=manual testing of translate bubble, and other menu buttons, views_unittests BUG=642254 Review-Url: https://codereview.chromium.org/2299443002 Cr-Commit-Position: refs/heads/master@{#415636}
-
rob.buis authored
BUG=402536 Review-Url: https://codereview.chromium.org/2239303003 Cr-Commit-Position: refs/heads/master@{#415635}
-
csharrison authored
This patch adds initialization for blink fuzzers that need the full unit test environment, as well as a simple fuzzer for the CSS tokenizer + parser. BUG=642570,642572 Review-Url: https://codereview.chromium.org/2274563002 Cr-Commit-Position: refs/heads/master@{#415634}
-
mkwst authored
As discussed in https://github.com/w3c/webappsec-csp/issues/98, this patch prevents execution of script via a nonce if an attribute named "<script" or "<style" is present, or if an attribute's value contains "<script" or "<style". That is, given `script-src 'nonce-abc'`, the following will execute: <script nonce=abc> // yay </script> But the following will not: <script <script nonce=abc> // yay </script> <script attribute="<script" nonce=abc> // yay </script> <script <style nonce=abc> // yay </script> <script attribute="<style" nonce=abc> // yay </script> Let's see if this is web-compatible, shall we? This patch locks the new behavior behind the experimental flag, and adds metrics that should help us understand what the real-world impact would be. BUG=639293 Review-Url: https://codereview.chromium.org/2260103003 Cr-Commit-Position: refs/heads/master@{#415633}
-
ulan authored
Revert of [BotHealth] Disable v8.infinite_scroll benchmarks on Windows (patchset #1 id:1 of https://codereview.chromium.org/2256853002/ ) Reason for revert: Re-enabling the benchmarks since the failure does not reproduce locally at TOT. Original issue's description: > [BotHealth] Disable v8.infinite_scroll benchmarks on Windows > > BUG=638724 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/11ba3bbd5819de5705c63a5c9df639bcbaa38c71 > Cr-Commit-Position: refs/heads/master@{#412704} TBR=fmeawad@chromium.org,eakuefner@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638724 Review-Url: https://codereview.chromium.org/2300613002 Cr-Commit-Position: refs/heads/master@{#415632}
-
rogerm authored
BUG=620414, 640669 Review-Url: https://codereview.chromium.org/2279543003 Cr-Commit-Position: refs/heads/master@{#415631}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/299d5acf..051fb8c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2294223003 Cr-Commit-Position: refs/heads/master@{#415630}
-
boliu authored
Normal destroy already calls removeCallbacksAndMessages. This Cl covers when the CleanupReference runs before the java side is garbage collected. Add a test for this, and stop this test suite repeating since they are only unit tests. Review-Url: https://codereview.chromium.org/2292393002 Cr-Commit-Position: refs/heads/master@{#415629}
-
glebl authored
The rebaseline bot failed to rebase tests for https://crrev.com/409303 and only updated TestExpectations. This patch marks all those tests as NeedsManualRebaseline. BUG=642668 NOTRY=true Review-Url: https://codereview.chromium.org/2294293002 Cr-Commit-Position: refs/heads/master@{#415628}
-
battre authored
Revert of Disallow non-namespaced use of base::Version. (patchset #2 id:40001 of https://codereview.chromium.org/2261523006/ ) Reason for revert: Mac builders fail. See http://crbug.com/639416#c11 Original issue's description: > Disallow non-namespaced use of base::Version. > > BUG=639416 > > Committed: https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 > Cr-Commit-Position: refs/heads/master@{#415626} TBR=thakis@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639416 Review-Url: https://codereview.chromium.org/2296703005 Cr-Commit-Position: refs/heads/master@{#415627}
-
pwnall authored
BUG=639416 Review-Url: https://codereview.chromium.org/2261523006 Cr-Commit-Position: refs/heads/master@{#415626}
-
nednguyen authored
This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/578e20909005..fa2c4f21907f $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) Review-Url: https://codereview.chromium.org/2300623002 Cr-Commit-Position: refs/heads/master@{#415625}
-
estevenson authored
Using gcc_compile_wrapper.py unconditionally is inefficient and makes debugging more difficult. This is problematic since resource whitelisting occurs relatively infrequently. BUG=642498 Review-Url: https://codereview.chromium.org/2296033002 Cr-Commit-Position: refs/heads/master@{#415624}
-
cathiechen authored
COMMAND_PREFIX and COMMAND_SUFFIX should be used simultaneously BUG= Review-Url: https://codereview.chromium.org/2295103002 Cr-Commit-Position: refs/heads/master@{#415623}
-
vabr authored
PasswordFormManager::ProcessMatches currently happily accepts credentials from PasswordStore with a different PasswordForm::Scheme than the observed form has. However, it still has a DCHECK against it later (in the Autofill* methods), so it is clearly not expecting these, rather than mixing the schemes being by design. And it should not be by design. Especially, if the saved credential is a non-HTML one, and should be filled in a HTML form. Mixing them makes the non-HTML credential vulnerable against (injected attacker's) JavaScript accessing them. This CL filters out credentials with non-matching scheme from the batch coming from the PasswordStore. Given the absence of DCHECKs in release builds, this actually changes the behaviour for Chrome users, but the change is a desired one. BUG=640897 Review-Url: https://codereview.chromium.org/2298733002 Cr-Commit-Position: refs/heads/master@{#415622}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/3ee255f25954..272b311298d7 $ git log 3ee255f25..272b31129 --date=short --no-merges --format='%ad %ae %s' 2016-08-31 mtklein GN: forgot Clang+ccache fix on Android. And sort. 2016-08-31 mtklein GN: add sources_when_disabled to optional CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2300603002 Cr-Commit-Position: refs/heads/master@{#415621}
-
battre authored
BUG=642482 TBR=stanisc@chromium.org,nick@chromium.org Review-Url: https://codereview.chromium.org/2294113003 Cr-Commit-Position: refs/heads/master@{#415620}
-
tkent authored
This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG=642320 Review-Url: https://codereview.chromium.org/2295083002 Cr-Commit-Position: refs/heads/master@{#415619}
-
tyoshino authored
morrita@ has been inactive for 1+ year. To make reviewer selection work smoothly, remove morrita@ for now. R=mkwst BUG=none Review-Url: https://codereview.chromium.org/2274043002 Cr-Commit-Position: refs/heads/master@{#415618}
-
grunell authored
Accessing |max_render_time_| under |lock_| in Stop(). It's already accessed under the lock in the other place. BUG=641339 Review-Url: https://codereview.chromium.org/2292053002 Cr-Commit-Position: refs/heads/master@{#415617}
-
tzik authored
This CL adds a clang tool to rewrite unneeded scoped_refptr<>::get, and applies it to //base. To build and apply this tool, run below: $ ./tools/clang/scripts/update.py --force-local-build --without-android --tools base_bind_rewriter $ ./tools/clang/scripts/run_tool.py --regenerate-compdb base_bind_rewriters out/Release base Review-Url: https://codereview.chromium.org/2283003002 Cr-Commit-Position: refs/heads/master@{#415616}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1336315..299d5acf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2297733003 Cr-Commit-Position: refs/heads/master@{#415615}
-
msramek authored
The current implementation allows filtering for one origin. The GURL->bool filter that is nowadays used by BrowsingDataRemover allows specifying whitelists or blacklists of multiple URLs (typically entire origins). TBR=droger@chromium.org BUG=589586 Review-Url: https://codereview.chromium.org/2289853002 Cr-Commit-Position: refs/heads/master@{#415614}
-
tzik authored
When an IgnoreResult is passed as a rvalue-reference, Bind impl has passed the target functor as a lvalue-reference. That causes a compile failure when the target functor can be run via rvalue-reference only. This CL changes IgnoreResult handling in base::Bind impl, so that it uses rvalue-reference functor when IgnoreResult itself is passed as a rvalue-reference. BUG=554299 Review-Url: https://codereview.chromium.org/2298133003 Cr-Commit-Position: refs/heads/master@{#415613}
-
battre authored
Revert of All DCP manager tests that enroll/register are tested with all auths. (patchset #7 id:120001 of https://codereview.chromium.org/2287343004/ ) Reason for revert: Reverting due to use after free. See http://crbug.com/624187#c28 Original issue's description: > All DCP manager tests that enroll/register are tested with all auths. > > Use a FakeSigningService in the DeviceCloudPolicyInitializer in order > to be able to unit test re-enrollment for locked devices when > registering with a certificate. > > BUG=624187,641447 > TEST=unit_tests > > Committed: https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d > Cr-Commit-Position: refs/heads/master@{#415574} TBR=pastarmovj@chromium.org,drcrash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624187,641447 Review-Url: https://codereview.chromium.org/2302443002 Cr-Commit-Position: refs/heads/master@{#415612}
-
ricea authored
Some arguments to the PerformanceResourceTiming::create() methods have m_ prefixes, which makes them look like class members. Remove the m_ prefixes to reduce confusion. R=ksakamoto@chromium.org BUG= TEST=compiled Review-Url: https://codereview.chromium.org/2284323002 Cr-Commit-Position: refs/heads/master@{#415611}
-
sfiera authored
Review-Url: https://codereview.chromium.org/2297903004 Cr-Commit-Position: refs/heads/master@{#415610}
-
vitaliii authored
This CL adds ClearHistory() to ContentSuggestionsService and its providers, which is called when the history is removed using Clear Browsing Data dialog, so that the providers can remove their history. BUG=641321 Review-Url: https://codereview.chromium.org/2284393002 Cr-Commit-Position: refs/heads/master@{#415609}
-
zqzhang authored
BUG=642361 Review-Url: https://codereview.chromium.org/2291163002 Cr-Commit-Position: refs/heads/master@{#415608}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/8b4eaefc8859cf67683a5fa2e558b27e7c48dbfd Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/3a98a0a38287c090976ffd2f0cd47d12ba21b2d3 Add dart/packages recipe, and builders using it. (whesse@google.com) depot_tools: https://crrev.com/6d3c290164360907fe08784093e36314069e689f It's time to bring subprocess42 to depot_tools. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=635641 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2294243002 Cr-Commit-Position: refs/heads/master@{#415607}
-
pkalinnikov authored
Move the implementation of GURL::DomainIs into a shared function in url_util/, to be used both by GURL and url::Origin. The reason for this refactoring is to reap significant performance gains in scenarios where previously url::Origins had to be converted to GURLs for DomainIs checks. This involved string copying, allocations, and parsing the entire URL once again. BUG=517560 Review-Url: https://codereview.chromium.org/2287483002 Cr-Commit-Position: refs/heads/master@{#415606}
-
ellyjones authored
BUG=603176 Review-Url: https://codereview.chromium.org/2292233002 Cr-Commit-Position: refs/heads/master@{#415605}
-
tkent authored
- Use symbols consistent with operator<< for PositionAnchorType. - Add offset only if OffsetInAnchor The output of PositionTemplate::showTreeForThis() is changed: BODY * #text ... offset, offset:9 to BODY * #text ... offsetInAnchor[9] - printPosition() uses toAnchorTypeAndOffsetString(). The output of printPosition for OffsetInAnchor is changed: #text "..."@9 to #text "..."@offsetInAnchor[9] This CL doesn't affect production. Review-Url: https://codereview.chromium.org/2296863003 Cr-Commit-Position: refs/heads/master@{#415604}
-
olivierrobin authored
BUG=527059 TBR=mef, droger Review-Url: https://codereview.chromium.org/2291033003 Cr-Commit-Position: refs/heads/master@{#415603}
-
hiroshige authored
They are unused after https://codereview.chromium.org/2253853002/ and thus this CL removes them from MemoryCache::TypeStatistic and WebCache::ResourceTypeStat. This CL also fixes compile errors when MEMORY_CACHE_STATS is enabled. BUG=603791 Review-Url: https://codereview.chromium.org/2254593003 Cr-Commit-Position: refs/heads/master@{#415602}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/0f93d7965 BUG=637811 TBR=robhogan@gmail.com Review URL: https://codereview.chromium.org/2298713002 . Cr-Commit-Position: refs/heads/master@{#415601}
-