- 09 Mar, 2018 40 commits
-
-
Xi Han authored
ServiceManager may need to launch child processes before a BrowserMainLoop has been created, and therefore before any BrowserThreads exists. We therefore replace the BrowserThread::PROCESS_LAUNCHER with a global TaskScheduler sequence, created on-demand when the ServiceManager or ChildProcessLauncherHelper first need it. Under Windows we must use a single-thread TaskRunner, while on other platforms we are able to use a normal TaskScheduler sequence. File crbug.com/820200 to track that. Bug: 815225 Change-Id: Ia0f46461fb9cc92fddacf81ee96b764de8477d11 Reviewed-on: https://chromium-review.googlesource.com/941264 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542212}
-
Xianzhu Wang authored
Animated images may change before invalidation. For example, an image with SVG animation gets ImageChanged notification periodically but a paint triggered by some other change may not just follow an invalidation of the animated image. Bug: 819683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5acb3eedc0ac714a600ac6df752dc22245bf3d1d Reviewed-on: https://chromium-review.googlesource.com/956303 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542211}
-
https://pdfium.googlesource.com/pdfium.git/+log/3baef5c6daf5..69da36c5f841 $ git log 3baef5c6d..69da36c5f --date=short --no-merges --format='%ad %ae %s' 2018-03-09 rharrison Explicitly mark helper methods that only operate on ASCII ranges Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I111e9f1393101c60788b1cf62523606b3d233a42 Reviewed-on: https://chromium-review.googlesource.com/957313 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542210}
-
Luc Ferron authored
Bug: 820419 Tbr: kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd95ec218a700b7a9a6e34336f4ddee5442f8b02 Reviewed-on: https://chromium-review.googlesource.com/956116Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Luc Ferron <lucferron@chromium.org> Cr-Commit-Position: refs/heads/master@{#542209}
-
Katie D authored
Bug: 820373 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I992efd466f5bcb7f20c0b4045be91b9d0f3704c8 Reviewed-on: https://chromium-review.googlesource.com/956699 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542208}
-
wutao authored
This cl revises some Keyboard Shortcut Viewer (KSV) strings based on the feedback from TC. Bug: b/74114276, b/74085777, b/74086686, b/74114046 Test: Wait TC to verify. Change-Id: Idb1a6a3695af135ed6a146c58f7048abfbcc4618 Reviewed-on: https://chromium-review.googlesource.com/956607Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542207}
-
https://chromium.googlesource.com/catapult.git/+log/b90b97cf8dec..e490e96cd7f3 $ git log b90b97cf8..e490e96cd --date=short --no-merges --format='%ad %ae %s' 2018-03-08 dtu [dashboard] Add api_auth.Email() function. 2018-03-08 dtu [pinpoint] Delete extraneous patch argument when trying a patch. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I5e184099e83aa7a3aa66bbd528b9a7e36afaa948 Reviewed-on: https://chromium-review.googlesource.com/957311 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542206}
-
Qiang Xu authored
Changes: OnDisplayConfigurationChanged could not distinguish the case of swapping primary display. We now bind a callback in OnDisplayAdded ( it is called on reconnecting, leaving dock mode, exiting mirror mode) and run the callback in OnDisplayConfigurationChanged. Bug: 805046 Test: tested on device and added test coverage Change-Id: I332c9d368e9df4fc5630317902f2776eab5dc983 Reviewed-on: https://chromium-review.googlesource.com/956928Reviewed-by:
-
Charles Harrison authored
Bug: None Change-Id: I18438a934cecdb22a4586aee0ccd92db55ff08de Reviewed-on: https://chromium-review.googlesource.com/947746Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#542204}
-
rbpotter authored
Many webpages use window.print() immediately followed by window.close() in JS. This means that the renderer and web contents are torn down while the PDF is still being converted for the printer on Windows. However, the web contents are not needed if the full PDF document has already been rendered, so the PrintViewManager should just release the query and allow conversion and spooling to complete instead of cancelling the job. The CL to send the Print Preview PDF directly to the PrintViewManager broke this for users that use Print Preview because we no longer store an extra copy of the web contents in the BackgroundPrintingManager. This has been broken if using the system dialog since M64 or earlier. Bug: 820105 Change-Id: I308adba43b3604509275f6c0f2946545b94dd1d5 Reviewed-on: https://chromium-review.googlesource.com/956257 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#542203}
-
Dominic Mazzoni authored
The bounding box highlighted by assistive technology like ZoomText is wrong if the display resolution is not set to 100%. BUG=812892,820298 Change-Id: Id488583666c5e01e7aaed5ade7a5a3faeff900cd Reviewed-on: https://chromium-review.googlesource.com/955545 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542202}
-
Ryan Landay authored
I have a series of CLs in progress to allow StackLayout to support more than two tab stacks. This CL contains the necessary updates to the geometry logic. After this CL (and the preceding ones), the only thing keeping StackLayout from displaying more than two tab stacks is that a lot of the logic is hard coded to always show all normal tabs in one stack and all incognito tabs in another. I will split much of StackLayout into a base class in a future CL to allow creating variants with different behavior. When we display two tab stacks, we use asymmetric margins: we put one tab stack up against the edge of the screen (with a small border added by the Stack itself), and show the edge of the other tab stack on the other side. This CL does not change the behavior for this case. For three or more stacks, the behavior I'm going with for now is to make the margins symmetric. So no matter which stack is focused, we show the current tab centered, with the edge of a neighboring tab showing on either side if present, or a blank margin on that side otherwise. Bug: 648314 Change-Id: I383d9601f521a2eec47263f219027bc23818b3e2 Reviewed-on: https://chromium-review.googlesource.com/940613 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542201}
-
Sheng-Hao Tsao authored
This CL adds 2 things to JEA interface. 1. Exif. Currently HW JEA only encodes the image with APP0 JFIF segment. After this CL, it accepts Exif buffer and would insert the APP1 segment if Exif buffer is provided. 2. IPC compatibility. IPC from ChromeOS side relies on the buffer ID to identify the encoded results. The ID of VideoFrame is generated randomly at Chromium side which ChromeOS doesn't know. The CL changes JEA interface to use output buffer ID to identify each encode attemp. BUG=819847 TEST=Verified that JEA can be used from ChromeOS side with Exif buffer. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I87f13a435f9875999ca79dd5769fb925a9c59fb8 Reviewed-on: https://chromium-review.googlesource.com/954411 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542200}
-
Min Qin authored
This feature is currently defined in content/. This Cl moves it to components/download to remove download dependency on content/. BUG=803135 Change-Id: Iabbc34eff56554722d4aa7bde1f461135984ac74 Reviewed-on: https://chromium-review.googlesource.com/955899 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542199}
-
lgcheng authored
Since ArcAppDialg is no longer parented to AppList anymore, remove checks for parent widget. Also remove related test expectations. Bug: 820293 Test: Pass browser_test Change-Id: Iea0732ea329e6552ddb30c557dcc9575821a0394 Reviewed-on: https://chromium-review.googlesource.com/956666 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#542198}
-
Morten Stenshorne authored
Rename the method to PositionEmptyChildWithParentBfc(), and make it a const method. Also get rid of unused and unimplemented PositionWithBfcOffset(const NGBfcOffset&). Also some fixes in comments and parameter names, and added some comments on my own. Moved a DCHECK(is_empty_block) to also hit when PositionEmptyChildWithParentBfc(), just to be clear about the fact that the block has to be empty at this point. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7d171aa40d3f3a5705f7a0126725a7905d37c504 Reviewed-on: https://chromium-review.googlesource.com/955645Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542197}
-
erikchen authored
memory_instrumentation is the source of truth for memory metrics. It provides private_memory_footprint, a cross-platform consistent memory metric. The previous implementation exposed working_set and committed - Windows specific measurements, and phys_footprint - a macOS specific measurement. This CL replaces those metrics with private_memory_footprint. The only place these numbers are used is to generate a log string, used by the feedback system and the OOM reporting system. Change-Id: If39c626605f70e18e6044c7f1d2f0f1a8ce5562a Bug: 819289 Reviewed-on: https://chromium-review.googlesource.com/951754Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542196}
-
Michael Giuffrida authored
This is a reland of 65478d12 with Aura-specific tests moved to a subclass and #ifdef. Original change's description: > AppShell: Support reloading > > Implement reloading in ExtensionLoader. Uses keep-alives while apps are > reloading. A future CL will observe these keep-alives to keep app_shell open > during reload. > > Bug: 762642 > Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf > Reviewed-on: https://chromium-review.googlesource.com/912694 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540079} Bug: 762642 Change-Id: I6c516c4736ca2327965e034d10717341e23303dc Reviewed-on: https://chromium-review.googlesource.com/950342 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542195}
-
Ahmed Fakhry authored
BUG=805267 Change-Id: I39a7b31ad3f796cd059bafece3fa851da3e25049 Reviewed-on: https://chromium-review.googlesource.com/954066 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542194}
-
Hongchan Choi authored
TBR=sky@chromium.org Bug: 820390 Change-Id: I78d8234c0fe394fbe2bfe5bb424d0b2b30f87b9e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/957362Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542193}
-
https://webrtc.googlesource.com/src.git/+log/5a98049f6abe..a5aa68b73f1d $ git log 5a98049f6..a5aa68b73 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc942c1ecf8de3f8d08ec1aad4600c65af1d4f1d Reviewed-on: https://chromium-review.googlesource.com/956416 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542192}
-
Marijn Kruisselbrink authored
The typemap defines this as nullable_is_same_type, but without a SetToNull method that will result in runtime failures if null is actually passed. Bug: none Change-Id: Ife6427121c9f424ab8a2a0c52798f1806b650880 Reviewed-on: https://chromium-review.googlesource.com/956418Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542191}
-
Sean O'Brien authored
If an event from libevdev includes a MSC_TIMESTAMP field, send that timestamp to the gesture library. This field will be used by the gesture library because it has more accurate time deltas than CLOCK_MONOTONIC. BUG=b:65041115 TEST=Tested manually on lux and eve, using CL:742488 and CL:938751. MSC_TIMESTAMP is passed to gesture library if available. Change-Id: I05e5a6615e10d33bd0e290b6bb8ff11c2f05f2fc Reviewed-on: https://chromium-review.googlesource.com/817979Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#542190}
-
Alexey Kozyatinskiy authored
+ as bonus fixed a bug when we did not restore breakpoints active state after profiling. R=dgozman@chromium.org Bug: chromium:812438 Change-Id: Ie01262416522d26e8b328bcbce7387fc0a097db7 Reviewed-on: https://chromium-review.googlesource.com/953131 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Matt Menke authored
This will let use remove the use of URLRequestContextGetters in the NetworkService, and also let us adjust URLLoaderFactory lifetime to so that it lives as long as it has a live URLLoader, so it can own shared objects. Bug: 803149 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7028886f9df671530ee9863f80dc437adc20cdfb Reviewed-on: https://chromium-review.googlesource.com/952342Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542188}
-
Dominic Mazzoni authored
When the caret bounds are updated in RenderWidgetHostViewAura, we need to convert from DIP to screen pixels, just like in HWNDMessageHandler. TBR=kenrb@chromium.org Bug: 812892 Change-Id: I0797c5b2ed85349b85d90ac3fe5b2e4f21775fe0 Reviewed-on: https://chromium-review.googlesource.com/956540 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Calder Kitagawa authored
EquivalenceMap pruning in PruneEquivalencesAndSortBySource() and Prune() can truncate Equivalence size to 0. The previous logic was parsimonious in that it avoids moving an Equivalence's start boundary if its size was shrunken to 0. However, this is problematic. For example, truncating sorted Equivalences ********** ********* ** ****** yields ********** ** | <= Empty *** Note that now intervals are no longer sorted. This was an invariant property expected by the DCHECKS(). A better solution is to revert to etiennep@'s original implementation that moves start boundary of nullified Equivalences, and e.g., get: ********** ** | <= Empty *** Change-Id: I9b5d08cba88867ffff1df5592b91980136e2b331 Reviewed-on: https://chromium-review.googlesource.com/957202 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542186}
-
kristipark authored
Mac: Fix flaky NTP browser test where the expected NTP url changes depending on network connectivity If chrome://newtab/ maps to a remote url, it fails to load in a browser_test environment and instead redirects to the local NTP, which changes the url associated with WebContents. The NTP check in the app controller should be replaced once crbug.com/624410 is fixed. Bug: 817328 Change-Id: If17b93d3cafa194cfa5f433d3a422108a5181394 Reviewed-on: https://chromium-review.googlesource.com/954418 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542185}
-
Scott Violet authored
Using 'dispatch' is mildly confusing given the class doesn't really handle dispatch. BUG=none TEST=none Change-Id: I20f858d924d0a68efb2e449fd0ab3140ef5ffa54 Reviewed-on: https://chromium-review.googlesource.com/956496 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
- Adjust the alignment of the avatar icon in Touchable Chrome to follow the specs. - Draw a circular 1px stroke around the avatar with the same color as that of the tab separator stroke. - Refactor and gather some common code. BUG=805267 Change-Id: I2be3181232cd43724f71b899de7905869b003360 Reviewed-on: https://chromium-review.googlesource.com/956809 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Jared Saul authored
Update waterfall testing config to remove AutofillUpstreamSendDetectedValues and AutofillGooglePayBranding field trials, as both are launched to 100% and enabled at ToT Change-Id: I1fa15d595bd0d593611f25d1edbbed7c0412b2f0 Reviewed-on: https://chromium-review.googlesource.com/956100Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#542182}
-
Ryan Landay authored
I have a series of CLs in progress to allow StackLayout to support more than two tab stacks. This CL contains easy generalizations (e.g. adding loops) of existing logic that currently assumes there will always be exactly two tab stacks. Updating the geometry logic is more involved, so I will do that in a separate CL. Bug: 648314 Change-Id: I8613cdd5ec345dfa868d992575c5d8d560ca5b04 Reviewed-on: https://chromium-review.googlesource.com/940570Reviewed-by:
-
Mark Pilgrim authored
update to https://chromium-review.googlesource.com/c/chromium/src/+/884063 Bug: 773295 Change-Id: Iba3ea07f19034bf9a1ea2c75876cac5d28297486 Reviewed-on: https://chromium-review.googlesource.com/956291Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542180}
-
David Reveman authored
Monitor the root window instead of the aura env to determine when frame sink holder must be cleaned up. It's too late to cleanup the holder when aura is being shutdown. Bug: 814908 Test: Close chrome while fast ink view is visible. Change-Id: Ia807c9469d791e4d8d4973711cf904592bc05471 Reviewed-on: https://chromium-review.googlesource.com/957222Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542179}
-
yiyix authored
Added the missing unit to metrics in Compositing.SurfaceAggregator.SurfaceDrawQuad.*. Bug: 814909 Change-Id: Id140c4ddf3cdfc606de6373c586273f7d3a9f144 Reviewed-on: https://chromium-review.googlesource.com/956885Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#542178}
-
Alex Moshchuk authored
The test recently starting timing out on the bots, most likely because it was taking too long. It might've become too slow after r529904 added more code to it (coverage for downloads). This CL breaks up the latter addition into its own test. Bug: 806684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183 Reviewed-on: https://chromium-review.googlesource.com/944570 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
3dfddc05 changed this interface but did not update the MacViews implementation. TBR=aleventhal@chromium.org Bug: None Change-Id: Ic71d4160b6ffe3b09cfcfafc9de9b175974a2054 Reviewed-on: https://chromium-review.googlesource.com/956844Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542176}
-
Yury Khmel authored
This shares rule that force ToS not to be shown Bug: b/74258485 Test: Manually Change-Id: I1f15e9a6edfc238cc03f6d086c5bd519eabb0bc3 Reviewed-on: https://chromium-review.googlesource.com/951979 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542175}
-
https://pdfium.googlesource.com/pdfium.git/+log/5a7e330ef5e0..3baef5c6daf5 $ git log 5a7e330ef..3baef5c6d --date=short --no-merges --format='%ad %ae %s' 2018-03-09 dsinclair Remove unused methods from CPDF_DefaultAppearance Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4dedb94b6a909cc2e752696e426e98163081524e Reviewed-on: https://chromium-review.googlesource.com/956691Reviewed-by:
-
Chong Zhang authored
This CL: 1. Replaced |URLRequestInterceptor| usages with |embedded_test_server()| as the former is not supported in NetworkService. 2. Introduced |DownloadManager::Observer::OnDownloadDropped()| which is called when the download manager intercepted a download navigation but didn't create a download item. 3. Removed the following test cases from the filter: -DevToolsDownloadContentTest.MultiDownload -DevToolsDownloadContentTest.DefaultDownload -DevToolsDownloadContentTest.ResetDownloadState -DevToolsDownloadContentTest.DownloadCancelled -DevToolsDownloadContentTest.DeniedDownload -DevToolsDownloadContentTest.DefaultDownloadHeadless -DevToolsDownloadContentTest.SingleDownload Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9da96982ea8b5d0b4848f438a1f3a5bd8418dd72 Reviewed-on: https://chromium-review.googlesource.com/956560Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
