GitLab

Some jumbo builds broke because of too many CappedSizeInKB so moving
it to heap.h to unbreak the builds. It's a small inlined method.
The moved function is not using std::min to avoid including
<algorithm> in heap.h and potentially causing a measurable
build time regression.

TBR=mlippautz@chromium.org,haraken@chromium.org

Bug: 840789
Change-Id: I4e4bf3989235c6e7274a56f5c10823d8bb37a4df
Reviewed-on: https://chromium-review.googlesource.com/1090839Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#565289}

Fixing crbug.com/847501 and adding two regression tests for it.

Added SchedulerWorker::GetLastUsedTime() to support this fix and re-used
it to suppress the need for the delegate's |is_on_idle_worker_stack_|.

Tweaked WaitForWorkersCleanedUpForTesting() to allow being called
multiple times.

R=fdoray@chromium.org

Bug: 847501
Change-Id: I83f814358f679bdbee49778963ff9d05cd240adc
Reviewed-on: https://chromium-review.googlesource.com/1086978
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565288}

This change adds logic to BackgroundFetch Context to observe service
worker events, specifically, unregistration, and wiping of SW database,
and implements logic for the unregistration case.

It also adds a small unit test to verify the appropriate error code is
returned when the service worker is unregistered mid-fetch.

Bug: 841385
Change-Id: I0a22489ce79bbffb7a5528c8646522c40e59a799
Reviewed-on: https://chromium-review.googlesource.com/1071651
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565287}

This change adds rounded focus rings to the location icon button and to page
action buttons.

Bug: 848299
Change-Id: I06b501b664315ad615d334fee23149854550bd06
Reviewed-on: https://chromium-review.googlesource.com/1080889Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565286}

These tests mix use of QuitCurrent*Deprecated() with use of the current
RunLoop::Quit*Closure() model. Migrate them off the deprecated API so
that we can enforce quit-by-closure-only wherever QuitClosure is used.

Bug: 844016
Change-Id: Ib93c6419a81642a3d374ec08a3c71ddaacc3cb88
Reviewed-on: https://chromium-review.googlesource.com/1090211Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565285}

For ChromeCast screen reader, getDesktop is needed rather
than enableTab.  This creates an automation tree for all
running cast apps.  Added accessor for window tree host
to the accessibility manager.

Bug: b/73383411
Test: None
Change-Id: I79d0be3f9a5e3567ad493e86d1615dcacf9bffe6
Reviewed-on: https://chromium-review.googlesource.com/1086983
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565284}

This adds a WebOriginTrials interface, which can be used to query the state of
an origin trial given a WebDocument.

Bug: 845995
Change-Id: Ifbaed167bcfd2588436bd32f6f03d3f57171434c
Reviewed-on: https://chromium-review.googlesource.com/1088310
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565283}

These tests mix use of QuitCurrent*Deprecated() with use of the current
RunLoop::Quit*Closure() model. Migrate them off the deprecated API so
that we can enforce quit-by-closure-only wherever QuitClosure is used.

Bug: 844016
Change-Id: I5aca4ada0678f0cb1d84ced9fef9495fba751a7b
Reviewed-on: https://chromium-review.googlesource.com/1090213Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565282}

They now log error during creation and error while stream is
active separately. The names are changed to
Media.Audio.Render.StreamCallbackError2 and
Media.Audio.Capture.StreamCallbackError2 to avoid mixing the
new and old data. Also, errors are now logged only when they
are forwarded to the callback, to better correspond errors in
the upper layers.

Also drive-by fix some typos.

Bug: 836420
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie620c0f5864cdde3f98da1526de1fc0ed9456b66
Reviewed-on: https://chromium-review.googlesource.com/1078312Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565281}

Revert "Cleanup no longer used argument in MutableCSSPropertyValueSet::SetProperty."

This reverts commit 710b5cc7.
This reverts commit 9d45b94d.

Reason for reverts: suspected performance regression in 845944.

Combined reverts to make it easier to merge to M68.

Bug: 845944
Change-Id: Id01bb23981e82e25c26ff54a3970150f082d6878
Reviewed-on: https://chromium-review.googlesource.com/1090835Reviewed-by: Emilio Cobos Álvarez <emilio@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565280}

Bundle whichever startup snapshot is enabled (on Android, this is
presently the pure V8 one). Disable the gin_shell test, which tries
to invoke the gin_shell binary (but that doesn't really make sense
on Android, which only supports running Android apps packaged as APKs).

Works for me locally. Assuming this sticks, a followup will re-enable
gin_unittests on the bots.

Bug: 843124
Change-Id: Ia69a39263ed01b2d2b2664f58ec4263380a3ef00
Reviewed-on: https://chromium-review.googlesource.com/1089458
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565279}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/62e29b21..d993e197

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic3d30bd0626637481793e331641f4c882041ba42
Reviewed-on: https://chromium-review.googlesource.com/1090816Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565278}

Adds logging of consent_status::NOT_GIVEN for Play Store if the
user turns Play Store off after opting in.

Bug: b:79584730
Test: Disable ARC in chrome://settings, unit_tests
Change-Id: I42a84fce9219273a0f422174d5ccdcdec6cf0a38
Reviewed-on: https://chromium-review.googlesource.com/1066737
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565277}

Move tough_texture_upload_cases into the rendering folder and refactor
classes to inherit from RenderingStory

Bug: 849392
Change-Id: I50dcebcb563e2c50229884a062feb285c0ec4f8d
Reviewed-on: https://chromium-review.googlesource.com/1089453
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565276}

https://chromium.googlesource.com/catapult.git/+log/93a962f..a02c34c


git log 93a962f..a02c34c --date=short --no-merges --format='%ad %ae %s'
2018-06-07 csharrison@chromium.org Fix ChangeSecurityContext command in DeviceUtils


Created with:
  gclient setdep -r src/third_party/catapult@a02c34c

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic22968df1954d0a511d0cfd38d506deec9bc494f
Reviewed-on: https://chromium-review.googlesource.com/1090890Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565275}

CSSStyleDeclaration::AnonymousNamedGetter currently calls both
GetPropertyCSSValueInternal and GetPropertyValueInternal. However, it
really only needs to call GetPropertyValueInternal, since
GetPropertyValueInternal calls GetPropertyCSSValue interally if needed.
Make AnonymousNamedGetter only call GetPropertyValueInternal to reduce
duplicated code.

Change-Id: I6c63a1089e3b92d7947cf135512854f48ef7b130
Reviewed-on: https://chromium-review.googlesource.com/1089790Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565274}

The comment says it's supposed to be the same as chromium_win_clang_gtests
and interactive_ui_tests, but
https://chromium-review.googlesource.com/c/chromium/src/+/1076594 added
interactive_ui_tests to the clang list, and
https://chromium-review.googlesource.com/c/1090818/ removed chromium_win_clang_gtests
in favor of just chromium_win_gtests since the test lists have become equal.

This adds a bunch of tests to chromium_win_10_fast_ring_gtests that have been
added to chromium_win_clang_gtests and chromium_win_gtests after
chromium_win_10_fast_ring_gtests was forked. From the comment, it sounds like
adding these tests is what we should've done in the first place.

(I'm asking around if anyone looks at this bot at all since it's red and
it looks like it hasn't been touched in a while. Maybe I'll delete it in
a follow-up.)

Bug: 843511
Change-Id: I1fdb044c666941eb9beb8df0b50438e5a035f063
Reviewed-on: https://chromium-review.googlesource.com/1090819Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565273}

In a previous CL, WifiDataProvider implementations for
other platforms were modified to retain the wifi polling
policy state across restarts of the WifiDataProvider. This
CL updates the Chrome OS implementation to also retain this
information across provider restarts.

Relevant commit:
https://chromium.googlesource.com/chromium/src/+/abca656dd0f8e7aa02c21754ddb8581ab9e84b54

When the wifi polling policy state is lost, Chrome fails to
correctly apply the initial polling delay the next time the
WifiDataProvider is restarted. This can result in excessive use
of WLAN hardware and the network geolocation service when
the geolocation API is called many times in rapid succession.

BUG=828547

Change-Id: Iecad5b7f12f2d8fc72196db9e2108a7d2286d7bd
Reviewed-on: https://chromium-review.googlesource.com/1089190Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565272}

This change reverts back to only sending hover events to a clicked element. This is a step towards pinning behavior.

Also, the input handling processing order is now the following:
1. Process all end/leave events.
2. Process all update/move events.
3. Process all begin/enter events.
This scheme is more robust when handling several events within a single frame.

Bug: 848733
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I2d4da5234a4b60a00849bee4462fd676eccd80b6
Reviewed-on: https://chromium-review.googlesource.com/1082601Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565271}

This reverts commit b79fbf4d.

Reason for revert: CrSettingsLanguagesPageTest.Spellcheck is failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/9083 . Findit identified this CL.

Original change's description:
> Fixes crbug.com/814318 (spellcheck not functional):
> - only disables the "spellcheck" section when spellchecking is disabled
>   by policy, but not if disabled by the user;
> - disables the context menu entry if spellcheck is enforced by policy.
> 
> Bug: 814318
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I26e22bbc945b1cfb89a80a362d1ead1503350e42
> Reviewed-on: https://chromium-review.googlesource.com/1087678
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565253}

TBR=avi@chromium.org,stevenjb@chromium.org,macourteau@chromium.org

Change-Id: I401ffbe57e1c9157c218c623b6fecce4ca00eee7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814318
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1090950Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565270}

Make sure the same logic is used to detect renderer OOMs in various
places. Record UKM only for main frame OOM.
Also fixes the bug where UKM was recorded if renderer is not visible.
Move the metrics code out of CrashDumpManager to make it easy to switch
to crashpad.

Bug: 846871

Change-Id: I571cc762e8d3abe372f5b9f42f5b984614afa503
Reviewed-on: https://chromium-review.googlesource.com/1080278Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565269}

https://skia.googlesource.com/skia.git/+log/969bdef..18562b8


git log 969bdef..18562b8 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 caryclark@skia.org fix pathops fuzzer


Created with:
  gclient setdep -r src/third_party/skia@18562b8

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: Id7a9135517132e231baf8da228d5c8af52b82f2d
Reviewed-on: https://chromium-review.googlesource.com/1090790Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565268}

Previously, SyncAuthManager did not notify its client when it dropped
its cached access token just before requesting a new one (which didn't
seem to cause any problems in practice though). This CL adds the
missing notification.

As a followup to https://crrev.com/c/1089061, this also adds more
tests around access token fetches and credentials changed events in
SyncAuthManager (one of which exposed the missing notification).

Bug: 842697
Change-Id: I6e0179355659694f011534bcef2550cc0f415528
Reviewed-on: https://chromium-review.googlesource.com/1090836
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565267}

Bug: 780835
Change-Id: I89b56680b3ffea40c8a87a42423d182268c06615
Reviewed-on: https://chromium-review.googlesource.com/1082491
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565266}

This adds tests for primary account events (sign-in/out), for access
token requests, and for auth errors. Notably still missing are tests
for refresh token events.

Bug: 842697
Change-Id: Ic24a5bd097e1d9d0352a427fa24f6b7dbf65d908
Reviewed-on: https://chromium-review.googlesource.com/1089061
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565265}

Using wpt-import in Chromium 03976eed.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
36591a08 "Correctly detect when a multicol descendant becomes or ceases to be a containing block."
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19161

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-scoping

TBR=foolip

No-Export: true
Change-Id: I7522939601eb3f4091dd24755694ecf7dfb7b751
Reviewed-on: https://chromium-review.googlesource.com/1090752
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565264}

This CL fixes SystemTrayTrayCastMediaRouterChromeOSTest browser test
with Mash by using SystemTrayTestApi mojo interface. The CL also fixes
the tests in UnifiedSystemTray.

TEST=SystemTrayTrayCastMediaRouterChromeOSTest
(--enable-features=Mash)
BUG=847104

Change-Id: I691371f2b4284fbc0490745b7a54b15125b67719
Reviewed-on: https://chromium-review.googlesource.com/1088348Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565263}

IWYU. This fixes the libstdc++ build after commit 68d36054 ("Add
LazilyDeallocatedDeque a custom deque for TaskQueueManager"):

    In file included from ../../third_party/blink/renderer/platform/scheduler/base/lazily_deallocated_deque_unittest.cc:5:0:
    ../../third_party/blink/renderer/platform/scheduler/base/lazily_deallocated_deque.h:302:10: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
         std::unique_ptr<Ring> next_;
              ^~~~~~~~~~
    ../../third_party/blink/renderer/platform/scheduler/base/lazily_deallocated_deque.h:354:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
       std::unique_ptr<Ring> head_;
            ^~~~~~~~~~

Bug: 819294
Change-Id: I3a49f212f036905d89088749431b09513b9c33b8
Reviewed-on: https://chromium-review.googlesource.com/1090717Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#565262}

Mark virtual/outofblink-cors/http/tests/xmlhttprequest/navigation-abort-detaches-frame.html as timing out

http/tests/xmlhttprequest/navigation-abort-detaches-frame.html is marked
as timing out, but there is a virtual/outofblink-cors/ version of the
test that was missing this expectation.

Bug: 518987
Change-Id: Id8c1c3e264a739beed0fe196cf36ac664c4f4ca9
Reviewed-on: https://chromium-review.googlesource.com/1089634
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565261}

Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1088759

I forgot to initialize a member variable.

Bug: 850085
Change-Id: Idae7c9fe8f658f5d6657881354d6254c302c53e6
Reviewed-on: https://chromium-review.googlesource.com/1090811Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565260}

https://crrev.com/c/1084576 increased the binary code size by
removing overloads of |const char*| version in ExceptionState.
This patch simply adds them back with an explanation why we
need them.

Bug: 849743
Change-Id: I634759c1aa514d5199f5b712336db8acffa5257a
Reviewed-on: https://chromium-review.googlesource.com/1090691Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565259}

This ensures that the memory and clang tot bots run the same tests as the
main waterfall bots.

Everything running on the main waterfall must be tested with clang/tot too
to make sure compiler updates don't break anything. This change makes it
impossible for things to get out of sync (on win).

If https://chromium-review.googlesource.com/c/chromium/src/+/1088754 hadn't
been reverted, this would've been behavior-preserving. As-is, it adds
headless_browsertests and headless_unittests to the win clang tot bots.

Bug: 843511
Change-Id: I0c0568b47ca5ee56de7525bfcca8fc5e234acd6d
Reviewed-on: https://chromium-review.googlesource.com/1090818Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565258}

Bug: 831496
Bug: 850395
Bug: 850358
Bug: 850206
Bug: 849978
Change-Id: Iff076718738bb365551d6dbc4e39edbb5bf3ffda

TBR=nhiroki@chromium.org

Change-Id: Iff076718738bb365551d6dbc4e39edbb5bf3ffda
Reviewed-on: https://chromium-review.googlesource.com/1090837Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565257}

There were some bugs in our startup flow that could end up turning
VR mode on for CustomTabActivity and others when the user is in VR
and 2D-in-VR is enabled, or the device bootsToVr (standalones).

This change ensures we reuse the same code to check whether Chrome is
launching into VR in all of the places we turn VR mode on.

Bug: 849488
Change-Id: Ie5c2ca2a2930b511ddfb73ab6ef4f569e732d3fb
Reviewed-on: https://chromium-review.googlesource.com/1089795Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565256}

This refactoring will enable code reuse to notify screen readers if
there are suggestions to be shown once focus change to a field. The new
function will be called by AutofillManager::OnFocusOnFormFieldImpl.

Please notice that, even with SingleClick enabled, the dropdown is not
shown by default if the user tabs into a field or on initial focus.

Bug: 848427
Change-Id: I6435c3d829207dbb46358064c716f84d2497567a
Reviewed-on: https://chromium-review.googlesource.com/1087792
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565255}

Adjusts colors and spacings to match the steady location bar specs.

Bug: 819235
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7ae135ed5c0e9413bdcd2f33e750abc3c2431631
Reviewed-on: https://chromium-review.googlesource.com/1082395Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565254}

- only disables the "spellcheck" section when spellchecking is disabled
  by policy, but not if disabled by the user;
- disables the context menu entry if spellcheck is enforced by policy.

Bug: 814318
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26e22bbc945b1cfb89a80a362d1ead1503350e42
Reviewed-on: https://chromium-review.googlesource.com/1087678Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565253}

This fixes an issue where long bookmark lists do not display the full
content when scrolled.

Bug: 848683
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie4c273f952a2348bc332d43e2c8193ca20e0f33f
Reviewed-on: https://chromium-review.googlesource.com/1085227Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Patrick Meenan <pmeenan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565252}

That change added nacl_loader_unittests to the clang tot bots, but
the win/cross bot sets enable_nacl=false.

TBR=kbr@chromium.org

Bug: 843511
Change-Id: I529df5b574ad904919084fa5534b0911e98c7898
Reviewed-on: https://chromium-review.googlesource.com/1090814Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565251}

With https://crrev.com/c/1070158, base::Bind() supports
block so convert uses of base::BindBlockArc() to instead
use base::BindOnce() or base::BindRepeating().

Bug: 701275
Change-Id: I5fe41637fe8029be0bfe36b0cb002711be9f9ddc
Reviewed-on: https://chromium-review.googlesource.com/1087064Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565250}