- 24 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3cdc259008b5..216b984d3946 2020-08-24 mtklein@google.com delete nullptr,0 section of style guide If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I68bea69ab6d59cf36c5d8ac37632bb10f19ed7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800991}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/ui/views/profiles This CL was uploaded by git cl split. R=pbos@chromium.org Bug: 1110266 Change-Id: I7d6a1987ecc2507b95f9ec03cb7c90235fa17d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371261 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800990}
-
Jacobo Aragunde Pérez authored
Created AXEventCounter class to help tests counting accessibility events. Instead of writing their own observers, tests can create an instance of AXEventCounter and check how many events of each type have been registered. Bug: None Change-Id: I3b07a077a680b98415f5ed6bee1c4e6528237a22 AX-Relnotes: no user-facing changes. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336603 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800989}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I59c9d81e6c9a4af56a2770ac854e7809caadda19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359559 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800988}
-
Ian Kilpatrick authored
This piece of code was originally introduced in: https://chromium.googlesource.com/chromium/src/+/493129de0e666cb0b6fd6bf966a0993aa3d64be5 This had the effect of considering the margin-block-end of a LayoutBox as scrollable overflow. This wasn't in any specification. This appears to be trying to replicate an effect from FF, however this only occurs for FF on the root scroller, not arbitrary scrollers like this does. Fortunately Safari never shipped this behaviour. Bug: 34224 Change-Id: I1a2d45f598fb44955cc39017d70b126221d57a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371203Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800987}
-
Rohit Rao authored
If a user force-quits the app during launch (while the splash screen is still visible), it's possible for the app to receive applicationWillTerminate: without first receiving application:didFinishLaunchingWithOptions:. In this scenario, invoking the normal shutdown logic will lead to crashes, because the app was never started up. This CL adds logic to detect this case and return early from applicationWillTerminate. BUG=1115863,983504,1086396 Change-Id: I453f0ecae35a4431dc51490c6e38bbfd0d224f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367986 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800986}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c86f0d91767..09b5e6b1950b 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0d6b4440549b to 76e8dee41452 (3 revisions) 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b79773a35d52 to 4dd122392f3a (1 revision) 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44e1791f100c to 622558b02e1a (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I6fafc6778695c0acffa5a5443dd901b120a4be97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371330Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c0864ef. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" 2519d6aa "[SanitizerAPI] Change function name to match latest discussion" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0f48290ac55694767723fd63bfff26ffc7959c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372109Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800984}
-
Maksim Sisov authored
it's revealed when use_x11 && use_ozone config is used. Change-Id: Ic09cd74a6b424d0430f4eb6bda1e0d8be1b9fd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372482Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800983}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598226952-0b51be5d3acf41b4d5c1d696ddf01b10602a88d4.profdata to chrome-mac-master-1598270291-b801bf78b6b55c941ccf8675be0d44cb7bb468ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9420b7860a4d926c0b37efe6c42302fcbcce24d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371334Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/media/webrtc/webrtc_disable_encryption_flag_browsertest.cc This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 1110266 Change-Id: I0fc68995d831e7b6317f1b949c5bbf4298978702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371248 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800981}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7cf133ad5f0..70b2cf8b368d 2020-08-24 danilchap@webrtc.org Delete deprecated version of EncodedImageCallback::OnEncodedImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I89f27e4c9cf50b9f3c0ce9c9c78747b6c0e4144e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371332Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01f7fadf76bf..ecc4ecb65cd8 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb099222e319b09a3c54525341520a9f8e1322d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370523Reviewed-by:
-
sauski authored
Previously all generated preferences were created along with the service. As the SettingsPrivateEventRouter is created along with the profile, all generated preferences and all services they may depend on are also created. Preferences are only actually required to exist when they are observed, which may never occur during the lifetime of the browser. e.g a user never opens settings. This CL moves the creation of all generated preferences to only occur when an attempt is made to interact with a generated preference. Bug: 1112454 Change-Id: I82a565fd4181be018b9714d8c7a18b85e6bb988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343076Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#800978}
-
Nazerke authored
As a tabmodel needs to be deprecated, this CL extracts ClosingWebStateObserver into a browser agent to remove its usage in TabModel. Bug: 1050111,1045575,1045142 Change-Id: Ic6c5b65ff55bd211d38752b274c4dcbb9d854bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287434 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ca34252..856f8c9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0da88b406fe6bf448aac9d611d60b75fcb48536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372342Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800976}
-
Peter E Conn authored
TBR=wuwang@chromium.org Change-Id: Ibdaa1324d29bc989f2e18e34891a632e121b11f9 Bug: 1096656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372364 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800975}
-
Mihai Sardarescu authored
There is a single implementation of a GaiaAuthFercherIOSBridge, so the code is more readable if all the logic in this bridge lives only in the implementation class. Bug: 1101748 Change-Id: Ie7aaebb3f32323dd3310f273cda06d1225e3550d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368553 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#800974}
-
Bence Béky authored
Bug: 1115492 Change-Id: Ia6c923cfb55ea4e53054c603b6aa82eb58bde364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354457Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#800973}
-
Alex Ilin authored
'customize-themes' is largely a copy of 'ntp-customize-themes' Polymer 3 component from chrome/browser/resources/new_tab_page/customize_themes.js The component uses its own mojo interface to communicate with the browser. The interface is defined in ui/webui/resources/cr_components/customize_themes/customize_themes.mojom The component is moving into a new location to be reusable in new webUI pages. More context is in the bug. New tab page is switched to the new component in a follow-up CL https://crrev.com/c/2353449. Bug: 1115301 Change-Id: Id2b74da7a69be26a2ea587a830e23f6638f45820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352873 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800972}
-
Austin Tankiang authored
Bug: 1007662 Change-Id: I2e998f545703e0009c4887e9febf80c6039afc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371845 Commit-Queue: Honglin Yu <honglinyu@chromium.org> Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800971}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1110266 Change-Id: I953a64f3145beb1840c3138680dc13c7e88b497b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370295 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800970}
-
Andrey Zaytsev authored
Bug: 1120824, 1070620 Change-Id: I6e9ab2cb92801f03afb5bcaba0415d7d8c35636f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372302 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#800969}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/233cb555112c..f7cf133ad5f0 2020-08-24 rohitkrishnan@google.com Fix h264 decoding on iOS Simulator by not using IOSurface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie35c8711a3bf9146d764354b00636537e4d6e5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372008Reviewed-by:
-
Titouan Rigoudy authored
As noticed in crrev.com/c/2339972, the feature is not used in services/network anymore, only in content/. This change makes good on my promise in that CL to fix this state of things in a follow-up CL. Bug: chromium:986744 Change-Id: I633011b9eb6f5129dac0a31bdef4f0e9471c64e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366753 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..01f7fadf76bf 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3de852373f7bc1b728fa28cdc53965ad9d15fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372006Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I8a40b9ac4a9cbc3fd0933b94ec24485cf6075048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367868 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
This CL is the first CL that removes the feature flag kUseNSURLSessionForGaiaSigninRequests as the feature is enabled by default. A follow-up CL will also merge GaiaAuthFetcherIOSNSURLSessionBridge in GaiaAuthFetcherIOSBridge. Bug: 1101748 Change-Id: Id8ca73ca198bf3771aefabf157edf8229a84eb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366802Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#800964}
-
Benoit Lize authored
There are a few places where we access a PartitionRoot with the "wrong" thread safety template parameter. This is fragile, but also forces us to remove some DCHECK()s as their layouts don't match. This CL makes sure the layouts do match, which then removes the issue. The only downside is making PartitionRoot<NotThreadSafe> a tiny bit larger, but otherwise this does not add any runtime cost. Bug: 1092288 Change-Id: I7e24eceacd03682eab7693730a4fc7db973d6f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368874 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b3dbd0f5659..ec3fd1e6930e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: drott@google.com Change-Id: Idda835c320df8e7c95becc05cea5b9d8ab6dde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800962}
-
Richard Knoll authored
- Android expects these to be set and rejects payloads otherwise - Fixes access of |share_target| after a std::move() - Fixes transfer metadata process interpretation (0-1 vs 0-100) - Fixes FourDigitString hash from auth token Bug: None Change-Id: I88a2570d3c5b0ee772f28944914a5ae955151511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371624Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800961}
-
Dominik Röttsches authored
Bug: 1121099 Tbr: kbabbit@microsoft.com, katie@chromium.org Change-Id: Ibb27d5f44a0e009b6b51bed344f1c7e2268ccbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371705Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#800960}
-
Takashi Toyoshima authored
This patch modifies tests that see kOutOfBlinkCors feature flag, so to make them run only with OOR-CORS enabled. BlinkCors has already been deprecated and this is part of the work to remove the kOutOfBlinkCors feature work. Bug: 1053866 Change-Id: I59d3b9c42e61641053cc74aacc99493261ad51fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368642 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#800959}
-
Jonathan Mengedoht authored
Move CreateResourceRequestToWellKnownNonExistingResourceFor to anonymous namespace. Bug: 927473 Change-Id: I9e4c1f095177d27307a67b15bbc13bd342f25e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368597 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
-
Hajime Hoshi authored
Now no samples are emitted for regular VOLT metrics after the page is restored from the back-forward cache. This means that we will miss a lot of metrics for history navigations after we launch back-forward cache. As metrics for history navigations tend to be better figures than other navigations (e.g., due to network cache), the average of such metrics values will become worse and might seem regression if we don't take any actions. To mitigate this issue, we plan to emit 0 samples for such key metrics for back-forward navigations. This is implemented behind the flag so far, and we will enable this by default when we reach the conclusion how to adjust them. Bug: 1014174 Bug: 1121066 Change-Id: I04bf9646167aaf4c7241496a12ad66be3fe92681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354369 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#800957}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a69b6010. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I1d151a884245fb7857913b1be0b01b46a9696c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371569Reviewed-by:
-
Takashi Toyoshima authored
WebUI tests depend on kOutOfBlinkCors feature, and have feature set up code to enable it even on BlinkCORS fyi bots. Now that we turned down the fyi bots, the setup is not needed any more. Bug: 1053866, 1116928 Change-Id: I430946d5adae72f6b5f8b83f1572a27bade08b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367591Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f7edbe1f6f0..8c86f0d91767 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f257e0ea6b9a to 983698bb34ec (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If5da03e43d8a1edba7f7115e5f28a7411ba94188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371117Reviewed-by:
-
Marc Treib authored
This extends Sync.CommitLatency.* and Sync.ConfigureFailed, which were about to expire. While we're here, also change the recording of Sync.ConfigureFailed from the macro to the function. It's recorded rarely, so no need for the macro. Bug: 1117117, 1117140 Change-Id: Ic4c793771e495adbdaef3cba17fe514b045139e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361463 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#800953}
-
Tanmoy Mollik authored
This cl creates personalized sync promo for New Tab page. Screenshot: https://crbug.com/1116038#c1 Bug: 1116038 Change-Id: I73153ec34aad74cecd8a0c7bfa9bd5c5d7fada21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353258Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800952}
-
