- 06 Jan, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
See bug on how to reproduce the failure. The drop being aborted by deep scanning results in the drop data in web_frame_widget_base not being cleaned up, and causes assertion failures when a new drag is initiated. Calling OnDragExited cleans up the appropriate resources. Bug: 1033156 Change-Id: If2ab81a27ae65033c794f580344cd9c71d21f79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964533Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#728551}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1039283 Change-Id: I2ad1b19b5579289280da1744346131aa9b6dad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983211Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728550}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ed06c87. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6739689d61aff26f1b68dfbcbda297de0eba9589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988293Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728549}
-
Richard Knoll authored
Extending ExactTaskCreated and TaskExpired as NotificationTriggers are now using the exact task API. Bug: 1037582 Change-Id: Idc5b842efa4961d33ca4821862ba9b0ded9d951a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988347Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728548}
-
Tom McKee authored
WindowPerformanceTest exists to check the behaviour of WindowPerformance instances. It used to mock a page with DummyPageHolder (which, by way of a LocalDOMWindow, would end up owning a WindowPerformance instance) as well as construct its own WindowPerformance instance. This lead to the mock objects referring to a separate, intrinsic WindowPerformance than the one being directly manipulated by the tests. This change removes the one-off constructed WindowPerformance and exercises the WindowPerformance from the mock objects instead. Change-Id: I90980074362c36b630252a82f58b973ae1963965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965942Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#728547}
-
Mike Wittman authored
Relands 6f0c3820 with the StackSamplerImplTest.CopyStackTimestamp test updated to aggregate initialize the thread context to avoid using an uninitialized value. Records timestamps along with samples and plumbs them through to the ProfileBuilder interface. The CallStackProfileBuilder subclass will be updated in a following CL to record the timestamps, to support retrospective tagging of metadata on the samples. TBR=thestig@chromium.org,oysteine@chromium.org Bug: 1034758 Change-Id: Ibc3567a195c148ac2520bc19a757e9f8762823aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979006Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728546}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/347030813829..d0015fb415a4 git log 347030813829..d0015fb415a4 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 aerotwist@chromium.org Adds support for additional localization calls 2020-01-06 tvanderlippe@chromium.org Migrate resources/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@d0015fb415a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I762170457a3a80d7d4f4f2e708c4a250859e7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728545}
-
Stephen Nusko authored
rendering.mobile/linkedin_mobile_2018 rendering.mobile/linkedin_mobile_pinch_2018 rendering.mobile/linkedin_pathological_2018 NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1039281 Change-Id: I9bea0c7a94a7304deddda4ab551e0f5f5a98c358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988357 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
-
Stephen Nusko authored
I forgot to include system_health.common_mobile/load:tools:dropbox:2019 NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org,charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org BUG=1039277 Change-Id: I2578885c2079e65a74881f40a0e88721b905d8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983210Reviewed-by:
-
Jorge Lucangeli Obes authored
After fixing a data reporting bug we realized that there are still plenty of users reporting files being cleaned up. Postpone expiration for two releases to account for this. BUG=980946 TEST=pretty_print, validate_format. Change-Id: Ic81400d90220b75f55fb725820e5005e4ddbbf4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988209 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#728542}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3d6c36de379..6be45ec41f27 git log f3d6c36de379..6be45ec41f27 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-06 kjlubick@google.com [canvaskit] Update test to use correct metrics 2020-01-06 jlavrova@google.com Small bug fixes: leading spaces affect all width measurements, Created with: gclient setdep -r src/third_party/skia@6be45ec41f27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I9185c895b84723183fc663a75e3d4e368afd5908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988411Reviewed-by:
-
Nicolás Peña Moreno authored
Per https://heycam.github.io/webidl/#es-default-tojson, it is correct to directly add the attribute values of the interface to the builder instead of adding the results of toJSONForBinding(). Change-Id: I07f7ee5992de59938c0116f90dc4b5229c5d6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982792Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#728540}
-
Robert Ogden authored
This final status is defunct now that prerenders no longer run javascript. Bug: 1038061 Change-Id: I48f5051deecb465de8c4a9e60088b372db4b093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981101Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#728539}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad5473a1bad8..0a29f6fe80ef git log ad5473a1bad8..0a29f6fe80ef --date=short --first-parent --format='%ad %ae %s' 2020-01-06 lalitm@google.com trace_processor: migrate stack profile frames to db table Created with: gclient setdep -r src/third_party/perfetto@0a29f6fe80ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Ic32a710b00ed47ef0780cf050a8b04cc3bcfe024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988410Reviewed-by:
-
François Doray authored
In the past, TabManager tests have been disabled because of failures in the code that generates the content of a chrome:// URL. To minimize dependencies on external code, use simple test pages instead of chrome: // URLs in TabManagerTestWithTwoTabs. Change-Id: I84ae3c6a452b56aa9ad44465e7e6455f92dce937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974730 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#728537}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org,charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org BUG=1039277 Change-Id: Idb28cec9e5a6bdaecfd9644e66089b4fd83e6ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980184Reviewed-by:
-
haozhe authored
The spec: https://drafts.csswg.org/web-animations/#combining-shadow-lists The bug stems from: https://bugs.chromium.org/p/chromium/issues/detail?id=1005828 Bug: 10020843 Change-Id: I48fb990d76ba0b3e6e0bfc74bd46e2391a092259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960887 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#728535}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10a900e5ffaf..3716c2068ef3 git log 10a900e5ffaf..3716c2068ef3 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 sugoi@google.com Improve 1010102 blend precision Created with: gclient setdep -r src/third_party/swiftshader@3716c2068ef3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie5c949daa50cd36eaa68d1f4d7dc4abb7ea73796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987321Reviewed-by:
-
Antonio Gomes authored
... to use WebString instead. BUG=78725 R=haraken@chromium.org Change-Id: I7328edc399980f5b1105d07657c463cb1ac3f1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988291 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728533}
-
Chris Lu authored
This method will allow for the creation of embedder-specific methods that are tied to a specific Browser. Bug: 790886 Change-Id: I4fdf5b33c45910fe96eff834fc66843328ca05ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838263Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#728532}
-
Elly Fong-Jones authored
This is essentially a debugging hack - we know that windowserver crashes on the bots are caused by CoreGraphics trying to software- composite shadows from a window layer, and we know that these crashes only happen on VMWare bots. Bug: 899286 Change-Id: I531e6008ca30978dfb0f97562387af58cb53dd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976016Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#728531}
-
Andrew Grieve authored
Saves ~500ms of the R8 step on my machine. Bug: None Change-Id: Ifbb9bcbff999355a91291dad4201b4141b51ae2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984176 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728530}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7c5025db..4b11f995 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2541f4722edaa54ad8290b664e7f5a5f7a31435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728529}
-
Monica Basta authored
The profile entry is cleared on Primary account cleared. This is broken if the UPA still exists and has not changed. This is possible with |reset sync|. This CL prevents clearing the profile if there is an unconsented primary account. Fixed: 1038499 Change-Id: I64212726eee5534c3337a7074ff20dc6dcf5993c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983175 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Special top-level directory no long necessary now that we use binary resources in robolectric tests. Bug: 963624 Change-Id: I7330001028df10025ba0e11b310d9df586f7b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984477Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728527}
-
Ben Kelly authored
Its possible for the RenderProcessHostImpl to be destroyed on the UI thread before the BinderRegistry is destroyed on the IO thread. Bug: 1038019 Change-Id: Id6cb87fa0c4ea72c814d6f81ca296ec7be5f6f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986135 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#728526}
-
Christopher Grant authored
This change adds a pure 32-bit version of Monochrome, Trichrome and Webview to the 64-bit build configuration. Building these targets generates a product equivalent to building the targets on a 32-bit config. However, by adding these, we have the option of building all Monochrome and Trichrome products on a single 64-bit builder, and, we share the compilation work (as opposed to the obsolete process of "APK merging" parts from a 32-bit build into 64-bit products). The targets added here are the public versions. This change was originally reverted, because it exacerbated an unknown dependency problem with Trichrome, causing problems on trybots. That issue was fixed separately, meaning that these changes should be able to re-land safely: Revert: 8faa5fc4 Trichrome fix: d2a17895 It is being relanded with a follow-on change (that was also reverted), updated to handle WebView bundles: a2897b6b Also added to this version is coverage of the new webview bundles. TBR'ing torne and agrieve as they've already reviewed the original changes. TBR=torne@chromium.org, agrieve@chromium.org Bug: 1027573 Change-Id: Ie1c9f042a7046505b081bfb9312e48ee8ee3b197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960575Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#723897} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985527 Cr-Commit-Position: refs/heads/master@{#728525}
-
Andrew Grieve authored
In favor of using the new & simpler "sources" attribute. TBR=agrieve # Trivial BUILD.gn in components/ Bug: 1026378 Change-Id: I1bc6db5f66262bef18b0c458435e742230c1d4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982187 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728524}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6334d594f68c..8db9eccc0baf git log 6334d594f68c..8db9eccc0baf --date=short --first-parent --format='%ad %ae %s' 2020-01-06 cepheus@frii.com Bump revision Created with: gclient setdep -r src/third_party/glslang/src@8db9eccc0baf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Idff09dac36fd73ed26551428c6b9d96fff31e147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987322Reviewed-by:
-
Antonio Gomes authored
Instead, WTF::String is used. BUG=787254 R=haraken@chromium.org Change-Id: I046b6309b56e5d7664b0e7983d712aa3b21a12a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988289Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/933ea8c301b1..f3d6c36de379 git log 933ea8c301b1..f3d6c36de379 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 kjlubick@google.com [canvaskit] Add npm release target to ship smaller binaries Created with: gclient setdep -r src/third_party/skia@f3d6c36de379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I16638533758c0d7c11f83c26369730759956ac5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987937Reviewed-by:
-
Mikhail Khokhlov authored
Some tests depend on "telemetry_chrome_test" target directly, bypassing "perf" target. This CL moves the dependency on trace_processor_shell from "perf" to "telemetry_chrome_test" to make sure that all tests can use the trace processor to convert proto traces. Bug: 1038780 Change-Id: I308024cd5ec06bd4989ff983e28e9f26b19f792c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983173Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#728520}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8987f8f14e92..347030813829 git log 8987f8f14e92..347030813829 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 tvanderlippe@chromium.org Migrate worker_main/ to ESM 2020-01-06 tvanderlippe@chromium.org Migrate toolbox_bootstrap/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@347030813829 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d9eb3b37456ddb3027d4470fae8476c878f99e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987935Reviewed-by:
-
Andrew Grieve authored
Saves 300ms on my machine Bug: 1036740 Change-Id: I88a0cbb8d207ac1ef4710bd771b8eb69d6c2f514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980314 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
David Bokan authored
We kept |touch_scrolling_| simply to be able to set the |is_direct_manipulation_| bit on the scroll state in ScrollBy. It's cleaner to simply have InputHandlerProxy set this bit correctly in all cases. The majority of this CL is simply adding an extra parameter to the state creation method in unit tests so that we can set the bit correctly there too. This was a mechanical change. Bug: 1016229 Change-Id: If0c46d283fb030f205ffd39cdb0c04dd9e1bd7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981335 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728517}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0dbd769597c4..3d45c872224d Created with: gclient setdep -r src-internal@3d45c872224d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia983fb90908af6c18e19f4a411e44be4e1a5909a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987938Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728516}
-
Andrew Grieve authored
For non-official builds, sets compression level to 1, which yields a ~4% worse compression ratio, but compresses twice as fast. For official builds, sets compression level to 9, which yields a 0-1% better compression ratio, and compression twice as slow. On my machine, apkbuilder.py for Monochrome.apk in debug goes from 7.5 to 6.2 seconds, and with is_officail_build, 9.6 seconds. Bug: 1036740 Change-Id: I9296dcb45358a6c5cf742fc404dadbbbaec522fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980313 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
* Disable v1 signatures for Monochrome * Disable v3 signatures always * Adds timestamps for profiling (behind APKBUILDER_DEBUG) Signing debug Monochrome.apk goes from 10 seconds to 3 seconds. Here's an after breakdown from my machine: I 59413 9 Started (apkbuilder.py) D 59413 29 Adding AndroidManifest.xml D 59413 33 Adding assets/ D 59413 360 Adding classes.dex D 59413 1713 Adding lib/ D 59413 2107 Adding res/ D 59413 2286 Adding Java resources D 59413 2294 Running zipalign D 59413 2614 Signing apk I 59413 7513 Job's done (apkbuilder.py) Bug: 1036740 Change-Id: Ic12f52e5e3bd79ca057513cc2ae3d1c344d9858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980310Reviewed-by:
-
Gauthier Ambard authored
This CL cleans PageInfo up, preparing for a new design. The PageInfoModelObserver wasn't used, so it is removed. All the other things removed were never called, so they can be removed. Bug: 1038919 Change-Id: I95a6630bd3ff0c03c3cf9af4b25cb4ef88e33ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986789 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL changes PCDF to operate over WTF's Bind() helpers instead. BUG=787254 R=haraken@chromium.org Change-Id: Id812a11796e80a1a68de71e8a2f928c1416aa6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988287Reviewed-by:
-
