- 04 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df482aad3e7e..486508d8c322 git log df482aad3e7e..486508d8c322 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 cjmcdonald@chromium.org cros_extract_deps: Fix syntax to unpack additional return value Created with: gclient setdep -r src/third_party/chromite@486508d8c322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6d303dbf49f4b7084a55daa869140ee53a7b5305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712240}
-
Eric Stevenson authored
This will cause compile errors for proguard_enabled builds if generated proxy native classes aren't fully inlined and removed. An example where this would happen is caching the result of WrapperClassNameJni.get() in a member variable. Example errors: Item void org.chromium.base.MemoryPressureListenerJni.<init>() was not discarded. Some JNI wrapper classes were not fully optimized. org.chromium.base.MemoryPressureListenerJni should not appear in a release .dex file. Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. ... Item void org.chromium.base.library_loader.LibraryPrefetcherJni.<init>() was not discarded. Some JNI wrapper classes were not fully optimized. org.chromium.base.library_loader.LibraryPrefetcherJni should not appear in a release .dex file. Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. ... Bug: 993421 Change-Id: I488640859a939d41eed2e44bb01904062942257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894151 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712239}
-
Dana Fried authored
This affects behavior behind a flag so it's not a regression, but absolutely needs fixed while I figure out what to do with the rest of the code here. Change-Id: Iecaad932aa1d8dab44a5cf3f59077100f52a67eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896303 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712238}
-
Joel Hockey authored
Often times out in debug Bug: 1020318 Change-Id: Iab3efaddbfc0f4418c6b948948c8f460f73d5c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895267 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#712237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5dba5c7ba486..0460f06e10cf git log 5dba5c7ba486..0460f06e10cf --date=short --no-merges --format='%ad %ae %s' 2019-11-04 zakerinasab@google.com Merge "Docs: Add running UI and docs server to running.md" 2019-11-04 lalitm@google.com trace_processor: add RowMap iterator and use in Table iterator Created with: gclient setdep -r src/third_party/perfetto@0460f06e10cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I1ed2d3543f132c77b210b5d9b2a9d83ccc8c47f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897854Reviewed-by:
-
Greg Thompson authored
Also ensure that the temp dir can be deleted in TearDown. BUG=546640 R=sky@chromium.org Change-Id: I8e939324616a3e278c0508f639d0caaec2042f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894007 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2cba7759c45..23c213f71633 Created with: gclient setdep -r src-internal@23c213f71633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None Change-Id: Ia1bba79e8ea4669f969f531fb20fd9c5c803814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896510Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712234}
-
Matt Menke authored
This reverts commit f6ec475d. Reason for revert: We're seeing these failures on the tree again. Original change's description: > Revert "Remove SpawnedTestServer timeouts." > > This reverts commit 8e4bd238. > > Reason for revert: want to verify that workarounds to https://crbug.com/869227 inside vpython itself are actually useful > plus to read more logs. > > The original can re-landed any time if new occurrences of https://crbug.com/869227 manifest themselves. > > Original change's description: > > Remove SpawnedTestServer timeouts. > > > > These timeouts are ancient. The test infrastructure has its own > > timeouts, which should make these obsolete. Also, this may help with > > https://crbug.com/869227, where starting the Python test server > > times out. > > > > Bug: 869227 > > Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: David Benjamin <davidben@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#707894} > > TBR=davidben@chromium.org,mmenke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 869227 > Change-Id: Ic11c2e9a78568738a7712a1141876840f8a63740 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893789 > Auto-Submit: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711706} TBR=davidben@chromium.org,iannucci@chromium.org,tandrii@google.com,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869227 Change-Id: I31794b424e1d3aec994fea74f63645f85cb1b80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897976Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712233}
-
Joshua Pawlicki authored
This reverts commit 83ced150. Reason for revert: Causes timeouts for SpanTest.OutOfBoundsDeath in Windows debug builds. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=SpanTest.OutOfBoundsDeath Original change's description: > [base] Introduce base::CheckedContiguousRange > > This change introduces base::CheckedContiguousRange, which similarly to > base::span is a light-weight wrapper around a contiguous container > performing bound CHECKs. > > However, in contrast to base::span this class keeps a pointer to the > underlying container, and thus is able to respond to changes to data() > and size(), which base::span can't do. > > Furthermore, this change provides a constexpr overload of base::data() > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > Bug: 990059 > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712120} TBR=palmer@chromium.org,dcheng@chromium.org,jdoerrie@chromium.org Change-Id: I813ab3ab80d75cb96189584b504488e3ab5a6c43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894162Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712232}
-
Dale Curtis authored
Flakes on all platforms now, so should be marked everywhere. BUG=1010472,1019079 TBR=waffles Change-Id: Ibea535220eb3093e3a99f985a1077af5eb0cb258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898202Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712231}
-
Peter Wen authored
Specifically for the file apk_merger.py Bug: None Change-Id: I0e889d95d7749dbce3d812fc971e2b690ab20789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896506 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712230}
-
chrome://flagsmanuk authored
Bug: 950512 Change-Id: Ia670e8f931e886e4298ba07f9cd7f8cdd328e8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897484Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#712229}
-
Xianzhu Wang authored
This reverts commit 9f934997. The original patch broke deferred main frame update during page navigation because the new WebViewImpl::SetRootLayer() missed DeferMainFrameUpdate which was in the removed WebViewImpl::SetRootGraphicsLayer(). Fix that by adding back the logic. Original change's description: > Revert "Don't create GraphicsLayers for VisualViewport" > > This reverts commit 8657999c. > > Reason for revert: Caused crash crbug.com/1020181. > > Original change's description: > > Don't create GraphicsLayers for VisualViewport > > > > Now VisualViewport creates cc::Layers instead of GraphicsLayers, and > > creates foreign layers directly during painting instead of by collecting > > GraphicsLayers. This makes VisualViewport use the same code for CAP and > > pre-CAP. > > > > PaintLayerScrollableArea still uses GraphicsLayers which are created by > > PaintLayerCompositor/CompositedLayerMapping. > > > > GraphicsLayers created by PaintLayerCompositor/CompositedLayerMapping > > no longer need to attach to VisualViewport which no longer creates > > GraphicsLayers. > > > > Bug: 1012594 > > Change-Id: I5ce76a3b5728d3810d85d536357cb437eea5fc4f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869126 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710881} > > TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1012594, 1020181 > Change-Id: I3e0f5fa0b3698d8af7cd9f6d6f81e34f40c8b30d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894110 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711503} Bug: 1012594, 1020181 Change-Id: Ib1440e0c0ac5d5490697d85027fb30e24e51f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895081Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712228}
-
Hector Carmona authored
Also update users of FocusRowBehavior to set the index in order to take advantage of the new attributes. Bug: 1020305 Change-Id: Ife51f853060b5d8e67984f34f7333ec9f7c0345a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894324 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#712227}
-
Daniel Vogelheim authored
This will pass on the Trusted Type enforcement requirement set by the CSP header, but will not actually instantiate a TrustedTypePolicyFactory. That plugs the current hole; but might not be an acceptable long-term solution. Bug: 951536 Change-Id: I56d541d57184396ce1dacdac9236d9259189f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886826 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712226}
-
Dale Curtis authored
Pass/Timeout was already excluded, but Crash was left off. BUG=1014812 TBR=waffles Change-Id: Ib2da88c9dedbb46f5a00893d9b37a7e721619d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897856Reviewed-by:
-
Toni Barzic authored
Original attempt CL:1888652 got reverted because a new usage popped up. HomeLauncherGestureHandler currently has three observers: 1. AppListControllerImpl, which is also a HomeScreenDelegate implementation (on which HomeScreenGestureHandler already depends, so additional observer interface just obscures/complicates this dependency) 2. HomeLauncherStateWaiter which is used by interactive UI/perf tests to wait for launcher animations to complete 3. BackdropController which pauses backdrop updates while home launcher drag is in progress (this landed in parallel with first attempt of landing this) For case 1., moving the observer methods to HomeScreenDelegate interface will work fine. For case 2., the test waiter can register a callback with AppListControllerImpl to be run when the home launcher animations are complete - the same way it's done by LauncherStateWaiter, an equivalent test waiter used in clamshell mode (or for waiting for non-visibility app list state transitions) For case 3. the dependency is switched - instead of BackdropController observering HomeLauncherGestureHandler for drag events, HomeLauncherGestureHandler requests pause in backdrop updates while home launcher state transitions are in progress. Given that HomeLauncherGestureHandler already depends in BackdropController (to animate backdrop window), this removes newly added circular dependency. BUG=1005366 Change-Id: I73e249eaf41d8ccf1e349dfa6ba023eccb97159a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894464Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712224}
-
Yue Li authored
Extend the expiry milestone of assistant app support feature flag which is still in use. Bug: None Test: Locally build and test Change-Id: I18e8e08579e80343f2beecaecfaec7394fc1b5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895741Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#712223}
-
Vladimir Levin authored
This removes a TODO I was planning on doing, but I think it's fine to keep the override right in the getter, to ensure that we get correct behavior anytime we use the getter. R=chrishtr@chromium.org Bug: 10163281 Change-Id: Ie55b2d69bad47e20b7c2c9123a131e6c738f6e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897853Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712222}
-
Antonio Gomes authored
Blink uses its own WTF::ThreadSafeRefCounted instead. BUG=787254 R=guidou@chromium.org Change-Id: I468ec63f649381e0d2bc3e9b76472992d87605ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887370 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712221}
-
Ben Kelly authored
These tests were previously switched to exercise the case when the features were disabled since the fieldtrial_testing_config.json was setup to enable the feature. It turns out, however, that fieldtrial_testing_config.json does not affect web platform tests. Therefore re-enable the feature in these virtual test suites. Bug: 960012,1010624 Change-Id: I661ccaa0a76b9380f98d69abc8df4c01c28fe9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898168Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#712220}
-
Dale Curtis authored
PushMessagingBrowserTest.PushEventEnforcesUserVisibleNotification is flaking and OWNERS are not responding on bug. Disable. BUG=458160 TBR=peter Change-Id: I9f44abaee56ac06126c1ca88067832965bda8460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898087Reviewed-by:
-
Himanshu Jaju authored
SharingMessageSender replaces ResponseCallbackHelper. This ensures SharingFCMSender does not need to surface any other API. Bug: 1018274 Change-Id: Ieb9f7010ddeedc694fcfe72ff49c5659d758690d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895660 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#712218}
-
Robert Ogden authored
This should have been a part of https://chromium-review.googlesource.com/c/chromium/src/+/1867293 but was missed. Oops. Change-Id: I2f4a3992572b17156749f9abce3f95399b867a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895910 Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#712217}
-
James Cook authored
Chrome OS is introducing a separate settings UI to control sync for OS types like printers, OS settings, and Wi-Fi config. See go/split-settings-sync for links to PRD and mocks. * Add UserSelectableOsType for OS data types * Add types for both OS preferences and printers. This CL does both because EnumSet requires at least 2 enum values and I want to add UserSelectableOsTypeSet for consistency with the browser enum set. * Change SyncUserSettings to support the new types, as well as a "sync all OS types" control. * Add new prefs for sync OS preferences and sync all OS types. There was an existing pref for sync printers that wasn't used -- now it is used. Not everything is wrapped in #if defined(OS_CHROMEOS) because the convention in the sync code seems to be that all ModelType values and pref names are compiled on all platforms. However, all references to UserSelectableOsType are ifdef'd to make it clear that "OS type" is Chrome OS only. Bug: 1013466 Test: added to components_unittests and sync_integration_tests Change-Id: I1cd6f7e663c20dfb0f36c55d204b92ea19a73852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895755 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712216}
-
Antonio Gomes authored
Once the Onion soup of content/renderer/media/webrtc is reaching completion, it is possible to clean up most of the headers in third_party/blink/public/web/modules/mediastream. It includes: - processed_local_audio_source.h - media_stream_constraints_util.h - media_stream_constraints_util_sets.h - remote_media_stream_track_adapter.h - video_track_adapter_settings.h as well as the following mock files: - mock_media_stream_registry.h - mock_media_stream_video_sink.h - mock_media_stream_video_source.h Note that there are still headers left over deliberately in the public directory: (included in content/renderer): - media_stream_video_source.h - media_stream_video_sink.h - media_stream_video_track.h - webmediaplayer_ms.h (require extra round of clean up, eg renames) - web_media_stream_renderer_factory.h - web_media_stream_device_observer.h - web_media_stream_utils.h BUG=919392, 787254, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1e1c0b01b29dc84a5541c0a20253dd92df8f9133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886791 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712215}
-
Joshua Pawlicki authored
Disabling for debug builds. Bug: 1021191 TBR=rsorokin@chromium.org Change-Id: Iee02d25f1b3ca6fb2564d4093c0c8023d3913e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897486Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712214}
-
John Delaney authored
It is possible for a frame pending deletion to be provided to LoadPostCommitErrorPage, which results in a dump without crash as this is unspecified behavior. This CL adds an early return if the render frame host provided to LoadPostCommitErrorPage is not active. Bug: 1019180 Change-Id: Iceab9e54948bf9ba0bb5ce973fa276e96712a8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888713Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712213}
-
Emily Stark authored
Bug: 1016906 Change-Id: I5bbee26636b6051c141538669c6f1918ef233706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883122 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#712212}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/580a95b0..99086cbb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9c352786bb3a045a81101d1525a6bfa089ae8db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712211}
-
Elly Fong-Jones authored
Despite the name, AXRelativeBounds are actually the absolute bounds when used with Views views. The code in TableView was treating them as though they were relative, which led to table rows and cells having their virtual positions near the origin of the screen. After this change, they are correctly positioned. This change also implements AXVirtualView::GetNSWindow, which is being called by VoiceOver when navigating these table cells. It doesn't seem to matter whether it returns a correct value or not but having it NOTREACHED() causes the browser to crash in dcheck builds, which is bad. Bug: 1009024 Change-Id: I67c0cd05786896de873fc8a36129cd2f0f3dff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894308 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712210}
-
Michael Crouse authored
This change renames the HintCacheStore to OptimizationGuideStore as future changes will allow the store to contain additional entry types that are not hints, including prediction models and host model features. A future change will initialize the store in the keyed service rather than within the hints manager and hint cache to allow its use throughout the optimization guide. Bug: 1001194 Change-Id: I68271ed1070829be40d21463eb976390a66109ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896774 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Clark DuVall authored
Bug: 1021126 Change-Id: I5c7e6a1fe0bd0f3f3fe96d9ef71cae242973d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898086Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712208}
-
Lijin Shen authored
The background of URL bar is not displayed on swiping tabs or entering/existing tab switcher. This CL is trying to correct location bar background color by detecting whether it is an NTP and location bar is on top of the NTP or not. Bug: 874101 Change-Id: I6749d0829839cf753a99e1663e6c0565bd9bf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887655 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#712207}
-
David Benjamin authored
If the input is divided into 1-byte chunks, our existing limits don't directly bound things and the PostTask machinery is slow enough with sanitizers on that doing it 500,000 times in sequence tends to blow through the newly-tightened limit in https://chromium-review.googlesource.com/c/chromium/src/+/1797203. Bug: 1014767 Change-Id: Iaa047613c1ace18c4639e442d2224c0abf16c741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898166 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1021172 Change-Id: I0461cfab978517bd0d948487f785efce9df018df TBR=rdevlin.cronin@chromium.org Change-Id: I0461cfab978517bd0d948487f785efce9df018df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896505Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712205}
-
Archana Simha authored
Introduces the feature name and parameters, and overrides the middle slot promo with the extensions promo when the experiment is running. (Note: navigations to chrome scheme links from the NTP are currently blocked. This ability will be implemented in a future CL based on https://crrev.com/c/1893824) Design Doc: go/extensionscheckup Bug: 1019296 Change-Id: Ib1bf149e4ccdd38383ecb534b69ffac147b6e446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836021 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
-
Philip Rogers authored
We are changing the behavior of trivial 3d transforms to not require compositing and this means we lose test coverage of some compositing codepaths in the compositing/ directory. This change replaces trivial transforms that were likely intended to be compositing triggers with will-change: transform. Bug: 1018260 Change-Id: I6ec7edcbb418c530c7bf2e3b9477c4347c5eedc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893513 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712203}
-
Xianzhu Wang authored
- Add back the rect parameter of PaintPart() method, so that the caller (which is cc, and will be also from blink for CompositeAfterPaint) can control where the part should be painted. It was removed in crrev.com/c/1834286 when I thought we wouldn't use it. - Rename TRACK to TRACK_BUTTONS_TICKMARKS to distinguish from the track part concept in blink which doesn't include buttons and tickmarks. - Add cc::Scrollbar::ThumbRect() which replaces ThumbThickness() and ThumbLength(). The location is not used in cc because the compositor will compute it from scroll offset, but it's useful for CompositeAfterPaint non-composited scrollbars which also use cc::Scrollbar. - Move custom scrollbar specific logic (for back/forward track, scrollbar background, track background, buttons in reversed direction etc.) from scroll/scrollbar_theme* to CustomScrollbarTheme. Bug: 931486 Change-Id: I912ea4c53334520204ec4e369f77a88c79983bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897118 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Convert code abusing set_sources_assignment_filter to filter lists to instead manually filter the list using foreach and get_path_info. Bug: 1018739 Change-Id: I66205fe54ebdce67e23d0b14e594d237555bce8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890061Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
