GitLab

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/163783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294008
TBR=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/163813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313220
NOTRY=TRUE

Review URL: https://codereview.chromium.org/163673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251055 0039d316-1c4b-4281-b951-d872f2087c98

This means no file can be opened for write during the test run.

Windows can't be done at the moment due to bug 342913.

R=vadimsh@chromium.org
BUG=116251
BUG=342913

Review URL: https://codereview.chromium.org/136973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251054 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/121223002

BUG=324535

Review URL: https://codereview.chromium.org/121223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251053 0039d316-1c4b-4281-b951-d872f2087c98

Argument copying and lookups are a bit more complicated than they have to be.
This cleans up the code a little bit to make the trusted plugin more compact.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/161403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251052 0039d316-1c4b-4281-b951-d872f2087c98

Cleanups:
  Explicitly handle snapped case in SetChildBounds
  Use SetMaximizedOrFullscreenBounds in OnWindowAddedToLayout

BUG=none

Review URL: https://codereview.chromium.org/161293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251051 0039d316-1c4b-4281-b951-d872f2087c98

I'm still tweaking the script to accommodate specific libraries. Rebuilding the entire list of libraries with every change is less than fun.

R=glider@chromium.org
BUG=313751,343515
NOTRY=true

Review URL: https://codereview.chromium.org/161133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251050 0039d316-1c4b-4281-b951-d872f2087c98

WebRTC browser tests is based on Manycam virtual capture device,
but this does not work with AVFoundation, see bug.

Termporarily, disable AVFoundation for those tests, hence using
QTKit capture Framework.

BUG=327618, 288562

Review URL: https://codereview.chromium.org/163243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343006

Review URL: https://codereview.chromium.org/132793014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251048 0039d316-1c4b-4281-b951-d872f2087c98

c1cb193 disable NEON for arm64 platform

BUG=314720, 342387
R=urvang@google.com
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/153273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251047 0039d316-1c4b-4281-b951-d872f2087c98

Use GCC's __builtin_expect() branch prediction hint to tell the compiler
that trace events are likely to be disabled. This lets the compiler
optimize trace event shim code embedded in functions by moving it
outside the critical path and by annotating it with hints for the CPU's
runtime static branch predictor (depending on the architecture).

The exact performance impact of this change is difficult to quantify,
but the disassembly shows improvements to code locality. For example,
cc::ThreadProxy::CompositeAndReadback, which begins with a call to
TRACE_EVENT0(), looks like this before the change (x64):

00000000004bc2e0 <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE>:
  [... prologue ...]
  4bc30a:	48 8d 35 e7 e7 2d 00 	lea    0x2de7e7(%rip),%rsi        # 79aaf8 <.L.str>
  4bc311:	48 8d 15 8b 60 2e 00 	lea    0x2e608b(%rip),%rdx        # 7a23a3 <.L.str7>
  4bc318:	48 8d bc 24 f0 03 00 	lea    0x3f0(%rsp),%rdi
  4bc31f:	00

  /* Initialize scoped trace memory tracker. */
  4bc320:	e8 7b 19 0a 00       	callq  55dca0 <_ZN4base5debug17ScopedTraceMemory10InitializeEPKcS3_>

  /* Have seen this trace event before? */
  4bc325:	48 8b 1d 94 78 3d 00 	mov    0x3d7894(%rip),%rbx        # 893bc0 <_ZZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectEE28trace_event_unique_atomic149>
  4bc32c:	48 85 db             	test   %rbx,%rbx

  /* No? Better initialize it then */
  4bc32f:	75 16                	jne    4bc347 <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE+0x67>
  4bc331:	48 8d 3d c0 e7 2d 00 	lea    0x2de7c0(%rip),%rdi        # 79aaf8 <.L.str>
  4bc338:	e8 63 6f 09 00       	callq  5532a0 <_ZN4base5debug8TraceLog23GetCategoryGroupEnabledEPKc>
  4bc33d:	48 89 c3             	mov    %rax,%rbx
  4bc340:	48 89 1d 79 78 3d 00 	mov    %rbx,0x3d7879(%rip)        # 893bc0 <_ZZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectEE28trace_event_unique_atomic149>

  /* Trace event has been initialized. Is its category enabled? (atomic load) */
  4bc347:	48 c7 84 24 d0 03 00 	movq   $0x0,0x3d0(%rsp)
  4bc34e:	00 00 00 00 00
  4bc353:	f6 03 05             	testb  $0x5,(%rbx)

  /* Trace category is disabled => jump to rest of function. */
  4bc356:	0f 84 a8 00 00 00    	je     4bc404 <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE+0x124>

  /*
   * Trace category is enabled => compute timestamp and arguments and
   * append the event to trace log.
   */
  4bc35c:	e8 df cc 0b 00       	callq  579040 <_ZN4base14PlatformThread9CurrentIdEv>
  4bc361:	4d 89 e6             	mov    %r12,%r14
  4bc364:	41 89 c4             	mov    %eax,%r12d
  4bc367:	e8 a4 3d 0c 00       	callq  580110 <_ZN4base9TimeTicks22NowFromSystemTraceTimeEv>
  4bc36c:	48 89 84 24 80 00 00 	mov    %rax,0x80(%rsp)
  4bc373:	00
  4bc374:	e8 47 69 09 00       	callq  552cc0 <_ZN4base5debug8TraceLog11GetInstanceEv>
  4bc379:	48 8d 8c 24 80 00 00 	lea    0x80(%rsp),%rcx
  4bc380:	00
  4bc381:	48 89 0c 24          	mov    %rcx,(%rsp)
  4bc385:	c7 44 24 30 00 00 00 	movl   $0x0,0x30(%rsp)
  4bc38c:	00
  4bc38d:	48 c7 44 24 28 00 00 	movq   $0x0,0x28(%rsp)
  4bc394:	00 00
  4bc396:	48 c7 44 24 20 00 00 	movq   $0x0,0x20(%rsp)
  4bc39d:	00 00
  4bc39f:	48 c7 44 24 18 00 00 	movq   $0x0,0x18(%rsp)
  4bc3a6:	00 00
  4bc3a8:	48 c7 44 24 10 00 00 	movq   $0x0,0x10(%rsp)
  4bc3af:	00 00
  4bc3b1:	c7 44 24 08 00 00 00 	movl   $0x0,0x8(%rsp)
  4bc3b8:	00
  4bc3b9:	48 8d 2d e3 5f 2e 00 	lea    0x2e5fe3(%rip),%rbp        # 7a23a3 <.L.str7>
  4bc3c0:	be 58 00 00 00       	mov    $0x58,%esi
  4bc3c5:	45 31 c0             	xor    %r8d,%r8d
  4bc3c8:	48 89 c7             	mov    %rax,%rdi
  4bc3cb:	48 89 da             	mov    %rbx,%rdx
  4bc3ce:	48 89 e9             	mov    %rbp,%rcx
  4bc3d1:	45 89 e1             	mov    %r12d,%r9d
  4bc3d4:	4d 89 f4             	mov    %r14,%r12
  4bc3d7:	e8 24 a4 09 00       	callq  556800 <_ZN4base5debug8TraceLog37AddTraceEventWithThreadIdAndTimestampEcPKhPKcyiRKNS_9TimeTicksEiPS5_S3_PKyPK13scoped_refptrINS0_24ConvertableToTraceFormatEEh>

  [... actual function code ...]

After the change:

00000000004bcab0 <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE>:
  [... prologue ...]
  4bcad8:	48 8d 35 89 f0 2d 00 	lea    0x2df089(%rip),%rsi        # 79bb68 <.L.str>
  4bcadf:	48 8d 15 2d 69 2e 00 	lea    0x2e692d(%rip),%rdx        # 7a3413 <.L.str7>
  4bcae6:	48 8d bc 24 f0 03 00 	lea    0x3f0(%rsp),%rdi
  4bcaed:	00

  /* Initialize scoped trace memory tracker. */
  4bcaee:	e8 fd 20 0a 00       	callq  55ebf0 <_ZN4base5debug17ScopedTraceMemory10InitializeEPKcS3_>

  /* Have seen this trace event before? */
  4bcaf3:	48 8b 1d c6 80 3d 00 	mov    0x3d80c6(%rip),%rbx        # 894bc0 <_ZZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectEE28trace_event_unique_atomic149>
  4bcafa:	48 85 db             	test   %rbx,%rbx

  /* No? Jump to the initialization code at the end of the function. */
  4bcafd:	0f 84 7e 03 00 00    	je     4bce81 <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE+0x3d1>

  /* Is the trace category enabled? (atomic load) */
  4bcb03:	48 c7 84 24 d0 03 00 	movq   $0x0,0x3d0(%rsp)
  4bcb0a:	00 00 00 00 00
  4bcb0f:	f6 03 05             	testb  $0x5,(%rbx)

  /* If so, jump to the event appending code at the end of the function. */
  4bcb12:	0f 85 84 03 00 00    	jne    4bce9c <_ZN2cc11ThreadProxy20CompositeAndReadbackEPvRKN3gfx4RectE+0x3ec>

  [... actual function code ...]

  [... code for initializing trace event...]

  [... code for appending trace event...]

In other words, the trace event related code has been moved outside the
main function code flow. This should improve code cache utilization.

Note that this change currently has no effect on ARM, since
__builtin_expect() is a no-op because of -Os and -mthumb. Also, despite
being a GCC extension, __builtin_expect() is also supported by Clang.

Review URL: https://codereview.chromium.org/160673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251046 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces the prerequisites for the upcoming Android
backend tracing classes of the memory_inspector tool. In particular:
 - The mock_adb binary, which will be used by the unittests to mock
   adb responses.
 - The prebuilts_fetcher.py which pulls and syncs the prebuilts from
   GCS (in a similar way to what telemetry currently does).

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/158993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251045 0039d316-1c4b-4281-b951-d872f2087c98

When the supervised user changes his avatar, the change is
synced to his other devices, as well as to the settings of
the custodian who sees the updated avatar when opening the
supervised user import overlay.

BUG=339060
TEST=unit_tests

Review URL: https://codereview.chromium.org/147083016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251044 0039d316-1c4b-4281-b951-d872f2087c98

Didn't finish for M34, hiding the flag for the cut.

BUG=341556

Review URL: https://codereview.chromium.org/162833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251043 0039d316-1c4b-4281-b951-d872f2087c98

This is a non-perfect, temporary fix for the bug. It should be revisited after the M34 cut. There's e.g. discussions about tying this to getUserMedia. Bug for this: https://code.google.com/p/chromium/issues/detail?id=342770

BUG=342689

Review URL: https://codereview.chromium.org/152923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251041 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251040 0039d316-1c4b-4281-b951-d872f2087c98

This is the client side part, the server config is in CL 61376672.

BUG=338260,338289

Review URL: https://codereview.chromium.org/149503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251038 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251037 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dsinclair

Review URL: https://codereview.chromium.org/162883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251036 0039d316-1c4b-4281-b951-d872f2087c98

The trick is to leave action, username_element and password_element
fields of the form empty, this will stop the browser from autofilling
every form on the page with the credentials and will require user
interaction.
The user will have to click on the input box, select his login from
the drop down and click 'submit'. When this happens, Login Data will
be updated with the action url of the particular form.

Basically, since we don't know which form on the page is the one we 
have imported credentials for, we don't autofill anything until the 
user tells us. We'll remember his choice afterwards.

BUG=52513

Review URL: https://codereview.chromium.org/153043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331302
R=marja@chromium.org

Review URL: https://codereview.chromium.org/163073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251034 0039d316-1c4b-4281-b951-d872f2087c98

When smartcard auth is disabled we need to wipe the store and any open
sockets. By issuing a NULL cert being added this happens.

BUG=341500

Review URL: https://codereview.chromium.org/161653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329604

Review URL: https://codereview.chromium.org/162723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341224

Review URL: https://codereview.chromium.org/145813010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251031 0039d316-1c4b-4281-b951-d872f2087c98

Mavericks introduced [NSView setCanDrawSubviewsIntoLayer:] which I
suspect has changed some of the animation compositing pipeline.
Recently, the app launcher has been "tearing" the canvas while dragging
items around quickly.

This change ensures that the common ancestor view of the
NSCollectionView and the transitive layer used for custom drag
animations is layer-backed. This prevents the tearing.

BUG=341769
TEST=Drag items around the OSX app lanucher quickly - icons should
animate smoothly, without tearing.

Review URL: https://codereview.chromium.org/159573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251030 0039d316-1c4b-4281-b951-d872f2087c98

NativeAppWindowViews has Windows-specific code in #ifdefs. Move this
into derived class NativeAppWindowViewsWin.

BUG=None

Review URL: https://codereview.chromium.org/161753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251029 0039d316-1c4b-4281-b951-d872f2087c98

Applies the same renaming as http://crrev.com/142523003 and also removes obsolete methods.

Renamed methods:
- DeriveFont(size_delta, style) => Derive(size_delta, style)

Removed methods:
- DeriveFont(size_delta)
- GetAverageCharacterWidth()
  # Use GetExpectedTextWidth(1) instead.
- GetStringWidth(text)
  # Use gfx::GetStringWidth(text, font_list) instead.

BUG=265485
TEST=Run ui_unittests, views_unittests.

Review URL: https://codereview.chromium.org/138013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251028 0039d316-1c4b-4281-b951-d872f2087c98

Adding an Android repo manifest which will be used in the Android plus
ToT Chromium build setup.

BUG=None
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/160553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251027 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251026 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167047:167065&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/162713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251025 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan@chromium.org
BUG=341211

Review URL: https://codereview.chromium.org/143003031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251024 0039d316-1c4b-4281-b951-d872f2087c98

WebKitTestController::TimeoutHandler doesn't seem to be used anywhere.

Review URL: https://codereview.chromium.org/162903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251023 0039d316-1c4b-4281-b951-d872f2087c98

Fix mistake introduced in r247334. Webview needs more tests.

BUG=

Review URL: https://codereview.chromium.org/162523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251022 0039d316-1c4b-4281-b951-d872f2087c98

Added corresponding protocol buffer definitions for raw events, but in aggregated format.
Added EncodingEventSubscriber:
- encodes events in protocol buffer format
- (we need to test how much aggregation helps with reducing the size, if at all)
Added unit tests.

TODO in the future CLs: add event filtering, size-based windowing

Review URL: https://codereview.chromium.org/138913014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251021 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=341329

Review URL: https://codereview.chromium.org/162033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343049
R=msw@chromium.org

Review URL: https://codereview.chromium.org/152843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251019 0039d316-1c4b-4281-b951-d872f2087c98

Remove the unified IO code on the browser.

Unified IO is not used any more and it should be removed.

TBR=dalecurtis@chromium.org
BUG=337096
TEST=bots, and nothing breaks.

Review URL: https://codereview.chromium.org/163343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251018 0039d316-1c4b-4281-b951-d872f2087c98

RWHVA needs to deregister itself properly as an observer of
CompositorVSyncManager even if the compositor itself is destroyed.  Do this
properly by keeping a reference to the CompositorVSyncManager.

BUG=343199
TEST=local build, run on desktop Linux, Win7

Review URL: https://codereview.chromium.org/152983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251017 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=343565

Review URL: https://codereview.chromium.org/163783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251016 0039d316-1c4b-4281-b951-d872f2087c98