GitLab

Bug: 869513
Change-Id: Idd1db8f01eb27cb5b5cfdc063ee23b0dc09feb15
Reviewed-on: https://chromium-review.googlesource.com/1157167
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580283}

This is the next step in removing IO thread hopping from the
renderer-side non-Blink IDB code.

Bug: 717812
Change-Id: I4f0bfc8d98ad7bd9d041954f74215f75271702f9
Reviewed-on: https://chromium-review.googlesource.com/1155794Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580282}

The previous code doesn't check nullptrs thoroughly, causing
clusterfuzz pages to crash. This patch adds the checks for those cases
to make sure they don't crash.

Bug: 863338
Change-Id: Ibed005057fa376cb65200ad51e6dbb16bafa2c6a
Reviewed-on: https://chromium-review.googlesource.com/1142457
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580281}

Take the PageLoadMetricsWaiter and separate it from the
PageLoadMetricsBrowserTest so it can be used for specific observer
tests. Rename to PageLoadMetricsTestWaiter to reflect is is only
intended for testing purposes.

Change-Id: Id506c194ab658eba2b5364f201db140023baae72
Reviewed-on: https://chromium-review.googlesource.com/1158973
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580280}

This change implements subscribing to Gatt Notifications for WinRT and
enables corresponding tests.

Bug: 821766
Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
Reviewed-on: https://chromium-review.googlesource.com/1156686Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580279}

This change refactors the captured sites automation framework code out
of autofill_captured_sites_interactive_uitest. By completing this
refactor, other Chrome teams can leverage the captures sites
automation framework to test their team's features on real-world sites.

Also included in this change are a few minor fixes:
1. Fixed the captured sites autofill test to work with EventWaiters.
2. Modified a few test recipe files to address test breaks caused by
removing the client name parameter from autofill server queries.

Bug: 866152
Change-Id: Iee47cee8bd038ce0920caf6d63440c90c94b6285
Reviewed-on: https://chromium-review.googlesource.com/1147512
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580278}

New notifications for Top Sites or Suggestions would overwrite the
current custom links, regardless if custom links was initialized or not.
This would replace the tiles in the frontend with the new set of Top
Sites/Suggestions and break custom link functionality.

Bug: 856394
Change-Id: Id60459722448f626c1c21e2424cbfbe55df5b6c6
Reviewed-on: https://chromium-review.googlesource.com/1159325
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580277}

Bug: 870193
Change-Id: Ie7131514e1cf45f958dca11df8a142ea92440cad
Reviewed-on: https://chromium-review.googlesource.com/1159992Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580276}

There's just one field for the enabled bit so this one's trivial
(with an InnerEnable() function).

For reference the PR that introduced the new
InspectorSessionState / InspectorAgentState / Fields
was https://chromium-review.googlesource.com/c/chromium/src/+/1149201.
We're migrating things from state_ to this new mechanism,
which allows incremental updates to flow back to the browser
process.

Change-Id: I25b61b207354dee8eeeb9718dd5bbf205f769eea
Reviewed-on: https://chromium-review.googlesource.com/1159737Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580275}

Updates the sending of the Resolve request to no longer include cookies,
and to only include the URL when the Unified Conset helper's anonymous
data collection is enabled.

BUG=865104, 825428

Change-Id: Id33afbcca55ddafcade925d5e717ce1167701ae2
Reviewed-on: https://chromium-review.googlesource.com/1155839
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580274}

TBR=dcheng@chromium.org

Bug: 842872
Test: touch explore to within the VK; verify that if you wait for the window message to read, you get a hint thereafter.
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I136837ee7f20145aa09815f84d107613671eba1a
Reviewed-on: https://chromium-review.googlesource.com/1108923
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580273}

https://chromium.googlesource.com/catapult.git/+log/7110f0868455..eae13a4b34cc


git log 7110f0868455..eae13a4b34cc --date=short --no-merges --format='%ad %ae %s'
2018-08-02 wangge@google.com Add Test Runner to Long Term Health Tool


Created with:
  gclient setdep -r src/third_party/catapult@eae13a4b34cc

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390
TBR=sullivan@chromium.org

Change-Id: I27c7cae3d66f22240391425e227dbf14553609af
Reviewed-on: https://chromium-review.googlesource.com/1160787Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580272}

The option would seemingly allow the creation of HttpOnly cookies,
which is not permitted with the document.cookie API and we don't want
to introduce that capability here. This didn't work anyway as the API
would fail the cookie creation as coming from a non-HTTP source and
reject the script call, so just remove the option.

Spec issue: https://github.com/WICG/cookie-store/issues/41
Spec PR: https://github.com/WICG/cookie-store/pull/87

Bug: 729800
Change-Id: Id1115db5fbb432a3dd7647b565c5e7e8f45d4e14
Reviewed-on: https://chromium-review.googlesource.com/1160927
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580271}

This allows ProfileSyncService to start up in "standalone transport"
mode even if the user has disabled Sync-the-feature. In particular,
the disable reasons USER_CHOICE and PLATFORM_OVERRIDE and the
FirstSetupComplete state don't prevent Sync-the-transport from
starting up.

Still missing:
- GetState should now be renamed to GetTransportState.
- UI code hasn't been updated, so UI might show wrong state.
- New integration tests.

Bug: 856179
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59d3a4b548b279ec6cb5ca563747859dd9533618
Reviewed-on: https://chromium-review.googlesource.com/1148392Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580270}

This boolean needs to be reset in order to prevent an extra |Cancel| hit
for the ContextMenu.DelayedElementDetails metric.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I271a8d4ca58b854b92c1b09d8a8346f0f00d65a4
Reviewed-on: https://chromium-review.googlesource.com/1159600Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580269}

Use OnceCallback instead of Callback (which is an alias for
RepeatedCallback) in AddressSorter, take it by value instead of const
ref in Sort() method.  While this does not directly involve changing a
CompletionCallback into a Callback, it still belongs to that bug,
because this is blocking changing TestCompletionCallback::callback()
return type (at Bind() in AddressSorterTest.Sort).

Bug: 807724
Change-Id: Ib5b366143657e1a7bbb14be3583825831ecc0001
Reviewed-on: https://chromium-review.googlesource.com/1160385Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580268}

Add activity to measure Tracing API related timings. In particular it allows
to measure time for loading a given URL with or without tracing enabled. It
also provides the overall tracing time, i.e. time it takes from starting
tracing until completion when all traces are written to disk.

Example usage:
$ adb shell am start -n org.chromium.webview_shell/.WebViewTracingActivity -a VIEW -d \
  http://www.google.com --ez enableTracing true

BUG=797312

Change-Id: Iac5e871952d356762f351527b6aafdb4faf07255
Reviewed-on: https://chromium-review.googlesource.com/1153249
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580267}

Most of the functionality in these files interacts closely with layout and paint, so it makes sense
to put them in core/ to eliminate needless indirection. Since there are no remaining sub-classes of
ScrollableArea outside of core/ this is mostly a mechanical refactoring.

The PlatformChromeClient class is removed here, as it is now obsolete. Previously, the only
subclasses were ChromeClient (in core/page/) and a unit testing stub in
platform/scroll/scrollbar_test_suite.h. Since scrollbar_test_suite.h has moved into core/scroll/,
it can use EmptyChromeClient (from core/loader/), just as other unit tests in core/ do.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I08567764310b0190de45e40789d83ce80b600dd0
Reviewed-on: https://chromium-review.googlesource.com/1136888Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580266}

Bug: 869975
Change-Id: I4c3cb4c46372caa64bea6bbc1126743aa27b64ca
Reviewed-on: https://chromium-review.googlesource.com/1158971Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580265}

This reverts commit 7d8b7c2d.

Reason for revert: Need to revert https://crrev.com/c/1156998

Original change's description:
> Add in-process VizCompositorThread for software compositing.
> 
> We are having issues where starting a GPU process consistently fails on
> some systems. Currently OOP-D runs the display compositor in the GPU
> process always. This includes when both hardware acceleration and
> SwiftShader are disabled. If we can't start the GPU process, we can't
> run the display compositor and Chrome crashes.
> 
> This CL changes where the VizCompositorThread runs if the GPU access is
> disabled on Windows. We start the thread after giving up on the GPU
> process and create FrameSinkManagerImpl + dependencies on it.
> 
> Also fix chrome://gpu page so that OOP-D and surface sync features are
> still correct if |gpu_access_blocked| is true.
> 
> There is a lot of peripheral cleanup and code reuse possible as a follow
> up to this CL. It's not attempted here to make this easier to merge back
> to M69.
> 
> Bug: 849639
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: Ica6a3ec5b0e7951cb6807b135df4b4cfe410e394
> Reviewed-on: https://chromium-review.googlesource.com/1158723
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580241}

TBR=sadrul@chromium.org,kylechar@chromium.org,piman@chromium.org

Change-Id: I00fc978561630ef292436e2d44012a0931551d0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849639
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1161121Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580264}

Also move the autocomplete sync tests to their own file.

Bug: 869526
Change-Id: I49d75e522c41bce8aca8179c8adbdc475354dd58
Reviewed-on: https://chromium-review.googlesource.com/1157184
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580263}

Bug: 755840
Change-Id: Ia43352a67cb170ffa8d8177de0ba00ff8dbd6c68
Reviewed-on: https://chromium-review.googlesource.com/1158967
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580262}

This change removes the WebUSBOnSharedWorker flag and the Blink IDL
changes made to expose WebUSB in the SharedWorkerGlobalScope, since the
feature will not be implemented anytime soon.

Bug: 837414
Change-Id: I0bf49b8bb7fc9ded42d43732ed1c01c0b6831ffc
Reviewed-on: https://chromium-review.googlesource.com/1153222
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580261}

This matches the behavior of Cocoa textfields, and also makes it possible to
right-click paste at the end of a textfield.

Bug: 856609
Change-Id: Ic609b2bb78737d379e7e0a57ab3f4c7f16a3cec9
Reviewed-on: https://chromium-review.googlesource.com/1160768
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580260}

This change creates an Origin Trial for the Shape Detection API.

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eJnB-5Sg-mQ/uvdWnO2OBQAJ

Bug: 646035
Change-Id: Ib7b18f8544c0f9d7d4bb8730102800d63cc54c9f
Reviewed-on: https://chromium-review.googlesource.com/1159684Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580259}

Current iteration:
1. Autocomplete queries will only autocomplete if it is confident in a
   url or text query (no apps or answer cards).
2. Autocomplete is based off of the first result view in the
   SearchResultPageView.
3. Up/Down/Left/Right/Tab keys all trigger autocomplete.

Bug: 865543
Change-Id: I579a6f1fb4cdc2af5e7a43577a73a843663e5e8c
Reviewed-on: https://chromium-review.googlesource.com/1161014Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#580258}

TBR=dcheng@chromium.org

Bug: 865063
Change-Id: Ieca1efe67cbc9b0340f4bc9f1e0e5af9a0a0391d
Reviewed-on: https://chromium-review.googlesource.com/1160442
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580257}

This improves link time of binaries.

Bug: 794423, 702625
Change-Id: Ib82cd52851339936881c989282bb41a349e769bc
Reviewed-on: https://chromium-review.googlesource.com/1154771
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580256}

This patch adds one-time IPH for the bottom toolbar for the first time
that it is enabled. The help bubble appears under the bottom toolbar
and states that the icons have moved to the bottom of the screen.

Bug: 862611
Change-Id: I597401a1030cc9f0c4ea3537bcf9a597b8d28275
Reviewed-on: https://chromium-review.googlesource.com/1138729
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580255}

This relands commit e63be647.

This originally got reverted because it broke generate_build_files
on chromium.perf/Win Builder.

Bug: 830892

Original change's description:
> Add logging and chrome_utils directories
>
> Bug: 830892
> Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045
> Reviewed-on: https://chromium-review.googlesource.com/1158719
> Reviewed-by: Joe Mason <joenotcharles@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Oliver Li <olivierli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580163}

TBR=pkasting@chromium.org,joenotcharles@chromium.org,dullweber@chromium.org

Change-Id: I526ff309c639ef26c8a8f2e98722aa730cc3e911
Reviewed-on: https://chromium-review.googlesource.com/1160776Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580254}

In https://chromium-review.googlesource.com/c/chromium/src/+/1151715
I missed one of the tests. Enable it now.

Bug: 767926
Change-Id: I6c8aaa9c6e5a955be747df4fba1f8a3e95166ca7
Reviewed-on: https://chromium-review.googlesource.com/1159348Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580253}

Doesn't seem to break anything.

Bug: 647842
Change-Id: I5151602cc62a6c14bff5ac1398cd7f8cd01d1555
Reviewed-on: https://chromium-review.googlesource.com/1159354Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580252}

Fixes small conflict after crrev.com/c/1036524.

Bug: None
Test: cast_media_unittests
Change-Id: Ib0a83c0074c6f9f7b9532cefe10c7331ec11e645
Reviewed-on: https://chromium-review.googlesource.com/1160932
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580251}

Excluding ios12-sdk-xcode-clang
Uploaded xcode10 beta 5 10L221o to cipd along with
runtimes iOS 10.3.simruntime and iOS 11.4.simruntime.

  infra_internal/ios/xcode/mac  10l221o
  infra_internal/ios/xcode/ios  10l221o

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If598b51a86f261c2fdcaa0b0ec0e2ec4d15db3ac
Reviewed-on: https://chromium-review.googlesource.com/1158608
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580250}

Removed using SelectableItemView in download home. Instead properties for
selected and selectionModeActive will be set into the ListItem from the mediator.

Bug: 850600, 868205
Change-Id: I36d98b4f7cfde8d6c8a93adae091cd8024b14e3c
Reviewed-on: https://chromium-review.googlesource.com/1150810Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580249}

Normally we set focus on mousedown and touchstart.
But if the page doesn't have any touch handlers we
filter out all the touch events and so the view
will not get the focus. So when a gesture tap comes
to generate mouse events and etc page doesn't have
focus. This CL also adds the foucs on gesture tap
to make sure the appropriate view is focused. If
the view is already focus due to previous touch start
or mouse down this does nothing.

Bug: 861998
Change-Id: Icf10910533d694111fe6c106fbb41b48f57165d5
Reviewed-on: https://chromium-review.googlesource.com/1158714
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580248}

This CL has a few tiny cleanups:
- Uses {} in conditionals if either the body or the condition
 is >1 line.
- base::ContainsValue() for ease of reading.
- Uses early return.

No logical changes intended.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1085ba8084982c2e78aa57052c4b8d05b3f72dc7
Reviewed-on: https://chromium-review.googlesource.com/1160763Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580247}

There's only one field, for the enabled_ state. I made
an InnerEnable private function so we don't need a seperate
boolean to distinguish any more.

Change-Id: I65cc41c775d0c01ea10ce54c261b36d1e92dc7fe
Reviewed-on: https://chromium-review.googlesource.com/1159687Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580246}

There's no need to define _LAST enumerators, since Mojo provides these
automatically.

Bug: 742517
Change-Id: Ibafea09dd000cf14db4033790bef6a860b5030e6
Reviewed-on: https://chromium-review.googlesource.com/1159263Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580245}

ET_SCROLL_FLING_START/CANCEL are represented as GestureEvents if
EF_FROM_TOUCH is set, otherwise ScrollEvents. The deserializer always
treated them as ScrollEvents.

BUG=867035
TEST=covered by test

Change-Id: I2540ccc8766fbf59eafa0c3beadd8dd2e4ec4ade
Reviewed-on: https://chromium-review.googlesource.com/1159621
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580244}