GitLab

BUG=396645

Review URL: https://codereview.chromium.org/557433002

Cr-Commit-Position: refs/heads/master@{#293796}

https://chromium.googlesource.com/chromium/blink/+log/86ce4af33b763b24cf2365d8cd19a2ebade676c3..09bd97099a92cf983363f8db6c6c2178b0cd7c6a
TBR=arv@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/557443002

Cr-Commit-Position: refs/heads/master@{#293795}

BUG=412086
TBR=lfg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/552013002

Cr-Commit-Position: refs/heads/master@{#293794}

This CL introduces util_unittest.cc, which acts as a place for current and
future functions in util.h.

BUG=411108

Review URL: https://codereview.chromium.org/552433002

Cr-Commit-Position: refs/heads/master@{#293793}

Speculative, to see if it helps with

==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
    #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
    #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
    #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
    #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
    #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
    #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
    #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
    #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
    #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
    #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
    #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
    #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
    #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
    #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894

Started happening here
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/98
(see stdio for symbols), and this looks like the only change in that
build.

This reverts commit c76ef732.

BUG=384644
TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/550413002

Cr-Commit-Position: refs/heads/master@{#293792}

Review URL: https://codereview.chromium.org/549753002

Cr-Commit-Position: refs/heads/master@{#293791}

Revert of Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/554843002/)

Reason for revert:
I unchecked cq, not sure why this revert was landed. (I want to revert https://codereview.chromium.org/469993003/ instead)

Original issue's description:
> Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/543663003/)
>
> Reason for revert:
> Speculative, to see if it helps with
>
> ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
>     #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
>     #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
>     #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
>     #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
>     #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
>     #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
>     #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
>     #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
>     #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
>     #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296
>     #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
>     #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
>     #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
>     #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
>     #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
>     #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894
>
> Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.)
>
> Line 1164 is
>
>   if (params.visible_on_all_workspaces) {
>     state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY"));
>     ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops);
>   }
>
> https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
>
> Original issue's description:
> > Fix maximize on some window managers
> >
> > On some window managers the Maximize hints are not respected when they
> > are set on an unmapped window. There was an existing workaround for this
> > in the code, but the workaround failed whenever ShowWindowWithState
> > didn't happen to be called with the parameters needed to activate the
> > workaround. This meant that if a window was first made visible and later
> > activated, it would not get maximized at all.
> >
> > This fix saves whether the maximize hints need to be sent to the window,
> > and makes sure it gets done after mapping the window.
> >
> > BUG=
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be
>
> TBR=erg@chromium.org,arjanl@opera.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/013b6d4051e8e2c8960faa12b92e273925aaee5b

TBR=erg@chromium.org,arjanl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/551123002

Cr-Commit-Position: refs/heads/master@{#293790}

If you have the internal Chrome Android checkout and build for linux,
the #ifdef around this code will be satisfied
(SPDY_PROXY_AUTH_ORIGIN will be defined) but it fails to compile.

NOTRY=true

Review URL: https://codereview.chromium.org/556603002

Cr-Commit-Position: refs/heads/master@{#293789}

This is required at least on Windows as it's used by system headers to
control things like assert, etc.

R=brettw@chromium.org
BUG=335824,354261

Review URL: https://codereview.chromium.org/475153002

Cr-Commit-Position: refs/heads/master@{#293788}

Review URL: https://codereview.chromium.org/513313004

Cr-Commit-Position: refs/heads/master@{#293787}

Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/543663003/)

Reason for revert:
Speculative, to see if it helps with

==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
    #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
    #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
    #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
    #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
    #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
    #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
    #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
    #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
    #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296
    #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
    #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
    #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
    #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
    #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
    #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894

Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.)

Line 1164 is

  if (params.visible_on_all_workspaces) {
    state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY"));
    ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops);
  }

https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Original issue's description:
> Fix maximize on some window managers
>
> On some window managers the Maximize hints are not respected when they
> are set on an unmapped window. There was an existing workaround for this
> in the code, but the workaround failed whenever ShowWindowWithState
> didn't happen to be called with the parameters needed to activate the
> workaround. This meant that if a window was first made visible and later
> activated, it would not get maximized at all.
>
> This fix saves whether the maximize hints need to be sent to the window,
> and makes sure it gets done after mapping the window.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be

TBR=erg@chromium.org,arjanl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/554843002

Cr-Commit-Position: refs/heads/master@{#293786}

BUG=412042
TBR=jschuh@chromium.org

Review URL: https://codereview.chromium.org/556573003

Cr-Commit-Position: refs/heads/master@{#293785}

TEST=run the script:
enter 'u' to upload, login and verify that uploading is successful.
Back at the prompt, enter 'p' to publish publically. Verify ChromeVox updates.

Review URL: https://codereview.chromium.org/515723005

Cr-Commit-Position: refs/heads/master@{#293784}

BUG=None
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/550503003

Cr-Commit-Position: refs/heads/master@{#293783}

BUG=410527
R=rsesek, DaleCurtis

Review URL: https://codereview.chromium.org/533423002

Cr-Commit-Position: refs/heads/master@{#293782}

BUG=406014
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/538143002

Cr-Commit-Position: refs/heads/master@{#293781}

Revert of Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/)

Reason for revert:
Broke Linux ChromiumOS Tests (dbg)(3)

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace()
#1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f3bc709f4a0 <unknown>
#3 0x7f3bc7151a43 __poll
#4 0x7f3bc7b8dff6 <unknown>
#5 0x7f3bc7b8e124 g_main_context_iteration
#6 0x7f3bcf366f35 base::MessagePumpGlib::Run()
#7 0x7f3bcf468180 base::MessageLoop::RunHandler()
#8 0x7f3bcf4cfcc2 base::RunLoop::Run()
#9 0x0000041e0729 content::RunThisRunLoop()
#10 0x0000041e06ba content::RunMessageLoop()
#11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult()
#12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
#13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
#14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop()
#15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run()
#17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo()
#18 0x0000041c9c25 base::internal::Invoker<>::Run()
#19 0x00000063f0de base::Callback<>::Run()
#20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun()
#22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun()
#24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run()
#25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo()
#26 0x7f3bd7bd960a base::internal::Invoker<>::Run()
#27 0x7f3bd80a852e base::Callback<>::Run()
#28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow()
#29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks()
#30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize()
#31 0x7f3bd7bcda55 content::BrowserMain()
#32 0x7f3bd7a6224f content::RunNamedProcessTypeMain()
#33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run()
#34 0x7f3bd7a617b5 content::ContentMain()
#35 0x0000041c82cb content::BrowserTestBase::SetUp()
#36 0x00000176afc3 InProcessBrowserTest::SetUp()
#37 0x000000674823 ExtensionBrowserTest::SetUp()
#38 0x000000674852 ExtensionBrowserTest::SetUp()
#39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>()
#41 0x00000180ad73 testing::Test::Run()
#42 0x00000180b4cb testing::TestInfo::Run()
#43 0x00000180baca testing::TestCase::Run()
#44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests()
#45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>()
#47 0x000001810c97 testing::UnitTest::Run()
#48 0x0000041a5531 RUN_ALL_TESTS()
#49 0x0000041a4547 base::TestSuite::Run()
#50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite()
#51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#52 0x0000041d9efb content::LaunchTests()
#53 0x00000176954b LaunchChromeTests()
#54 0x00000080262f main
#55 0x7f3bc708a76d __libc_start_main
#56 0x0000005ffda9 <unknown>
[123/334] CommandsApiTest.ContinuePropagation (TIMED OUT)

Original issue's description:
> Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands.
>
> ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string.
>
> Previously, only the latter case was handled when trying to continue propagating keys.
>
> BUG=407163
> TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*).
>
> Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a

TBR=finnur@chromium.org,dtseng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407163

Review URL: https://codereview.chromium.org/552533003

Cr-Commit-Position: refs/heads/master@{#293780}

Split the Website Settings page's origin list into Allowed and Blocked lists when both lists exists.

BUG=372607

Review URL: https://codereview.chromium.org/542203003

Cr-Commit-Position: refs/heads/master@{#293779}

Please see https://codereview.chromium.org/510323002 for reference.

BUG=None

Review URL: https://codereview.chromium.org/546243002

Cr-Commit-Position: refs/heads/master@{#293778}

The previous approach used pref_names::kInstallForceList directly, change it to an observer of ExtensionManagement class instead.

BUG=177351
TEST=ExtensionServiceTest,ExternalPolicyLoaderTest

Review URL: https://codereview.chromium.org/536573003

Cr-Commit-Position: refs/heads/master@{#293777}

We restrict futex operations to everything but "priority inheritance".

BUG=408847
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32

Review URL: https://codereview.chromium.org/549653002

Cr-Commit-Position: refs/heads/master@{#293776}

Following the steps done in https://codereview.chromium.org/323163003/

Not sure how to test this, any guidance?

I want the sync_integration_tests binary to be stored in
official Chrome build gs:// drops just like
browser_tests and other test binaries already are. Then
I can set up automation to approve new releases of Sync
server.

BUG=411389

Review URL: https://codereview.chromium.org/545103003

Cr-Commit-Position: refs/heads/master@{#293775}

BUG=
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/547793002

Cr-Commit-Position: refs/heads/master@{#293774}

in webrtc. Our resampler is capable of handling any sample rates.

This has been reviewed here:
https://codereview.chromium.org/548503002/

BUG=411241
TBR=xians,dalecurtis
NOTRY=true

Review URL: https://codereview.chromium.org/554733002

Cr-Commit-Position: refs/heads/master@{#293773}

BUG=352293

Review URL: https://codereview.chromium.org/546943002

Cr-Commit-Position: refs/heads/master@{#293772}

Note that this copy may not be completely in sync with the renderer’s copy. That’s OK.

BUG=407376
TEST=no visible change
R=creis@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/551443002

Cr-Commit-Position: refs/heads/master@{#293771}

BUG=352293

Review URL: https://codereview.chromium.org/538063003

Cr-Commit-Position: refs/heads/master@{#293770}

BUG=409226
TEST=unittest and visual

Review URL: https://codereview.chromium.org/544383003

Cr-Commit-Position: refs/heads/master@{#293769}

It was running in Chrome's unit_tests for historical reasons.

* Remove usage of Chrome's TestExtensionPrefs by instantiating our own
  simplified ExtensionPrefs.
* Move ShellAppSorting to NullAppSorting so it can be used for the above
  as well as app_shell.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/549663002

Cr-Commit-Position: refs/heads/master@{#293768}

When switching users, we used to focus the profile that initiated the
action. This causes weird skip-a-roos if you try to tab to a different
pod before the forced focus completes, so don't focus any pods by default.

BUG=410718
TEST=Start Chrome with --enable-new-menu. Click on "Switch Person". The
User Manager should come up, no pods should be focused, and if you try
to left arrow or right arrow really fast, the pods shouldn't jump focus.

Review URL: https://codereview.chromium.org/546953002

Cr-Commit-Position: refs/heads/master@{#293767}

Code refactoring for location provider while registering for location updates.
While registering the location provider for location updates location updates are requested
redundantly for gps enabled or disabled code.

BUG=411182

Review URL: https://codereview.chromium.org/546633004

Cr-Commit-Position: refs/heads/master@{#293766}

[FAIL] org.chromium.content.browser.input.ImeTest#testSelectActionBarClearedOnTappingInput:
junit.framework.AssertionFailedError
  at org.chromium.content.browser.input.ImeTest.assertWaitForSelectActionBarStatus(ImeTest.java:698)
  at org.chromium.content.browser.input.ImeTest.testSelectActionBarClearedOnTappingInput(ImeTest.java:206)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
  at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
  at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
  at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
  at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

BUG=412004
TBR=keishi, jdduke, aurimas

Review URL: https://codereview.chromium.org/553833003

Cr-Commit-Position: refs/heads/master@{#293765}

This is to support querying GCM channel status for all users. This
is needed to drop the sign-in enforcement.

BUG=384041
TEST=new tests added

Review URL: https://codereview.chromium.org/530253002

Cr-Commit-Position: refs/heads/master@{#293764}

The settings page will now have two options near the profile management,
which will control whether Browse As Guest and Add Person will be
available from the User Manager. These settings will not be available to supervised users, and will appear only on Desktop OSes.

Also, add a new enterprise policy for the Enable Add Person preference (Browse As Guest policy already exists).
BUG=406473

NOTE: I will remove PRESUBMIT.py from this CL before landing it. It needs to be modified to upload to rietveld from my Windows machine, see crbug.com/409029

Review URL: https://codereview.chromium.org/518063002

Cr-Commit-Position: refs/heads/master@{#293763}

While working on a fix to issue 408594, we'll disable eager gesture detection.

BUG=408594

Review URL: https://codereview.chromium.org/536843003

Cr-Commit-Position: refs/heads/master@{#293762}

Original review here: https://codereview.chromium.org/543433002

This CL includes path fixes that are required due to directory structure changes in the new revision(s)

TBR=tommi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/545003004

Cr-Commit-Position: refs/heads/master@{#293761}

Follow-up to https://codereview.chromium.org/525513003 to fix includes
of Pepper files when ENABLE_PLUGINS isn't defined (Ozone ECS builder).

BUG=none
TBR=markus@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/554693002

Cr-Commit-Position: refs/heads/master@{#293760}

Previous tests were flaky and keep getting disabled.

BUG=

Review URL: https://codereview.chromium.org/545643002

Cr-Commit-Position: refs/heads/master@{#293759}

BUG=none

Review URL: https://codereview.chromium.org/542313003

Cr-Commit-Position: refs/heads/master@{#293758}

Found by clang, which says:

..\..\sandbox\win\sandbox_poc\pocdll\handles.cc(156,34) :  warning(clang): precision used with 'Z' conversion specifier, resulting in undefined behavior [-Wformat]
                      "Type: %-13.13wZ Path: %wZ\r\n",
                             ~~~~^~~~~

"undefined behavior" is a bit too strong language for a vendor-defined type,
but http://msdn.microsoft.com/en-us/library/0ecbz014.aspx doesn't document
what precision does for %Z, and in practice it seems to be ignored (see
http://llvm.org/PR20876). So don't use it.

No intended behavior change.

BUG=82385
R=scottmg@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/552663004

Cr-Commit-Position: refs/heads/master@{#293757}