- 08 May, 2018 40 commits
-
-
Blake O'Hare authored
The result of GetFocusedFrame() can be null. I discovered this while using this value in a debug log statement, not from actual production code, so there is no known user-facing crash or bug at this point. Change-Id: Ie272aa67d2c0b9d60f62f670091e6ee3ac08b82d Reviewed-on: https://chromium-review.googlesource.com/1046505Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556705}
-
Noel Gordon authored
These AudioPlayerBrowserTest run on a target_os="chromeos" linux build which attempts to use PulseAudio for audio, and always fails [1]. The tests still PASS, since they don't need to test lower-layer audio, but they do output PulseAudio LOG failure messages. To avoid that, use a fake audio layer instead, which can be requested by a media command- line switch kDisableAudioOutput after crrev.com/539638. [1] PulseAudio won't work in this case and the LOG output of the tests indicate that (see bug 835626 comments #3 and #7). Bug: 835626,835742 Change-Id: I8113c15a123bfb8048141e7a20c8d02cf3341e13 Reviewed-on: https://chromium-review.googlesource.com/1047045Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556704}
-
Kunihiko Sakamoto authored
This reverts commit ddd9f0ee. Reason for revert: Speculative revert for animation-worklet-scroll-timeline.html failure on WebKit Linux Trusty Leak bot. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/18614 Original change's description: > Composite ScrollTimeline scrollSource when appropriate. > > This CL makes being the scrollSource of an active (i.e. the scrollSource is > scrollable) and attached (i.e. it is being used by at least one WorkletAnimation > as a timeline) ScrollTimeline a compositing reason. It does not change the > requirement that the scrollSource must be composited for the WorkletAnimation to > be sent to the compositor, nor does it change the case where a scrollSource stops > being composited whilst a WorkletAnimation is running. Those will be addressed in > follow-up CLs. > > Bug: 776533 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231 > Reviewed-on: https://chromium-review.googlesource.com/1036934 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556541} TBR=pdr@chromium.org,majidvp@chromium.org,smcgruer@chromium.org Change-Id: I615c3bfd9b9c6346b3a521a6922af3f56da6c308 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776533 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1049207Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556703}
-
Kunihiko Sakamoto authored
This reverts commit 2f1216f9. Reason for revert: Caused use-of-uninitialized-value in Linux MSan Tests bot. https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/9657 Looks like client_socket_factory_ is not initialized? Original change's description: > [network service] Add an API to upgrade a TCP socket to a TLS socket > > This CL: > - Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of > mojom::TCPConnectedSocket can perform TLS connect on top of an already > connected tcp client socket. > - Adds a tls_socket.mojom file which includes the interface definition of > TLSClientSocket. > > Other changes to support implementing UpgradeToTLS(): > - Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in > socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive > side in preparation for UpgradeToTLS() without worrying that data might be > buffered by the tcp socket. > - Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp > socket to cancel a pending ReadIfReady() and unregister their event watchers. > > Bug: 721401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744 > Reviewed-on: https://chromium-review.googlesource.com/1034080 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556605} TBR=mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org Change-Id: Iaa5ad743e7cdf90239675cef6f34457ea8b5be8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1049206Reviewed-by:
-
Fady Samuel authored
The name ResizeOrRepaint is a misnomer. This CL renames it to something more appropriate. This CL also renames the resize_ack_pending_ to visual_properties_ack_pending_. Bug: 672962 Change-Id: Ibee6540617d0bcd4e5bf2f2492beb618aff19255 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1048113 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556701}
-
Kunihiko Sakamoto authored
This reverts commit b5d6fee9. Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672 Original change's description: > Use GG700 / Chrome icon color for toolbar > > Replaces GG800 with GG700 as icon color in a couple of places: > > * Omnibox default chip (HTTP (i) icon for instance). > * BubbleIconView inside omnibar (these used to be GG700 but regressed > to GG800 in Touchable / Refresh recently). > * Toolbar button icons. > > Bug: chromium:821996, chromium:834510 > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef > Reviewed-on: https://chromium-review.googlesource.com/1040875 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556646} TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:821996, chromium:834510, chromium:840657 Reviewed-on: https://chromium-review.googlesource.com/1049445Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 835626 Change-Id: I1f2037fe9bebc3005b561440f6ead2dd3eadf80c Reviewed-on: https://chromium-review.googlesource.com/1049090Reviewed-by:
-
Renee Wright authored
This test was failing in debug. onRemoveTap_: function(event) { this.showRemoveDialog_ = true; this.async(() => this.$$('#removeDialog').showModal()); }, in cs.chromium.org/chromium/src/chrome/browser/resources/settings/crostini_page/crostini_subpage.js always comes up with this.$$('#removeDialog').showModal == undefined in debug. I do not know why. But this dialog is being replace with a View dialog very soon anyway. Bug: 838097 Change-Id: Id78b498ee9ce54849793eb9518bbb513a426f13d Reviewed-on: https://chromium-review.googlesource.com/1036710 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556698}
-
Ramin Halavati authored
Network traffic annotation is added to sockets write functions and hence their create functions do not need to be tested in traffic annotation tests anymore. Hence unnecessary code is removed from traffic_annotation_auditor. Bug: 690323 Change-Id: I70676ea7dab9f1db3a6d5c3625d85dda6ddc8a11 Reviewed-on: https://chromium-review.googlesource.com/1046166Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#556697}
-
Renee Wright authored
Method names such as StartVmConcierge are confusing. Rename to StartConcierge etc. third_party/cros_system_api/dbus/debugd/dbus-constants.h still has const char kStartVmConcierge[] = "StartVmConcierge"; const char kStopVmConcierge[] = "StopVmConcierge"; as these need to match the method names in the service. Bug: 839206 Change-Id: I48800e595a2756fd8bc8d35ca136dd73a825b08e Reviewed-on: https://chromium-review.googlesource.com/1041365 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556696}
-
Alan Cutter authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1029882 with debug linkage fixed. Original description: The code was written with the expectation that HostedAppButtonContainer::StartTitlebarAnimation() is called before HostedAppButtonContainer::OnImmersiveRevealStarted(). This is not the case when in tablet mode and results in crashes. This CL updates HostedAppButtonContainer to allow these methods to be called in either order. Bug: 836482 Change-Id: Ia862c8bfccf448322cb878892e70b38eb68818e4 Reviewed-on: https://chromium-review.googlesource.com/1045955 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556695}
-
Sasha Morrissey authored
Fix bug where selecting a folder in a Team Drive in the Files App doesn't update the currently selected folder in the left-hand directory tree. ensure it is reflected in the LHS. Test: Select a folder in the RHS in the Files App in a team drive and Bug: 840207 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieeb9be680a043498bfbbb8f12eb38b8015c4d6bb Reviewed-on: https://chromium-review.googlesource.com/1045957Reviewed-by:
-
Malay Keshav authored
This patch inverses the ui scales before sending them as output device scale factor. Bug: 840107 Change-Id: I19eb520818281161abd53230b8cabcd0d40e1ebd Component: wayland, scaling, aura shell Reviewed-on: https://chromium-review.googlesource.com/1049115 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556693}
-
Jennifer Apacible authored
Currently, we don't close the existing Picture-in-Picture window when the a new tab (i.e. content::WebContents) initiates Picture-in-Picture mode. This change tears down Picture-in-Picture mode for the current video before opening a new one. This change also pauses the video on user gesture to close. When the Picture-in-Picture window is closed, the video in tab will not continue playing, even if it was playing in the window. BUG: 823172 Change-Id: I15e4ada29c6447fd15751503e1ad41868a89e71a Reviewed-on: https://chromium-review.googlesource.com/1044752 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 77db7fb7. With Chromium commits locally applied on WPT: 8d1dda31 "Revert "Adds a test for basic WebRTC video codec conformance."" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17145 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=raphael.kubo.da.costa@intel.com No-Export: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0aaea7e106de989a660cd820d618d4a7bb774486 Reviewed-on: https://chromium-review.googlesource.com/1049029 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556691}
-
Jiaquan He authored
This commit: - breaks the inheritance relationship of ChromeSearchResult and SearchResult; - removes all SearchModel class references from Chrome; - removes ChromeSearchResult::Duplicate and uses SearchResultMetadata to publish results. Bug: 733662 Change-Id: Iacf407818d74a69daa06c6649cfbf255b8921df4 Reviewed-on: https://chromium-review.googlesource.com/1038766Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#556690}
-
John Chen authored
Currently, ChromeDriver closes desktop Chrome by simply killing the top-level Chrome process. This isn't graceful, and causes problems in some scenarios. This commit sends a Browser.close command to close the browser gracefully. Bug: chromedriver:2311 Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7 Reviewed-on: https://chromium-review.googlesource.com/1037585 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#556689}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cee97214012..9ad6814d5f1e $ git log 6cee97214..9ad6814d5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide022b70ed3106a81564148f2e46bd710f2ffeed Reviewed-on: https://chromium-review.googlesource.com/1048834Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556688}
-
Daniel Cheng authored
Bug: 816778 Change-Id: Ib5ab2e9d89fa2e49a3e273b09ab20ce511163856 Reviewed-on: https://chromium-review.googlesource.com/938567Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556687}
-
John Budorick authored
TBR=bsheedy@chromium.org Bug: 840638 Change-Id: I3acc6d00d75f6c6dce370961d7459dc3a50faef4 Reviewed-on: https://chromium-review.googlesource.com/1049274Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#556686}
-
Ian Vollick authored
Previously, we'd plumbed the display rotation as an integral angle, but the only valid values were 0, 90, 180 and 270 degrees. We then converted to an enum. With this CL, we plumb the enum directly. Bug: 836948 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ia99aa7543188fb56f9595cea835b2dfee496f811 Reviewed-on: https://chromium-review.googlesource.com/1045910 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556685}
-
Yuly Novikov authored
We need to reduce the load on Vk N5X bots in order to be able to run dEQP Vk tests on them. Bug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I036c98e02e22c269399feed20225ecd6759cb413 Tbr: kbr@chromium.org No-try: true Reviewed-on: https://chromium-review.googlesource.com/1048210 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#556684}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife9b0b37224aa2f59cc1b907f340388b05c7c477 Reviewed-on: https://chromium-review.googlesource.com/1033996Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556683}
-
Bence Béky authored
Send HTTP/2 PRIORITY frames when the priority of an HTTP or WebSocket request backed by an HTTP/2 stream changes. Bug: 166689, 500673 Change-Id: Icd1dd31ff9893215110e26d2f7100912e2a9e7a8 Reviewed-on: https://chromium-review.googlesource.com/1045988 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556682}
-
Darren Shen authored
This patch adds a new private API getting the composition bounds of the currently focused text field. This will be used by the inline handwriting feature, and may be used for full screen handwriting. Bug: 824604 Change-Id: I33e66684ffb6d551e5acf8d13057e047ce1311c8 Reviewed-on: https://chromium-review.googlesource.com/1043666 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
-
tzik authored
As std::random_shuffle is deprecated in C++14, and removed in C++17, its usage blocks the transition to C++17. This CL adds base::RandomShuffle as the replacement, updates all users, and adds a presubmit check to ban std::random_shuffle. Bug: 752720 Change-Id: I99a9dd267e56c04176cf3dc1f6bb7025cdb1deb6 Reviewed-on: https://chromium-review.googlesource.com/1023495Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#556680}
-
Alex Kalugin authored
_ProcessEntry function (which is called only on win) uses shlex.split to split command line arguments. shlex.split function operates in posix mode by default and stripps out all quotes, therefore arguments with spaces in them are split into separate arguments and misinterpreted later. For example -D"MY_DEFINE=\"MY VALUE\"" command line argument is converted in two arguments -DMY_DEFINE=\MY VALUE\. Change-Id: Ie0e92a903782c7f2578d2c99a61fc9c6f4bf57e3 Reviewed-on: https://chromium-review.googlesource.com/1046966Reviewed-by:
-
Fredrik Hubinette authored
This is the first step towards implemeing support for the "SDR brightness" slider in windows 10 RS4. It may also come in handy for implementing brightness-adjusted pseudo-HDR on android devices. Bug: 823547 Change-Id: If9dbdb1b0c56916d3422ba502c3322d9cfe9b385 Reviewed-on: https://chromium-review.googlesource.com/1048685Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#556678}
-
Tetsui Ohkubo authored
This reverts commit edd33a2c. Reason for revert: All ash focus rings are broken Original change's description: > Remove border outline when focused when tab key is used. > > Bug: b/74415372 > Test: Manually Tested > Change-Id: I4e3e5a5b48054b6a7c59e2a02b38b0d200885fee > Reviewed-on: https://chromium-review.googlesource.com/1009243 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Sara Kato <sarakato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554301} TBR=yoshiki@chromium.org,oshima@chromium.org,yawano@chromium.org,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=b/74415372,838850 Change-Id: Id2bafab905a039f634ebcf62a6ab0f919274564d Reviewed-on: https://chromium-review.googlesource.com/1049205 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#556677}
-
Koji Ishii authored
Following bot results are included. 5210 5211 5212 5213 5214 5215 5218 5223 5225 5234 5242 5250 3 lines were removed and 8 lines were deflaked by consecutive results since 5152. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I21b84e82e702b280263c307f74598596ec502f75 Reviewed-on: https://chromium-review.googlesource.com/1045952 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556676}
-
Kunihiko Sakamoto authored
This reverts commit 71098015. Reason for revert: ios build is still broken. https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59679 Original change's description: > Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits) > > https://webrtc.googlesource.com/src.git/+log/823f9135f858..d5ef6ff258da > > $ git log 823f9135f..d5ef6ff25 --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > BUG=chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402 > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Ibaedd51469f75941f90aed9f4ba6bb686cd79f6c > Reviewed-on: https://chromium-review.googlesource.com/1048112 > Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556561} TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I2823387c7aadad799befbf88cc5b4503a379dd3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:None, chromium:840347, chromium:839860, chromium:838402 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1049345 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
InlineBoxTraversal is not supposed to alter the layout tree, so its member functions should return const pointers. Some member functions always return non-null values, so their return types are changed to const references to beffer clarity. This is also a preparation patch for crrev.com/c/1038058, splitting off some of its trivial changes to reduce the size of the big patch. Bug: 822575 Change-Id: I9c32814a88d42e9115be97425b0e0015c4d1779d Reviewed-on: https://chromium-review.googlesource.com/1048785Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#556674}
-
Alexey Kozyatinskiy authored
Network should not be intsrumented with JavaScript AsyncTask instrumentation since it does not trigger JS execution explicitly. R=pfeldman@chromium.org Bug: chromium:840502 Change-Id: I07a939b7f583b0330fa40afb0326a40e58918547 Reviewed-on: https://chromium-review.googlesource.com/1049107 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556673}
-
Ted Choc authored
This reverts commit 76b70285. Reason for revert: ava.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:210) at org.chromium.chrome.browser.TabsTest.runToolbarSideSwipeTestOnCurrentModel(TabsTest.java:1627) at org.chromium.chrome.browser.TabsTest.testToolbarSwipeOnlyTab(TabsTest.java:1477) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:114) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) Original change's description: > Attempt to deflake TabsTest#testToolbarSwipePrevTab* > > This patch updated the toolbar swipe tests to not depend on criteria > helpers and operate on about:blank pages rather than the ntp. Most > importantly, this fixes an issue where we assert tab selection before > waiting for the callback. > > Bug: 813584 > Change-Id: I1e743291add6398bc3eebc06c03c6c69cefc21f9 > Reviewed-on: https://chromium-review.googlesource.com/1044538 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556240} TBR=tedchoc@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813584 Change-Id: I5a6e7d7f585cae58772eb2474b08b45a2d71439c Reviewed-on: https://chromium-review.googlesource.com/1048646 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556672}
-
Emil A Eklund authored
In legacy layout multi-line image mask painting is handled by giving the entire width of the element to the painting code and then clipping it to ensure the left edge is omitted for all but the first line and the right edge is for all but the last. This is inefficient and different from how the logic to omit edges is implement for other border/image paint calls. This change adds include_logical_left_edge/include_logical_right_edge to the NinePieceImageGrid constructor and uses these new parameters to size the left and right edges respectively. Matching existing painting logic. Bug: 714962 Test: fast/borders/inline-mask-overlay-image.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4bcefcc91115a9601632d9e1a0bce70b591cd0a6 Reviewed-on: https://chromium-review.googlesource.com/1048844 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
rdar://35063950Eugene But authored
rdar://35063950 is not fixed and workaround is still needed. Bug: 840426 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I033a508aadc0dad25bc2b70b0db5527a5800e4c5 Reviewed-on: https://chromium-review.googlesource.com/1048566Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556670}
-
Jennifer Apacible authored
This change allows the user to interact with the window contents, most notably the media controls. This also disables dragging on the window, which is a lower priority to have compared to working media controls. Previously, we were unable to interact with Mac controls. Other platforms, such as Linux, required a double click to interact with them. Manually tested on Mac OSX and Linux. Enabling dragging will be done in a future patch. BUG: 839721 836389 Change-Id: Iddaa83d244c0b76760688d12e469afc9265d93a8 Reviewed-on: https://chromium-review.googlesource.com/1048394Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#556669}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 835626 Change-Id: I45957a882b6f3209cc06f6eb2f70d1e6d12f4012 Reviewed-on: https://chromium-review.googlesource.com/1049087Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556668}
-
Bence Béky authored
Remove global ScopedTaskEnvironment instance that lives across all of net_unittests. Add a local variable or test fixture member to whichever test would crash/fail without that. Change type from default to IO for whichever test would crash/fail without that. In some cases, like HttpServerPropertiesManagerTest, make member private and add protected accessors. In most other cases make member protected and access directly from tests. I was mostly doing this by occurrence, and I'm happy to change any test in either direction. I made scoped_task_environment_ the last member unless it was necessary to construct it before the constructor of some other members. I generally made it a private member, unless it is manipulated from a test and I was too lazy to write an accessor, or unless it needed to be created before other, non-private members, because I did not feel like the ugliness of multiple alternating private and protected sections is justified. I'm happy to change this is necessary. Bug: 791831 Change-Id: I578690820c07264372cff9dbd8bd9c944c243ba8 Reviewed-on: https://chromium-review.googlesource.com/1037405 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556667}
-
Luciano Pacheco authored
This fixes the issue where ChromeVox was reading "Zero width no break space" while File Manager or "Save as" dialog was loading. This unicode char was added by the following patch, but without a clear reason: https://chromium.googlesource.com/chromium/src/+/9485ad7b2a08306e23e9980d73a0eaa73da98610%5E%21/#F10 Bug: 835789 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7cc698071ab0c42df4f208e92a2c3cf0fb15cb0a Reviewed-on: https://chromium-review.googlesource.com/1034415Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#556666}
-
