- 16 Mar, 2020 40 commits
-
-
Joe DeBlasio authored
This CL fixes a mistaken NOTREACHED() that was reached when a user opened PageInfo on a page that triggered the (metrics-only) sensitive-keyword heuristic. It also adds a test for such. Fixed: 1061244 Change-Id: I11e6be8c4f75f308cc8f75f48523c4f64a275917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103398Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#750593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/496706c9672e..98b339fb3c01 git log 496706c9672e..98b339fb3c01 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 wolfi@chromium.org New icons for breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@98b339fb3c01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4493d277b78505954032b4c6b8036707790a0957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750592}
-
Xiaocheng Hu authored
Both call sites of Font::Update() in FontFaceSetDocument are redundant, so this patch removes them. The first call site is redundant as StyleResolver::ComputeFont() will set the underlying Document's FontSelector to the font. The second call site is redundant as it repeatedly sets the Document's FontSelector to the font. This is also preparation for eliminating Font::Update(). Bug: 1049295 Change-Id: I43196beb8c77e420083a125a6050d73d06e7b9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103146Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750591}
-
sczs authored
When attempting to upload saved a card, there's a check where it assumes that the user providing a date expiration value is because the date was expired. This ends up calling LogSaveCardRequestExpirationDateReasonMetric which DCHECKS if the provided date is not expired. After enabling the editing support on the Save Card modal on iOS, users should not be able to send an expired date, but they will provide a date when attempting the upload (even if it is the original the date). Bug: 1029067 Change-Id: I874c8af5f24159e00a6cb3c50d46d988d3f391cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099481 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750590}
-
Yue Zhang authored
Bug: 1057828 Change-Id: I5f2c3e6d24905471d268aec3119d86d1db26fdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095924Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750589}
-
Mitsuru Oshima authored
Bug: b/148977363 Change-Id: I3568916986b9b5b8917e1ca3afa2cb0be126d150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104653Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#750588}
-
Chris Mumford authored
This change shifts from building the SQLite source in Chromium to building the SQLite source which now resides in its own repository. Motivation: now that SQLite has an official Git mirror we can switch from manually maintaining a set of patches to having a Chromium specific set of branches (master and releases). This simplifies the maintenance task and this repository. Bug: 945204 Change-Id: I83febc92d8968a75be69aeb18b352561b8817f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013741Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#750587}
-
Yue Zhang authored
http://crrev.com/c/2023250 assumes that we can get updated parent view height and width by swapping the value when orientation changes, which doesn't hold true for all devices. This CL fixes this issue by dynamically getting the parent view measures instead of using cached values. Also, this CL adds a regression test to make sure that TabGridDialog and selection editor that shows within TabGridDialog always show in the same position with same size. Bug: 1060472 Change-Id: I65dc93ebbbdababfc699671a2339a53a47d6a3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099239Reviewed-by:
-
Gauthier Ambard authored
The NewTab button is now enabled by default. This CL removes the code that is no longer useful. Bug: 974751, 998090 Change-Id: I8eb959753c35b522d58ca8c0626a1d0c7259b42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100851 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#750585}
-
Hongchan Choi authored
BaseAudioContext::decodeAudioData() caches the task runner reference so it can notify when a decoding task is finished. However, if this method gets called after the execution context is thrown away, attempting to access the task runner is invalid. This patch blocks such attempt and exit the function call. Test: Locally confirmed the repro case does not crash. Bug: 1058680 Change-Id: Id25a5bba0e4cf5a366dc1153ce4e6b353fad77ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091226Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750584}
-
Robbie Gibson authored
For unknown reasons, on iOS 13, whenever the user focuses a UITextField, the pasteboard's changeCount is incremented by 2, although the contents don't change. To fix this, if the changeCount is incremented by 2, we fallback and check MD5, because there's no way to know if the difference is because of this bug or because two actual changes occurred. It is possible to focus multiple text fields in between calls to this method (so properly, we should fallback to MD5 any time the change count difference is even), but that occurs much less frequently. The most common time this method is called is on tapping the omnibox, which will trigger the one-focus case. Bug: 1058487 Change-Id: I4d2b831840f98c071cc2dd76af10bd5d4731b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096562Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#750583}
-
Patrick Noland authored
In https://crrev.com/c/2076402/ I removed a call to setTitleToPageTitle in onTabClosed, and inadvertently failed to replace it. Rather than replacing it directly, I think it's better to call onNavigatedToDifferentPage instead. This calls setTitleToPageTitle but also updates the status icon and re-checks the TITLE_ONLY state. For context, the check for getWebContents().isLoadingToDifferentDocument() was introduced to fix a hera (tabs in the Android launcher) bug in this internal cl: https://crrev.com/i/182069 I don't think this is really relevant any longer, since Hera is long gone, but I will happily re-purpose it. Bug: 1061356 Change-Id: I9b3e8ad675a022ba1da2e2409ee6dab96775e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105396Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#750582}
-
Liquan (Max) Gu authored
Change: * Add success test * Add no-service test * Add unresponsive-service test * Remove smoke test Bug: 1057488 Change-Id: I9b3924b437b4f2eaf1fe016cee397bc75ffefc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102109 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750581}
-
David Tseng authored
Test: browser_tests --gtest_filter=ChromeVox*KeyboardHandler*.* Change-Id: Ide1ec47e01e44c8bb635335883e01d68cff50b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104263 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750580}
-
Marc Treib authored
A bunch of passwords/encryption-related helpers existed in passwords_helper/encryption_helper but also had almost-identical copies in single_client_passwords_sync_test. This CL moves all the helpers into passwords/encryption_helper and de-dupes the almost-copies -> less duplication, and they can now be used in additional tests (like PasswordManagerSyncTest). Bug: 1058339 Change-Id: I5bae176053ca6c2a063d09fa3a80efb116df4003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101000 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#750579}
-
Peter Kotwicz authored
This CL changes WebApkActivityTestRule to disable WebAPK updates. BUG=1054718 Change-Id: I193827f09fed1a6d9f7f93d78fc2a37f845df748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098769Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750578}
-
Pâris Meuleman authored
This removes crash expectations that got fixed following the changes in https://crrev.com/c/2074482. Bug: 1040059 Change-Id: I91a9bfa3b49686ec204e5103e6bae369d351fb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096587 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750577}
-
W. James MacLean authored
NavigationPredictorPreconnectClientBrowserTest .PreconnectNotSearchBackgroundForeground is flakey on mac, see bug for details. TBR=ryansturm@chromium.org Bug: 1061932 Change-Id: I23de7d1b8aec2cfa34ae9b2c2d2f6c855a961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105418Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750576}
-
Michael Thiessen authored
This is just a readability improvement, no functional changes. It was confusing that shouldCloseTab appeared to only be used in some cases like actions that result in OVERRIDE_WITH_ASYNC_ACTION, when we were actually just recomputing shouldCloseTab under the assumption that it wouldn't change. Change-Id: I52b16cef1483c328bc595bc329f4a9098b3fc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101311Reviewed-by:
-
arthursonzogni authored
Check the COOP/COEP headers defined in a response from the ServiceWorker are correctly taken into account. This test is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2100790 Bug: 922191 Change-Id: I3cbb577edb5a0fa1527464a57dff2b4863a1bc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102577 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750574}
-
Eric Willigers authored
Various includes of extensions headers from chrome/browser/ui/views are no longer required. Change-Id: I6edd33bcffa8c8b733292220239c70b1de0dc4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104708 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#750573}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I05bece4a4848cf084c65a206c76f8232f4cc7474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105416Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750572}
-
Elly Fong-Jones authored
This document outlines the associated data pattern, and the two most commonly used implementations of it in Chromium: SupportsUserData and KeyedService. Bug: None Change-Id: I45ad8d2961221fd64022168982f454fe655340fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102591 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750571}
-
Peter Wen authored
Turbine: https://github.com/google/turbine Turbine is a library for generating java headers. Java headers are equivalent to interface jars generated by ijar. Basically a .jar file of .class files that have private methods and variables removed, and method bodies removed, so that only the minimal public/package/protected interface of the class are preserved. This allows library A that depends on library B to pass in library B's header in its classpath rather than the full .jar file generated by an invocation of javac. Since turbine runs much faster than javac (3-5x speedup), this allows the libraries to be compiled with javac in parallel more often. The implementation is in a subsequent CL for ease of revert/relands. Bug: 1056299 Change-Id: I515515b874c9897ed38fa68a96cd0cd0dbf5c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090726Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18f1a2797005..71e412b29c10 Created with: gclient setdep -r src-internal@71e412b29c10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia4457b30689acc00e29b982ebfa1d567500193cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750569}
-
Roman Aleksandrov authored
Track review following setup box is checked. Change-Id: I99be8c503159194018e4af1b1f1be91237e5e8f3 Bug: 1056740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095103 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#750568}
-
Rayan Kanso authored
The test has been consistently failing. TBR=sahel@chromium.org Bug: 1061919 Change-Id: I41c50e7ed55bae4207791ac02b5ff362473945a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105434Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#750567}
-
John Budorick authored
This reverts commit 4154e5e3. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061936 Original change's description: > Fix combining characters for c with acute accent > > The table had ´c map to ç instead of ć, imitating GTK from circa 2008. > This was overlooked in the conversion, and left no way for users to > type ć (used in Polish for example). > > I speculate that GTK was imitating the Windows ‘US International’ layout, > which has that mapping. We have a separate section of the combining table > for the Windows-like ‘US International PC’ that does map ´c map to ç, > but this should not still happen for other layouts. > > Bug: 1061753 > Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750545} TBR=kpschoedel@chromium.org,yhanada@chromium.org Change-Id: I9c78d16522887c691e3e6e4cdd7d4979410c5845 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105419Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750566}
-
Gabriel Charette authored
base::ThreadPool:: (API as a destination) is the new desired paradigm. worker_pool:: was already API-as-destination; can remove redundant ThreadPool() trait with new API. R=haraken@chromium.org Bug: 1026641 Change-Id: Ida08feab710143da2308ef1361550a9aced39d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105454 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#750565}
-
Andrew Grieve authored
See https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md TBR=agrieve # Mechanical renames Change-Id: I1298f139e15919ec1597510ef3a556a67ee2acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103040 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
As part of the DialogDelegate close refactor I changed the default behavior of dialogs that have both cancel and accept callbacks to require opting in to receiving a callback on close as well. This dialog is one of the few that were both depending on this behavior and had no test coverage for that dependency. This change: 1) Opts that dialog into receiving a callback on close, using the pattern called "pattern 2" from r743269 2) Adds test coverage for the behavior here Bug: 1056116 Change-Id: I3b4a30c6015bf76534b6b083586a13fdc55bac2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100727Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#750563}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bb74c4299b8..f94815068d75 git log 7bb74c4299b8..f94815068d75 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 18daa81e3d3d..3a50a43df988 (14 commits) 2020-03-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-03-15 mtklein@google.com rearrange to emphasize most salient params 2020-03-15 reed@google.com add programs to compose, lerp and luma colorfilters 2020-03-15 reed@google.com colorfilter's program returns a color 2020-03-15 reed@google.com change onProgram to return its color, or an invalid-color if failed 2020-03-14 reed@google.com skvm for compose shaders 2020-03-13 djsollen@google.com Remove mips workarounds for Android. 2020-03-13 jvanverth@google.com Reland "Clear out atlases if they haven't been used in a while." 2020-03-13 sgilhuly@chromium.org SkiaDawn: Early out in recordProgramInfo 2020-03-13 fmalita@chromium.org [svgdevice] Handle text path effects 2020-03-13 jvanverth@google.com Revert "Clear out atlases if they haven't been used in a while." 2020-03-13 csmartdalton@google.com Remove instanced draws and simplify GrMesh 2020-03-13 reed@google.com remove legacy virtual from enforcer 2020-03-13 jvanverth@google.com Clear out atlases if they haven't been used in a while. 2020-03-13 bryct@amazon.com Implement support for path effects in SkSVGDevice backend. 2020-03-13 robertphillips@google.com Make AAFlatteningConvexPathOp surface its programInfos at record time 2020-03-13 reed@google.com hide getters so we can change the internals of SkVertices 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2e5bd9b1e658..6963f58c7678 (14 commits) 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5309fd86..907b992f (527 commits) 2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7e857092052e..18daa81e3d3d (9 commits) 2020-03-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-03-12 mtklein@google.com dot for JIT 2020-03-12 mtklein@google.com restore Op::round 2020-03-12 csmartdalton@google.com Migrate GrMeshTest to the new bind/draw API 2020-03-12 reed@google.com remove LerpRed shader 2020-03-12 reed@google.com add draw-via-serialize mode to viewer 2020-03-12 robertphillips@google.com More programInfo cleanup 2020-03-12 reed@google.com add gm for clipShader in a layer 2020-03-12 brianosman@google.com More GrDrawVerticesOp cleanup, to reduce redundant state 2020-03-12 robertphillips@google.com Update three GrMeshDrawOps to surface their programInfos at record time 2020-03-12 fmalita@chromium.org [skottie] Cleanup VectorValue use 2020-03-12 michaelludwig@google.com Remove drawBitmap et al. from SkDevice 2020-03-12 mtklein@google.com make switching skvm-on-llvm easier 2020-03-12 fmalita@chromium.org [skottie] Effects cleanup pass 2020-03-12 brianosman@google.com Remove (unused) shader caps from default GP factory functions 2020-03-12 brianosman@google.com Simplify and optimize GrDrawVerticesOp vertex writing loop 2020-03-12 robertphillips@google.com Clean up programInfo creation in GrMeshDrawOp-derived Ops 2020-03-12 borenet@google.com Update Skia milestone to 83 Created with: gclient setdep -r src/third_party/skia@f94815068d75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058905,chromium:1059890,chromium:1059939 Tbr: egdaniel@google.com Change-Id: I22963250cdbbec26d2c3740f05971dc59bd28e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105413Reviewed-by:
-
kylechar authored
There were a few remaining references to OOP-D in the code that are no longer relevant since the feature is launched. Bug: 936425 Change-Id: I32930a85684007068303d1b8083a3b4a00227e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101189Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750561}
-
Sylvain Defresne authored
Some targets want to copy files from $ios_sdk_platform_abs_path. Since those points to sub-directory of $root_build_dir when goma RBE is enabled, this causes failure at "gn gen" time since there are no target creating those files according to gn. To fix this, add a new target that pretends to create those files. Bug: 1061487, webrtc:11429 Change-Id: I9d2330c4c6e041e59f24c459e50fe787602abde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102544 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750560}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PaymentRequestHeader class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Icd95cb4f4b2af2faef88a4043a8f6e6153eff468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105153Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750559}
-
Omer Katz authored
Add tests designed to reveal more issues in Vectors and Deques. Bug: 986235 Change-Id: Ifd2808ba926d6cc6232f2762058fe0e8978756a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102657 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750558}
-
Nohemi Fernandez authored
- Clarifies the difference between unified consent add account and reauth. Add account and reauthentication methods in identity differ in that one provides the user with a screen to enter their account details and the other automatically prefills these details. - Implements sign-in completion for reauth. Bug: 971989 Change-Id: I2b0d2d2cc830f7e989480d7444002144d26a38ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095118 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750557}
-
Andrew Grieve authored
And enable authentication of downstream trybot results. Bug: 1048299 Change-Id: Id24c9ee400171c709c87bfb0fd4c58112cfd154e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103387 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#750556}
-
Stephen McGruer authored
Tackling the set of calls that avoided the automated refactor (for various reasons). There are about 50 in total, split up into a few CLs to make reviewing it easier. Bug: 1051932 Change-Id: I3d51fe842f2858e9528b9012cb9da9d29e300c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083736Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Jens Widell <jl@opera.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#750555}
-
Sean Gilhuly authored
Display output from SkiaRenderer Dawn is upside-down on Windows. Pass a SurfaceOrigin parameter when constructing SkiaOutputDeviceDawn so that the origin can be set per platform. Bug: 1021566 Change-Id: Ic8fbf30cc21bfab2f7c10c63118d4730216172e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103265Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#750554}
-
