- 11 Sep, 2018 40 commits
-
-
sebsg authored
Change-Id: I48f30252eb920a4e9a89291a79e1ff612cb72595 Reviewed-on: https://chromium-review.googlesource.com/1220566Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#590455}
-
Aldo Culquicondor authored
Extract platform independent code from the GvrSchedulerDelegate for reusability and testing. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iaa90b42ea7e81995c32344c9da083c96bdc55a71 Reviewed-on: https://chromium-review.googlesource.com/1195711 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#590454}
-
Harley Li authored
Set the minimum height of storage panel's key-value table so that the preview panel down below won't obscure it when dragged upward, confusing the users. Screenshot: https://imgur.com/a/VhC4X7x Bug: 865091 Change-Id: I152f9082f6dd1646a1e8eaeb4d9111b181546553 Reviewed-on: https://chromium-review.googlesource.com/1220477 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#590453}
-
Eric Aleshire authored
This action performs the actual autofilling of the form, by selecting a specific element in an autofillable form, then tapping on the autofill suggestion. The profile data used to autofill is hardcoded in this file for now. uwyiming@ may have plans to move this profile data into the test recipe in the future, but for now this is sufficient. Additionally, I move some shared code between the click and autofill actions to a base class. I tested this action using a recipe I wrote against Walmart's shop page. Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9629a11da48a3910c1765f455491456005aada75 Reviewed-on: https://chromium-review.googlesource.com/1208141 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590452}
-
Ian Clelland authored
This queues a report through the Reporting API whenever VR or XR device access are requested in a frame in which the 'vr' feature is not allowed according to feature policy. Bug: 867471 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5e0256c799f986e30b1f3746ef0fce1b6d9f93eb Reviewed-on: https://chromium-review.googlesource.com/1195438Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#590451}
-
wutao authored
The last line of sytled_label does not have enough space for customized line height. This patch fixes this bug. Bug: b/114129692 Test: StyledLabelTest.LineHeight Change-Id: I2a218b244983043d9f23d413fe33acefb5ac890f Reviewed-on: https://chromium-review.googlesource.com/1217068 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#590450}
-
W. James MacLean authored
This CHECK was inserted for debugging purposes, but it's fine to convert it to a NOTREACHED to avoid crashing Android SI users in the wild. Bug: 877092 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I35791a7af641c2425935aa095a16faf44c8cfa20 Reviewed-on: https://chromium-review.googlesource.com/1220100 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590449}
-
Kevin McNee authored
In WebViewImpl, we initialize something called |cachedZoom| which is never used. This is presumably supposed to be |cachedZoomFactor|. We give this a more descriptive name and initialize it with the correct value. We also explicitly initialize |userAgentOverride|. Bug: None Change-Id: Id506c12b5b53502b44fcea575b96803a584ac31b Reviewed-on: https://chromium-review.googlesource.com/1219905Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#590448}
-
Xi Cheng authored
Change-Id: Icc77d7f903bf29fb79fee5270e97098208ad154c Reviewed-on: https://chromium-review.googlesource.com/1219970Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#590447}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91dfc811. With Chromium commits locally applied on WPT: d3406a52 "Add more WPT tests for mixed-content check in workers/worklets (2/2)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24554 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic3c86c431478bd7ddb070bb1f3ce283106349175 Reviewed-on: https://chromium-review.googlesource.com/1219988 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590446}
-
Kurt Horimoto authored
Now that there is a single FullscreenControllerObserver function for all fullscreen-driven animations, we can remove duplicated code and consolidate setup to a single function. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I25a0b7f9797f2a62f79317f9f1ec8121da5dbf5c Reviewed-on: https://chromium-review.googlesource.com/1053179 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590445}
-
Ryan Daum authored
Adds a facility to stop touch events from being processed by all event handlers and rewriters while the screen is off. CastTouchEventGate is installed by the window manager as the first event rewriter in the chain. When it is eanbled it will discard all touch events, but notify registered observers that it has done so, so the device can be woken up and touch event processing restored. Bug: internal b/109894724 Test: unit test and manual on device Change-Id: I82cf69d3d02f476256b28e2c3994b264fa31fc91 Reviewed-on: https://chromium-review.googlesource.com/1220166Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#590444}
-
Xianzhu Wang authored
Bug: 882973,882974,882975 Change-Id: If63c4f260a11360f2044dc94a14fea20c2133ac4 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Reviewed-on: https://chromium-review.googlesource.com/1220467Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590443}
-
danakj authored
This reverts commit 7c4f701b. Reason for revert: This is asserting on bots, something is wrong. Original change's description: > Make ClientResourceProvider::ReceiveReturnsFromParent() be O(N+MlogM) > > Currently this methods works as O(N*M), where > N = size of imported_resources_ in the provider > M = number of resources being received by the provider > > That is because each received element is removed individually from the > imported_resources_ set, and each removal will cost O(N). > > Instead, sort the incoming resources, then walk through the two > sets of resources in parallel, which is O(N+M). During this walk, > replace resources to be removed from imported_resources_ with resources > that we are keeping as we walk, which is O(1). Then erase the empty space > created by this process at the end of the loop, which is O(N). This > makes the complexity O(2N+M) = O(N+M). > > This is similar to the std::remove_if() algorithm, except that we have > to write it ourselves to avoid O(M) work at each step, and instead walk > the received resources in parallel. > > We also sort the returned M resources as a prelude, to ensure we can do > the walk in parallel. This costs O(MlogM), making the whole thing > O(N+MlogM). > > Similarly, for ClientResourceProvider::ReleaseAllExportedResources() > stop removing elements individually. In this case we can use > base::EraseIf to iterate through the set, act on each element, and > return true if it should be erased. > > R=piman@chromium.org > > Bug: 881295 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I94522eb07e2f09b20a10d8f254faa63fd2ab9d0e > Reviewed-on: https://chromium-review.googlesource.com/1211908 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590347} TBR=danakj@chromium.org,piman@chromium.org Change-Id: I37c9b08ad6cb2d18aeee224f4c282e22612bb1d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881295 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1219996Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#590442}
-
Victor Costan authored
This CL updates the chromium_logger.h implementation with the changes in https://github.com/google/leveldb/commit/7b945f200339aa47c24788d3ee9910c09c513843. The CL also does minor cleanup in the Chromium port code. Change-Id: I6ec4a464963bd0011ee01ea9879fda5d8836418e Reviewed-on: https://chromium-review.googlesource.com/1205639Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590441}
-
Lan Wei authored
We have an issue that Windows virtual Keyboard appears whenever a text area is selected with the mouse or keyboard. Since we decide to only show the virtual keyboard when the input type is touch. Bug: 871756 Change-Id: Ia804afad907341ed478409d223b67f09c6b7f8f3 Reviewed-on: https://chromium-review.googlesource.com/1194406Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#590440}
-
Hiroshige Hayashizaki authored
To expose FetchClientSettingsObject in FetchContext in https://chromium-review.googlesource.com/1200042, this CL moves FetchClientSettingsObject to platform/. Bug: 880027 Change-Id: I71c9eac42fc561e58742398cfa229b21c31662c7 Reviewed-on: https://chromium-review.googlesource.com/1198889 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#590439}
-
Marijn Kruisselbrink authored
This takes a somewhat hacky approach to return an async iterator from getEntries(), but at least it makes for await work on it. Also adds create option to getFile and getDirectory to be able to create new entries. Bug: 872465 Change-Id: I297c89c917bc86dfc2b3bbcf2d501ff5e59a85d7 Reviewed-on: https://chromium-review.googlesource.com/1197904 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590438}
-
Ryan Cui authored
Increase shard count used for the debug and msan/asan builders to prevent the tests from timing out. Repurposes shards previously used for mash_browser_tests, as crrev.com/c/1175222 reduced the number of tests running as part of that suite to just 1. Also sets the timeout for tests back to 1800. It was bumped up to 3600 by crrev.com/c/1217124. Bug: 874090 Change-Id: Ia2b0ea4d3264e240dadde04f8ff049ff9a8b5735 Reviewed-on: https://chromium-review.googlesource.com/1217124Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590437}
-
Carlos IL authored
Change-Id: I22a1596e41c499f2330ce3e8bacc8dc7c99ae7bd Reviewed-on: https://chromium-review.googlesource.com/1220476Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#590436}
-
Luna Lu authored
TBR: iclelland@chromium.org Bug: 874629 Change-Id: Ia5346b73344bf33dd1446591b85acf0d6a608e9b Reviewed-on: https://chromium-review.googlesource.com/1220091 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#590435}
-
Joe Downing authored
This change is a result of our discussions with the privacy folks. The old behavior was to center the disconnect window along the x-axis and dock it just above the taskbar. The change is to now position the dialog near the center of the y-axis as well to maximize the chances of a local user seeing the disconnect window before it auto-hides. This change also fixes a bug where I was setting the position after animating the window so it would appear to jump when being reshown. BUG=882926 Change-Id: I3e923937f10f24c3e719f311380a98b77644e866 Reviewed-on: https://chromium-review.googlesource.com/1220029Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#590434}
-
Karan Bhatia authored
Currently on Mac, when the blocked action bubble is shown for an extension in the app menu, it is shown over the app menu and it's not possible to interact with the bubble. Fix this by closing the app menu if needed before showing the bubble. Tested with both Cocoa and Views browser windows. BUG=880875 Change-Id: I3ab9b1136f01ca1cf5dd13fd51831f05072c8437 Reviewed-on: https://chromium-review.googlesource.com/1211964Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590433}
-
Hongchan Choi authored
When both input and output are 1 in AudioWorkletNode, it ignores the output channel count specified by user. Fix this incorrect behavior so the specified channel count can be honored properly. See also: https://webaudio.github.io/web-audio-api/#configuring-channels-with-audioworkletnodeoptions Bug: 861681 Test: webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html Change-Id: Ie5cc7f3a5a2b48c67cdf39e93bde8477bfedae89 Reviewed-on: https://chromium-review.googlesource.com/1216072 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#590432}
-
Xing Liu authored
This CL does the following things: 1. Implements a GpuVideoAcceleratorFactories for browser process in content/ to create MojoVideoDecoder in the browser process. 2. Decodes video frame with MojoVideoDecoder in browser process in DownloadMediaParser. The actual decoding happens in GPU process with Android MediaCodec, which is same as other usages for MediaCodec based decoders. Test is covered in DownloadMediaParserTest. TBR=dtrainor@chromium.org Bug: 826021 Change-Id: I242ff31ba8f205af3b03709fb78bd14f5bc33e45 Reviewed-on: https://chromium-review.googlesource.com/1212343 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590431}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5831e1113332..fb18639804e7 git log 5831e1113332..fb18639804e7 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 jvanverth@google.com Set ambient stroke to full width of blur. 2018-09-11 jvanverth@google.com Fix some overflowing integers in SkPolyUtils Created with: gclient setdep -r src/third_party/skia@fb18639804e7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ic8b46387c77c6ea01d0df93b9e629b8cce8d47aa Reviewed-on: https://chromium-review.googlesource.com/1220229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590430}
-
Chong Zhang authored
The trace is already broken and doesn't seem to be used. See bug for more details. Bug: 880129 Change-Id: I822f24c2367a1acb76c1eeddade6b2ceefd1355a Reviewed-on: https://chromium-review.googlesource.com/1216083Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#590429}
-
Peter Beverloo authored
We suspect that nobody uses this because it's completely undocumented, but since it's exposed to developer we should gather metrics for a little while to confirm. Change-Id: I57b7b8dcd7e861842bdf81b8b62787f44e62ffbf Reviewed-on: https://chromium-review.googlesource.com/1209642Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#590428}
-
Jialiu Lin authored
If an OAuth2 token is fetched during Chrome OS sign-in, we update the advanced protection status accordingly for the primary AccountInfo (in AccountTrackerService). Bug: 866620, 882576 Change-Id: I729a7c47b8b3e45589c03df0fe8b8c9ab7c4084e Reviewed-on: https://chromium-review.googlesource.com/1205107Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#590427}
-
Joel Einbinder authored
This measures the content inside a glasspane with getBoundingClientRect instead of offsetHeight. When the content had a non-integer height, offsetHeight could be rounded down from the real height. This would cause a scrollbar to appear. Change-Id: Ib9b4067e74c41e1649e35be2827147d2e2f23f3f Reviewed-on: https://chromium-review.googlesource.com/1167652Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#590426}
-
Kurt Horimoto authored
The animations added by FullscreenUIElements are the same regardless of which callback was being called, resulting in a lot of code duplication and boilerplate code. This CL consolidates FullscreenController animations into a single callback. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I898f172a85e38c7d837665d9185f30d95be28d8a Reviewed-on: https://chromium-review.googlesource.com/1053123 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#590425}
-
Quan Nguyen authored
Bug: 872805 Change-Id: I16c0de6d930b26ad6400cc0580f73fc2404c92b3 Reviewed-on: https://chromium-review.googlesource.com/1171251 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#590424}
-
Xianzhu Wang authored
Remove flakiness expectation for paint/invalidation/selection/selection-partial-invalidation-between-blocks.html It's no longer flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=paint%2Finvalidation%2Fselection%2Fselection-partial-invalidation-between-blocks.html TBR=yoichio@chromium.org Bug: 774437 Change-Id: I40e82ad1c5cab68d9996961eba44394edf26ed7f Reviewed-on: https://chromium-review.googlesource.com/1220171Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590423}
-
Tatiana Buldina authored
Bug:868599 Change-Id: I59ddac3c2c1ada97b252d8d86faf051b4d7ba80b Reviewed-on: https://chromium-review.googlesource.com/1219891Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#590422}
-
Wez authored
This reverts commit ffc90f42. Reason for revert: Issue 864351 has been traced to a bug in ThirdPartyModulesBlocking. Original change's description: > Copy some diagnostic values to the stack and alias them. > > Temporarily add some values to minidumps, to help diagnose BlobReader > crash reports. > > Bug: 864351 > Change-Id: I70a8b36e83fdb1c43f698d83aaf6b712da6a9264 > Reviewed-on: https://chromium-review.googlesource.com/1185906 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585337} TBR=wez@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864351 Change-Id: I390f315985eb1cb900b7548ae87949c3e9e08fa9 Reviewed-on: https://chromium-review.googlesource.com/1216712 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#590421}
-
Vladislav Kaznacheev authored
- Use only 32 and 192 sizes - Apply png optimizer. - Use correct icons in icon_decode_request.cc Bug: 879617 Test: manual Change-Id: Icced1e403c75852b2143c695dd22032c3a9e4f8c Reviewed-on: https://chromium-review.googlesource.com/1216084Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#590420}
-
Francois Doray authored
This will allow use of these constants in constexpr expressions. Change-Id: Ia2d6f8ab6969eedbc9b9b763f7f700ffaaaee14b Reviewed-on: https://chromium-review.googlesource.com/1219769Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#590419}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/f7b0e1d901da..7b945f200339 Following up on leveldb cleanups, this CL also removes the ssize_t definition from port_chromium.h, and the OS_WIN macro definition that was required by it. $ git log f7b0e1d90..7b945f200 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 costan Clean up posix_logger.h. 2018-09-04 costan Remove ssize_t from code that is not POSIX-specific. 2018-09-04 costan Simplify Limiter in env_posix.cc. 2018-09-04 costan Clarify comments for leveldb::Env file reading methods. 2018-09-04 costan Remove GCC on OSX from the Travis CI matrix. 2018-08-19 costan Expose WriteBatch::Append in the C API. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: I4f045f15cdae69e15f5a52c05cff9e7671fb2753 Reviewed-on: https://chromium-review.googlesource.com/1205472Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590418}
-
Stephane Zermatten authored
I had forgotten to initialize pending_precondition_check_count_; running the component tests with asan highlighted that. Bug: 882901 Change-Id: Ia9621e80946da39e3d6ecb8e8c98a09beb4a76e2 Reviewed-on: https://chromium-review.googlesource.com/1219709Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590417}
-
Will Harris authored
../../chrome/browser/win/chrome_process_finder.cc(97,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int' [-Wshorten-64-to-32] timeout_in_milliseconds = new_timeout.InMilliseconds(); ~ ~~~~~~~~~~~~^~~~~~~~~~~~~~~~ BUG=879657 Change-Id: I2a711f97feb92925a3b53e08d06af5da1b61820e Reviewed-on: https://chromium-review.googlesource.com/1214744 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590416}
-