- 03 Mar, 2020 40 commits
-
-
Jonathan Backer authored
This reverts commit b85847a2. Reason for revert: https://crbug.com/1058118 Original change's description: > Add Android to SkiaRenderer field trial > > Bug: 1019787 > Change-Id: I3f3121b7da6e46a9558ac0a2058b9ba8239fea84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078772 > Auto-Submit: Jonathan Backer <backer@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746352} TBR=backer@chromium.org,rkaplow@chromium.org,holte@chromium.org Change-Id: I6286d17f4ffee5072dcfad30e702668b5fe5cb0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085551Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746488}
-
Toni Barzic authored
Hides marketing opt-in toggles from marketing opt-in screen - seems weird, but the screen is also used as the final screen in the flow, with pieces to force shelf navigation buttons in tablet mode. Marketing opt in toggle implementation is slipping to M-83, so hide the toggle by default (a follow-up will update the screen UI to address the white space where the opt-in toggle should be). Adds browser tests for the screen. BUG=976949 Change-Id: If4c9db85be2607f99be15c9aef27f7b67fc41367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083952 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746487}
-
Daniel Cheng authored
Bug: none Change-Id: I0dda0908227f65cda8a35931e83fd94a308c6f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083563 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746486}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f57a5e85c09d..683c198380db git log f57a5e85c09d..683c198380db --date=short --first-parent --format='%ad %ae %s' 2020-03-03 joselea@microsoft.com Typecheck SegmentedRange.js 2020-03-03 vidorteg@microsoft.com Locking lighthouse terms. 2020-03-03 joselea@microsoft.com Typecheck ParsedURL.js 2020-03-03 jacktfranklin@chromium.org Remove `Number.gcd` Created with: gclient setdep -r src/third_party/devtools-frontend/src@683c198380db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e4cf098ca848a41c25b9587195ffd4fdd2d8891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746485}
-
Alison Maher authored
As discussed in http://crrev.com/c/2066753: "PreferredColorScheme has been removed in crrev.com/c/1845575 in favor of setting color scheme via NativeTheme. This causes regression for dark mode support in WebView by the following two reasons: 1. When WebView is run in multiprocess mode it means it has both browser and renderer processes. Changes to NativeTheme that happens in aw_settings (browser side) are not seen by NativeTheme in style_engine (renderer side). 2. Different WebViews may use different darkening strategies. Using a singleton to store preferredColorScheme means that we can't differentiate them. While the first problem can be solved by notifying theme_helper which observes changes in browser side NativeTheme and passes them to renderer, the second requires that preferredColorScheme is not controlled by singleton. This CL also adds tests to prevent such regression in the future." This change builds on top of the CL above to revert more of crrev.com/c/1845575 and http://crrev.com/c/1728056. The result is that PreferredColorScheme is now updated through WebPreferences/WebSettings and is only sent to the render process in one way. Bug: 970285 Change-Id: Ia2ba874c23e2ab47a27ec53b52dcbee1ac5aeee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079192 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94b928cd7d3d..964aa91580b6 git log 94b928cd7d3d..964aa91580b6 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 bsalomon@google.com Simplify adding key in SkImage_Lazy::lockTexturProxyView 2020-03-03 bsalomon@google.com Use spin lock in SkIDChangeListener 2020-03-03 bungeman@google.com Check for invalid unicode in fallback. 2020-03-03 jlavrova@google.com Selection in justification: Bugs: skia: 9969 2020-03-03 fmalita@chromium.org [skottie] Add another text grouping test Created with: gclient setdep -r src/third_party/skia@964aa91580b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057692 Tbr: herb@google.com Change-Id: If59bec1a91375da3111679329299fd68e072b734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085021Reviewed-by:
-
Ovidio Henriquez authored
This change fixes the checks for the WebBluetoothNewPermissionsBackend feature flag. Previously, it was checking if the BluetoothDelegate* was not null and if the flag was enabled in the same statement. This is incorrect because it falls back to using the original permissions system if the delegate is null, which shouldn't happen if the feature flag is enabled. With this change, the feature flag is checked first, then the delegate pointer. If the delegate pointer is null, then the current Web Bluetooth operation fails. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM Bug: 589228 Change-Id: Ib01e90b49924d7ba4e1dd03c8117eae9e21e795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081526 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746482}
-
Felipe Andrade authored
Add retry logic with exponential backoff to KerberosCredentialsManager for addition of managed accounts. This will cover the cases when the first attempts fail because network is not ready yet, for example. Network instabilities are common on first user login because OpenNetworkConfigurations often changes network config on ChromeOS. Bug: 1049331 Change-Id: I74b91cfd6fda3fc923061050a97fcb791761815e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039453 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746481}
-
nancy authored
AppServiceAppIconLoader is used to replace ArcAppIconLoader to load app icons for all apps. BUG=1016159 Change-Id: I8889a7931127a83e6da48ab23878a9ba284aa303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084190Reviewed-by:
-
Jeff Yoon authored
This is a reland of 4ed2234c TBR=sdefresne@chromium.org TBR_REASON=Locally verified change build/config/ios/rules.gni no longer breaks `gclient sync` when target_os_only = True Original change's description: > generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests > > The existing iOS recipe utilizes an isolate template, and an > isolated.gen.json file to fill the template in per test with > config-variables and path-variables. This isolate template contains > the command arguments to invoke the iOS test runner. > > To support the iOS recipe migration to the Chromium recipe, I use GN to > generate a script per test target instead of the isolate template. The > script is pre-baked with arguments to the test runner (run.py). The > given Swarming task is expected to execute the test by invoking the > generated script. > > Invoking the generated script requires changes to gn_isolate_map.pyl > for each iOS test target, and thus, these changes are only additive. > > * "ios_test_runner_wrapper" template wraps the generate_wrapper target. > It bakes iOS specific arguments into the script, such that it can > launch run.py with the given args. > * ios_eg2_test, ios_eg_test, and test templates have > been updated to utilize the ios_test_runner_wrapper for iOS targets. > * mb.py to skip generated_directory check when writing isolates. > View crbug/ in comments. > > Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64 > Bug: 1055328,912681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745105} Bug: 1055328, 912681 Change-Id: Ib6449bce4b07c8c50b0a59f58fe65caeaa48425f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083379 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746479}
-
David Bokan authored
In https://crrev.com/2fc1cb4db60 I removed a state bit from LTHI called |did_lock_scrolling_layer|. This bit looked like it was tracking the same thing as "are we currently in a scroll" for which we already have other state. Unfortunately, this was subtly wrong on two counts: 1) |did_lock_scrolling_layer| was only set in the non-animated path; animated scrolls always appeared invisible to this bit. 2) This was intentionally distinguishing between "currently scrolling" in the sense of "we've received a ScrollBegin" and "actively scrolling" in the sense of "we've received a ScrollBegin as well as a ScrollUpdate that's caused some scrolling". The latter is clear from the CL that added the bit: https://codereview.chromium.org/676853002/. The use case in mind is pages that preventDefault all touchmoves but not the touchstart. In that case, CurrentlyScrollingNode will return a valid node because we receive a ScrollBegin. However, we don't want to consider the compositor in a scroll for scheduling purposes as the page is likely handling these touches on its own. The effect of this is that IsActivelyScrolling now returns true for cases like wheel scrolling. This caused a change to scheduler prioritization and regressed checkerboarding (but improved smoothness). This CL restores the old behavior by making use of some existing state and also updates names and comments to make this more clear to future readers. Bug: 1052474 Change-Id: Ibadf6053c1cc067ec659f6b84225a78cbda437b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083941Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746478}
-
Rouslan Solomakhin authored
Patch #7: On Android, pass currency to the CanMakePaymentEvent when minimal UI feature is enabled, so the updated WPTs can pass. Before this patch, the "currency" field of the CanMakePaymentEvent was set only on desktop. After this patch, the "currency" field of the CanMakePaymentEvent is set on both desktop and Android when the minimal UI feature is enabled, e.g., through chrome://flags/#enable-web-payments-minimal-ui flag, and the relevant WPT passes on both desktop Android when opened in a full browser. Bug: 1005076 Change-Id: I9d24b97730c10bc4e6f4ce38ced89a3c33bb1a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079686 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746477}
-
Mason Freed authored
After [1], the correct error to throw when upgrading a custom element is now TypeError, rather than InvalidStateError. Firefox and Safari have already changed to this, Chrome is now the odd-one-out. [1] https://github.com/whatwg/html/pull/4525 Fixed: 1057423 Change-Id: Ifebcbc5823370a05cbebecf3ddf39d6ecbe260b6 Bug: 1057423 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082086 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#746476}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bbbd9a2a1f41..8985fc91089f git log bbbd9a2a1f41..8985fc91089f --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cepheus@frii.com Fix long lines in the SPIR-V generator, retrigger bots. Created with: gclient setdep -r src/third_party/glslang/src@8985fc91089f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I559c0cf96d6f2e65c81e522c9f64909a237c7825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085022Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/496a335a8700..5e1ea251895c git log 496a335a8700..5e1ea251895c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 srte@webrtc.org Simplify initialization of test FrameGeneratorCapturerConfig. 2020-03-03 henrika@webrtc.org Fixes flaky ADM unittest 2020-03-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 73a39687..20a0a16e (745464:746350) 2020-03-03 jonaso@webrtc.org Add jonaso@ to p2p/OWNERS 2020-03-03 jonaso@webrtc.org Unbreak ICE renomination 2020-03-03 courtneyfe@chromium.org Fix Chromium Roll failing because of -Wrange-loop-construct Created with: gclient setdep -r src/third_party/webrtc@5e1ea251895c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044521 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4bb073583d297fc04d1f259ee2ea661d2152ffd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085023Reviewed-by:
-
Bo Liu authored
When TopControlContainerView is destroyed and recreated on when weblayer fragment is retained across activities, there is a mismatch between the content offset in native code and the new top controls, causing a mismatch that leads to touch events being offset incorrectly until new scroll causes a sync again. Set content offset on init, which also sets it on re-init that fixes this bug. Bug: 1057625 Change-Id: I477e2efb648028c0204091a33f16d17e61248efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081841Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746473}
-
Stephen White authored
Tiny fix: make SkiaOutputDeviceDawn to use gfx:: prefixed SurfaceOrigin. Change-Id: I5bf8c217eeacc79af82084ae61e98863c04ed559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085292 Auto-Submit: Stephen White <senorblanco@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
-
Alison Maher authored
Add fragmentation support for fieldset content (excluding the legend). Tests added to NGFieldsetLayoutAlgorithmTest. Bug: 875235 Change-Id: I0e61bbac924be00cc389adc77abc73390ccfa1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071582 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#746471}
-
Ana Salazar authored
Add a metrics reporter for Layer Animations within the navigation widget. Bug: 1049705 Change-Id: I1ade5e327b926856a940fc72ae50bf9928097fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049824 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#746470}
-
Anqing Zhao authored
Use a new class 'UserSessionInitializer' to handle common initialization logics in 'ChromeSessionManager' and 'UserSessionManager'. Whenever profiles are loaded, corresponding methods in the observer will be triggered. Bug: 977489 Change-Id: Ida1c7cae0406a42edfe62ebf192dfd9bbcbe1301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085253Reviewed-by:
-
rajendrant authored
This CL setup command line params to skip optimization guide models to trigger lite page redirect preview. Bug: 1049675 Change-Id: I2dbcbf6af4ceddf302785c9e6b0514e1ec7e2f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081844Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#746468}
-
Steven Bennetts authored
TBR=stevenjb@chromium.org Change-Id: If16478a59069f8a3df61e2341222e51a07eb6913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083568 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746467}
-
Alexander Timin authored
PrerenderTabHelper at the moment listens to a number of methods, including DidStartNavigation and DidRedirectNavigation without using them. Delete them as they are not needed. R=tbansal@chromium.org Change-Id: I4c9de8c10aab644b165e49399088c05b99f80043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066790 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746466}
-
Nazerke authored
This CL modernizes the LocationBarCoordinator - to use |browser| in the initializer - to use self.browser to get browserstate, webstatelist and dispatcher values. Bug: 1029346, 1048686 Change-Id: I87e10f13748c477b841dadb42249bfd89860d9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078453Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#746465}
-
Mark Pearson authored
The previous advice was too strict about emitting at a regular interval when at the end of event is perfectly okay. Inspired by https://chromium-review.googlesource.com/c/chromium/src/+/2049824/16 Change-Id: I93b3f44a9c91d623e08c9327d902e7ca6af36263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083683 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746464}
-
Donn Denman authored
BUG=1048827 TBR=mastiz@chromium.org Change-Id: I95387295890b0df545a03314f55e822503a36eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084715 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746463}
-
Łukasz Anforowicz authored
This reverts commit 68e96adf. Reason for revert: See https://crbug.com/966223#c28 Original change's description: > Document origin for neither-GET-no-HEAD request made by extensions > > Bug: 1036458, 966223 > Change-Id: Ia32c5256376bd7ead965b0ade24f48e76b35acb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980655 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729209} TBR=yhirano@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1036458, 966223 Change-Id: Ib76bda52d3c173f9dd7140e408185b5820163f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082607Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#746462}
-
Collin Baker authored
Other functions in the class do similar null checks. See bug report for crashes on frame_connector_->GetParentRenderWidgetHostView() call. Bug: 1041922 Change-Id: Ifbd3023aa24bd307841bc97dbc03ed444a8bc85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083739Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#746461}
-
Stephen Roe authored
This makes it easier to estimate Fuchsia ARM64 CI builder test stability before turning on CI tests. After Fuchsia ARM64 CI builder tests are turned on, the fuchsia-fyi-arm64-rel exceptions can be relaxed to debug flakey tests before enabling them in CI. Note that there are a lot of changes in generated files like ci.json that are unrelated to the test_suite_exceptions.pyl changes. Could earlier changes to source files have been checked in without updating the generated files? Bug: 1042512 Change-Id: I9abf23fef24243f0c60fdd85c108720906aaa60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083342 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c3655c3a7d55..f8b286781636 git log c3655c3a7d55..f8b286781636 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 xiaoxuan.liu@arm.com Vulkan: Add support for VK_EXT_index_type_uint8 Created with: gclient setdep -r src/third_party/angle@f8b286781636 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0805a5d0d6e2be9b9d341ed75c1ee13f3f8ce233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085016Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f37cd3c..65b70d61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I72ca9ea8bf78f6b012b5ef03a54d9ca60c5150e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746458}
-
Mikel Astiz authored
The USS implementation of bookmark sync launched with M77 and most code has already been cleaned up. Transaction versions embedded in BookmarkModel are no longer used and can also be deleted. Change-Id: Icfe2ab727edce293c73b7b3ae521df66a71d843a Bug: 933756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081426Reviewed-by:
-
Tim Dresser authored
Bug: 1051558 Change-Id: Iea32652052262e5ac4454fe07ee1bcaacec285cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084712Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#746456}
-
Kurt Horimoto authored
Bug: none Change-Id: I12c62918c78a9cd8249396b6cfe33a5bb544c254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084714 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746455}
-
Ken Rockot authored
This enables the unsandboxed out-of-process Storage Service for separate runs of browser_tests, content_browsertests, extensions_browsertests, and interactive_ui_tests on Linux and Windows FYI bots. Once these remain green for a bit, they can just move to the main waterfall. Bug: 994911 Change-Id: I565e6ba067d3dced10df5c5faa92031db766e8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083844Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#746454}
-
Tim van der Lippe authored
This were replaced by e2etests in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062588 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062603 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: I857c07937cb753cf452d9fcef84a9f3f56eee1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085191Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746453}
-
John Lee authored
Previously, the swipe animation was mapped to where the user's pointer would be and would make the tab element disappear before the close event was confirmed. This CL sets it up such that the animation does not progress and only detects when a swipe happens. This is to address a bug where the front-end is not able to confirm whether the tab was successfully closed, due to an unload dialog. Bug: 1050747 Change-Id: Ia0a4658260ebd73a05bd616b4a8df5d4c4e2525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083403Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746452}
-
Nohemi Fernandez authored
Adds a gradient layer aligned with the UnifiedConsent embedded screen that will hide part of text if the device size is small to give the illusion that it is hidden further down on the device. Updates the anchors of the confirmation and skip sign-in buttons. Bug: 971989 Change-Id: I20cde343820af0d4ab5de3f45a374eaed48190b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080367 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746451}
-
Robbie Gibson authored
Before, if there were suggestions on the NTP, they would immediately appear. The better animation is to scroll the fakebox up to the top of the screen and then present the suggestions. To do this, when entering the omnibox from NTP, we only focus the location bar, which causes the scrolling animation. -fakeboxFocused is already called in the animation completion block, which does the actual work to make the omnibox text field first responder, causing the suggestions to appear. To finish off, the -locationBarDidBecomeFirstResponder code now only focuses the location bar if we are not on the regular NTP. Bug: 1057643 Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Mac Builder Next doesn't use a builderless machine; there's one machine that is allocated to it. When the machine was updated to Mac 10.15, its tasks started expiring because the machine no longer matched the os dimension. Change-Id: I039c61f381d0a65204a62b9c1333b1f6b652a416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083561 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
