GitLab

This adds the mojo OutputProtection interface and implementation that is
used to provide the OutputProtection service to the Chrome OS
cdm-oemcrypto daemon.

BUG=b:168230642,b:153111783,b:132039686,b:169530695
TEST=Unit tests pass, HDCP enabling/verify works with daemon

Change-Id: Ia40a8631894f937e79ab4504a7121d31b3713ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432804Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#811423}

This CL pushes out the expiration of two histograms by a year:
DevTools.KeyboardShortcutFired and DevTools.KeybindSetSettingChanged

Bug: 1130657, 174309
Change-Id: Id6af73627f34477ed4b87e2b42df547cd42fb28d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432136Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#811422}

A frame context is necessary to parse vp9 compressed data and
the context is updated every frame by default. In other words,
it is necessary to see all previous frames.
In temporal layer encoding, frames in temporal layers, e.g. TL0
only stream and TL0+TL1 stream, must be able to be decoded even
though there is no frames in TL2. To resolve the frame context
problem, we enable error resilient mode in temporal layer
encoding. It let the frame context not be updated and thus the
syntax of a frame can be decoded independently of the previous
frames.

Bug: b:169219904, b:169538499
Test: https://appr.tc/?vsc=vp9&vrc=vp9
Change-Id: I976dc2d2f0f91d69b87b081da22f1c153ecb634c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435030Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811421}

This is very similar to
https://chromium-review.googlesource.com/c/chromium/src/+/2399082 ,
which dealt with items whose inline axis was the flexbox's main axis.
This patch deals with items whose block axis is the flexbox's main axis.

Old behavior: Use post-layout height of image items, obeying
min/main/max height.

New behavior: use the intrinsic height after applying the aspect ratio
and min/main/max width. Ignore computed min/main/max height.

Fixed: 987000
Change-Id: If64eeca9cc541bec863b1132aea4fd89305f5d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433629
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811420}

https://chromium.googlesource.com/catapult.git/+log/3cd3b4e18cd1..21e6e530cf90

2020-09-28 sebmarchand@chromium.org Make the CHROME_SHUTDOWN_TIMEOUT var work on !win platforms

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1071664
Tbr: rmhasan@google.com
Change-Id: If7c8e3dc43c7b6fce2b2d6b38fa401df74d91011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811419}

static_cast is better suited for downcasting since it can check that the
types are related.

/components/spellcheck
This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Change-Id: I8e56e103edc746726326ebef61563614b82fd6c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435961
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811418}

https://skia.googlesource.com/skia.git/+log/defd223d4023..3d921f1b2c56

2020-09-28 johnstiles@google.com Add unit test to demonstrate lack of SkSL swizzle optimization.
2020-09-28 johnstiles@google.com Add 'tricky' OutParams golden output.
2020-09-28 mtklein@google.com impl q14 in JIT using even lanes
2020-09-28 herb@google.com air gap SkStrikeClient API from implementation
2020-09-28 bungeman@google.com Respect kGenA8FromLCD when creating mask from path.
2020-09-28 herb@google.com introduce SkGlyphRect specialized for union & intersect
2020-09-28 johnstiles@google.com Fix call counts for intrinsic functions.
2020-09-28 johnstiles@google.com Reland "Support out parameters that use a swizzle."
2020-09-28 michaelludwig@google.com Check SkRRect::transform result, don't assume S+T matrix is safe
2020-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6a3c229f to 8563523f (1024 revisions)
2020-09-28 bungeman@google.com Fix gms placing text in bounds.
2020-09-28 bsalomon@google.com Log more info for Chrome bug 1132617
2020-09-28 egdaniel@google.com Use sk_sp for GrVkImageViews.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1132617,chromium:1132739
Tbr: brianosman@google.com
Change-Id: Icb6397aa0b3e78e24b85a64d3eea0ad53bd1eee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436096Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811417}

We were loading xsurface at startup when FeedV2 was enabled.
Now it's only loaded when the feed surface is created.
This change shouldn't even affect normal startup when the NTP is
loading, because the startup() function is typically called after
creation of the feed surface in that case.

Bug: 1130677
Change-Id: If5edaa35fc387e92530b01e2421e1eef4b6ced82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422690Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811416}

The GetRenderWidgetHostViewMac(NSObject*) test function was using
whether a WebContents was a guest to determine whether a cast to
RenderWidgetHostViewMac was safe. This would not be correct with other
nested WebContents, so we update the logic to check for a root RWHV
before casting.

Bug: 533069
Change-Id: I7af9fae9a862e2731e5770a1f628f9d6c39f8dc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436950Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811415}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/chromeos/crostini
This CL was uploaded by git cl split.

R=hollingum@google.com

Change-Id: I5fa53d165710036fd346b5d864251502ce57cbc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435979
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#811414}

This reverts commit 3df38ad3.

Reason for revert: OverflowScrollInterruptedByInstantScroll fails on linux-chromeos-dbg

BUG=1133037

Original change's description:
> Rewrite scroll interruption tests into browser tests
>
> After we finish the scroll unification, the scrolls happens mainly on
> the compositor thread, and the scroll code in the main thread will be
> removed. eventSender sends the scroll events to main thread, so it
> would not work after the scroll unification. We rewrite below tests
> fast/scroll-behavior/main-frame-interrupted-scroll.html,
> fast/scroll-behavior/overflow-interrupted-scroll.html and
> fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
> because we cannot guarantee that the scroll arrives before the animation
> completes.
>
> Bug: 1047176
> Change-Id: I79275eb7f2a78fd52e0c1ac93c4ee7d95d27b22f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250663
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811361}

TBR=ajuma@chromium.org,bokan@chromium.org,lanwei@chromium.org

Change-Id: I124efbb27cbba87f09c96e4813ad66532487b95e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436781Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811413}

This CL is a mechanical change that renames GetAppLaunchURL() to
GetAppStartUrl(). This makes the getter more consistent with the web
app manifest field it represents:
https://www.w3.org/TR/appmanifest/#start_url-member

This is in preparation to reintroduce GetAppLaunchUrl() with a slightly
different behaviour. Instead of just returning start_url it will append
any query parameters specified at install time to be used as the launch
URL.

Bug: 1045537
Change-Id: I99d1b16f83caaa5b53a0c392268dc9b389b0aa33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435135Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811412}

BluetoothMediumClassic::GetRemoteDevice should now return a new device
with the given mac address if one hasn't been added yet.

Bug: 1131981
Test: unit_tests
Change-Id: I5a8f19469799074e667bfa05f3ae667d789d8572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435821
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811411}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Idacff67c0f62dc93adbc5e22551b0c5c6e335132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436436Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811410}

This reverts commit 4f50dcad.

Reason for revert: Revert to release resource for Android M CQ builder as the bot usage is high now: http://shortn/_6Egeg4knUp

Original change's description:
> luci: increase the experimental percentage to 20 from 5 for MM-x86-rel
>
> The builder runs a smaller test suite since crrev.com/c/2422710.
> The GCE capacity should be able to hold more traffic.
>
> Bug: 997376, 1127110
> Change-Id: I23c9bb5b55aa5f335dea3bdc1817c4793fcf9eb0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429249
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Commit-Queue: Haiyang Pan <hypan@google.com>
> Cr-Commit-Position: refs/heads/master@{#811299}

TBR=liaoyuke@chromium.org,hypan@google.com

Change-Id: Iddef5694a45ec74fcfd4bb478008963bde2fcf5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997376
Bug: 1127110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436854Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#811409}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3860f7c6..a9c65f64

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0692fe45254dcddf5f9bbbefd39d38a6cf3e1ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436059Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811408}

Add a new Polymer element, source-select, to display scan sources (e.g.
flatbed, document feeder, etc.) in a dropdown. Styling will be added in
subsequent CLs.

Bug: 1059779
Change-Id: I88603298c3c749905527b5d74216f6285d984d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424988Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811407}

Adds a setter for the thumbnail element to accept an ImageData object
with which to paint the canvas of its thumbnail. The canvas is sized
according to the dimensions of the image and the screen resolution.

Bug: 652400
Change-Id: I885a1524cadd55731d90bfd0a8d2c4788beb1370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430728Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811406}

This is a follow-up from the Nearby Connections uprev to add the
|enable_bluetooth_listening| advertising option which allows listening
on incoming Bluetooth Classic connections.

Bug: 1131986
Change-Id: I76c5ee5583264e0e65afdc6f48db4455922f5c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432197
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811405}

AccountManagerUIHandlerTest tests were disabled in
https://bugs.chromium.org/p/chromium/issues/detail?id=1131834
due to flakiness with ExternalWebAppManager. This is due to
https://chromium-review.googlesource.com/c/chromium/src/+/2423823
altering the behaviour of when
chromeos::ProfileHelper::IsPrimaryProfile() gets called uncovering
an incompatiblity between the profile created by these tests and
IsPrimaryProfile().

This CL disables ExternalWebAppManager's start up flow to avoid
triggering the IsPrimaryProfile() incompatibility so we can
re-enable these tests.

Bug: 1131834
Change-Id: Ia4d15785a64b45689f742d3604c10e1b8502cafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434412
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811404}

Bug: b:169578241
Test: manually
Change-Id: Ia9ae5b9a71838c160ca81c73842c59b71db16270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436583Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811403}

Adds Dawn's tests to Linux FYI Experimental Release (NVIDIA)

Bug: chromium:1016948, dawn:200
Change-Id: I69f3c9d7c4eb4e54e7ae2c5d8738547b4784d17b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424036
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811402}

There's 2 issues with histogram_paths.py on Windows:
  - Some path have different casing on Win vs Linux, see
    crbug.com/1132974 . This is not the right way to fix this but this
    allows running histogram_paths.py on Windows.
  - Normalizing the path separators after sorting them causes some
    sorting differences (this causes
    "tools/metrics/histograms/histograms_xml/renderer4/histograms.xml"
    to appear before
    "tools/metrics/histograms/histograms_xml/renderer/histograms.xml" on
    Windows.


Bug: 1132974
Change-Id: Id6953f29f2073551df9a13cc2c72d2e6eef33cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436293Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811401}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/views/extensions
This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Change-Id: I5300e111b30d94c6571f090128a32ad638f0f2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435980
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811400}

https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..09a013c1993f704e

$ git log ba9d95e4328b..09a013c1993f704e --date=short --no-merges --format='%ad %ae %s'
2020-09-28 wub Change quic_toy_client.cc to include the correct header file for AF_INET/AF_INET6/AF_UNSPEC on windows.
2020-09-28 bnc Add code count for quic_fix_http3_goaway_stream_id.
2020-09-28 fayang Dropping initial keys at the end of writing to avoid potential missing write keys in the middle of writing.
2020-09-28 bnc Do not clip error codes larger than QUIC_LAST_ERROR.
2020-09-28 quiche-dev Fix //third_party/quic/core:quic_connection_test with randomized flags
2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets).
2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed.
2020-09-25 quiche-dev Fix a latent query-of-death

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: I4e66876896183a09d1c33fc3d2f0768bbe71f619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435748
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Auto-Submit: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811399}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ac564dd6553..29d2aa6ec8cc

2020-09-28 vidorteg@microsoft.com Changing tone on a settings screen string.
2020-09-28 alexrudenko@chromium.org Refactor highlight and grid tools
2020-09-28 chrche@microsoft.com [Loc] Dont localize "top" and "iframe" when used as Javascript context
2020-09-28 wolfi@chromium.org Fix bug where FrameTreeNode is selected despite clicking elsewhere

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1131801,chromium:941561
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7e38b38baf620297992dad1597d99d46c474952e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436092Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811398}

The --no-service-autorun command line switch prevents service processes
from registering for autorun. This change updates ChromeDriver to use
this flag for desktop sessions. Service processes are tied to the
same user data directory as the browser process that launched them. If
a service process is created during a ChromeDriver session, it will use
the temporary user data directory that ChromeDriver created. This
directory is deleted at the end of the ChromeDriver session so it will
be meaningless after a machine reboot. The --no-service-autorun switch
ensures that we don't try to launch a service process with a previously
deleted user data directory on startup.

This issue was first found in Microsoft Edge. A notification service
is created and added to autorun by default when Edge starts for the
first time in a new profile. A downstream fixed has been checked in to
disable this service when --enable-automation is passed on the command
line. However, --no-service-autorun is still a good idea for
ChromeDriver since any potential service processes that are created
during a ChromeDriver session should not create OS artifacts such as
autorun entries that persist beyond the ChromeDriver session.

Bug: 1132969
Change-Id: I12c501b9e6c9ff8887f28fdd6f3144b113218e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436773Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#811397}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/views
This CL was uploaded by git cl split.

R=pbos@chromium.org

Change-Id: Ifd8b52796b8a642ac5fbcf8b4c069f0eac730437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435804
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811396}

This reverts commit 2dc7fd65.

Reason for revert: Merged to 86. Was temporary to support merge of a safer fix.

Original change's description:
> media: Ensure sync token synchronization for VideoFrame images.
>
> Instead of relying on the sync token returned by
> AcceleratedStaticBitmapImage to ensure synchronization with the raster
> stream used by skia, perform this when the mailbox is returned. This is
> temporary to allow merging a safer change to 86 release branch.
>
> R=​dalecurtis@chromium.org
>
> Bug: 1131123
> Change-Id: I639a0d864fae29ddb32182aeda5ba2e854b1f5ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433049
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Auto-Submit: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810936}

TBR=dalecurtis@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1131123
Change-Id: Ia49977cb40ab9caea536d7c3dfeab4a97181874a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435782Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811395}

This reverts commit f56db26f.

Reason for revert: breakage was already fixed in 1df2fd67

Original change's description:
> Revert "Adjust aggregate_vector_icons GN template."
>
> This reverts commit 6197ec27.
>
> Reason for revert: Broke chromeos-betty-pi-arc-cfi-thin-lto-chrome
>
> BUG=1133015
>
> Original change's description:
> > Adjust aggregate_vector_icons GN template.
> >
> > Change the name of the icon list from `icons` to `sources`. This makes
> > gn format alphabetize the list.
> >
> > Bug: 1132894
> > Change-Id: I8dfe07d74fa2ddfd32ef8bec8729923e999a640e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427135
> > Commit-Queue: Evan Stade <estade@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#811364}
>
> TBR=sky@chromium.org,estade@chromium.org
>
> Change-Id: I69cd779577af70125c23f4b6085d62d97ec231fc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1132894
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436394
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811389}

TBR=sky@chromium.org,estade@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1133015
Bug: 1132894
Change-Id: I73199d77ecb5dd156ef89a40dcc26581841b12cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436892Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811394}

R=sky
BUG=1066670

Change-Id: Ie60214eede9dc3d7f332d01918ffc9a618ec09b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431413
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811393}

The expression already has the specified type.

Bug: None
Change-Id: I49ac50699182978380f964959957ea1001046b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435920
Commit-Queue: ssid <ssid@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811392}

Bug: 1131989
Change-Id: I9b84112d9d3552a744010f4008a3d9b7d21b4fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429446Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#811391}

Previously, android_library_factory assumed that parameters would have
no bounded type parameters. This CL adds code to generate those bounded
type parameters for public method arguments in *Factory.java files.

Example:
Previously method(Callback<Context> a) would become method(Callback a)
in the generated *Factory.java file. Now the <Context> type parameter is
preserved in the generated *Factory.java file.

Add missing dep for
//components/browser_ui/android/bottomsheet:factory_java and
//chrome/browser/video_tutorials:factory_java since previously these
imports were elided due to the type parameter being omitted.

Bug: 1131954
Change-Id: Ic5303cfaae5e3e89eddc00f9bcfef919ebb3d7dc
Fixed: 1131954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428734
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811390}

This reverts commit 6197ec27.

Reason for revert: Broke chromeos-betty-pi-arc-cfi-thin-lto-chrome

BUG=1133015

Original change's description:
> Adjust aggregate_vector_icons GN template.
>
> Change the name of the icon list from `icons` to `sources`. This makes
> gn format alphabetize the list.
>
> Bug: 1132894
> Change-Id: I8dfe07d74fa2ddfd32ef8bec8729923e999a640e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427135
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811364}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I69cd779577af70125c23f4b6085d62d97ec231fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436394Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811389}

This is a reland of 1b36f1a7. The fix is to not use a video that requires proprietary codecs.

Original change's description:
> Add autoplay parameter to navigations.
>
> Bug: 1131881
> Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810932}

Bug: 1131881
Change-Id: I4d791880960a0b1ad3dbaf88ece39c4f1b6c8f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435838
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811388}

If AXPosition::AsValidDOMPosition is called with kMoveLeft on an inline
text box created from generated content, and that text box immediately
follows an input with visibility:hidden, an infinite loop can occur: In
the case of generated content, AsValidDOMPosition will attempt to create
a previous position based on the previous object (i.e. the hidden input,
which lacks accessible children). In order to not skip over intervening
text in the case of native text controls, CreatePreviousPosition returns
a position immediately after that control (i.e. the generated content).

In order to prevent this infinite loop, check the resulting AXPosition
before calling AsValidDOMPosition on it. If the position hasn't changed
after we've tried to convert a generated-content position into a DOM
position, return an empty AXPosition.

AX-Relnotes: Prevents a page crash when accessibility is enabled.

Bug: 1131019
Change-Id: I4d7899bb598ce03a679b553aafb509ef2028ac05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426490
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811387}

This is a follow-up CL for https://crrev.com/c/2413830. After the CL,
mojom::PrerenderHandleClient was the client of mojom::PrerenderProcessor
so that should have been renamed to mojom::PrerenderProcessorClient.

Bug: 1132746
Change-Id: Ia55cbf2f0e248baf3f172caeccbd29be18f3f614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434071Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811386}

Change-Id: I802ac8a08a2e97e4cfac121108fc98611cb3bd70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430289Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811385}

ChromeOS AMD devices seem to have troubles scanning out high-bit depth
framebuffers; this CL disables creating such DisplayColorSpaces on
said platforms while we fix that.

(FTR there're no HDR-capable panels on AMD Chromebooks, but users can
connect an external HDR screen, hitting this path.)

Bug: b/169576243, b/165825264
Change-Id: I7e451d9817fee34d01c7d1ef943ef43fb1dce4be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435925Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811384}