- 24 Oct, 2019 40 commits
-
-
Mike Wittman authored
pthread_attr_getstack returns the lowest address in the stack allocation, so the size must be added to get the base address. Also adds logic to cache the main thread base address to avoid performance overhead on Android. This is modeled after similar logic in GetStackEnd() in base/debug/stack_trace.cc. Bug: 988579 Change-Id: Ia31b85afafc98b61dc60eb2c0d0ab64ba70877c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869831 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709076}
-
Peter Kasting authored
Bug: 82078 Change-Id: I0b56a851bafdd9894bf8ccd44bf9a765f7170498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869828 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#709075}
-
Antonio Gomes authored
... so that it can be used on more testing files. Note that, given that one of the methods reimplemented need access blink::WebLocalFrame, the newly added files can not reside in renderer/platform/testing, where other similar files are. BUG=787254 R=guidou@chromium.org Change-Id: I1dd6154407d744daab6cdbad0003bf2ddafe7485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873986 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#709074}
-
Emily Stark authored
Named namespaces are discouraged in chrome/ (as discussed on chromium-dev and recently codified in https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#named-namespaces). This removes the safety_tips namespace, renames a couple functions as needed, and does a little more miscellaneous cleanup (e.g., removing unnecessary aliases). TBR=csharrison@chromium.org,ellyjones@chromium.org Change-Id: I28dbd6ba2a90784fe148e91ccd75bc607d6192b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876474Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#709073}
-
Henrique Nakashima authored
Initially, it contains: - ChromeColors (was part of ColorUtils) - @color - toolbar_background_primary - toolbar_background_primary_dark - standard_mode_tint - tint_on_dark_bg Shared resources that correspond to Chrome style should be moved here. Bug: 995916 Change-Id: I455c63e444655e4bac6f8b68cb7d2b9650f06f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872181Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709072}
-
Stephen White authored
Change-Id: I5c5b27bdf1923aa3d0b3a6fb2fb36d3ce1fcb733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864361 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709071}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad557c41da7c..3671a6a21726 git log ad557c41da7c..3671a6a21726 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 jmadill@chromium.org Revert "git-cl: Add diff lines of context setting." Created with: gclient setdep -r src/third_party/depot_tools@3671a6a21726 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ie5a2589a464303c34e6ca1f7c01a7ead5023ad25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709070}
-
Dave Tapuska authored
Move FrameMsg_ResetContentSecurityPolicy to a RemoteFrame mojo interface. BUG=1008432 Change-Id: I8b96015cefc57e297594ac6d2ebc4024ffd698e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873400 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709069}
-
David Dorwin authored
Bug: 1013709 Test: There are separate tests for the render and browser process. Renderer process (adapted from https://crrev.com/2349963002): 1. Load the file from http://crbug.com/288697#c12. 2. Change the OS time zone. 3. Click "recheck" and verify that the new time zone is displayed. Don't reload the page as this could result in a new renderer process. 4. Change the OS time zone back to the original time zone. 5. Repeat step 3. Browser process (adapted from https://crrev.com/697203006): 1. Open History (chrome://history/) 2. Change the OS time zone. 3. Reload the History page and verify that times displayed are in the new time zone. Change-Id: Ifefbb67efebda8a23200a3ba163ce961a7260807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845623Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709068}
-
Friedrich Horschig authored
This CL ensures that the touch to fill backend properly dismisses all remains of touch to fill before showing the password preferences. Because the dismissal was incomplete, users wouldn't be able to trigger a keyboard or any touch to fill sheet. Bug: 1017724 Change-Id: If26f00332897064c10fb12a17edaf2503a96d1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878828Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#709067}
-
Nicolás Peña Moreno authored
Currently, |enabled_| is a boolean used as a performance optimization to avoid doing work when nothing is subscribing to violations that are reported by the PerformanceMonitor. This is often the case, so the optimization works well, although it is only slightly faster than just checking whether the corresponding |thresholds_| entry is_zero(). However, we plan to start buffering longtasks soon, which requires observing for them from the beginning regardless of the presence of a PerformanceObserver. With this change, |enabled_| would not work well as an optimization because it would be set to true most of the time. This CL changes its meaning so that it excludes longtasks, thus being false most of the time even after we start observing longtasks by default. Bug: 1016815 Change-Id: I06d8e8631c83663ead48f344ca08759472edf61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874048 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709066}
-
Andreas Haas authored
In the context of an ongoing refactoring of WTF::ArrayBuffers we move the implementation out of libwtf. The idea is to merge it into DOMArrayBuffer eventually and get rid of WTF::ArrayBuffer completely. StaticBitmapImage included WTF::ArrayBufferContents but cannot include anything in third_party/blink/renderer/core/typed_arrays/*. With this CL I remove the direct creation of ArrayBufferContents in StaticBitmapImage. The idea behind the CL is that instead of creating an ArrayBufferContents in ConvertToArrayBufferContents, we just pass a pointer to the backing store of the ArrayBufferContents, and let StaticBitmapImage just fill that backing store with data. I renamed the function therefore to CopyToByteArray. To be able to allocate an ArrayBufferContents of the right size, StaticBitmapImage now also provides a SizeInBytes function, and MayHaveStrayArea to indicate if the backing store needs to be zero-initialized. Alternative implementations would be to just fill a WTF::Vector, and then copy the result into an ArrayBufferContents, or to provide a producer function to StaticBitmapImage so that it can allocate an ArrayBufferContents in an opaque way. I did not like both, the former requires extra copying, the latter is too complicated. R=jbroman@chromium.org Bug: chromium:1008840 Change-Id: I0b283dd9605f31905f3cb0d65615fc85d84e8f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871674Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709065}
-
Clark DuVall authored
Change-Id: I8e0c93abdbaf040347448a51c0280cbfe524abc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877307 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#709064}
-
Jared Saul authored
Removes outdated owners (csashi, dlkumar, jiahuiguo) and extends three histograms for a year that we still find useful. Fixed: 1016405, 1016413, 1016432 Change-Id: Ie4b2f2075ba8862a892bb270c5d2d48b3a4849b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877811Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#709063}
-
Jérôme Lebel authored
Removing Unified consent flag description. Related to: crrev.com/c/1866513 Bug: 951313, 1015805 Change-Id: I5f42081038b0176e3d55d1935f0592688dd05cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813507 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#709062}
-
Mike Wittman authored
The stack sampling implementations for Linux and Android platforms require the pthread_t type to obtain the stack base address, in addition to the PlatformThreadId. This change introduces a minimal ThreadToken abstraction that encapsulates the necessary thread state across platforms. TBR=gab@chromium.org Bug: 988579 Change-Id: Ie5d70709ddae362ca414dc5a635e456c8bd9f8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860151Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709061}
-
Robbie Gibson authored
The boolean looks like it was needed because there was a bug in iOS 4 that didn't allow for this custom copy behavior. Now, the underlying OnCopy method never returns false, and iOS 4 is no longer supported, so this doesn't need t return a boolean. The copy will always happen. Bug: 866446 Change-Id: I11f3b90b191d10442ab513d377756cacbfb898e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869005 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709060}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateAssistantAudioDecoder in AssistantAudioDecoderFactory interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. Bug: 955171 Change-Id: I2de4cb0561c69201335817ec6a873258a30d9a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871503 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709059}
-
Himanshu Jaju authored
Consistently use hardware_info while renaming devices in SharingService. This allows us to locally modify manufacturer names at a single place. Bug: 1016332 Change-Id: I309ddc4abb93242ba496666996badefbf10c24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878650Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709058}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I5771e2c7294c29241ccda5a55f9ebb5f95117871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876976 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#709057}
-
Emily Stark authored
Namespaces are discouraged in chrome/, as previously discussed on chromium-dev and recently codified at https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#named-namespaces. This CL removes the lookalikes:: namespace. Change-Id: I91cd483630881c4cb29fb5cf3f44ca91b5a767c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877127 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709056}
-
Javier Ernesto Flores Robles authored
This reverts commit 770741aa. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[iOS][MF][EG2] Migrate credit card tests" > > This reverts commit b27f6c3c. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[iOS][MF][EG2] Migrate credit card tests" > > > > This reverts commit 919aab84. > > > > Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 > > > > Original change's description: > > > [iOS][MF][EG2] Migrate credit card tests > > > > > > Consolidate Manual Fallback matchers in one place. > > > Consolidate credit card Autofill helpers in the respective app > > > interface. > > > > > > TBR= eugenebut@chromium.org > > > > > > Bug: 1017685, 1016367 > > > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#709020} > > > > TBR=stkhapugin@chromium.org,javierrobles@chromium.org > > > > Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1017685, 1016367 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709028} > > TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org > > Change-Id: If9bf98648abb8c0211764c378490c34f84039f27 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017685, 1016367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878490 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709048} TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org Change-Id: I3adaebe3761571c6bbd5721edd49639a5c0e49a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878829Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#709055}
-
Livvie Lin authored
Rename INSECURE to INFO and DANGEROUS to NOT_SECURE_WARNING. The eventual goal is to use the info icon to convey site information and a grey triangle icon to indicate non-secure connections (crbug.com/1008219). Thus, this cl renames the info icon to be more descriptive and the danger icon to be more general. Bug: 1008219 Change-Id: Id012ec42d4c6ec75e4f7aee4247029b89b4d704a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876129Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c8a7000517d..87002bea1174 Created with: gclient setdep -r src-internal@87002bea1174 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8f8553c5c2f2cd58a32fc32bac4ca23c3b1702a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709053}
-
Stephen McGruer authored
Because this file has multiple tests with the same name ('All') and an existing MAYBE_All macro, rename the test to 'AllBCM' to avoid macro collision. TBR=tommycli@chromium.org Bug: 1010381 Change-Id: I475153dc2ec05fb737fe59a7568c619ebfdc68da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878530Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709052}
-
Tricia Crichton authored
Some code paths do not set the status message for UnexpectedAlertOpen errors. When these are encountered, the code crashes when the { or } are not found. This CL checks for that state and prevents the crash. Fixed: chromedriver:3073 Change-Id: I9cc1cf4f1988af1300f9363add90a1217f0cb26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877136Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#709051}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I9ecb68a507a98f02f2238d28feb6ff72da71f8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875482Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709050}
-
manuk authored
Apparently back in 2011, undoing a cut in TextfieldModel would restore the cut text with incorrectly reversed selection direction. This was evident when then modifying the selection (e.g. shift + arrows/home/end). This was worked around by reversing the selection an additional time. However, the original reversal no longer occurs, so the workaround is now causing the bug it was meant to fix. This CL removes the workaround selection-reversal. Bug: 1017179 Change-Id: If230de84455b5be5feedc12ba6636668642e68dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875474 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709049}
-
Javier Ernesto Flores Robles authored
This reverts commit b27f6c3c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[iOS][MF][EG2] Migrate credit card tests" > > This reverts commit 919aab84. > > Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 > > Original change's description: > > [iOS][MF][EG2] Migrate credit card tests > > > > Consolidate Manual Fallback matchers in one place. > > Consolidate credit card Autofill helpers in the respective app > > interface. > > > > TBR= eugenebut@chromium.org > > > > Bug: 1017685, 1016367 > > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709020} > > TBR=stkhapugin@chromium.org,javierrobles@chromium.org > > Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017685, 1016367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709028} TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org Change-Id: If9bf98648abb8c0211764c378490c34f84039f27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878490Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#709048}
-
Christopher Grant authored
For a period of time, LLD couldn't produce partitions in debug builds, and hence a workaround was needed for the debug non-component case. The same workaround would kick in if partitioning were disabled on release builds (ie. a kill switch). Now, LLD is fixed and partitions have soaked long enough to drop the kill switch. Bug: 1011834 Change-Id: I00bdb911c61a7e7e7cd7359daa996074494b8b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873910Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709047}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I1a29243c5dd4ab9a446baa7c4ddebb3408e7f5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875485Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709046}
-
Henrique Nakashima authored
Also remove DOWNLOAD_TAB_MANAGEMENT_MODULE since it becomes unused. Bug: 1012975 Change-Id: I8a687bc395ebb1d0f775eb7b83321047ba4ecb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863033Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709045}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia455a6ec86eda0230ff287ba2b2ca0348b57771e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709044}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I07244066da4394b74830765f6219b630f66b2cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876977Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709043}
-
Emily Stark authored
We previously created this directory to hold safety tips code, but we haven't actually used it. This CL moves the safety tips code from chrome/browser/lookalikes/safety_tips to chrome/browser/reputation. Mostly an automatic transformation with tools/git/move_source_file.py, but some manual fixup was required. TBR=dtrainor@chromium.org Bug: 1017369 Change-Id: I9a0f6511cc0eca929ef81d3fb27262110a835ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875514 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#709042}
-
John Z Wu authored
//ios/web_view does not support any data migration between accounts Change-Id: Ic357556ba9c6d7f71611c3a839b3675f6b169d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869018Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#709041}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b54b963. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I22ae9c9213c10d6d90601b2dbaf805cef9f394d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877377Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/137a46738b35..38c2b4512e74 git log 137a46738b35..38c2b4512e74 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 lalitm@google.com Merge "trace_processor: add test for custom clock power rails" Created with: gclient setdep -r src/third_party/perfetto@38c2b4512e74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3ffe846abc872a3a8d2c48267e3edf3d9a4259d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709039}
-
Stephen McGruer authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: If6820dc2e87850a5f3965a8bef663e5a0ff0c531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878908Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709038}
-
Chris Lu authored
Since BadgeState is a mask, a direct equality comparison to BadgeState values for the BadgeItem properties is not the correct way to assess if a badge is accepted. To add testing support for this case, accepted a11y identifiers for BadgeButtons are created, and they will be properly set in setAccepted: in BadgeButton. Bug: 976901, 1016793 Change-Id: Id17eb82e0764fbbf80b871df0b974fe148c2339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872938 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#709037}
-