GitLab

BUG=555865

Review-Url: https://codereview.chromium.org/2290503003
Cr-Commit-Position: refs/heads/master@{#416291}

Removing this call should be safe because the call just does following
things:
1. Sets started_ to false in VideoCapturerTrackSource. This doesn't
matter since it will be destroyed soon.
2. Calls WebRtcDummyVideoCapturer::Stop. This just sets the state of the
dummy video captuer to CS_STOPPED. This doesn't matter since it will be
destroyed soon.

Motivation behind this change is that we want to remove Restart and Stop
from VideoTrackSourceInterface. This code is the last usage of these
methods.

Review-Url: https://codereview.chromium.org/2308543002
Cr-Commit-Position: refs/heads/master@{#416290}

We were OOMing a unit test on lollipop devices since we were using a
resource larger than MAX_TEXTURE_SIZE which is 2048, so we had a
bitmap of size:
  (100 * 2048 / 9.9, 15 * 2048 / 9.9)
= (20687, 3104)

Which is an ARGB32 bitmap so 4 bytes per pixel: 256,849,792 bytes.

With this patch we have
  (100 * 512 / 9.9, 15 * 512 / 9.9)
= (5172, 776)

Which is 4,013,472 which will fit in memory much easier.

R=enne
BUG=642333
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2306833002
Cr-Commit-Position: refs/heads/master@{#416289}

This isn't caught by the unit test because it's not tested; it's
questionable whether it's worth adding a unit test for that function as
it is now, since that method just invokes some external commands.

This issue was caught by looking at the latest failures on
w3c-test-autoroller.

BUG=629275

Review-Url: https://codereview.chromium.org/2304053002
Cr-Commit-Position: refs/heads/master@{#416288}

Direct executors are banned by default - if cronet detects an executor with this behavior, it will fail the request immediately. Callers can disable this enforcement by using a new method on UrlRequest.Builder. Callers can use directexecutor to get finer grained control over their threading behavior - lightweight callbacks won't necessarily need to hop back and forth between threads.

BUG=566195

Review-Url: https://codereview.chromium.org/2283243002
Cr-Commit-Position: refs/heads/master@{#416287}

Also simplify initialization path.

BUG=none
TEST=unit tests

Review-Url: https://codereview.chromium.org/2300133002
Cr-Commit-Position: refs/heads/master@{#416286}

Change --exrta_histograms-file option to --extra_histograms-file.

BUG=

Review-Url: https://codereview.chromium.org/2296833003
Cr-Commit-Position: refs/heads/master@{#416285}

* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on
  each HTTP/2 connection.
* Immediately notify HpackDecoder about the change so that it allows the encoder
  to update the dynamic table size up to this limit.  It is safe to do so before
  receiving the SETTINGS ACK, because the new limit is larger than the default 4
  kB.  In fact, a server following RFC 7540 Section 6.5.3 word-by-word might
  already use the larger limit before sending an ACK.

BUG=642784

Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30
Review-Url: https://codereview.chromium.org/2300683002
Cr-Original-Commit-Position: refs/heads/master@{#415718}
Cr-Commit-Position: refs/heads/master@{#416284}

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke

Review-Url: https://codereview.chromium.org/2299143005
Cr-Commit-Position: refs/heads/master@{#416283}

This is extracted to its own class for simplicity and ease-of-reuse.  It was also originally intended to be a lock-free object but that ended up being overly complicated so has been put on indefinite hold.

BUG=620813

Review-Url: https://codereview.chromium.org/2255503002
Cr-Commit-Position: refs/heads/master@{#416282}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6256ea38cc13..54acca7c4f74

$ git log 6256ea38c..54acca7c4 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 perezju [Telemetry] Schedule platform.GetMemoryStats for deprecation

BUG=632021

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2306883003
Cr-Commit-Position: refs/heads/master@{#416281}

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG=642790

Review-Url: https://codereview.chromium.org/2296343004
Cr-Commit-Position: refs/heads/master@{#416280}

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2297943002
Cr-Commit-Position: refs/heads/master@{#416279}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d9e7b3b2..d36aae63

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2307923002
Cr-Commit-Position: refs/heads/master@{#416278}

This was regressed in crrev.com/2296983003

BUG=none
TBR=dgozman

Review URL: https://codereview.chromium.org/2303663003 .

Cr-Commit-Position: refs/heads/master@{#416277}

This relands https://codereview.chromium.org/2299223002 which was
reverted because of random pixel under-invalidations.

Now clear the bitmaps before drawing the pictures.

BTW changed the error indication color from solid red to translucent
magenta to distinguish from the normal red pixels in test results.

> This will let the tests having under-invalidation issues produce the
> same result on all builds, so enable us to rebaseline the tests with
> failure results. In this way we can track either regressions and
> progressions instead of ignoring the tests.
>
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2299223002
> Cr-Commit-Position: refs/heads/master@{#416060}

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/2301303002 .

Cr-Commit-Position: refs/heads/master@{#416276}

https://chromium.googlesource.com/skia.git/+log/3ed189743700..df0e3ece7076

$ git log 3ed189743..df0e3ece7 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 mtklein Revert of Force SkPath::getConvexity() cache for thread safety. (patchset #1 id:1 of https://codereview.chromium.org/2300003003/ )
2016-09-02 tikuta Add some required packages to tools/install_dependencies.sh
2016-09-02 reed record drawfilters
2016-09-01 msarett Make swizzler optional for SkPngCodec, refactor xforms
2016-09-01 msarett Request legacy mode behavior from SkCodec in BitmapRegionDecoder
2016-09-01 mtklein GN: Build and link with LLD when using our Clang toolchain.
2016-09-01 mtklein The *SAN bots are now all Clang bots.
2016-09-01 mtklein Remove tsan.supp.
2016-09-01 brettw Move Skia GN sources to a separate .gni file.
2016-09-01 halcanary SkPDF: revert changes to CMapName/Registry/Ordering in 3d01c62
2016-09-01 mtklein Force SkPath::getConvexity() cache for thread safety.
2016-09-01 rmistry Fix PostUploadHook for Gerrit issues

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2304983002
Cr-Commit-Position: refs/heads/master@{#416275}

(Original issue: http://crrev.com/2299673002 - fixed test failures on Mac
by disabling accessibility between subsequent runs.)

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2299283002
Cr-Commit-Position: refs/heads/master@{#416274}

-annotations is needed for @Config,
-shadows & -utils are needed for Shadow use cases

BUG=

Review-Url: https://codereview.chromium.org/2292083007
Cr-Commit-Position: refs/heads/master@{#416273}

Moving unittests which depend on files moved under enable_webtrc by
http://crrev.com/2287263003

BUG=none
TEST=content_unittests with enable_webtrc=true

Review-Url: https://codereview.chromium.org/2302903004
Cr-Commit-Position: refs/heads/master@{#416272}

Turn the <svg> into a block to avoid having to compensate for the
baseline of an inline.

BUG=397255

Review-Url: https://codereview.chromium.org/2303043003
Cr-Commit-Position: refs/heads/master@{#416271}

BUG=636405
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2304113002
Cr-Commit-Position: refs/heads/master@{#416270}

Wasm modules may be large (megs) and their compilation is time- and
resources consuming (many seconds on desktops, more on mobile).

With structured cloning support, developers may save/restore compilation
results in IndexedDB, or decide to compile on worker threads.

This first CL introduces basic support and a basic test.

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Dogpn1hpnhw

BUG=v8:5072

Review-Url: https://codereview.chromium.org/2255673003
Cr-Commit-Position: refs/heads/master@{#416269}

Revert of Add test of MakeUniqueID() and friends. (patchset #3 id:40001 of https://codereview.chromium.org/2306043002/ )

Reason for revert:
Fails on several bots: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQAsSCVdmQ3VscHJpdCIxY2hyb21pdW0vY2MyZjYxMjA0YzBlZGU1YzNjNTY5OWJjMDc5NmJiMmJiZmFiNzI1OQw

Original issue's description:
> Add test of MakeUniqueID() and friends.
>
> Committed: https://crrev.com/cc2f61204c0ede5c3c5699bc0796bb2bbfab7259
> Cr-Commit-Position: refs/heads/master@{#416259}

TBR=sfiera@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2302363002
Cr-Commit-Position: refs/heads/master@{#416268}

BUG=631245

Review-Url: https://codereview.chromium.org/2287353002
Cr-Commit-Position: refs/heads/master@{#416267}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/324d39a894c0..6256ea38cc13

$ git log 324d39a89..6256ea38c --date=short --no-merges --format='%ad %ae %s'
2016-09-02 jbudorick [devil] Add a markdown help text formatter.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2307043002
Cr-Commit-Position: refs/heads/master@{#416266}

BUG=494719

Review-Url: https://codereview.chromium.org/2307613002
Cr-Commit-Position: refs/heads/master@{#416265}

For inline boxes, the reference box should be computed per-fragment, and
be subject to box-decoration-break. We're not quite there yet though, so
go for "local compat" for now and align with Gecko. This way we're
slightly closer to "correct" (the "single line" case ought to be fairly
correct for instance), and hopefully avoid getting sucked into a compat
"sinkhole".
Adjust css3/masking/clip-path-reference-box-inline.html to match.

BUG=641907
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2303773002
Cr-Commit-Position: refs/heads/master@{#416264}

third_party/closure_compiler/run_compiler was failing due to missing compile_js*.gypi under ui/file_manager.

BUG=none
TEST=third_party/closue_compiler/run_compiler
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2296953008
Cr-Commit-Position: refs/heads/master@{#416263}

The implementations of content::AsyncResourceHandler and
content::ResourceDispatcher contained redundant assignments of
encoded_data_length. Fixed.

BUG=

Review-Url: https://codereview.chromium.org/2301893002
Cr-Commit-Position: refs/heads/master@{#416262}

https://github.com/w3c/webappsec-csp/issues/112 notes that '<meta>' has
some script-like capabilities that aren't currently covered by CSP. This
patch adds metrics for usage of 'Set-Cookie' and 'Refresh' in documents
that block inline script. If it turns out that the intersection is low,
perhaps we can make this backwards-incompatible change.

R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2308513002
Cr-Commit-Position: refs/heads/master@{#416261}

This adds the BudgetDatabase as a member of the manager, paving the way
for the switch from using the prefs to store budget to using the proto
database.

This also adds Reserve and Consume entrypoints on the BudgetManager.
Reserve is the entrypoint for the Mojo service to enable Javascript to
purchase reservations with budget. Consume is the entrypoint for clients
of the Manager to determine if an origin should be allowed an action,
either because it has a reservation or because it has enough budget to
cover the cost.

BUG=617971

Review-Url: https://codereview.chromium.org/2272563005
Cr-Commit-Position: refs/heads/master@{#416260}

Review-Url: https://codereview.chromium.org/2306043002
Cr-Commit-Position: refs/heads/master@{#416259}

Instead, implement ThreadedSSLPrivateKey::Delegate directly using the
JNI functions. This removes all of Chromium's uses of RSA_METHOD and
ECDSA_METHOD.

Rather than a function from jobject to EVP_PKEY exposed by
keystore_openssl.h, have SSLPlatformKeyAndroid expose a function from
jobject to SSLPrivateKey. That then gets routed through whereever
the EVP_PKEY used to be routed. In particular, OpenSSLClientKeyStore
now acts on a scoped_refptr<SSLPrivateKey> rather than a
crypto::ScopedEVP_PKEY.

OpenSSLClientKeyStore is also rewritten to be much simpler, but all its
problems (like not being thread-safe) still remain. That will be resolved
by finishing the SSLPrivateKey refactor and routing it up through
//content so we can do away with the inherently global
FetchClientCertPrivateKey.

Port the old keystore_unittests.cc tests to test the new wrapper. Trim
it down a little so it tests just the wrapper object, but test all
hashes.

BUG=394131

Review-Url: https://codereview.chromium.org/2291213002
Cr-Commit-Position: refs/heads/master@{#416258}

As same as a Window object, we do not need to support a constructor
for WindowProperties object.

BUG=643357

Review-Url: https://codereview.chromium.org/2306023002
Cr-Commit-Position: refs/heads/master@{#416257}

Revert of Temporarily decrease min-idle time for todomvc pagesets (patchset #1 id:1 of https://codereview.chromium.org/2276313002/ )

Reason for revert:
no longer needed

Original issue's description:
> Temporarily decrease min-idle time for todomvc pagesets
>
> Also record all the events
>
> BUG=636405
> R=skyostil@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/0f5391d7b30ce4536222f46aa5804f13f65da25d
> Cr-Commit-Position: refs/heads/master@{#414521}

TBR=skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636405

Review-Url: https://codereview.chromium.org/2308593002
Cr-Commit-Position: refs/heads/master@{#416256}

Dependencies are correct, successful triggered task on 4 core laptop:

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253

Review-Url: https://codereview.chromium.org/2290373002
Cr-Commit-Position: refs/heads/master@{#416255}

The following two methods defined in process.mojom are not needed anymore
because oom_adj setting and lowmemorykiller are disabled by default on Android side.
- DisableBuiltinOomAdjustment()
- DisableLowMemoryKiller()

BUG=b:30971151
TEST=minnie

Review-Url: https://codereview.chromium.org/2282053005
Cr-Commit-Position: refs/heads/master@{#416254}

Review-Url: https://codereview.chromium.org/2300233003
Cr-Commit-Position: refs/heads/master@{#416253}

Enhance the chrome.app.window API for shelf integration with the possibility of
pinning the showInShelf=true windows.

Based on https://codereview.chromium.org/1914993002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with showInShelf property set
to true. Pin a newly created window that has its own icon in the shelf, then
close it and open it again by clicking the pinned icon.
TEST= https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2290603002
Cr-Commit-Position: refs/heads/master@{#416252}