- 23 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c969abf14f2f..62f76f09dd6f 2020-06-23 primiano@google.com Docs: fix typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7fae0c2cf83d569b611608a0e20995da14951c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781254}
-
Clemens Arbesser authored
This is a reland of ae61a59a I reproduced the build failure and added the missing include. Original change's description: > [Autofill Assistant] Added ForEach interaction. > > Note: this is an alternative solution for http://crrev/c/2235698 > > This interaction executes a number of callbacks for the input loop value. This is intended to be used to inflate UI elements for client-only values, i.e., for values that the backend can't specify. > > Internally, ForEach loops are implemented by introducing the concept of callback contexts, which will change value and view lookup accordingly. > > In particular, callback contexts are used to automatically replace placeholders of the form ${i} in value and view identifiers (where 'i' is the loop identifier). This allows creating and referencing values and views with templated names, such as "created_view_${i}" and "value[${i}]". > > Bug: b/145043394 > Change-Id: I53089252fe1cc14b2b1fb74cfc56d7314bc4b37c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241975 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Marian Fechete <marianfe@google.com> > Cr-Commit-Position: refs/heads/master@{#780785} Bug: b/145043394 Change-Id: I36b64f8d5a64f66f9e9081137a61a20c31ade8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259847Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781253}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592884413-6b42064f372939c6b2068eeb31d6b96cefc4be86.profdata to chrome-win32-master-1592887944-a5350dcd6f0f1194a03615a841b47284864b512a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id94bb540bab9e4b7eb1df6b6a753fce131918919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259604Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifb68d5f797e5d3fc41d5433795548fe523e7194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259728Reviewed-by:
-
Ramin Halavati authored
CanOpenBrowser used IsOffTheRecordProfile instead of IsIncognitoProfile, applying incognito policy selections on all OTR profiles. It's now updated to only affect incognito. Bug: 1033903, 968028 Change-Id: I889cbbcacfe2fb0a42c81debc6d738487e1fdd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249932Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#781250}
-
Christian Dullweber authored
When a user grants a permission in regular mode, we replace the ALLOW content settings with an ASK setting in incognito mode. These settings should not be shown in the UI if ASK is the default setting. The current behavior also fails an assert in PermissionParamsListBuilder::createPermissionParams, which is fixed by this CL. Bug: 1092809 Change-Id: Ic74f77cca11b6d3ff0839e6f908002cf76838c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235822Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#781249}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d4b9f576ebb4..36b5bb701da9 2020-06-22 rharrison@google.com Add support for different default/trunks in roll-deps (#3442) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I23d5602369caa2848e1a53844a0c852828155426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259605Reviewed-by:
-
Vikas Soni authored
Metric to record whether an aggregated frame has video or not. Bug: 1085628 Change-Id: I08dca785bd664e92208a1943142acf7c597bde82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252618 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#781247}
-
Mikel Astiz authored
The whole get_commit_ids.h file is going away and hence integration-like tests in SyncerTest can be deleted. Change-Id: Ic9cedcf88cd4d9e517742413f7bccc9a0dc7cbd4 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257188Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781246}
-
Christoph Schwering authored
This CL adds a left margin of 8px. Bug: 1095904 Change-Id: I77a797ddabe5639190f1133065ffc628b7b4b44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257853Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#781245}
-
Hayato Ito authored
This reverts commit cdc21b6f. Reason for revert: [Sheriff] OSSettingsNearbyShareSubPageV3Test.All is consistently failing. See https://crbug.com/1098193 for the detail. Original change's description: > [Nearby] Enable Polymer3 support in Nearby Share Settings > > This CL adds and verifies Polymer3 support in the Nearby Share > subpage. A browser test is used to verify the Polymer3 setup is > working correctly. The test suites added are: > OSSettingsNearbyShareSubPageTest.* and > OSSettingsNearbyShareSubPageV3Test.* > > Change-Id: I9cc1e64bb08eb58ad9c83c1486191fbf4de78e26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251062 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781173} TBR=khorimoto@chromium.org,vecore@google.com,tjohnsonkanu@google.com Change-Id: Ifbb6c0334868861a6405ed8c70d29a0b99e577a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259398Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781244}
-
Oleh Lamzin authored
Move JS related targets to resources/BUILD.gn file. Bug: b:158566609 Change-Id: I910fc19e50af7d60ae885e7038176f0b11974376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244211Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#781243}
-
David authored
This is a reland of c7067b96 in which `linux-chromeos-chrome` failed because our internal observer wasn't added which triggers an attribute toggle that MediaAppIntegrationTest.FileOpenCanTraverseDirectory waits for.The observer is added in our latest DEPS change crrev/c/2257464. Original change: crrev/c/2249266 This cl changes the way we load files such that 1. we load a single file, after this users can interact with the app. 2. we asynchronously load every other related file in that directory, will update the app when it is done. Notably: * adds a way to register observers to AbstractFileList * adds a way to add files and notify observers to ReceivedFileList * adds IPC to 'load-extra-files' * adds `processOtherFilesInDirectory` & `globalLaunchNumber` which keeps loads in sync Existing tests provide a lot of coverage for the new codepaths, however there are edge cases such as loading the first file then doing one of the following 1. invoking launchable IPC i.e. rename 2. invoking non launchable IPC i.e. delete / save 3. start an edit (or another action) changing the UI This cl adds tests for 1 & 2. in the case of 1, we have a token `globalLaunchNumber` to make sure only the most recent load is fulfilled. in the case of 2, we load files as normal as the previous focus file is now removed from the file system. 3. is handled internally in cl/317047655 Bug: b/158043802, 996088 Change-Id: I795915611a687b7cc85674a3e2b88659eee99795 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259696Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#781242}
-
Ewann authored
This Cl tints the checkmark image present in the cookies view. Bug: 1063824 Change-Id: I549d7f9456c34aa38f1b053ad3680e0a5d6dfb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253747 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781241}
-
Tal Pressman authored
1. Add "onload" experiments (instead of FMP). 2. Add experiments that affect all queue types. 3. Refactor feature definitions. Bug: 1090251 Change-Id: Ibb64e7f462f7d6c4722037b85dbf45cfd69a9e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255935 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781240}
-
Saho Kobayashi authored
Send kValue changed event when state description change event of range widget is sent. CL to set kValue when state description of range widget is sent: CL:2224487 AXTreeSourceArcTest.StateDescriptionChangedEvent Bug: b:154433831 Test: ArcAccessibilityUtilTest.FromContentChangeTypesToAXEvent Change-Id: Iea60accbc90a6aa04bdb1b9644ab623c9a8acc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251518 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781239}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0928d0b13fd..008ec94fc147 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in console/consolePinPane.css 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-06-23 bmeurer@chromium.org [third_party] Cherry-pick unreleased CodeMirror wast changes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1083142,chromium:1093322 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I347eb635f25deb7f0df01675aa6db98ea7ee238e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259726Reviewed-by:
-
Simon Zünd authored
Design doc: https://bit.ly/browser-issue-storage This CL adds an Issue storage in the browser process, so Issues no longer need to be sent to the renderer process to be stored and reported there. Characteristics of the storage: - The issue count is capped at 1000 issues per WebContent - The storage is cleared for main frame navigations (modulo redirects) - When subframes get deleted, issues associated with the deleted subframe get "re-parented" to the main frame Bug: chromium:1063007 Change-Id: I75f164812770e8c73fc388d27767cc9151e5e4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246139 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#781237}
-
Hayato Ito authored
TBR=skobes@chromium.org Bug: 1098148 Change-Id: I13e6a6fd51735ff6ef6e162b93564f5585c2584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259397Reviewed-by:
-
Omid Tourzan authored
The links in the banner text hide when window shrinks and ellipsis appears but as their display is visible they can gain focus through tab key. It results in breaking the ellipsis message and scrolling down to show the link text. The following structure of elements used to handle this situation: container > wrapper > link This change adds an observer to check if the ellipsis is shown and hide the wrapper if so, so the <link> can't get focus anymore. The CSS ellipsis is active and applied if the scroll width or height of the element is greater than its client width or height. This is checked every time the size of element changes. The links don't get focus with tab key as their container is hidden when CSS ellipsis active. It behaves good because the links are the last part of the texts, so having overflowed or ellipsis means the links are invisible now and safe to hide their container. The download warning message needed more changes as the link was embedded in the message string, so a wrapper (link-wrapper) added to handle hide. Hiding the link itself leads to removing of ellipsis so a wrapper helps. Bug: 1082539 Change-Id: I13a8e6569da93967963a0f5c919b19e30c0fedca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257459 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781235}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592884413-02978613062131a2d07ebbd18f49e538455b68fd.profdata to chrome-win64-master-1592891992-572d12f4a11aaaeb26a619bef233d3655144eb8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I570168b013289e7b83c05e0f57909328d6d00f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259603Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2641327e3d38..758d13cf2772 2020-06-23 dberris@chromium.org pinpoint: Show hash in commit info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I4c59e5e850cca7f8136b8e5eefdbefecf350822c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259727Reviewed-by:
-
Gavin Williams authored
On CrOS, printer icons with a status badge will be displayed next to each printer in the dropdown. The printer status responses are saved in a dictionary accessible by the dropdown. When the dictionary is updated with a new status, the printers in the dropdown are triggered to recalculate the color of its status badge. Screenshot: http://screen/nOgp4BEL9i7 Bug: 1059607 Change-Id: I4422d628ab6627ab74fa1810dda89cbe19a9acf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238509 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781232}
-
Yao Xiao authored
We used to measure overlay-popup-ad. This CL adds another use counter to measure the overlay-popup in general, including both ads & non-ads. This is achieved by adding extra flags to OverlayInterstitialAdDetector to denote whether the current candidate is an ad, as well as whether we have encountered ad and/or general interstitials. Bug: 1048136 Change-Id: I6dc809ceed51aa9b9747af44d8db6ed38721bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250957 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#781231}
-
Yoshifumi Inoue authored
This patch changes "insert-text-at-tabspan-001.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I369a82d7b8c6874d016864f0e6e84bbd3567ad6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259874Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781230}
-
Nohemi Fernandez authored
We take a strong reference in an asynchronous dispatch that delays the called method for kDisplayPromoDelay seconds. This can cause an issue if trying to shut down the scene and app at the same time. Bug: 971989 Change-Id: Ib5165034b9789dd39e6abf2e376bd4f06bcd0032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255610 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781229}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=kinuko Bug: 1031540 Change-Id: I970f0010731c6190f3fd73e3f4643e1369442ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254326 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#781228}
-
Keita Suzuki authored
https://chromium.googlesource.com/external/github.com/GoogleChromeLabs/pywebsocket3.git/+log/89c922843410..faf478a0453c $ git log 89c922843..faf478a04 --date=short --no-merges --format='%ad %ae %s' 2020-02-26 36944670+quasi-mod Add UnitTests for standalone server 2020-02-26 36944670+quasi-mod Update optparse to argparse 2020-02-18 36944670+quasi-mod Update license year in websocket_server.py (#5) Created with: roll-dep src/third_party/pywebsocket3/src Change-Id: Ifc42a609ed7a7c70eb9ec770faf3715e05375250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257653Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781227}
-
Yoshifumi Inoue authored
This patch changes "paste-text-at-tabspan-001.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I541d054ef7427b17eaa99f35162d6cd4c36697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259396 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
This CL introduces an Abseil component on which all Chromium Abseil clients will have to depend on. Abseil doesn't export symbols explicitly, so for the moment Chromium exports all of them when is_component_build=true. On Android, Linux and Mac -fvisibility=default is used while on Windows a .def file is generated at Abseil roll time. Bug: 1046390 Change-Id: I1697eb9e0179cee01badcf1b687acd94160e5f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174434 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781225}
-
Jérôme Lebel authored
UIApplicationWillEnterForeground doesn't exist with MultiWindow enabled. To keep the same behavior in Chrome, MainApplicationDelegate needs to listen to UISceneWillEnterForegroundNotification notifications. When the first window goes back to foreground, the method needs be called: -[AppState applicationWillEnterForeground:metricsMediator:memoryHelper: tabOpener:] Related to crbug.com/1097080: "AuthenticationService should not rely on foreground/background notifications" Fixed: 1092485, 1090748 Change-Id: Ic248fa9c88a10bb3340b1a4f32efa75b9b751491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252103 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781224}
-
Henrik Boström authored
If we receive a thermal signal we lazily instantiate the ThermalResource and inject it into the webrtc::PeerConnection. The ThermalResource is wired to respond to new thermal measurements. This will make the WebRTC video pipeline be able to react to overuse or underuse due to thermal signals. The ThermalResource is only used if the corresponding base::Feature is enabled, which is DISABLED by default. Both code paths are tested. Bug: chromium:1094844 Change-Id: I9f47c1f4f9bc98349b328d71f0eb71cc4c398444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247837 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781223}
-
Mikel Astiz authored
Commit ordering requirements across entities are relevant for bookmarks only, and no longer implemented within the sync engine. The tests deleted in this patch exercised the legacy Sync Directory, to be deleted soon. Equivalent tests, with modern requirements in mind, already exist in SyncedBookmarkTrackerTest. Change-Id: I4abf6c5231d545d0bd34d397b0855563821bea18 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257237 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
CursorLoader caches cursors, so it should only be used from a single place, the NativeCursorManager implementations. In this case, CursorLoader::SetPlatformCursor() isn't needed anyway, because the cursor is just used to obtain its bitmap and hotspot via GetCursorBitmap/Hotspot, and those don't need the platform cursor. Bug: 1097556 Change-Id: I32e2a867ec2b15374e545d1b268c7f427cd8fab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256220 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781221}
-
Yoshifumi Inoue authored
This patch chnages "5032066.html" to test all platform behaviors instead to detect failure on locally for all platforms for ease of debugging. Bug: 707656 Change-Id: I5f7e477a88b6fdaefe98ec34567f927a9f159dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259700 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
This reverts commit 17ef0754. Reason for revert: Suspected to cause a compatibility issue with Google Play Books Original change's description: > <ruby>: Introduce |text-align: -internal-space-around| > > This CL adds |-internal-space-around| keyword to |text-align| CSS > property. It is used for the default value of ruby annotation boxes > and ruby base boxes. > > We assumed |start|, the initial value of text-align, in ComputedStyle > had a special effect for ruby annotation and ruby base, and we made a > variant of kJustify internally. The code was complicated, and > introducing |-internal-space-around| simplifies the code. > > This CL has a small behavior change: > - If text-align:start is specified to <rt>, we ignored it before this > CL and applied the 'space-around' behavior. > After this CL, we apply text-align:start behavior in that case. > > * LayoutRubyRun.cc > ComputedStyle for LayoutRubyBase was sometimes overwritten by > LayoutObject::PropagateStyleToAnonymousChildren(), and the TextAlign > value was reset to kStart. Uses UpdateAnonymousChildStyle() to keep > the expected TextAlign value. > > * insert-paragraph-into-table-expected.txt > |style="text-align: -internal-space-around;"|, which is unable to > parse, appears. This will be fixed when we implement ruby-align CSS > property. > > Bug: 1069817 > Change-Id: Iecc1e999d11b58dd4d950f3579310546f5db7585 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217673 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773079} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Bug: 1069817 Change-Id: If71faebb37f89fb81b74ddb4a5c6683c34c40751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259393Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#781219}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592870283-bd79a360110f798833aeb2f02d9fe028111bb918.profdata to chrome-mac-master-1592891992-7e90ec0b60a74a0e681805c7cbe855e46353b429.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3a70dbe1018de9c972fb9935074331ebbd424e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259599Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58d0c5d57da6..87cae0e24e81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1097788 Tbr: hayato@google.com Change-Id: I863b86e6a8879f917896bf833aab6f4a8ba8866d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781217}
-
Ewann authored
This Cl updates TableViewInfoButtonItem and his cell. - Replaces |setIconImage| by |setIconImage:image withTintColor:color|. - Replaces trailing button icon. - Reduces cell vertical padding. Bug: 1095579 Change-Id: I7d7fc26698871e80e1a6b14883b93cdc92796e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252238Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
Wojciech Dzierżanowski authored
After adding VerifyAndClearExpectations() to OnTimeUpdate* tests it became clear that they didn't test the right code paths exactly due to missing pieces of HTMLMediaElement setup. Bug: 1075458 Change-Id: I4995b60fa6b4fada0476ce3a11b2e850ee3bb95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256240Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#781215}
-
