- 19 Feb, 2020 40 commits
-
-
Armando Miraglia authored
This reverts commit 0fce13aa. Reason for revert: It broke the chromium.webrtc bot (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Tests%20(dbg)%20(K%20Nexus5)/5712) Original change's description: > Update and enable CanSetupH264VideoCallOnSupportedDevice. > > - Ensure that call actually uses H264 by checking codec type in > video track stats. > > - Enable CanSetupH264VideoCallOnSupportedDevice test. > > Bug: webrtc:11244, 1047994 > Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Sergey Silkin <ssilkin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742572} TBR=hta@chromium.org,mcasas@chromium.org,guidou@chromium.org,ssilkin@chromium.org Change-Id: I4ea3badad7ed564801a458263eb6366991f2924c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11244, 1047994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063135Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#742621}
-
Hirokazu Honda authored
RtcVideoEncoderFactory: Create VideoEncoder if it's unknown whether the configured profile is supported crrev.com/c/2035481 delays filling VEA supported profiles in GpuVideoAcceleratorFactoriesImpl because it queries GPU process the supported profiles, instead of referring cached info of GpuInfo instance. Therefore, it can be unknown whether the configured profile on CreateVideoEncoder is supported. We create VideoEncoder in the case, relying that the software encoder fallback happens later if no hw encoder is capable of the profile. Bug: 2035481 Test: webrtc.RTCPeerConnection.* on soraka and kukui Change-Id: I04334073769914005b6ec1a82170457d340f4a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035486 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742620}
-
Hirokazu Honda authored
crrev.com/c/2035481 delays filling VEA supported profiles in GpuVideoAcceleratorFactoriesImpl because it queries GPU process the supported profiles, instead of referring cached info of GpuInfo instance. If getVEASupportedProfiles() is called in flight, the function reports as if the HW encoders support no profile. The issue due to this timing problem happens in fact on some CrOS devices. This CL mitigates the timing issue by setting the initialized VEA supported profiles to ones based on cached info of GpuInfo instance. Besides, this clarifies a caller of getVEASupportedProfiles() that the function returns nullopt if the factory hasn't got the results from GPU process. Bug: b:147404923 Test: webrtc.RTCPeerConnection.* on soraka and kukui Change-Id: Ie6867cb6f79934f66cf8550e2d41ec54671a5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035461 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#742619}
-
Monica Basta authored
Bug: 1053875 Change-Id: Ic3bcb4886d1d9033809853a784029de683863f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062417 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#742618}
-
Rune Lillesveen authored
Bug: 1053965 Change-Id: I610aecce124cbda287eb05030955415f66b84676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062977 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#742617}
-
David Van Cleve authored
This change adds an interface for performing the Trust Tokens protocol operations of issuance, redemption, and request signing. It is a common parent CL of three changes, each of which adds the implementation of a single protocol operation. The plan is for URLLoader to be provided a request helper on requests suitable for executing Trust Tokens operations (and no helper otherwise). Bug: 1042962 Change-Id: I8861ca08047da6b55bf90e67dca1b4f458598615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052468 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#742616}
-
Nico Weber authored
Bug: 804884,1053958 Change-Id: I7182072d3530ab3459373c6b45cca2cf753b6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063904 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#742615}
-
Peng Huang authored
The problem is because the swapbuffers ack callbacks could be called with any gl context. So we need call MakeCurrent before calling BeginWrite(). Bug: 1052745 Change-Id: I03f5e8b6f3ca1e53b9d407789f3f131a10f49356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062906Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742614}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f25db531203d..1b1227d53e69 Created with: gclient setdep -r src-internal@1b1227d53e69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifd10bfbe5b1d69006c75d070eca2b198477d75e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742613}
-
Michael Lippautz authored
MSVC is unsupported, see https://groups.google.com/a/chromium.org/g/chromium-dev/c/fuVUxe1q6EA/m/is1EpDqwBQAJ Bug: 1053958 Change-Id: Ibd8872d1b3be7509c2eec17f4e7d83cbb7398406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063131Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0aa86a7ae831..21e5074dcdb8 git log 0aa86a7ae831..21e5074dcdb8 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Revert "Create VulkanImageWrappingTests for dma-buf images" 2020-02-18 hob@chromium.org Create VulkanImageWrappingTests for dma-buf images Created with: gclient setdep -r src/third_party/dawn@21e5074dcdb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996470 Tbr: cwallez@google.com Change-Id: Ib8de94143b3924e0741434f14f482324be60c421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063821Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742611}
-
Fredrik Söderquist authored
This means that patterns that are in error are cached rather than being attempted to be rebuilt. This is consistent with how gradients are handled. Bug: 109212 Change-Id: I72d418c78cc3314021d21977a53e93b3f7686757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062971 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#742610}
-
Francois Doray authored
This reverts commit 47b6798d ("https://chromium-review.googlesource.com/c/chromium/src/+/1976500). This commit is suspected to have affected the 95th percentile of SessionRestore.ForegroundTabFirstPaint4 on Mac. Reverting it temporarily to verify that hypothesis. TBR=sky@chromium.org Bug: 1035419, 1020549, 1022492 Change-Id: Ide1787a64b28c9f731ee1cb4f8bf0c451bb072e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062692Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#742609}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22500101fbd..e68978417ac4 git log e22500101fbd..e68978417ac4 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-19 janscheffler@chromium.org Inform developers about the ServerTiming API 2020-02-19 jacktfranklin@chromium.org Revert "Fix TS + Ninja integration" 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-02-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-18 tross@microsoft.com Fix focusing stop button after timeline profiler initialization 2020-02-18 jalyn@microsoft.com Fix watch expression deletion bug 2020-02-18 eirage@chromium.org Add save&load to input panel 2020-02-18 jonathan.garbee@chromium.org DevTools: scroll console scopes if more exist than can be seen 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {resources,sdk,search,security}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from {source_frame,sources,text_editor,text_utils}-legacy.js 2020-02-18 tvanderlippe@chromium.org Fix screenshot image_diff for Linux 2020-02-18 tvanderlippe@chromium.org Remove typedefs from timeline{_model}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from web_audio-legacy.js 2020-02-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-18 tvanderlippe@chromium.org Revert "Extract `toBase64` into `StringUtilities`" 2020-02-18 wolfi@chromium.org Revert "Reland "Use 1000 not 1024 for kB and MB calculations"" 2020-02-18 jacktfranklin@chromium.org Fix TS build checking for bridge files 2020-02-18 jacktfranklin@chromium.org Extract `toBase64` into `StringUtilities` 2020-02-18 tvanderlippe@chromium.org Fix TS + Ninja integration 2020-02-18 wolfi@chromium.org Fix layout issue in add-location-table 2020-02-18 kimanh@chromium.org [devtools] Make wasm source url clickable 2020-02-18 wolfi@chromium.org Reland "Use 1000 not 1024 for kB and MB calculations" Created with: gclient setdep -r src/third_party/devtools-frontend/src@e68978417ac4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811,chromium:1035309,chromium:1038461,chromium:1050423,chromium:1050549,chromium:1051458,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib131cc87d0ca0aed94c09de6e339e5471444e09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063820Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742608}
-
Sergey Poromov authored
This reverts commit ef364481. Reason for revert: [sheriff]: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > Allow mixed-security content in promoted PWA windows > > Prior to this CL, mixed-security content was blocked entirely in > standalone PWA windows with scopes. This CL allows those PWAs to display > mixed-security content, but when this happens, the window will show the > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > the presence of mixed content. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > This removes a behavioural difference between promoted PWAs and "create > shortcut" apps without manifest scopes. > > > Bug: 910016 > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742515} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: I677c642411685d840b793fc2f0d507188e0dbae7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063173 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8962e435..ac15544d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5064e3d44b50e6ad1eb2f877e78c55160e0894b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742606}
-
Anton Bikineev authored
This adds counterparts of gc metrics for minor GCs. Bug: 1029379 Change-Id: I32726cb374af73d80094639248d3b467d77aedb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061251 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742605}
-
Sergey Poromov authored
This reverts commit d81e22c1. Reason for revert: [sheriff]: Depends on a CL https://crrev.com/c/2041380 that: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > desktop-pwas: Do not prefer apps with scopes over those that don't > > This CL updates AppRegistrar::FindAppWithUrlInScope() to ignore the > IsShortcutApp() status of a web app and just use the default scope the > same as a specified scope. > > This makes web apps with default scopes will be treated the same > as web apps with scopes specified in their manifest reducing the > behavioural differences between promoted installs and "create shortcut" > installs. > > Bug: 910016 > Change-Id: Ifa2c94132fa806a013a6d210dff0d7505df4c3f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051464 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742533} TBR=alancutter@chromium.org,glenrob@chromium.org Change-Id: Ia8a3cc96521c77ce26a0b4268862d6751d4c94b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063017Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742604}
-
Antonio Gomes authored
This CL allows us to remove content/common/frame_message_structs.cc|h as well as to clean up references to FrameMsg_ViewChanged_Params in content/common/content_param_traits.cc|h. BUG=1051135 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org Change-Id: I175b6412452b09ffc15083be305dee31a69584f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062091 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#742603}
-
Viktor Semeniuk authored
This change allows to copy password into clipboard by clicking corresponding button in menu item. Button was implemented in previous CL. Bug: 917337 Change-Id: I28ceb294b2f4e7cb0f783154b4307c4888a477ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054094 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742602}
-
Robbie Gibson authored
This separate protocol is in preparation for moving the text zoom coordinator usage code from BVC to BrowserCoordinator. Once there's a separate protocol, the BrowserCoordinator can implement it instead of the BVC. Bug: 1052818 Change-Id: I5215864219a8419e4bb170bff3a89b31f3a80c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062997 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#742601}
-
Torne (Richard Coles) authored
It's possible for there to be a pending Java exception for the current thread when the Android version of MessagePumpForUI is called, because the ALooper we use to schedule our message pump iterations can also have other callbacks running on it and ALooper doesn't check for exceptions between callbacks. One example of this is render thread exceptions on P and earlier, which are thrown by sending a message to the UI thread in native - if we get unlucky and our MessagePumpForUI runs afterward in the same ALooper polling cycle, we will crash the first time we make a JNI call, resulting in a confusing stack trace. Avoid this by just skipping our callback execution if there is a pending exception set at the start of the callback. If the exception ends up not being fatal (caught by something higher up the stack) then our callback will be run again in the next iteration, as the fd has not been reset. Bug: 1052830 Change-Id: Ie13ceab6c2c1b988189791546fa12a5529ef17b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062434Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#742600}
-
Wez authored
This reverts commit eddd5af6. Reason for revert: Appears to have caused ARM64 and Debug bots to fail on waterfall, due to MISSING files. Original change's description: > [fuchsia] Migrate to use Fuchsia SDK Vulkan package rules. > > Bug: 1050703, fuchsia:46115 > Change-Id: I3e8c795e616bc803513efd33cff64ca95a625875 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058968 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742595} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: If4eedd955b95391da6fc45454876a93411ecb986 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050703, fuchsia:46115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063018Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742599}
-
Nazerke authored
This CL modernizes the HistoryCoordinator - to use |browser| in the initializer - to remove the public property for browserstate and dispatcher. - to use self.browser to get browserstate and dispatcher values. Bug: 1029346, 1048408 Change-Id: I303cc9ce692c15f582f8648a8049ea2251148746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063128Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#742598}
-
Christian Dullweber authored
Show a section header for permissions if both, permissions and cookie controls are shown. Rearrange the controls in CookieControlsView. Screenshot: https://crbug.com/1040091#c11 Bug: 1040091 Change-Id: I54156e0ac8ae819c6578cbf50bda3066dd8467db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056945 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742597}
-
Tanmoy Mollik authored
SyncTestRule doesn't provide a way to override the instance of ProfileSyncService it holds. For this reason some tests might override the ProfileSyncService with a subclass but SyncTestRule will hold a copy of the old ProfileSyncService instance. This cl adds a method in SyncTestRule to override ProfileSyncService and refactors some tests that need to use it. Bug: 1030725 Change-Id: I9fc1b770df4c153e726a4e071e432fc585561889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012380 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742596}
-
Wez authored
Bug: 1050703, fuchsia:46115 Change-Id: I3e8c795e616bc803513efd33cff64ca95a625875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058968 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742595}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes. This CL was uploaded by git cl split. Bug: 968047 Change-Id: I7647e425e2d58b5b23df3cc7bb391665f1c87902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063010 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742594}
-
Felipe Andrade authored
Seventh batch of KerberosCredentialsManager unit tests. This time, adding tests for the UpdateAccountsFromPrefConfig method. Bug: 952251 Change-Id: Ie651af8ea53b32458a0bc25e8d000b5e4b3b6363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054108Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#742593}
-
Antonio Gomes authored
Messages will live in LocalMainFrame mojom interface. BUG=1051165 Change-Id: Ib68be561dc38cf8a8cabd894a56cc6d036728041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063069 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742592}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/4e083db26373..4f95c4097fa1 $ git log 4e083db26..4f95c4097 --date=short --no-merges --format='%ad %ae %s' 2020-02-18 dschinazi Deprecate quic_fix_handling_of_bad_prox_packet 2020-02-18 dschinazi Parameterize QuicDispatcherTest by version 2020-02-18 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_log_coalesce_stream_frame_frequency 2020-02-18 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_rr_write_scheduler. 2020-02-18 quiche-dev Surface receive_timestamp to QuicStream::OnStreamFrameAcked. 2020-02-18 fayang Remove unreachable statement and unused variable from general_loss_algorithm. 2020-02-18 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_use_http2_priority_write_scheduler. 2020-02-14 nharper Change number of connection attempts in QuicClientBase::Connect 2020-02-14 nharper Internal QUICHE change 2020-02-14 wub gfe-relnote: (n/a) Deprecate --quic_sanitize_ack_delay. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia3919e9cc5f387f2ad94a4d8f313a7cfeb7aa5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063259 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742591}
-
Wez authored
renderer_fuzzer often takes longer than the default action_timeout() set by TaskEnvironment as the Run() timeout. Bug: 1053401, 1053479, 1053634 Change-Id: Ia4f58bf3a480c89875fe4ddce2f80e4d81818ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062350 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742590}
-
Julian Pastarmov authored
Replace .cache with .config. BUG=none Change-Id: Ie801e3980adebcfd0514e60b42a82b06a30a1cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051125Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742589}
-
Kent Tamura authored
This CL has no user-visible behavior changes. Change-Id: I80da7333d3a8a91fd37b460a2f2582b6182ae9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062845Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742588}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ed0da37dd994..c008fcb8cc0f git log ed0da37dd994..c008fcb8cc0f --date=short --first-parent --format='%ad %ae %s' 2020-02-19 johnkslang@users.noreply.github.com Merge pull request #2089 from Roy-AMD/Fix-iomapper-issue Created with: gclient setdep -r src/third_party/glslang/src@c008fcb8cc0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If52e7f18a788b33ce0f56f67197d02ee16ffcf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742587}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53bc9c82f33f..f25db531203d Created with: gclient setdep -r src-internal@f25db531203d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0da559844d9fe6d979259e3b75a1d3cdc46e7721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064057Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742586}
-
Kent Tamura authored
This makes text-overflow:ellipsis workable. * MenuListInnerElement switches to margin-left/right from padding-left/ right. Overflowed text is painted on padding area. * LayoutMenuList::ComputeIntrinsicLogicalWidths refers to LayoutTheme. InnerBlock's margin values are zero in this function. Bug: 436654, 1040828 Change-Id: I5167cf5ae5ad2e823f8e688ad39db7ea833b9079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061769 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742585}
-
Sergey Poromov authored
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Sample run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3317 Logs: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8888037310866866032/+/steps/browser_tests/0/logs/Deterministic_failure:_KioskAppManagerTest.UpdateAndRemoveApp__status_FAILURE_/0 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=KioskAppManagerTest.UpdateAndRemoveApp TBR=apotapchuk@chromium.org Bug: 1044417 Change-Id: I8d028974d8451f0f37a5445c5cda193d43559976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062343 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742584}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I41ac276f5c04705893a9c42d97bc3a4bfb9b9151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056508Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742583}
-
Wez authored
We now have a memory pressure signals implemented for Fuchsia, and even when those are unavailable the lower 64MB discardable memory limit can be set via --enable-low-end-device-mode=true. Bug: 996030, 1020698 Change-Id: I24a76324f4fd8a6ec6c907a5437983c34d9f9908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056477 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742582}
-