- 02 May, 2018 40 commits
-
-
Alexander Timin authored
This patch only plumbs ObserverType to CalculatedThrottlingState, but does not modify logic yet. This patch is extracted from http://crrev.com/c/956224 by ryansturm@ to unblock dedicated worker throttling and load throttling work. R=ryansturm@chromium.org,alexclarke@chromium.org TBR=toyoshim@chromium.org Change-Id: I4b554a48a7f5a247eac7687de93b68ac37dea07e Reviewed-on: https://chromium-review.googlesource.com/1039805Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555516}
-
Mark Pilgrim authored
(split off from https://chromium-review.googlesource.com/c/chromium/src/+/1035543 ) This adds GetSharedURLLoaderFactory(), which returns a SharedURLLoaderFactory owned by the SystemNetworkContextManager and backed by the SystemNetworkContext. Bug: 773295 Change-Id: I5301e9785d913dd27cdc36e7ef4f759290e1ecf5 Reviewed-on: https://chromium-review.googlesource.com/1037943 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555515}
-
Peter Kasting authored
* Removed initial TabStrip* arg, no one was using it. * Changed names from e.g. TabStripAddedTabAt() to OnTabAdded() to shorten and make consistent with other observer OnXXX() names. * Changed TabStripMaxXChanged() to OnTabsMaxXChanged() in keeping with the meaning change in https://chromium-review.googlesource.com/c/chromium/src/+/1038789 . * Changed override order in GlassBrowserFrameView to match base class. BUG=none TEST=none Change-Id: Ibf29362d818d8f63e34c168d428173bca6e2a257 Reviewed-on: https://chromium-review.googlesource.com/1038796 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555514}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d4cebe797eb..9dea5038cdf1 $ git log 5d4cebe79..9dea5038c --date=short --no-merges --format='%ad %ae %s' 2018-05-01 bmgordon Reland "cbuildbot: Use previous build state for chroot reuse" Created with: roll-dep src/third_party/chromite BUG=chromium:829665 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib2d03b9830dbc167cc5111d0f16a0d6eec7fab1b Reviewed-on: https://chromium-review.googlesource.com/1040113Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555513}
-
Rayan Kanso authored
Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/ TBR=avi@chromium.org Bug: 826257 Change-Id: Ib34d8640545beae4b6b0dfa38d634937215ae4ff Reviewed-on: https://chromium-review.googlesource.com/1026730 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555512}
-
Christopher Grant authored
Having a dedicated mode for prompts should make visibility of other elements simpler when prompts are active. To make this work: - Simplify voice search, content and omnibox's visibility gating logic - Fix voice search metrics reporting - Add vollick@'s sequence object to introduce an alternative to transient elements - Removed illegal visibility bindings (ancestor bound to descendant) and related hacky workarounds. BUG=829880 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ic0f6c7546797b956eda02e50fd9384149a3612c6 Reviewed-on: https://chromium-review.googlesource.com/1031209 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555511}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. Also remove the exception in BrowserTestBase::InitializeNetworkProcess which isn't needed anymore. Bug: 776589 Change-Id: I87d5efedba8f967dc6b5c890cede22d53e60c90c Reviewed-on: https://chromium-review.googlesource.com/1037626Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555510}
-
Ahmed Fakhry authored
BUG=838561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7c4874880c80706327d97cbf86cef54c940abd6b Reviewed-on: https://chromium-review.googlesource.com/1040348Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555509}
-
Steve Kobes authored
This configuration is no longer tested. Bug: 823365 Change-Id: Ied6ece777017245dad4ec93ef25f691f9110e62b Reviewed-on: https://chromium-review.googlesource.com/1040536Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555508}
-
Eric Stevenson authored
In diagnose_bloat.py and generate_gradle.py the defaults for max jobs (-j) are too high for machines without a large amount of RAM. This should help non-Googlers. Bug: 799954 Change-Id: I0f1480cb3bf93c17e9a182da821876b0d6f5f12c Reviewed-on: https://chromium-review.googlesource.com/1038440Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555507}
-
Scott Chen authored
The test broke when some <settings-toggle-button>s in settings Privacy page was moved to a new element. The original CL (1022716) did not break trybots because the problematic tests only run for branded builds. Bug: 838543 Change-Id: Iadc8076f870bdca9831e52e7fa5929052f95c038 Reviewed-on: https://chromium-review.googlesource.com/1037925 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555506}
-
Sorin Jianu authored
The returned vector must contain a nullptr for an extension id that does not exist. Bug: 837371 Change-Id: I1e81a64c64c6a1d2b0cb9a76a278836c7412eb07 Reviewed-on: https://chromium-review.googlesource.com/1037906 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555505}
-
Ned Nguyen authored
This reverts commit d8a31d45. Reason for revert: suspect breaking blink_heap_unittests BUG:chromium:839114 Original change's description: > [oilpan] Enable incremental marking buildflag > > Includes incremental garbage collection infrastructure in regular > builds. Does not enable incremental marking at runtime! > > This CL may cause throughput regressions and is an attempt > to collect a broad range of potential performance issues. > > Bug: chromium:757440 > Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed > Reviewed-on: https://chromium-review.googlesource.com/980753 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555449} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I1d1cd812dcf24a9a87ad6100658e4c18979f29bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:757440 Reviewed-on: https://chromium-review.googlesource.com/1040688Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#555504}
-
Dmitry Gozman authored
This reverts commit 5419f892. Reason for revert: fails again. See https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Win_Builder__dbg_%2F130922%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout. Original change's description: > Reland "Move manifest.mojom and content::Manifest to blink" > > This is a reland of c07726e1 > > Original change's description: > > Move manifest.mojom and content::Manifest to blink > > > > ... as a part of Onion Soup project. > > > > This also required moving WebDisplayMode from public/platform > > to public/common since it's referenced both in manifest itself > > and, more generally, browser code. > > > > mojom::blink::Manifest is typemapped to blink::Manifest, which uses > > stl types and should be used by blink's embedder, not blink > > implementation. > > > > Bug: 704441 > > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae > > Reviewed-on: https://chromium-review.googlesource.com/1006188 > > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554953} > > TBR=dgozman > > Bug: 704441 > No-Presubmit: true > Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f > Reviewed-on: https://chromium-review.googlesource.com/1036507 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555485} TBR=dgozman@chromium.org,sky@chromium.org,dcheng@chromium.org,jbroman@chromium.org,mathp@chromium.org,dtrainor@chromium.org,reillyg@chromium.org,haraken@chromium.org,mlamouri@chromium.org,mastiz@chromium.org Change-Id: I2b3d28d1eafb06d480701e6bc69033ea3bcca33a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704441 Reviewed-on: https://chromium-review.googlesource.com/1040685Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555503}
-
Zhenyao Mo authored
This is for updating Win Intel GPU bot for a newer driver BUG=838970 TRY=optional GPU bots TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iea98808dabcf24ce2f4e14b421c11a7f203d194e Reviewed-on: https://chromium-review.googlesource.com/1040246 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#555502}
-
Alexis Hetu authored
Some tests apparently try to allocate a GLImageIOSurface before a context is created. Checking for EGL is now done without using the current context, by checking the current GL implementation. Bug: chromium:726075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I06fb589b43d71ae977db9efd0d5d10ac54f954af Reviewed-on: https://chromium-review.googlesource.com/1035086Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555501}
-
Dave Tapuska authored
Appears this feature shipped roughly 2 years ago in M51. Remove old supporting code that isn't needed anymore. BUG=610900 Change-Id: I121dd3da84ab2ca963bb87a47343972a9ba794c4 Reviewed-on: https://chromium-review.googlesource.com/1037843Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#555500}
-
Fredrik Söderquist authored
Avoid the implicit conversion to int in the constructor for WebPoint. Also don't pass through WebPoint at all since AppendDropShadowFilter take an IntPoint. Bug: 836480 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2c05681c686cf9f7169c79cf5f67849f483f36f8 Reviewed-on: https://chromium-review.googlesource.com/1039829Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#555499}
-
Nate Fischer authored
No change to logic, this only adds a systrace event to log startup performance in the support library. This doesn't appear to be an issue in local benchmarks, but the bot may perform differently. Bug: 838702 Test: N/A Change-Id: Idde301b3e620e7ca13e779ac35f08338c58910df Reviewed-on: https://chromium-review.googlesource.com/1039154Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555498}
-
Sky Malice authored
This also creates a new folder at chrome/browser/android/feed that may contain C++ files and is compiled out per build flag. Bug: 831644 Change-Id: I80973b8e3857fc6258153acc3172aebe8d857087 Reviewed-on: https://chromium-review.googlesource.com/1025218Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#555497}
-
Ian Vollick authored
This reverts commit 4995409b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Update build rules to support ARCore > > Define enable_arcore and add some build rules to use it. > > Bug: 833511 > Change-Id: I716123c2a282d7d123883df81ebbc00a0a883be8 > Reviewed-on: https://chromium-review.googlesource.com/1033580 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555174} TBR=ddorwin@chromium.org,vollick@chromium.org,yfriedman@chromium.org,mthiesse@chromium.org,estevenson@chromium.org,jbudorick@chromium.org Change-Id: Ib28c3cb527bc43a31561ed118f586236d4234bef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833511 Reviewed-on: https://chromium-review.googlesource.com/1040605Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555496}
-
David Bertoni authored
Bug: 827288 Change-Id: Id6050bc02fbb68b29e9b2a6c7abb652186aaba13 Reviewed-on: https://chromium-review.googlesource.com/1038151Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#555495}
-
Elad Alon authored
This CL will just highlight the problem. Passing the CL to Sarah Chan, who will fix. Bug: 838873 Change-Id: If0878c717a572fb7d9522fa85e3a6c1d4f002151 Reviewed-on: https://chromium-review.googlesource.com/1039368 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#555494}
-
Joe Downing authored
This CL adds a minimal KeyboardHook impl for ozone which enables browser-level keyboard lock functionality. System-level keyboard lock will require some additional investigation / integration work and will be implemented in a future CL. BUG=680809 Change-Id: Ib3ff830f04750667afa4b34602bd11d277fe7880 Reviewed-on: https://chromium-review.googlesource.com/1028725 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#555493}
-
Maks Orlovich authored
Before this change, if we had a cookie we could not load (decryption failed, non-canonical), the row would be simply ignored on reading --- and then when a new cookie with the same key was written, write would fail due to violating uniqueness constraints. The eviction of those rows would also be spotty, since most mechanisms relied on cookies being reported to cookie monster, though "delete domain on exit" policy would still work. This attempts to recover by dumping the entire eTLD + 1 group, which is good for data consistency but may be overly disruptive. Bug: 838901 Change-Id: I72f9497a094463db8fdfa2b4d8662b18911428b3 Reviewed-on: https://chromium-review.googlesource.com/980673Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#555492}
-
Sidney San Martín authored
I didn't catch that it was needed on 10.11 up front because the presence of the window that shows construction stripes in Chromium builds made the problem vanish. Weird stuff. Bug: 838353 Change-Id: I7cf9e352ff51dccfdbc561da58905175dab68742 Reviewed-on: https://chromium-review.googlesource.com/1038624Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555491}
-
kylechar authored
Rename OffscreenCanvas* files in content to better match what they are, a generic embedded frame sink for the renderer. The implementation was originally written for offscreen canvas but now has multiple uses. This CL is just a rename of classes, files and member variables. The main renames are as follows: OffscreenCanvasSurfaceImpl -> EmbeddedFrameSinkImpl OffscreenCanvasProviderImpl -> EmbeddedFrameSinkProviderImpl OffscreenCanvasProviderImplTest -> EmbeddedFrameSinkProviderImplTest mojom::OffscreenCanvasProvider -> mojom::EmbeddedFrameSinkProvider mojom::OffscreenCanvasSurfaceClient -> mojom::EmbeddedFrameSinkClient Member variables and files are renamed to match as well. Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6889c94aacc91a7787606b062822e8ad9461338b Reviewed-on: https://chromium-review.googlesource.com/1020184 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#555490}
-
Matt Mueller authored
Bug: 410574 Change-Id: If9d4642061ab8fb40903d7f3901b7313caf8244b Reviewed-on: https://chromium-review.googlesource.com/1036621 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555489}
-
Alexander Alekseev authored
Not yet suported service "usm" needs to be behind flag CrOSEnableUSMUserService. Bug: 837107 Change-Id: If3bfc4d58d1894074fb7b50c94b8fe91ee459e5a Reviewed-on: https://chromium-review.googlesource.com/1038813Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#555488}
-
Avi Drissman authored
BUG=838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8df9263f159af6a1152b46882a80bec0c52a822d Reviewed-on: https://chromium-review.googlesource.com/1036566Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555487}
-
Charlie Harrison authored
This is a pre-req to a refactoring effort splitting off logic from main.cc and adding new tests. This CL also changes rule_stream_test.cc -> rule_stream_unittest.cc Bug: 833419 Change-Id: I9c73a336c2bae2fdbdbe7db68346c8c9a64be325 Reviewed-on: https://chromium-review.googlesource.com/1040045 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555486}
-
Dmitry Gozman authored
This is a reland of c07726e1 Original change's description: > Move manifest.mojom and content::Manifest to blink > > ... as a part of Onion Soup project. > > This also required moving WebDisplayMode from public/platform > to public/common since it's referenced both in manifest itself > and, more generally, browser code. > > mojom::blink::Manifest is typemapped to blink::Manifest, which uses > stl types and should be used by blink's embedder, not blink > implementation. > > Bug: 704441 > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae > Reviewed-on: https://chromium-review.googlesource.com/1006188 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554953} TBR=dgozman Bug: 704441 No-Presubmit: true Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f Reviewed-on: https://chromium-review.googlesource.com/1036507 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555485}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2050565fe116..f9ab22385ead $ git log 2050565fe..f9ab22385 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 robertphillips Modify SkGpuBlurUtils::GaussianBlur's reexpand method and allow more approx fit intermediates 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms 33bdf05..513d372 (1 commits) 2018-05-01 herb Reland "Remove devKerning" 2018-05-01 herb Take sk_sp<SkDevice> instead of SkDevice* 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms a1c0fe6..33bdf05 (1 commits) 2018-05-02 kjlubick Add public repro instructions for repoducing fuzzers 2018-05-02 mtklein Revert "fonts: Set up remote glyph caching to push fonts." 2018-05-02 mtklein Revert "Remove devKerning" 2018-05-02 mtklein Revert "fonts: Dont memcpy with nullptr in SkRemoteGlyphCache" 2018-05-02 mtklein Revert "fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache." 2018-05-02 mtklein Revert "Add padding back to make msan happy" Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ic58c56833d60fbd583fbf671a31cfb3fb94eb975 Reviewed-on: https://chromium-review.googlesource.com/1039772Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555484}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1eb58e1f8892..1037c743e338 $ git log 1eb58e1f8..1037c743e --date=short --no-merges --format='%ad %ae %s' 2018-05-01 ehmaldonado presubmit: Don't overwrite cwd when running tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829084 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iba54fff4eeb01ec9698dab0338cb391054c1874a Reviewed-on: https://chromium-review.googlesource.com/1040106Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555483}
-
Dave Schuyler authored
This CL passes the correct available width to ComputeMatchMaxWidths so that the text get an ellipsis if needed. Also, the description view will not be shown if there is no space for it. Bug: 836740, 838592 Change-Id: I096fddd1191dfb61f1cd008e4b81a79bd718d1f2 Reviewed-on: https://chromium-review.googlesource.com/1038618Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555482}
-
Olivier Robin authored
RationalizeCreditCardFieldPredictions run twice - Once after getting the heuristics type - Once after getting the server types. The second time, the local type used to rationalize is the result of the first run. This means that if the type is remove on the first run, the server data wont restore it. Change implementation to always use the heuristics result during this rationalization. Also introduce overall_type. overall_type will give the result of local computation, after heuristics and rationalization. heuristics_type will keep the result of the heuristics type inference. Change-Id: I90dd108f92f3cbcf06cbe1ed41c033bf51ccbd3e Reviewed-on: https://chromium-review.googlesource.com/1016913 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#555481}
-
Peter Kasting authored
This method was used in the following places: (1) TabScrubber, where the code did nothing. (2) BrowserNonClientFrameViewMus, to handle the tabstrip being deleted before the frame. (3) GlassBrowserFrameView, to NOTREACHED() because the tabstrip should never be deleted before the frame. (4) A test that the call was fired. Because of (3), I assume (2) is actually dead code. Since that's the only functional use, it seems like this whole method can disappear. BUG=none TEST=none Change-Id: I5945ccd019741eff09df286bf5ae1bfa82337761 Reviewed-on: https://chromium-review.googlesource.com/1039004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555480}
-
Peter Kasting authored
There were basically two callers of this function: * GlassBrowserFrameView, which only cares about the new tab button position anyway, and thus can ask for it directly. * BrowserNonClientFrameViewMus, which wants to know where the tabstrip's "client area" is. Fix this by explicitly handling the "tab" and "new tab button" areas separately, so it won't matter if there's a "non-client" gap between them. In theory, this frame should never be used with TRAILING mode, but with this change the TabStrip API can't be misused. BUG=822063 TEST=none Change-Id: Iaad98ce2485b2897ecffb6c5ec0a6bea5c218f7d Reviewed-on: https://chromium-review.googlesource.com/1038789Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#555479}
-
Brian White authored
Bug: 836875 Change-Id: I633a00c07f52093c12a49723fd213dfc03192eba Reviewed-on: https://chromium-review.googlesource.com/1039346 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#555478}
-
https://webrtc.googlesource.com/src.git/+log/878a3df8a25d..2a35c43779f6 $ git log 878a3df8a..2a35c4377 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:836790,chromium:none,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d9ffa08d725ed51ad90bd7df30e4c98c9296796 Reviewed-on: https://chromium-review.googlesource.com/1039779Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555477}
-