GitLab

Note: not adding a seperate Oilpan entry, just mark it flaky while
Oilpan is enabled on ToT.

TBR=eae@chromium.org,harken@chromium.org
BUG=581990
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1643903002

Cr-Commit-Position: refs/heads/master@{#372043}

As per the CPP style guide, variables declared constexpr or const, and whose
value is fixed for the duration of the program, are named with a leading "k"
followed by mixed case. Since objects don't have a constant value for the
duration of the program, refactor "kTestString" to "test_string".

Review URL: https://codereview.chromium.org/1649573002

Cr-Commit-Position: refs/heads/master@{#372042}

BUG=580928

Review URL: https://codereview.chromium.org/1626213002

Cr-Commit-Position: refs/heads/master@{#372041}

This patch is two fold:
1. Adds the capability of adding deprecation messages for CSSPropertyIDs
as they are parsed.
2. Adds the relevant deprecation message for
-webkit-background-composite. The reasons for which are highlighted here
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/thxrbc8XOmc

BUG=498588

Review URL: https://codereview.chromium.org/1585383003

Cr-Commit-Position: refs/heads/master@{#372040}

Notification type SIMPLE is for the web notification actually and it triggers some hacks which causes the problem (see the issue).

This patch changes the type to BASE_FORMAT without hacks.

BUG=b/26831435

Review URL: https://codereview.chromium.org/1640333003

Cr-Commit-Position: refs/heads/master@{#372039}

TBR=rockot@chromium.org
BUG=581987
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1646813002

Cr-Commit-Position: refs/heads/master@{#372038}

I2S: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_nu6HlbNQfo/XzaLNb1bBgAJ

BUG=471199

Review URL: https://codereview.chromium.org/1636303003

Cr-Commit-Position: refs/heads/master@{#372037}

Currently dialog boxes do not take main status from the parent window.
Change this so that any child window does not become a main window.

Also, use the same trick that Cocoa bubbles use to avoid the traffic
lights dimming, but only do this for child windows that don't have their
own traffic lights.

BUG=543689

Review URL: https://codereview.chromium.org/1614663002

Cr-Commit-Position: refs/heads/master@{#372036}

We store a flag for finding ::before or ::after in
InvalidationSetFeatures, yet they are not added as features to
invalidation sets. That means we need to handle *::before as a universal
selector and cause subtree invalidations.

R=ericwilligers@chromium.org
BUG=581675

Review URL: https://codereview.chromium.org/1639133003

Cr-Commit-Position: refs/heads/master@{#372035}

Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2 id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started failing

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
>
> BUG=580337
>
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Review URL: https://codereview.chromium.org/1646803002

Cr-Commit-Position: refs/heads/master@{#372034}

cwallez@ pointed out the file was unmaintainable. Generate it from a
script instead. Effort was expended to minimize the initial changes. The
only changes are:

1. webgl_conformance_tests and webgl2_conformance_tests are swapped.
2. The D3D9 and GL versions of gles2_conform_test on the Windows testers
   come first.
3. content_unittests was missed on several testers, and is now present.

This script will be generalized later to create the forthcoming
chromium.gpu.json.

BUG=542370
TBR=dpranke@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1647833004

Cr-Commit-Position: refs/heads/master@{#372033}

Currently, Mac10.7 & Linux & Linux Oilpan [ Debug ] to be precise.

Note not adding a seperate Oilpan entry, but be aware this test is
failing on Linux Oilpan Debug after the related change [1].

[1] https://codereview.chromium.org/1623073003

TBR=haraken@chromium.org,fmalita@chromium.org
BUG=581978
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1640153003

Cr-Commit-Position: refs/heads/master@{#372032}

This matches behavior of ImageView::SetImage.

BUG=581965

Review URL: https://codereview.chromium.org/1641993002

Cr-Commit-Position: refs/heads/master@{#372031}

Before this patch, the serviceworker-internals shows a render process host ID in
"Renderer process ID" entry. This is not really helpful for blink/chromium
developers to debug errors related to renderer process activity.

After this patch, the internal page shows a real render process ID in the entry.

BUG=544760

Review URL: https://codereview.chromium.org/1645453002

Cr-Commit-Position: refs/heads/master@{#372030}

Oilpan is enabled on ToT, and is reading from TestExpectations and
has no Expectations file of its own (for now).

Mark the test as a flake and place it in TestExpectations "Oilpan"
area of that file.

TBR=haraken@chromium.org,ksakamoto@chromium.org
BUG=299010
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649653002

Cr-Commit-Position: refs/heads/master@{#372029}

BUG=514857,581604
TBR=bpastene@chromium.org

Review URL: https://codereview.chromium.org/1640233003

Cr-Commit-Position: refs/heads/master@{#372028}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0085d5c64509..a7e38c146fe9

$ git log 0085d5c64..a7e38c146 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1649463003

Cr-Commit-Position: refs/heads/master@{#372027}

Drive-by: put app banner support behind experiment.

BUG=540864

Review URL: https://codereview.chromium.org/1641513003

Cr-Commit-Position: refs/heads/master@{#372026}

https://chromium.googlesource.com/skia.git/+log/62358e77c2b8..4c5f1f611469

$ git log 62358e77c..4c5f1f611 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 fmalita Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1643713003

Cr-Commit-Position: refs/heads/master@{#372025}

Link header preloads were not working when sent over subresources.
This CL fixes that.

BUG=568025

Review URL: https://codereview.chromium.org/1627203002

Cr-Commit-Position: refs/heads/master@{#372024}

Culled inline hittesting was recently fixed [1] which exposed a
bug in LayoutInline::hitTestCulledInline where hit testing checked
for region intersection but returned a value based on region
containment. This bug was partially fixed in [2] for list-based
tests but a bug still existed for point-based tests.

This patch updates LayoutInline::hitTestCulledInline to check for
hit tests using region intersection, and return a value based on
region intersection (not containment). This was done by fixing a FIXME
to implement HitTestRequest::addNodeToListBasedTestResult for regions.

In addition, this patch changes the return value of
HitTestRequest::addNodeToListBasedTestResult to be an enum which
better explains its behavior.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=193729
[2] https://crrev.com/b489f7917175e2449c8f6d5874ab3ba0b7f31e88

BUG=579412

Review URL: https://codereview.chromium.org/1630793002

Cr-Commit-Position: refs/heads/master@{#372023}

fast/text/justify-ideograph-vertical.html
fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-complex.html

BUG=581974
TBR=kojii@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649643002

Cr-Commit-Position: refs/heads/master@{#372022}

This CL adds Dr. Fuzz config in mb_config.pyl to support building
tests for Dr. Memory and Dr. Fuzz on Windows.

R=dpranke@chromium.org
BUG=572694

Review URL: https://codereview.chromium.org/1633413002

Cr-Commit-Position: refs/heads/master@{#372021}

BUG=580337

Review URL: https://codereview.chromium.org/1641933002

Cr-Commit-Position: refs/heads/master@{#372020}

Re-enable its TestExpectations for [ Debug Mac10.7 ]

BUG=463358
TBR=hans@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1642763004

Cr-Commit-Position: refs/heads/master@{#372019}

- Tighten up he second argument of moveElementOutOfAncestor();
  ContainerNode -> Element

- Add inDocument() check in makeInsertedContentRoundTrippableWithHTMLTreeBuild().
  crrev.com/371774 fixed one such case. However we still might have such cases.
  Add inDocument() check just in case in order to avoid future crashes.

BUG=537815

Review URL: https://codereview.chromium.org/1649513003

Cr-Commit-Position: refs/heads/master@{#372018}

Using update-w3c-deps in Blink 329450ec.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,cbiesinger@chromium.org
BUG=492664

Review URL: https://codereview.chromium.org/1639343003

Cr-Commit-Position: refs/heads/master@{#372017}

Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.

I'm not sure what caused these errors to start appearing right now,
but this should fix it.

BUG=581782

Review URL: https://codereview.chromium.org/1645613003

Cr-Commit-Position: refs/heads/master@{#372016}

Don't try to make VisibleSelection for elements of which content is not
selectable.

This CL has no user-visible behavior changes because
selectionFromContentsOfNode() created a null VisibleSelection before this CL.

BUG=477839
TEST=automated

Review URL: https://codereview.chromium.org/1647833002

Cr-Commit-Position: refs/heads/master@{#372015}

Re-enable the TestExpectations which was commented out for some
reason (no explanatory comment).

TBR=wkorman@chromium.org
BUG=581963,463358
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1643863002

Cr-Commit-Position: refs/heads/master@{#372014}

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.

Review URL: https://codereview.chromium.org/1644813002

Cr-Commit-Position: refs/heads/master@{#372013}

This CL removes a static variable s_isPageBackground which is used to
tell the current tab is in background or foreground. It is because it's
almost impossible to tell this.

For example,  one renderer process of a new tab page is used for
multiple tabs. Another example is that reloading a page will re-use the
process with a new Page object and updating a static variable along with
reloading will be complex.

After this CL, we won't be able to get the number of decompression only
in a background tab. With the new UMA, we can't give a go-sign for
CompressibleString but at least we can give a no-go-sign.

BUG=581266
TEST=n/a

Review URL: https://codereview.chromium.org/1646443002

Cr-Commit-Position: refs/heads/master@{#372012}

The z component of the translate CSS property was ignoring length units
and treating everything as px.
This change fixes this by converting units into their px equivalent.

BUG=581918

Review URL: https://codereview.chromium.org/1640293004

Cr-Commit-Position: refs/heads/master@{#372011}

BUG=525873

Review URL: https://codereview.chromium.org/1637003002

Cr-Commit-Position: refs/heads/master@{#372010}

This CL adds Blink.MemoryCache.RevalidationPolicy.Preload.* that collect stats
of preloading requests, and
makes the existing Blink.MemoryCache.RevalidationPolicy.* to collect stats of
non-preloading requests only.

BUG=579496

Review URL: https://codereview.chromium.org/1642523002

Cr-Commit-Position: refs/heads/master@{#372009}

BUG=none

Review URL: https://codereview.chromium.org/1645733002

Cr-Commit-Position: refs/heads/master@{#372008}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e8c9e565cd60..0085d5c64509

$ git log e8c9e565c..0085d5c64 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1643703003

Cr-Commit-Position: refs/heads/master@{#372007}

WindowManager->WindowManagerDeprecated (i'll nuke this entirely soon)
WindowManagerInternal->WindowManager

I'll move the WindowManager classes into window_manager.mojom once I
nuke WindowManagerDeprecated (I can't now because of a cycle).

BUG=none
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1644773004

Cr-Commit-Position: refs/heads/master@{#372006}

TBR=groby@chromium.org
BUG=581959

Review URL: https://codereview.chromium.org/1644873002

Cr-Commit-Position: refs/heads/master@{#372005}

Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (patchset #24 id:460001 of https://codereview.chromium.org/1541393003/ )

Reason for revert:
GN asan and tsan are broken, wasn't aware bots are running GYP only. Reverting until we can figure out what to do with GN asan/tsan and probably msan.

Original issue's description:
> Improve performance of Character::isCJKIdeographOrSymbol by using trie tree
>
> This patch is another effort to make Character::isCJKIdeographOrSymbol
> faster.
>
> The previous CL[1] made it faster by ~90% for codepoints below U+2020,
> but codepoints abvoe U+2020 were not as fast. This CL makes all
> codepoints faster, as fast as ICU functions.
>
>       Before  After Improve ICU
> All    2569 => 292    88%   298
> ASCII    68 =>  68     0%   160
> Han    2958 => 263    91%   344
> Hira    258 =>  11    95%    14
> Arabic   37 =>  32    13%    44
> * # of code points and iterations vary by rows.
>
> The previous CL[1] clarified that binary search is not as fast as ICU
> functions such as uscript_getScript(). This patch changes to use
> UTrie2, which is the data structure ICU property functions use.
>
> In addition in this patch:
> * U+2763 and U+2764 are added as requested by drott@.
> * Character::isUprightInMixedVertical() was switched to UTrie2 too.
> * Character::isCJKIdeograph() was removed because it is no longer used.
>
> [1] https://codereview.chromium.org/1545073002
>
> BUG=571943
>
> Committed: https://crrev.com/e6dc3f425137021f39eddbbeb2035273ce36f986
> Cr-Commit-Position: refs/heads/master@{#371917}

TBR=eae@chromium.org,drott@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571943

Review URL: https://codereview.chromium.org/1644893002

Cr-Commit-Position: refs/heads/master@{#372004}