- 22 Jan, 2018 40 commits
-
-
Jacob Dufault authored
Bug: 803727 Change-Id: I2fc28069cd33106b3c9019b402e9f549d956e54c Reviewed-on: https://chromium-review.googlesource.com/879466Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#531031}
-
Evan Stade authored
These were removed from the build in 7426194d but accidentally left in the tree. TBR=peter@chromium.org Bug: 755413 Change-Id: Iba88cc7091f897c00a9d2b2173482f2fbaf86317 Reviewed-on: https://chromium-review.googlesource.com/878909Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#531030}
-
Tommy C. Li authored
In preparation for eliding parts of the displayed URL in the steady state Omnibox, we are going to introduce a GetURLForDisplay method. To keep things clear, we're renaming the old method from GetFormattedURL to GetFormattedFullURL to clarify that this old method (generally) yields a string with the equivalent meaning to the input URL. This is in contrast to the new GetURLForDisplay method which may perform destructive (meaning-changing) elisions. Bug: 797354 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 TBR=rohitrao@chromium.org Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 Reviewed-on: https://chromium-review.googlesource.com/876646 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531029}
-
Siddhartha authored
The native functions invoked are sometimes not run as a task which is registered with TaskAnnotator. Add events on generated jni functions to be able to trace them. Causes 80KB regression on the binary size, so use for temporary debugging in Dev channel and revert CL. BUG=801260 Change-Id: I80931fc07d74ed27edebe3cf35bce689f8138099 Reviewed-on: https://chromium-review.googlesource.com/853081 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#531028}
-
Dmitry Gozman authored
This patch moves message handling logic to DevToolsSession, removes duplicated logic from several DevToolsAgentHost implementations and hides multiple public methods exposed by the session. Bug: 776009 Change-Id: Id38a2bc2fa24591c04d9f1b0400fa522dd54d329 Reviewed-on: https://chromium-review.googlesource.com/875141Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531027}
-
Dave Schuyler authored
These files appear to be disconnected and unused. I contacted the original author (rlp@) for their thoughts. If they recall correctly this feature was removed. It sounds like these are just orphans. (code health) Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib632f0e92f0bb6eeb40cacb42fbb2bd655c76bf2 Reviewed-on: https://chromium-review.googlesource.com/877514Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#531026}
-
Joy Ming authored
Before this change, the behavior between the having the flag (#enable-downloads-foreground) enabled or not was different. With the flag enabled, swiping away a paused download notification cancels it and without the flag enabled, swiping away did not cancel. This change makes the behavior consistent in that swiping away a paused download does not cancel the download, rather, allows the user to go through downloads home to cancel it themselves. Bug: 803999 Change-Id: I1bd413575629885f7caeda11c0a5eff59f6c7375 Reviewed-on: https://chromium-review.googlesource.com/877187Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#531025}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I6e4717ab767dfc7b9f65e2621faf14237c65ab54 Reviewed-on: https://chromium-review.googlesource.com/879400Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531024}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I8e007ad264c7cc0f20b7e0a6a2b7e3c266d54e25 Reviewed-on: https://chromium-review.googlesource.com/879393Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531023}
-
Nate Chapin authored
Bug: 624061 Test: http/tests/security/frameNavigation/xss-ALLOWED-same-origin-top-navigation-without-user-gesture.html Change-Id: I78909ab0726b85881225de413302886479761a8f Reviewed-on: https://chromium-review.googlesource.com/877407 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#531022}
-
Fan Yang authored
In QUIC, let control frame manager send and manage control frames. Protected by --quic_reloadable_flag_quic_use_control_frame_manager. Merge internal change: 181644997 Change-Id: Ibfc98acd42c465b9e093a4b8e339821b69d73eaf Reviewed-on: https://chromium-review.googlesource.com/878284Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531021}
-
Lily Houghton authored
This renames net/proxy to net/proxy_resolution, and hoists net/proxy/proxy_server* to net/base. NOPRESUBMIT=true TBR=tbansal@chromium.org,boliu@chromium.org,stevenjb@chromium.org,gene@chromium.org,sky@chromium.org,halliwell@chromium.org,kinuko@chromium.org,mkwst@chromium.org,reillyg@chromium.org,dimich@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,garykac@chromium.org,eugenis@chromium.org,rhalavati@chromium.org Bug: 613632 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id8ceccb9b75ab1fc87e184de8661527444eedf1f Reviewed-on: https://chromium-review.googlesource.com/868176 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531020}
-
Joy Ming authored
Before this CL, there was a bug on L and lower devices (pre-Marshmallow) where the notification for the completed download would disappear if Chrome was swiped away from the recent activities drawer. This is because on pre-Marshmallow devices, swiping away an activity means killing the process immediately after it completes, which does not allow us to properly deal with the notification and it dies with the service. Even though we have backup measures for downloads in other states (ie. in-progress or paused) with the service START_STICKY, but since we do not persist information about completed or failed downloads, we are unable to recreate the notifications properly. Therefore, in this CL we fix that bug by pre-emptively launching a notification with a new notification id for all completed or failed downloads in phones that are L or below before calling stopForeground. For more information, see the writeup at go/downloads-on-l-devices. Bug: 747563 Change-Id: I079ba924cfa4cb48304e5d94813225ea3eccd8b9 Reviewed-on: https://chromium-review.googlesource.com/869138 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531019}
-
Becky Zhou authored
Bug: 804294, 804296 Change-Id: I9c854705f6481d3b3479a0251ee810800bdcfcde Reviewed-on: https://chromium-review.googlesource.com/879351Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Francois Doray authored
Change-Id: Ib3306e8c136b74c2cdaa9c5e9c33f995a2f4c5e6 Reviewed-on: https://chromium-review.googlesource.com/879390Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#531017}
-
Jay Civelli authored
The use of XML_PARSE_RECOVER in libxml2 is discouraged in production code as it hides errors in invalid XML and exercises some less-tested code paths in libxml2. Bug: 804379 Change-Id: Ic7a93d4a7e30d250beb8f018b923baad074d4f0d Reviewed-on: https://chromium-review.googlesource.com/879106Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#531016}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86972689478940ab2110fe1cd1b869bed5eff43f Reviewed-on: https://chromium-review.googlesource.com/879562Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#531015}
-
Findit authored
This reverts commit 6c4efb8d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 531003 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjNGVmYjhkZDY2YzYxYjVlZTU1NDUzZTAyMWY0M2Q1OGE0ZDMwOTMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/26183 Original change's description: > Makes metrics_reporting_state not use g_browser_process > > This is a precursor to loading local state, about flags and field > trials earlier, before BrowserProcess has been created. > > BUG=800358 > TEST=none > > Change-Id: I22dc0f6422e53073c06e183f6dc396b49a524633 > Reviewed-on: https://chromium-review.googlesource.com/865154 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531003} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=800358 Change-Id: I93683145391bc9d869a71e19e945f97033fbfc9c Reviewed-on: https://chromium-review.googlesource.com/879531 Cr-Commit-Position: refs/heads/master@{#531014}
-
marcin authored
Replace FloatLabelLayout with CompatibilityTextInputLayout as per suggestion from https://chromium-review.googlesource.com/c/chromium/src/+/875270#message-605ab443ccb5ae5408f35bf74e9341830ccb4e43 Change-Id: I69bf048cc02ae4b0ae962b5dd8513b4afd8df661 Reviewed-on: https://chromium-review.googlesource.com/877240Reviewed-by:
-
Alex Newcomer authored
Fixes the bug where the launcher would animate off screen on small scale factors for the HALF animation. Also enforces EXPECT_EQ(EXPECTED, ACTUAL) within app_list_presenter_delegate_unittest.cc Bug: 804033 Change-Id: Iac717640dc69677aa69a09b9a7a95414b4779aec Reviewed-on: https://chromium-review.googlesource.com/879388Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531012}
-
Ivan Afanasyev authored
ActivationStateComputingNavigationThrottle throttles response until AsyncDocumentSubresourceFilter get an activation state from blocking pool task runner. This task runner: a) Has TaskPriority::BACKGROUND priority, i.e. page opening is throttled until some info from low priority task runner retrieved. b) Processes obsolete ruleset files deletion and new ruleset files indexing. I.e. page opening sometimes is throttled until obsolete files deletion finished but does not depends on it. Changeset splits blocking task runner on two items: 1. Low priority background task runner for obsolete files deletion and new rulesets indexing. 2. High priority blocking task runner for tasks that influe user experience. Bug: 803412 Change-Id: Ic165012d8d2035610e06f0eaeda67d738b96caa1 Reviewed-on: https://chromium-review.googlesource.com/867041 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#531011}
-
Michael Thiessen authored
It appears that the ToolbarManager was using onViewDetachedFromWindow in order to perform destruction/cleanup, though the code I'm moving here dates back to the merging of clank into chromium. Going back through the history on the internal review site prior to the merge, the destroy() function didn't exist at the time onViewDetachedFromWindow was first used for cleanup, though it's not clear to me why this was the case. VR needs to reparent the view tree, which means detaching and re-attaching views from/to the window. ToolbarManager already has a destroy() function that appears to serve the same purpose as onViewDetachedFromWindow, so this CL moves the code from there to destroy(). Bug: 793430 Change-Id: Iff5414b6698be81ec4bc4899a5686ed905e4359d Reviewed-on: https://chromium-review.googlesource.com/878978Reviewed-by:
-
Helen Li authored
This CL patched over Mandoline's UDP part (https://codereview.chromium.org/1873463003) and made modifications. Interface definition: - udp_socket.mojom, which is modeled after udp_socket_posix/win.h - udp_socket_impl.h/cc, the concrete implementation. It uses a net::UDPSocket as the underlying //net socket implementation. Network Service: - network_service.mojom is modified to bind a UDPSocketRequest and a UDPSocketReceiverPtr with a udp_socket_impl. Design doc: https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit?usp=sharing Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibad5ec0e64e5e50ec7ff05305ffd35e1b48878d4 Reviewed-on: https://chromium-review.googlesource.com/796933Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#531009}
-
Steven Bennetts authored
VPN configurations were never shared in the non Settings based UI. We should preserve that behavior in the new UI. (The current behavior is completely wrong and always shares VPN configurations even when they require certificates). Bug: 798924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4470a77b8f4f36e0f46aba5505eafd96fb0ca799 Reviewed-on: https://chromium-review.googlesource.com/876933 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#531008}
-
Jonathan Backer authored
Added raster_cmd_buffer_functions.txt to matches current usage of raster_implementation_gles.cc Renamed cmd_buffer_functions.txt to gles_cmd_buffer_functions.txt Copied build_gles2_cmd_buffer.py to build_raster_cmd_buffer.py and pared down the python dicts to remove unnecessary entries. Commented out the actual autogen of raster code. Small fixups are required. Will uncomment with fixups in later CLs. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I08548650f45dff1580318cfdd01af16faaea2aa3 Reviewed-on: https://chromium-review.googlesource.com/878982Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531007}
-
Sigurdur Asgeirsson authored
The ASAN runtime and the sandbox battle over the CreateThread intercept when this CSRSS lockdown is enabled. Bug: 783296 Change-Id: Idde700679a24f16cd6387986589527fe39b6523c Reviewed-on: https://chromium-review.googlesource.com/879349 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531006}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0a20f3ce6c4d..e426d783c4e6 $ git log 0a20f3ce6..e426d783c --date=short --no-merges --format='%ad %ae %s' 2018-01-19 dtu [pinpoint] Break long chart names. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibe109802600cf06c638dc34b6523421db5f4429d Reviewed-on: https://chromium-review.googlesource.com/879389 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531005}
-
Andrey Lushnikov authored
There are cases when multilpe sourcemaps refer to the same sources: 1. this might happen when bundles share common code 2. this is also the case with hot module reload: every reload injects a new script with a new sourcemap that refers to the same sources. +--------+ +-------> | foo.ts | + +--------+ SM1 + +-------> +--------+ | bar.ts | <-- overlapping source file +-------> +--------+ + SM2 + +--------+ +-------> | baz.ts | +--------+ In the first case, contents of overlapping sources are equal and thus don't deal any trouble. In the second case, contents of overlapping sources are different; the latest injected sourcemap has the most up-to-date version of the content. This patch teaches CompilerScriptMapping to re-create UISourceCodes for the sourcemap sources if a new SourceMap got attached referring to the same source. This behavior satisfies both cases. BUG=438251 R=dgozman, kozy Change-Id: I98384eed39d6b347d466538fc9151a0c7b798a95 Reviewed-on: https://chromium-review.googlesource.com/875419 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531004}
-
Scott Violet authored
This is a precursor to loading local state, about flags and field trials earlier, before BrowserProcess has been created. BUG=800358 TEST=none Change-Id: I22dc0f6422e53073c06e183f6dc396b49a524633 Reviewed-on: https://chromium-review.googlesource.com/865154 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531003}
-
Eugene Ostroukhov authored
This reverts commit ddbc46df. Reason for revert: breaks DevTools debugging Original change's description: > DevTools: prefer reload in browser > > This performs reload in the browser, to make it more consistent with > regular reload expirience (e.g. warning about resubmitting POST > navigation would be shown now). > > Bug: 614869 > Change-Id: I90d36eb389b04cc41f5ab7524cbc6209bf100412 > Reviewed-on: https://chromium-review.googlesource.com/860575 > Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530678} TBR=dgozman@chromium.org,eostroukhov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 614869 Change-Id: I3a305d6f364179c5591b1873cfc129f8bcf6fc49 Reviewed-on: https://chromium-review.googlesource.com/879120Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#531002}
-
Eugene Ostroukhov authored
Configure Network domain to only send request bodies bigger then 64k when required by the user. Bug: 772402 Change-Id: Iae63d58efe2c67904458cb8b163a2eb8d4b4e65f Reviewed-on: https://chromium-review.googlesource.com/862703 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
-
Nate Chapin authored
This reverts commit cd10b9fa. Reason for revert: suspected perf regression: https://bugs.chromium.org/p/chromium/issues/detail?id=804318#c3 Original change's description: > Move the special case for image loads in unload handlers to ImageLoader > > Bug: > Change-Id: Ifa506c6a3b7060cfd0889d920548b0b9a4c91f4a > Reviewed-on: https://chromium-review.googlesource.com/860995 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530010} TBR=hiroshige@chromium.org,japhet@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1b1315b5ec72bf190290e781b883cf5339d82c34 Reviewed-on: https://chromium-review.googlesource.com/878923Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#531000}
-
Dmitry Gozman authored
We should return false for backward-compatibility with older frontends. Regressed here: https://chromium.googlesource.com/chromium/src/+/baf650e823bb8fd2615e6ec2920b46600d2a7585. Bug: 802928, 801835 Change-Id: Ibbe3a932467f5c4cb7c6db49bef12f5c10a40926 Reviewed-on: https://chromium-review.googlesource.com/879166 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#530999}
-
Amirhossein Simjour authored
Voice input disabled when one of the tabs is capturing autio. BUG=804362 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9b80889a93d17bedb16b90c6ef8c3a3ae5e01da8 Reviewed-on: https://chromium-review.googlesource.com/878944 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#530998}
-
Mikhail Pozdnyakov authored
Return error codes from the SensorProvider.GetSensor() method. In future it will be used to return correct errors in Generic Sensor API (e.g. 'NotAllowedError' if permissions are denied). Bug: 796894 Change-Id: I613c6f3792fde3c05142f1b4cf809655b4acb15f Reviewed-on: https://chromium-review.googlesource.com/864325Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
-
Jared Saul authored
Bug: 800997 Change-Id: I568a3038fbc1874a148199daaf1cd5f8b416ef5f Reviewed-on: https://chromium-review.googlesource.com/879170Reviewed-by:
-
Kurt Horimoto authored
Bug: 803817 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie9fa5f65fbf16b1885146078e637e512b364713a Reviewed-on: https://chromium-review.googlesource.com/877104Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#530995}
-
Nate Chapin authored
Bug: 801826 Change-Id: Ib8552a33c551d887a39d8eab9a3317311ac26385 Reviewed-on: https://chromium-review.googlesource.com/876927Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/393e26647033..9c1848952ede $ git log 393e26647..9c1848952 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d842a95e73b3d1beef6acd80b3185e786fcd7e2 Reviewed-on: https://chromium-review.googlesource.com/879169 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#530993}
-
Matt Wolenetz authored
When fudge room increases, MergeAllAdjacentRanges should merge all ranges that are adjacent based on the new fudge room. Previous code would not try to merge sets of more than 2 adjacent ranges, resulting in disjoint ranges which should have been coalesced. This change updates MergeAllAdjacentRanges to try to merge the current range with the next one repeatedly if the previous merge was successful. This change also stops using the approximate buffer duration (based on the maximum duration or continuous interbuffer DTS distance seen so far) as the reported range end time for ranges ending with a zero duration buffer. In combination with the previously broken MergeAllAdjacentRanges logic, approximated range end times that grow dynamically as a side effect of fudge room growth led to previously disjoint ranges overlapping each other (and failing the strengthened IsRangeListSorted() debug build verifications added as part of fixing bug 791095.) This change uses a constant 1 microsecond for the duration of a buffer that is reported as zero duration by the stream parsing and frame processor when calculating the buffered end time of a range. Since public base::TimeDelta::FromInternalValue usage is deprecated, this change also switches usage to FromMicroseconds in SBS and SBR. BUG=803018,803293,791095 TEST=SBS.*ZeroDurationBuffersThenIncreasingFudgeRoom, and removal of a FrameProcessorTest that verified the obsolete fudge-room-based buffered range reporting. The clusterfuzz cases in bugs 803018 and 803293 also no longer repro locally with this change. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b4adfeb5064c15e57211d2f07132e7723f7f66a Reviewed-on: https://chromium-review.googlesource.com/871517 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#530992}
-
