GitLab

This CL adds the CacheStorageEagerReading feature.  When enabled
cache.match() responses will be eagerly read if the call was made
during a FetchEvent with the same URL.  When this occurs the body
of the response will be contained in a mojo::DataPipe.  The blob
is still passed via the side_data_blob field in order to support
reading code cache.

This CL also moves the previous use of the response |side_data_blob|
field for storing code cache into cache_storage to a new field called
|side_data_blob_for_cache_put|.  This is done to avoid confusion over
how to read the code cache out of the value.  When putting into
cache_storage the code cache is stored in the primary data stream,
but when reading out of cache_storage its in the side data stream.
With additional work on blobs it should be possible to unify these
in the future.

Bug: 1010624
Change-Id: If6ae293e48f7db07f15690692755c03c453f6254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836391
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705229}

The specification added a step to increase sizes to accommodate spanning
items crossing flexible tracks instead of ignoring their contents
completely. This is done after handling all grid items that don't cross
such tracks, and this time items are considered together, not grouped by
their span size.

Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items

BUG=935102

TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html
TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html
TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html
TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html

Change-Id: Ic91a2eb471fae23cde1570c461f491cd5335d771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492337Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#705228}

Removes the ios12-beta-simulator FYI and try bots.

BUG=934252

Change-Id: I26f076db0fc97d8cc2dd72b0198c5984a6bc5592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852486Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705227}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome

BUG=762641
TBR=rkc@chromium.org

Change-Id: I6e3d2cabb591f4d82b496a69956bdbfa27f5e959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856684Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705226}

This is needed for BoxFragment painting (and FragmentItems work?)
as a box (without a NGPaintFragment) can have "outline: solid" which needs
to be painted.

Bug: 988015
Change-Id: Ib58b228c671a5e7e9e36152d3aa0add893087238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856540
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705225}

Bug: 980533
Change-Id: I3c4f1e12e048ba953500d8f7173220e04da997ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856879
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705224}

This CL updates the DialogContainsText logic in
MediaDialogViewBrowserTest to more explicitly depend on the structure
of the MediaNotificationView.

Bug: 1008905
Change-Id: Ia6350710dbf70b07dcaa9a9473ece3969f8942eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854663
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705223}

This is a follow up to crrev.com/c/1809966. Disables Vasco chips in the NTP
when zero-prefix suggestions are enabled using omnibox::kOnFocusSuggestions

Bug: 996516
Change-Id: I8ee718d710fd150eabf4f2943cdc9b489a76b33a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856861Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705222}

ScopedFeatureList is unsafe to use after browser threads have been
started. This constraint will imminently be enforced by DCHECK to
prevent further erroneous usage from landing.

This CL corrects usage within media, geolocation, and permissions
related code.

This is split from a larger CL where in some rare cases, correction
was too complex to resolve before landing the DCHECK, so corresponding
test(s) may be disabled instead of fixed.

Bug: 846380
Change-Id: I48856217d97c1b5d0acf44c4b36ebb138a3beee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850731Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#705221}

WebThemeEngineImplDefaultBrowserTest.GetSystemColor fails
non-deterministically on Windows2008Server. To fix this, the test is
updated to only run on Win7 and above.

Bug: 1010924
Change-Id: Ibda98ca611c27176ff831d0c85462579ae2c37dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856578
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705220}

This feature is intended to ship in 79, so the feature needs to be
enabled.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/CHCM_xALBG4/JeQQYkONBwAJ

Bug: 1007537
Change-Id: I3e4dac8da7a24806e652ef3d97f8e1fb7bee6daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823881
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705219}

Direction and writing-mode is propagated from body to the viewport, but
when the computed value of those properties are different between the
root and body elements, their used values are the computed values of the
body element. The computed values are not affected by this.

We implement this propagation by using a ComputedStyle on the
HTMLHtmlElement's LayoutObject which has the propagated values for
direction and writing-mode.

The modified tests relied on direction on #container being different
from the #container parent. That is no longer possible with body being
container and the used direction value of body propagated to html.
The tests were modified to use a child of body as container instead,
the removed 8px margin was just replicating the body margin and we do
not want that on the #container div.

Spec: https://drafts.csswg.org/css-writing-modes-3/#principal-flow

TEST=external/wpt/css/css-writing-modes/wm-propagation-002.html
TEST=external/wpt/css/css-writing-modes/wm-propagation-body-033.html
TEST=external/wpt/css/css-writing-modes/wm-propagation-body-037.html

Bug: 988585
Change-Id: I2879c8fdc082940d2baaf67e126b28915f9f1eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852786
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705218}

This change intends to fix touch with a screen reader in nested
elements across the browser frame, as the tabs and the location bar.
The issue here is that the focus ring is the first child found and
returned by HitTestSync and does not allow to continue looking for
the nested view child.
For example, if touching the bookmark button inside the location bar,
focus ring (which covers all the area of the location bar) will be
found before the bookmark button.

This fix adjusts HitTestSync by now calling
View::GetEventHandlerForPoint which returns the hit child on the
view. Then we still iterate the children of this view since
we need to return the deepest-most child it can find. The benefit
on calling now GetEventHandlerForPoint is that this method
already knows how to handle overlapping views.


Bug: 990560
Change-Id: I9076c3dfaa1424b69eb49b83c07b10ebeb26776d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817289Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Maria Villarreal <mavill@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705217}

This is to allow associating cast apps with platform views.
WebviewService will be deprecated in future change.

Bug: b/136460199
Test: Compile cast_shell
Change-Id: I5bad0fe7817ec65e3719d9c43d0b08fcb679cd80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856278Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#705216}

Now there are
16 pages in mobile representatives,
15 pages in desktop (Windows) representatives,
16 pages in desktop (Mac) representatives,


Page below visualizes all the clusters of each platform, over the data
capture in the past 50 days.
https://x20web.corp.google.com/users/be/behdadb/clusterDashboard/charts.html

The clusters re created using the scripts provided in
tools/perf/experimental/story_clustering with some modifications which I'll
upstream.

New upper limits are set for representatives, which will be temporary and
after collecting one week of data on gpu-fyi bot we can adjust and update.
The current limits are chosen based on the last 50 values on dashboard for
each story.

TBR=crouleau@chromium.org

Bug: chromium:1011969
Change-Id: Ie9ed124e162dbcc161365fbc93d18c2efa3580e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846232
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705215}

There are some potential breaking changes for the WebXr gamepad module
that may make it so that it cannot be shipped at the same time with the
main WebXr Device API.  Adding this flag enables the flexibility to ship
the WebXr Device API without the optional Gamepad module if breaking
changes are needed to the gamepad module.

Bug: 1013415
Change-Id: I2c79a2a9991a6497197357ecc9f38719b0379a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854863
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705214}

This reverts commit 776645cc.

This CL was reverted because it caused on-device crash loops:
base::CreateSequencedTaskRunner() would fail on a DCHECK because of lack
of access to |g_thread_pool|.

Now that the libcast_media_1.0_audio target is statically linked when
possible, this is no longer an issue. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1846314

Bug: internal b/135280530
Change-Id: Ib84ff58f17dec31abe3ba438a1a87a53763942af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848576Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Jenny Wong <jyw@google.com>
Cr-Commit-Position: refs/heads/master@{#705213}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/af9c6ce85491..4d4275fc6a5d

git log af9c6ce85491..4d4275fc6a5d --date=short --no-merges --format='%ad %ae %s'
2019-10-11 achuith@chromium.org flash: Prefer full_payload download.

Created with:
  gclient setdep -r src/third_party/chromite@4d4275fc6a5d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic27275d31bd1c1e63b92441e56b5c96cc61ac33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856627Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705212}

ScopedFeatureList is unsafe to use after browser threads have been
started. This constraint will imminently be enforced by DCHECK to
prevent further erroneous usage from landing.

This CL corrects usage within Chrome Notificatios, Push messaging,
Sharing, and Autofill browser tests.

This is split from a larger CL where in some rare cases, correction
was too complex to resolve before landing the DCHECK, so corresponding
test(s) may be disabled instead of fixed.

Bug: 846380
Change-Id: I81ab8aa383c385c90980377842656c402d8dd2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850734Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#705211}

Bug: 1013000
Change-Id: I225064e4cdbeab4ed23588df8ec0154f00d6dd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851225
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705210}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I556dc4abd7e9688782bdbaced5198d06561b8c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855420Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705209}

It's possible for width to be non-zero while the icon is hidden. In
this case, we do want to grow the label starting from 0 width.

Change-Id: I80d6d216aef5f5ec8d849fd844ce21e38079f863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850966Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705208}

I updated the chromium bot configs to exclude Chrome-only tests in
https://crrev.com/c/1838375, but the new category filter flags are not
available in the CELab package we use in chromium/src, so this broke
our bots. Oops.

Updating the package will fix this.

Notable changes since the last version:
- Implement @category & filter arguments for EnterpriseTestCase:
  https://crrev.com/c/1823607

Bug: 1013507
Change-Id: I0aeee6021d25b2a3dd0f514f35821dd66069c4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856398Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Mathieu Binette <mbinette@google.com>
Cr-Commit-Position: refs/heads/master@{#705207}

This CL brings in changes in mojo and browser needed to surface the
subscription-based variant of the API to JavaScript. The explainer can
be currently found in the following URL:
https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md

Changes related to floor height estimation are due to the fact that in
order to implement hit test for local-floor reference spaces, the
current height estimation needs to be known to ArCoreImpl.
Additionally, if we ever decide to estimate the floor height more
intelligently, it would have to be done in ArCoreImpl so it's one more
reason to move floor height information there.

Bug: 928481
Change-Id: I2d21bfa021c3a238455dd3489353233c5c848a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829942Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705206}

Site Settings page currently shows the enterprise "office" icon
instead of the "kite" icon for supervised users. This CL fixes this
and ensures that the kite icon and "This setting is managed by a
parent." tooltip is shown in Site Settings when a supervised user
is logged in.

Bug: 1005547
Change-Id: I91d81337b3f1b5cd070163ecc032a1695592dc0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838652
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705205}

This moves Browser away from listening to for INVALIDATE_TYPE_AUDIO for
audibility state changes.

This is part of a refactor detailed in the attached bug.

Bug: 846374
Change-Id: I09cd8395c16bba812e9417f2ca6364d43864d39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854214
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705204}

Use JS modules instead, since HTML Imports are being removed.

Replace CallJavascriptFunction() with FireWebUIListener(), since within
a JS module context, all variables/functions are private (unlike previous
behavior of being global), and can't be called from the outside

Bug: 937747
Test: Visit chrome://webapks, should no longer see HTML import warnings in DevTools.
Change-Id: I4319d6b78a9a4c370a2f9152e7448e7c3325adf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850271
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705203}

Tracing_controller_impl.cc/.h now uses the Consumer Mojo interface rather
than the old Agent/Coordinator interface, allowing the latter to be deleted in
the next CL.

As part of this, the option to anonymize the data has to be moved from
the TraceConfig struct to be an explicit argument to StopTracing instead,
as the filtering/whitelisting done at JSON export time needs the full
unfiltered proto data available.

BUG=839086

Change-Id: Id73b73a1cdbc6c7a6c8d343c391136abc5914743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817207Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705202}

Bug: 1012831
Change-Id: I40adeaa1c625ee45f21cd3cc1f1ada50d8760c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854719
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705201}

I noticed telemetry hadn't changed after submitting the StartupTabPreloader
and this is because we where not accepting intents with a component.

This patch adds support for intents with a component name compatible with
ChromeTabbedActivity.MAIN_LAUNCHER_ACTIVITY_NAME.

BUG: 1013535
Change-Id: I4bc48ffc70676638358fcb58a38719d7198499c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852788
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705200}

First, re-lands the fix to bug 836554, which ensures TalkBack
announces when a slider changes. This time, adds a check to only fire
the TYPE_VIEW_SELECTED event if the slider has accessibility focus,
hoping that will address the problems with fullscreen video by suppressing
announcements when an unfocused slider changes.

Also, doesn't expose the "can scroll forwards / backwards" actions on a slider
that isn't an HTML INPUT control, because a pure ARIA slider won't respond
to those. That addresses bug 917845.

Finally, added code to ensure that a slider updates the accessibility tree
when its value changes - I found this was necessary in order to get
announcements after changing a slider with the volume keys.

Bug: 836554, 917845, 953652
Change-Id: I3f1f88321a4644bc5729c16c14e0bd9037a641ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853857Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705199}

Enable by default in preparation for 100% rollout.

Bug: 851335
Change-Id: I46cee16a1b803c7b2d55362baa1c56d630a2b83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854031Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705198}

This reverts commit fbb09263.

Reason for revert: Test is flaky

Original change's description:
> [profile-menu] Re-enable browser test _WithUnconsentedPrimaryAccount
> 
> ... and wait for SyncTransportActive during the setup.
> 
> Bug: 995720, 1012167
> Change-Id: Ib0523c68738f226a29171fabc64264cf36c03f37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856061
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705126}

TBR=droger@chromium.org,tangltom@chromium.org

Change-Id: I44760e6374571726196153bf32022c9735fb7984
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995720, 1012167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856958Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705197}

No behavioral change intended.

Change-Id: I6905ee8f089812ee46eb454de7062a35b10db26f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849266Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705196}

This CL changes how credential entries are bound to the corresponding
views in the ListView - now PropertyModel is used to provide Credential
instances. The same PropertyModel contains FAVICON property for the
favicon.

Bug: 1012646
Change-Id: I1943220e6b716224d3e7ae5fb7ec226edc70e299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852430
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705195}

https://skia.googlesource.com/skia.git/+log/9b33e3602340..27c4369651a8

git log 9b33e3602340..27c4369651a8 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-11 herb@google.com Introduce SkGlyphDrawableBuffer

Created with:
  gclient setdep -r src/third_party/skia@27c4369651a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Bug: None
Change-Id: Ib2a9806f52e52d9bd56986206f6fa897c743c158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856678Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705194}

This change performs minor clean-ups of base::AutoReset such as making
use of std::exchange in its move operations, taking the constructor
argument by forwarding reference and getting rid of the branch to
protect against self-move assignment.

Bug: None
Change-Id: I7cac40c037dc1e18367b42d3057bc984f14cb472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855838Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705193}

Scroll view to show auto-selected toggle.
Fix layout issue with zero height divs.

Bug: 1010166
Change-Id: I56399b4a43da16797b3b25a818b8d39f3a4c89e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848380Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#705192}

Problem:
In third_party/blink/renderer/core/input/gesture_manager.cc, the
function GestureManager::HandleGestureLongTap did not process
kGestureLongTap for Android, but it is not enough.
In web_view_impl.cc, function WebViewImpl::HandleGestureEvent processes
kGestureLongTap, it clears the context menu, but does not generate new
data for the context menu since GestureManager ignores kGestureLongTap.
Then in some conditions, it will make the context menu in Android
totally useless, click anything on the context menu won't do anything.

Fix:
In this CL, we check if we should process long_tap action before clear
ContextMenuController.

Bug:1012068

Change-Id: I2d490d5bde19f016d117437bcb793459b92a0cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849171Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705191}

No functional changes intended, please revert if things break.

This function is a large, and hard to follow. I'm hoping to break out a
bunch of functions that are clearer about what they're doing and make
ordering clearer.

Bug: 1006927
Change-Id: Icd6c09563e577153829c8243758b8c98aff1b6c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837872
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705190}